Skip to contentSkip to conversation

tools/testing/cxl: Remove cxl_test module math loading message

PATCH Superseded [email protected] 3 participants 4 messages Jan 25, 2023 – Jan 26, 2023 CXL

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH v2 1/1 tools/testing/cxl: Remove cxl_test module math loading message

From: Alison Schofield <[email protected]>

Commit "tools/testing/cxl: Add XOR Math support to cxl_test" added a module parameter to cxl_test for the interleave_arithmetic option. In doing so, it also added this dev_dbg() message describing which option cxl_test used during load:
"[ 111.743246] (NULL device *): cxl_test loading modulo math option"

That "(NULL device *)" has raised needless user concern and the info emitted can be discovered elsewhere.

Remove the dev_dbg() messages and make the module_param readable via sysfs in case a lookup is wanted.

Fixes Fixes: 7a7e6edfca85 ("tools/testing/cxl: Add XOR Math support to cxl_test")

---

Changes in v2:
- Use correct Fixes Tag in commit log. (Ira)
- Param always appears in sysfs. Don't say otherwise in commit log. (Ira)
- Commit msg: s/modulo/module, s/messages/message
- No change in code

 tools/testing/cxl/test/cxl.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
tools/testing/cxl/test/cxl.c +1 -3
index 30ee680d38ff..ede84de69f59 100644
@@ -1135,11 +1135,9 @@ static __init int cxl_test_init(void)
 	if (interleave_arithmetic == 1) {
 		cfmws_start = CFMWS_XOR_ARRAY_START;
 		cfmws_end = CFMWS_XOR_ARRAY_END;
-		dev_dbg(NULL, "cxl_test loading xor math option\n");
 	} else {
 		cfmws_start = CFMWS_MOD_ARRAY_START;
 		cfmws_end = CFMWS_MOD_ARRAY_END;
-		dev_dbg(NULL, "cxl_test loading modulo math option\n");
 	}
 
 	rc = populate_cedt();
@@ -1326,7 +1324,7 @@ static __exit void cxl_test_exit(void)
 	unregister_cxl_mock_ops(&cxl_mock_ops);
 }
 
-module_param(interleave_arithmetic, int, 0000);
+module_param(interleave_arithmetic, int, 0444);
 MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1");
 module_init(cxl_test_init);
 module_exit(cxl_test_exit);

base-commit: 589c3357370a596ef7c99c00baca8ac799fce531

Signature · 1 line
2.37.3
maintainer Reviewed-by on v2 1/1
#1 lore raw
Quoted 19 lines · On Wed, 2023-01-25 at 10:13 -0800, [email protected] wrote:

From: Alison Schofield <[email protected]>

Commit "tools/testing/cxl: Add XOR Math support to cxl_test" added a module parameter to cxl_test for the interleave_arithmetic option. In doing so, it also added this dev_dbg() message describing which option cxl_test used during load:
"[  111.743246] (NULL device *): cxl_test loading modulo math option"

That "(NULL device *)" has raised needless user concern and the info emitted can be discovered elsewhere.

Remove the dev_dbg() messages and make the module_param readable via sysfs in case a lookup is wanted.

Fixes Fixes: 7a7e6edfca85 ("tools/testing/cxl: Add XOR Math support to cxl_test")

---

Quoted 8 lines

Changes in v2:
- Use correct Fixes Tag in commit log. (Ira)
- Param always appears in sysfs. Don't say otherwise in commit log. (Ira)
- Commit msg: s/modulo/module, s/messages/message
- No change in code

 tools/testing/cxl/test/cxl.c | 4 +---

 1 file changed, 1 insertion(+), 3 deletions(-)

Looks good,

Quoted 28 lines
tools/testing/cxl/test/cxl.c +0 -2
index 30ee680d38ff..ede84de69f59 100644
@@ -1135,11 +1135,9 @@ static __init int cxl_test_init(void)
         if (interleave_arithmetic == 1) {
                 cfmws_start = CFMWS_XOR_ARRAY_START;
                 cfmws_end = CFMWS_XOR_ARRAY_END;
-               dev_dbg(NULL, "cxl_test loading xor math option\n");
         } else {
                 cfmws_start = CFMWS_MOD_ARRAY_START;
                 cfmws_end = CFMWS_MOD_ARRAY_END;
-               dev_dbg(NULL, "cxl_test loading modulo math option\n");
         }


        rc = populate_cedt();

tools/testing/cxl/test/cxl.c +0 -0
@@ -1326,7 +1324,7 @@ static __exit void cxl_test_exit(void)
         unregister_cxl_mock_ops(&cxl_mock_ops);
  }

tools/testing/cxl/test/cxl.c +1 -1
-module_param(interleave_arithmetic, int, 0000);
+module_param(interleave_arithmetic, int, 0444);

 MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1"); module_init(cxl_test_init); module_exit(cxl_test_exit);

base-commit: 589c3357370a596ef7c99c00baca8ac799fce531

maintainer
#2 lore raw
In reply to [email protected]
Quoted 8 lines · On 1/25/23 11:13 AM, [email protected] wrote:

From: Alison Schofield <[email protected]>

Commit "tools/testing/cxl: Add XOR Math support to cxl_test" added a module parameter to cxl_test for the interleave_arithmetic option. In doing so, it also added this dev_dbg() message describing which option cxl_test used during load:
"[ 111.743246] (NULL device *): cxl_test loading modulo math option"

Quoted 5 lines

That "(NULL device *)" has raised needless user concern and the info emitted can be discovered elsewhere.

Remove the dev_dbg() messages and make the module_param readable via sysfs in case a lookup is wanted.

Should the module_param perm change go to a second patch since it has nothing to do with removal of the debug warning?

Quoted 42 lines
Fixes Fixes: 7a7e6edfca85 ("tools/testing/cxl: Add XOR Math support to cxl_test")

---

Changes in v2:
- Use correct Fixes Tag in commit log. (Ira)
- Param always appears in sysfs. Don't say otherwise in commit log. (Ira)
- Commit msg: s/modulo/module, s/messages/message
- No change in code

  tools/testing/cxl/test/cxl.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
tools/testing/cxl/test/cxl.c +1 -3
index 30ee680d38ff..ede84de69f59 100644
@@ -1135,11 +1135,9 @@ static __init int cxl_test_init(void)
  	if (interleave_arithmetic == 1) {
  		cfmws_start = CFMWS_XOR_ARRAY_START;
  		cfmws_end = CFMWS_XOR_ARRAY_END;
-		dev_dbg(NULL, "cxl_test loading xor math option\n");
  	} else {
  		cfmws_start = CFMWS_MOD_ARRAY_START;
  		cfmws_end = CFMWS_MOD_ARRAY_END;
-		dev_dbg(NULL, "cxl_test loading modulo math option\n");
  	}
 
  	rc = populate_cedt();
@@ -1326,7 +1324,7 @@ static __exit void cxl_test_exit(void)
  	unregister_cxl_mock_ops(&cxl_mock_ops);
  }
 
-module_param(interleave_arithmetic, int, 0000);
+module_param(interleave_arithmetic, int, 0444);
  MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1");
  module_init(cxl_test_init);
  module_exit(cxl_test_exit);

base-commit: 589c3357370a596ef7c99c00baca8ac799fce531

author maintainer
#3 lore raw
Quoted 11 lines · Dave Jiang
Quoted 8 lines · On 1/25/23 11:13 AM, [email protected] wrote:

From: Alison Schofield <[email protected]>

Commit "tools/testing/cxl: Add XOR Math support to cxl_test" added a module parameter to cxl_test for the interleave_arithmetic option. In doing so, it also added this dev_dbg() message describing which option cxl_test used during load:
"[ 111.743246] (NULL device *): cxl_test loading modulo math option"

Quoted 9 lines
Quoted 5 lines

That "(NULL device *)" has raised needless user concern and the info emitted can be discovered elsewhere.

Remove the dev_dbg() messages and make the module_param readable via sysfs in case a lookup is wanted.

Should the module_param perm change go to a second patch since it has nothing to do with removal of the debug warning?

Thanks Dave -

I don't think a second patch, but I can make the connection better between the 2 pieces. Where it says the 'info emitted can be discovered elsewhere', elsewhere is that now readable param.

I'll rev it. Also, I might need to base on a fixes branch, rather than cxl/next, like I've been doing.

Will check.

Quoted 40 lines
Quoted 40 lines
Fixes Fixes: 7a7e6edfca85 ("tools/testing/cxl: Add XOR Math support to cxl_test")

---

Changes in v2:
- Use correct Fixes Tag in commit log. (Ira)
- Param always appears in sysfs. Don't say otherwise in commit log. (Ira)
- Commit msg: s/modulo/module, s/messages/message
- No change in code

  tools/testing/cxl/test/cxl.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
tools/testing/cxl/test/cxl.c +1 -3
index 30ee680d38ff..ede84de69f59 100644
@@ -1135,11 +1135,9 @@ static __init int cxl_test_init(void)
  	if (interleave_arithmetic == 1) {
  		cfmws_start = CFMWS_XOR_ARRAY_START;
  		cfmws_end = CFMWS_XOR_ARRAY_END;
-		dev_dbg(NULL, "cxl_test loading xor math option\n");
  	} else {
  		cfmws_start = CFMWS_MOD_ARRAY_START;
  		cfmws_end = CFMWS_MOD_ARRAY_END;
-		dev_dbg(NULL, "cxl_test loading modulo math option\n");
  	}
  	rc = populate_cedt();
@@ -1326,7 +1324,7 @@ static __exit void cxl_test_exit(void)
  	unregister_cxl_mock_ops(&cxl_mock_ops);
  }
-module_param(interleave_arithmetic, int, 0000);
+module_param(interleave_arithmetic, int, 0444);
  MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1");
  module_init(cxl_test_init);
  module_exit(cxl_test_exit);
 

base-commit: 589c3357370a596ef7c99c00baca8ac799fce531