iommu/vt-d: Set No Execute Enable bit in PASID table entry
Subsystems (2)
Lu Baolu
maintainerPATCH 1/1 iommu/vt-d: Set No Execute Enable bit in PASID table entry
Setup No Execute Enable bit (Bit 133) of a scalable mode PASID entry. It is required when XD bit of the first level page table entry is about to be set.
--- drivers/iommu/intel/pasid.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/iommu/intel/pasid.c +11 -0
@@ -364,6 +364,16 @@ static inline void pasid_set_page_snoop(struct pasid_entry *pe, bool value)pasid_set_bits (&pe->val[1 ],1 <<23 , value <<23 ); } +/* +* Setup No Execute Enable bit (Bit 133) of a scalable mode PASID +* entry. It is required when XD bit of the first level page table +* entry is about to be set. +*/ +static inline void pasid_set_nxe (struct pasid_entry *pe) +{ +pasid_set_bits (&pe->val[2 ],1 <<5 ,1 <<5 ); +} +/* * Setup the Page Snoop (PGSNP) field (Bit 88) of a scalable mode * PASID entry.
@@ -557,6 +567,7 @@ int intel_pasid_setup_first_level(struct intel_iommu *iommu,pasid_set_domain_id (pte, did);pasid_set_address_width (pte, iommu->agaw);pasid_set_page_snoop (pte, !!ecap_smpwc (iommu->ecap)); +pasid_set_nxe (pte);/* Setup Present and PASID Granular Transfer Type: */ pasid_set_translation_type (pte,PASID_ENTRY_PGTT_FL_ONLY );
Signature · 1 line
2.34.1
Quoted 6 lines
From: Lu Baolu <[email protected]>
Sent: Thursday, January 26, 2023 5:55 PMSetup No Execute Enable bit (Bit 133) of a scalable mode PASID entry. It is required when XD bit of the first level page table entry is about to be set.
"is about to set" sounds like the NXE bit is set conditionally when certain event happens. But the actual definition of NXE bit is to allow the use of XD bit of the first level page table.
With the comment fixed:
Baolu Lu
maintainerQuoted 6 lines · Kevin
Quoted 6 lines
From: Lu Baolu<[email protected]>
Sent: Thursday, January 26, 2023 5:55 PMSetup No Execute Enable bit (Bit 133) of a scalable mode PASID entry. It is required when XD bit of the first level page table entry is about to be set.
Quoted 7 lines
"is about to set" sounds like the NXE bit is set conditionally when certain event happens. But the actual definition of NXE bit is to allow the use of XD bit of the first level page table.
With the comment fixed:
Reviewed-by Kevin Tian<[email protected]>
Updated. Thank you, Kevin.
Best regards,
baolu
Baolu Lu
maintainerQuoted 7 lines · Lu Baolu
Setup No Execute Enable bit (Bit 133) of a scalable mode PASID entry. It is required when XD bit of the first level page table entry is about to be set.
Fixes ddf09b6d43ec ("iommu/vt-d: Setup pasid entries for iova over first level")Signed-off-by Ashok Raj<[email protected]>Signed-off-by Lu Baolu<[email protected]>
Patch queued for v6.3.
https://lore.kernel.org/linux-iommu/[email protected]/
Best regards,
baolu