drm/amd/display: reduce else-if to else in dcn10_blank_pixel_data()
Subsystems (3)
PATCH 1/1 drm/amd/display: reduce else-if to else in dcn10_blank_pixel_data()
checkpatch reportsdrivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c:2902:13: style:
Expression is always true because 'else if' condition is opposite to previous condition at line 2895. [multiCondition]
} else if (blank) {
^
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c:2895:6: note: first condition
if (!blank) {
^drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c:2902:13: note: else if condition is opposite to first condition
} else if (blank) {
It is not necessary to explicitly the check != condition, an else is simplier.
--- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c +1 -1
@@ -2899,7 +2899,7 @@ void dcn10_blank_pixel_data( dc->hwss.set_pipe (pipe_ctx); stream_res->abm->funcs->set_abm_level (stream_res->abm, stream->abm_level); } - }else if (blank) { + }else { dc->hwss.set_abm_immediate_disable (pipe_ctx);if (stream_res->tg->funcs->set_blank) { stream_res->tg->funcs->wait_for_state (stream_res->tg,CRTC_STATE_VBLANK );
Signature · 1 line
2.26.3
Alex Deucher
AppliedApplied. Thanks!
Quoted 36 lines · Tom Rix
checkpatch reports
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c:2902:13: style:
Expression is always true because 'else if' condition is opposite to previous condition at line 2895. [multiCondition]} else if (blank) { ^ drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c:2895:6: note: first condition if (!blank) { ^
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c:2902:13: note: else if condition is opposite to first condition
} else if (blank) {It is not necessary to explicitly the check != condition, an else is simplier.
Fixes aa5a57773042 ("drm/amd/display: Vari-bright looks disabled near end of MM14")Signed-off-by Tom Rix <[email protected]>--- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c +1
-2@@ -2899,7 +2899,7 @@ void dcn10_blank_pixel_data( dc->hwss.set_pipe (pipe_ctx); stream_res->abm->funcs->set_abm_level (stream_res->abm, stream->abm_level); } - }else if (blank) { + }else { dc->hwss.set_abm_immediate_disable (pipe_ctx);if (stream_res->tg->funcs->set_blank) { stream_res->tg->funcs->wait_for_state (stream_res->tg,CRTC_STATE_VBLANK ); --2.26.3