platform/x86/amd: pmc: add CONFIG_SERIO dependency
PATCH 1/1 platform/x86/amd: pmc: add CONFIG_SERIO dependency
From: Arnd Bergmann <[email protected]>
Using the serio subsystem now requires the code to be reachable:
x86_64-linux-ld: drivers/platform/x86/amd/pmc.o: in function `amd_pmc_suspend_handler':
pmc.c:(.text+0x86c): undefined reference to `serio_bus'
Add the usual dependency: as other users of serio use 'select' rather than 'depends on', use the same here.
--- drivers/platform/x86/amd/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/platform/x86/amd/Kconfig +1 -0
@@ -8,6 +8,7 @@ source "drivers/platform/x86/amd/pmf/Kconfig" config AMD_PMC tristate "AMD SoC PMC driver" depends on ACPI && PCI && RTC_CLASS + select SERIO help The driver provides support for AMD Power Management Controller primarily responsible for S2Idle transactions that are driven from
Signature · 1 line
2.39.0
Hi,
Quoted 4 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Using the serio subsystem now requires the code to be reachable:
Quoted 8 lines
x86_64-linux-ld:
drivers/platform/x86/amd/pmc.o: in function `amd_pmc_suspend_handler':
pmc.c:(.text+0x86c): undefined reference to `serio_bus'Add the usual dependency: as other users of serio use 'select' rather than 'depends on', use the same here.
Fixes 8e60615e8932 ("platform/x86/amd: pmc: Disable IRQ1 wakeup for RN/CZN")Signed-off-by Arnd Bergmann <[email protected]>
Thanks Arnd, I'll include this in my next fixes pull-req to Linus.
Regards,
Hans
Quoted 16 lines
--- drivers/platform/x86/amd/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/platform/x86/amd/Kconfig +1
-0@@ -8,6 +8,7 @@ source "drivers/platform/x86/amd/pmf/Kconfig" config AMD_PMC tristate "AMD SoC PMC driver" depends on ACPI && PCI && RTC_CLASS + select SERIO help The driver provides support for AMD Power Management Controller primarily responsible for S2Idle transactions that are driven from
Hi,
Quoted 4 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Using the serio subsystem now requires the code to be reachable:
Quoted 8 lines
x86_64-linux-ld:
drivers/platform/x86/amd/pmc.o: in function `amd_pmc_suspend_handler':
pmc.c:(.text+0x86c): undefined reference to `serio_bus'Add the usual dependency: as other users of serio use 'select' rather than 'depends on', use the same here.
Fixes 8e60615e8932 ("platform/x86/amd: pmc: Disable IRQ1 wakeup for RN/CZN")Signed-off-by Arnd Bergmann <[email protected]>
Thank you for your patch, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.
Regards,
Hans
Quoted 16 lines
--- drivers/platform/x86/amd/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/platform/x86/amd/Kconfig +1
-0@@ -8,6 +8,7 @@ source "drivers/platform/x86/amd/pmf/Kconfig" config AMD_PMC tristate "AMD SoC PMC driver" depends on ACPI && PCI && RTC_CLASS + select SERIO help The driver provides support for AMD Power Management Controller primarily responsible for S2Idle transactions that are driven from