.gitignore: Unignore .kunitconfig
PATCH 1/1 .gitignore: Unignore .kunitconfig
There are almost dozen of .kunitconfig files that are ignored but tracked. Unignore them.
--- .gitignore | 1 + 1 file changed, 1 insertion(+)
.gitignore +1 -0
@@ -100,6 +100,7 @@ modules.order !.get_maintainer.ignore !.gitattributes !.gitignore +!.kunitconfig !.mailmap !.rustfmt.toml
Signature · 1 line
2.39.0
Quoted 6 lines · Andy Shevchenko
There are almost dozen of .kunitconfig files that are ignored but tracked. Unignore them.
Signed-off-by Andy Shevchenko <[email protected]>---
Thanks! Only the original root-directory .kunitignore file was intended to be ignored, and that's no longer as important, and is now in the build dir anyway.
Cheers,
-- David
Quoted 18 lines
.gitignore | 1 + 1 file changed, 1 insertion(+).gitignore +1
-1@@ -100,6 +100,7 @@ modules.order !.get_maintainer.ignore !.gitattributes !.gitignore +!.kunitconfig !.mailmap !.rustfmt.toml --2.39.0
Quoted 34 lines · David Gow
Quoted 6 lines · Andy Shevchenko
There are almost dozen of .kunitconfig files that are ignored but tracked. Unignore them.
Signed-off-by Andy Shevchenko <[email protected]>---
Thanks! Only the original root-directory .kunitignore file was intended to be ignored, and that's no longer as important, and is now in the build dir anyway.
Reviewed-by David Gow <[email protected]>Cheers,
-- DavidQuoted 15 lines
.gitignore | 1 + 1 file changed, 1 insertion(+).gitignore +1
-0@@ -100,6 +100,7 @@ modules.order !.get_maintainer.ignore !.gitattributes !.gitignore +!.kunitconfig !.mailmap !.rustfmt.toml
Quoted 3 lines
Quoted 3 lines
--
2.39.0
Why is this a dot file in the first place?
Signature · 2 lines
Best Regards Masahiro Yamada
Quoted 36 lines · Masahiro Yamada
Quoted 34 lines · David Gow
Quoted 6 lines · Andy Shevchenko
There are almost dozen of .kunitconfig files that are ignored but tracked. Unignore them.
Signed-off-by Andy Shevchenko <[email protected]>---
Thanks! Only the original root-directory .kunitignore file was intended to be ignored, and that's no longer as important, and is now in the build dir anyway.
Reviewed-by David Gow <[email protected]>Cheers,
-- DavidQuoted 15 lines
.gitignore | 1 + 1 file changed, 1 insertion(+).gitignore +1
-0@@ -100,6 +100,7 @@ modules.order !.get_maintainer.ignore !.gitattributes !.gitignore +!.kunitconfig !.mailmap !.rustfmt.toml
Quoted 7 lines
Quoted 3 lines
Quoted 3 lines
--
2.39.0Why is this a dot file in the first place?
In short, historical reasons.
The long answer is that there are two places "kunitconfig" files are
used: as a user-provided file with their preferred test config (which is kept local), and as a recommended test config for a given subsystem (which is checked in).
Originally, no .kunitconfig files were checked in: one was either autogenerated or manually modified and left in the root source directory. This eventually moved into the build directory, and a number of features which de-emphasized it in favour of command-line arguments and the (new) checked-in per-subsystem configs, which probably shouldn't be hidden.
There's no fundamental reason (other than it being a bit annoying to rename everything and update the code) we can't change it, either for all kunitconfig files, or just the checked-in ones, if that's preferred.
-- David
Quoted 48 lines · David Gow
Quoted 36 lines · Masahiro Yamada
Quoted 34 lines · David Gow
Quoted 6 lines · Andy Shevchenko
There are almost dozen of .kunitconfig files that are ignored but tracked. Unignore them.
Signed-off-by Andy Shevchenko <[email protected]>---
Thanks! Only the original root-directory .kunitignore file was intended to be ignored, and that's no longer as important, and is now in the build dir anyway.
Reviewed-by David Gow <[email protected]>Cheers,
-- DavidQuoted 15 lines
.gitignore | 1 + 1 file changed, 1 insertion(+).gitignore +1
-0@@ -100,6 +100,7 @@ modules.order !.get_maintainer.ignore !.gitattributes !.gitignore +!.kunitconfig !.mailmap !.rustfmt.tomlQuoted 7 lines
Quoted 3 lines
Quoted 3 lines
--
2.39.0Why is this a dot file in the first place?
In short, historical reasons.
Quoted 10 lines
The long answer is that there are two places "kunitconfig" files are
used: as a user-provided file with their preferred test config (which is kept local), and as a recommended test config for a given subsystem (which is checked in).
Originally, no .kunitconfig files were checked in: one was either autogenerated or manually modified and left in the root source directory. This eventually moved into the build directory, and a number of features which de-emphasized it in favour of command-line arguments and the (new) checked-in per-subsystem configs, which probably shouldn't be hidden.
Do you mean there are two types for .kunitconfig - auto-generated ones and check-in ones?
If this patch is applied, is there a possibility where auto-generated .kunitconfig files would be accidentally added to the repository?
Quoted 6 lines
There's no fundamental reason (other than it being a bit annoying to rename everything and update the code) we can't change it, either for all kunitconfig files, or just the checked-in ones, if that's preferred.
-- David
Signature · 2 lines
Best Regards Masahiro Yamada
Quoted 62 lines · Masahiro Yamada
Quoted 48 lines · David Gow
Quoted 36 lines · Masahiro Yamada
Quoted 34 lines · David Gow
Quoted 6 lines · Andy Shevchenko
There are almost dozen of .kunitconfig files that are ignored but tracked. Unignore them.
Signed-off-by Andy Shevchenko <[email protected]>---
Thanks! Only the original root-directory .kunitignore file was intended to be ignored, and that's no longer as important, and is now in the build dir anyway.
Reviewed-by David Gow <[email protected]>Cheers,
-- DavidQuoted 15 lines
.gitignore | 1 + 1 file changed, 1 insertion(+).gitignore +1
-0@@ -100,6 +100,7 @@ modules.order !.get_maintainer.ignore !.gitattributes !.gitignore +!.kunitconfig !.mailmap !.rustfmt.tomlQuoted 7 lines
Quoted 3 lines
Quoted 3 lines
--
2.39.0Why is this a dot file in the first place?
In short, historical reasons.
Quoted 10 lines
The long answer is that there are two places "kunitconfig" files are
used: as a user-provided file with their preferred test config (which is kept local), and as a recommended test config for a given subsystem (which is checked in).
Originally, no .kunitconfig files were checked in: one was either autogenerated or manually modified and left in the root source directory. This eventually moved into the build directory, and a number of features which de-emphasized it in favour of command-line arguments and the (new) checked-in per-subsystem configs, which probably shouldn't be hidden.
Quoted 8 lines
Do you mean there are two types for .kunitconfig - auto-generated ones and check-in ones?
If this patch is applied, is there a possibility where auto-generated .kunitconfig files would be accidentally added to the repository?
I wouldn't think so -- the auto-generated ones live in the build directory (which is itself '.kunit' by default). You'd have to go out of your way to do an in-tree build, and then add generated files.
-- David
Quoted 2 lines · Andy Shevchenko
There are almost dozen of .kunitconfig files that are ignored but tracked. Unignore them.
It's still an issue, can we apply this patch or can somebody to propose the better sooner than later, please?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 8 lines · Andy Shevchenko
Quoted 2 lines · Andy Shevchenko
There are almost dozen of .kunitconfig files that are ignored but tracked. Unignore them.
It's still an issue, can we apply this patch or can somebody to propose the better sooner than later, please?
Agreed.
Masahiro, Shuah: who wants to pick this up? I'm happy either way.
Cheers,
-- David