Skip to contentSkip to conversation

drm/mediatek: Remove unused GEM DMA header include

PATCH Applied Rob Clark 3 participants 3 messages Jan 27, 2023 – Jan 29, 2023

Subsystems (3)
lore
Share & tools
lore

Rob Clark

author
#0 lore raw

PATCH 1/1 drm/mediatek: Remove unused GEM DMA header include

From: Rob Clark <[email protected]>

No longer needed since the removal of dependency on DMA helper.

Fixes 2ea8aec56bf1 ("drm/mediatek: Remove dependency on GEM DMA helper")
---
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/mediatek/mtk_drm_drv.c +1 -1
index cd5b18ef7951..7e2fad8e8444 100644
@@ -20,8 +20,8 @@
 #include <drm/drm_fbdev_generic.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem.h>
-#include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_ioctl.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
Signature · 1 line
2.38.1
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 7 lines · Rob Clark

From: Rob Clark <[email protected]>

No longer needed since the removal of dependency on DMA helper.

Fixes 2ea8aec56bf1 ("drm/mediatek: Remove dependency on GEM DMA helper")
Quoted 9 lines
---
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/mediatek/mtk_drm_drv.c +0 -0
index cd5b18ef7951..7e2fad8e8444 100644

drivers/gpu/drm/mediatek/mtk_drm_drv.c line 24

Quoted 6 lines
drivers/gpu/drm/mediatek/mtk_drm_drv.c +1 -1
@@ -20,8 +20,8 @@
 #include <drm/drm_fbdev_generic.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem.h>
-#include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_ioctl.h>

It took me a little while to realize why you needed this extra include. I guess DEFINE_DRM_GEM_FOPS implicitly refers to drm_ioctl(). Seems like really drm_gem.h ought to be the one including drm_ioctl.h, but maybe there's a good reason why we don't do that?

-Doug

maintainer Applied
#2 lore raw
In reply to Rob Clark

Hi, Rob:

Rob Clark <[email protected]> 於 2023年1月28日 週六 上午12:54寫道:

Quoted 4 lines

From: Rob Clark <[email protected]>

No longer needed since the removal of dependency on DMA helper.

Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.

Quoted 24 lines
Fixes 2ea8aec56bf1 ("drm/mediatek: Remove dependency on GEM DMA helper")
---
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/mediatek/mtk_drm_drv.c +1 -2
index cd5b18ef7951..7e2fad8e8444 100644
@@ -20,8 +20,8 @@
 #include <drm/drm_fbdev_generic.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem.h>
-#include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_ioctl.h>
 #include <drm/drm_of.h>
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_vblank.h>
--

2.38.1