Skip to contentSkip to conversation

ap: correct extra IEs length calculation for WMM IE

PATCH Applied James Prestwood 2 participants 2 messages Jan 27, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ap: correct extra IEs length calculation for WMM IE

The extra IE length for the WMM IE was being set to 26 which is the HT IE length, not WMM. Fix this and use the proper size for the WMM IE of 50 bytes.

This shouldn't have caused any problems prior as the tail length is always allocated with 256 or 512 extra bytes of headroom.

---
 src/ap.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
src/ap.c +2 -1
index 10cc0f00..b51befe4 100644
@@ -939,8 +939,9 @@ static size_t ap_get_extra_ies_len(struct ap_state *ap,
 
 	len += ap_get_wsc_ie_len(ap, type, client_frame, client_frame_len);
 
+	/* WMM IE length */
 	if (ap->supports_ht)
-		len += 26;
+		len += 50;
 
 	if (ap->ops->get_extra_ies_len)
 		len += ap->ops->get_extra_ies_len(type, client_frame,
Signature · 1 line
2.34.3
#1 lore raw

Hi James,

Quoted 10 lines · James Prestwood

The extra IE length for the WMM IE was being set to 26 which is the HT IE length, not WMM. Fix this and use the proper size for the WMM IE of 50 bytes.

This shouldn't have caused any problems prior as the tail length is always allocated with 256 or 512 extra bytes of headroom.

---
  src/ap.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks.

Regards,
-Denis