Skip to contentSkip to conversation

dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible

PATCH Applied Bartosz Golaszewski 4 participants 7 messages Jan 27, 2023 – Feb 9, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible

From: Bartosz Golaszewski <[email protected]>

Add a compatible for the sa8775p platform's Secure Channel Manager firmware interface.

---
 Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/firmware/qcom,scm.yaml +1 -0
index 4193492ba73e..fd3c787e44a8 100644
@@ -39,6 +39,7 @@ properties:
           - qcom,scm-msm8996
           - qcom,scm-msm8998
           - qcom,scm-qdu1000
+          - qcom,scm-sa8775p
           - qcom,scm-sc7180
           - qcom,scm-sc7280
           - qcom,scm-sc8280xp
Signature · 1 line
2.37.2
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add a compatible for the sa8775p platform's Secure Channel Manager firmware interface.

---
 Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
 1 file changed, 1 insertion(+)

If you send bindings separately from DTS (which is fine), please provide the link to the user - either DTS or driver for this compatible. Driver does not use it, thus to the DTS.

Best regards,
Krzysztof

#2 lore raw
Quoted 12 lines · Krzysztof Kozlowski
Quoted 9 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add a compatible for the sa8775p platform's Secure Channel Manager firmware interface.

---
 Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
 1 file changed, 1 insertion(+)
Quoted 6 lines

If you send bindings separately from DTS (which is fine), please provide the link to the user - either DTS or driver for this compatible. Driver does not use it, thus to the DTS.

Can you specify what kind of link you're expecting? I'm looking at previous commits for this file and not seeing anything. There's no upstream user of this compatible in any DTS yet.

Bart

#3 lore raw
Quoted 18 lines · Bartosz Golaszewski
Quoted 16 lines · Krzysztof Kozlowski
Quoted 9 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add a compatible for the sa8775p platform's Secure Channel Manager firmware interface.

---
 Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
 1 file changed, 1 insertion(+)

If you send bindings separately from DTS (which is fine), please provide the link to the user - either DTS or driver for this compatible. Driver does not use it, thus to the DTS.

Quoted 6 lines
Quoted 2 lines

Can you specify what kind of link you're expecting? I'm looking at previous commits for this file and not seeing anything. There's no upstream user of this compatible in any DTS yet.

I expect lore link to the patchset you sent using this binding, so we can verify whether you used it correctly or not. If people were testing their DTS against bindings they write, this would not be needed. Unfortunately people do not do that...

Best regards,
Krzysztof

#4 lore raw
Quoted 28 lines · Krzysztof Kozlowski
Quoted 18 lines · Bartosz Golaszewski
Quoted 16 lines · Krzysztof Kozlowski
Quoted 9 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add a compatible for the sa8775p platform's Secure Channel Manager firmware interface.

---
 Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
 1 file changed, 1 insertion(+)

If you send bindings separately from DTS (which is fine), please provide the link to the user - either DTS or driver for this compatible. Driver does not use it, thus to the DTS.

Quoted 6 lines
Quoted 2 lines

Can you specify what kind of link you're expecting? I'm looking at previous commits for this file and not seeing anything. There's no upstream user of this compatible in any DTS yet.

Quoted 5 lines

I expect lore link to the patchset you sent using this binding, so we can verify whether you used it correctly or not. If people were testing their DTS against bindings they write, this would not be needed. Unfortunately people do not do that...

Touché. I am making sure v2 passes dtbs_check though. :)

v1 didn't have this compatible and used the fallback directly, hence this patch being sent before v2. There's no link yet, as I'm still polishing the dts for sa8775p-ride. Will remember to add one in the future.

Bart

maintainer Applied
#5 lore raw
In reply to Bartosz Golaszewski
Quoted 6 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add a compatible for the sa8775p platform's Secure Channel Manager firmware interface.

Applied, thanks!

[1/1] dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible

      commit: 27d71e8063d99b4429832bc52de171ace6b1e562

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>
#6 lore raw
Quoted 9 lines · Bjorn Andersson
Quoted 6 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add a compatible for the sa8775p platform's Secure Channel Manager firmware interface.

Quoted 8 lines

Applied, thanks!

[1/1] dt-bindings: firmware: qcom,scm: add qcom,scm-sa8775p compatible

      commit: 27d71e8063d99b4429832bc52de171ace6b1e562

Best regards,
--
Bjorn Andersson <[email protected]>

Bjorn,

FYI I resent this patch as part of an integration series later[1] as per Krzysztof's suggestion. Could you pick the entire thing up too?

Thanks!
Bart

[1] https://lore.kernel.org/linux-arm-msm/[email protected]/