Skip to contentSkip to conversation

i2c: xiic: Use devm_platform_get_and_ioremap_resource()

PATCH In review [email protected] 3 participants 3 messages Jan 28, 2023 – Feb 12, 2023

Subsystems (2)
I2C subsystem host drivers Arm/Zynq architecture
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 i2c: xiic: Use devm_platform_get_and_ioremap_resource()

From: ye xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.

Signed-off-by ye xingchen <[email protected]>
---
 drivers/i2c/busses/i2c-xiic.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/i2c/busses/i2c-xiic.c +1 -3
index bee5a2ef1f22..5114888f2916 100644
@@ -752,7 +752,6 @@ static int xiic_i2c_probe(struct platform_device *pdev)
 {
 	struct xiic_i2c *i2c;
 	struct xiic_i2c_platform_data *pdata;
-	struct resource *res;
 	int ret, irq;
 	u8 i;
 	u32 sr;

@@ -761,8 +760,7 @@ static int xiic_i2c_probe(struct platform_device *pdev)
 	if (!i2c)
 		return -ENOMEM;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	i2c->base = devm_ioremap_resource(&pdev->dev, res);
+	i2c->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
 	if (IS_ERR(i2c->base))
 		return PTR_ERR(i2c->base);
Signature · 1 line
2.25.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · On 1/28/23 07:53, [email protected] wrote:

From: ye xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.

Signed-off-by ye xingchen <[email protected]>

note: in my part of world name is starting with upper letter

Quoted 27 lines
---
  drivers/i2c/busses/i2c-xiic.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/i2c/busses/i2c-xiic.c +1 -4
index bee5a2ef1f22..5114888f2916 100644
@@ -752,7 +752,6 @@ static int xiic_i2c_probe(struct platform_device *pdev)
  {
         struct xiic_i2c *i2c;
         struct xiic_i2c_platform_data *pdata;
-       struct resource *res;
         int ret, irq;
         u8 i;
         u32 sr;

@@ -761,8 +760,7 @@ static int xiic_i2c_probe(struct platform_device *pdev)
         if (!i2c)
                 return -ENOMEM;
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       i2c->base = devm_ioremap_resource(&pdev->dev, res);
+       i2c->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
         if (IS_ERR(i2c->base))
                 return PTR_ERR(i2c->base);
 
--
Quoted 1 line

2.25.1

Reviewed-by Michal Simek <[email protected]>

Thanks,
Michal

#2 lore raw
In reply to [email protected]
Quoted 7 lines · On Sat, Jan 28, 2023 at 02:53:12PM +0800, [email protected] wrote:

From: ye xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.

Signed-off-by ye xingchen <[email protected]>

Could you kindly rebase this to i2c/for-next or i2c/for-mergewindow? An earlier series for xiic has been applied there. Thanks!