Skip to contentSkip to conversation

configs: imx8mn_bsh_smm_s2: remove console from bootargs

PATCH RESEND Superseded Dario Binacchi 2 participants 4 messages Jan 28, 2023 – Jan 29, 2023 Arm i.MX and Layerscape

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 configs: imx8mn_bsh_smm_s2: remove console from bootargs

The Linux kernel device tree already specifies the device to be used for boot console output with a stdout-path property under /chosen.

Fixes 36b661dc919da ("Merge branch 'next'")

---

 include/configs/imx8mn_bsh_smm_s2.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/imx8mn_bsh_smm_s2.h +1 -1
index e97b8e871d22..deeed9c2f582 100644
@@ -14,7 +14,7 @@
 #include <config_distro_bootcmd.h>
 
 #define NANDARGS \
-	"nandargs=setenv bootargs console=${console} " \
+	"nandargs=setenv bootargs " \
 		"${optargs} " \
 		"mtdparts=${mtdparts} " \
 		"root=${nandroot} " \
Signature · 1 line
2.32.0
reviewer Reviewed-by on v1 1/1
#1 lore raw

Hi Dario,

Quoted 5 lines · Dario Binacchi

The Linux kernel device tree already specifies the device to be used for boot console output with a stdout-path property under /chosen.

Fixes 36b661dc919da ("Merge branch 'next'")

The patch looks good, but I don't understand why this needs a Fixes tag.

#2 lore raw

Hi Fabio,

Quoted 6 lines · Fabio Estevam

Hi Dario,

Quoted 1 line · Dario Binacchi
Quoted 6 lines
Quoted 4 lines

The Linux kernel device tree already specifies the device to be used for boot console output with a stdout-path property under /chosen.

Fixes 36b661dc919da ("Merge branch 'next'")

The patch looks good, but I don't understand why this needs a Fixes tag.

The patch re-added 'console=${console}':

include/configs/imx8mn_bsh_smm_s2.h +0 -0
diff --cc include/configs/imx8mn_bsh_smm_s2.h
index d09c2ab01610,84c19824bdca..c6b296281424
@@@ -14,11 -14,8 +14,9 @@@
  #include <config_distro_bootcmd.h>

#define NANDARGS \

-       "mtdids=" CONFIG_MTDIDS_DEFAULT "\0" \
-       "mtdparts=" CONFIG_MTDPARTS_DEFAULT "\0" \
-       "nandargs=setenv bootargs " \
+       "nandargs=setenv bootargs console=${console} " \
                "${optargs} " \
 +              "mtdparts=${mtdparts} " \
                "root=${nandroot} " \
                "rootfstype=${nandrootfstype}\0" \
        "nandroot=ubi0:root rw ubi.mtd=nandrootfs\0" \

that I already removed in the commit:
bede82f75075 ("configs: imx8mn_bsh_smm_s2: remove console from bootargs"). This is why I decided to add the fix tag.

Thanks and regards,
Dario

Quoted 2 lines
Signature · 17 lines
Dario Binacchi

Senior Embedded Linux Developer

[email protected]

__________________________________


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
[email protected]

www.amarulasolutions.com
reviewer
#3 lore raw
Quoted 19 lines · Dario Binacchi

The patch re-added 'console=${console}':

include/configs/imx8mn_bsh_smm_s2.h +1 -3
diff --cc include/configs/imx8mn_bsh_smm_s2.h
index d09c2ab01610,84c19824bdca..c6b296281424
@@@ -14,11 -14,8 +14,9 @@@
  #include <config_distro_bootcmd.h>
 
  #define NANDARGS \
-       "mtdids=" CONFIG_MTDIDS_DEFAULT "\0" \
-       "mtdparts=" CONFIG_MTDPARTS_DEFAULT "\0" \
-       "nandargs=setenv bootargs " \
+       "nandargs=setenv bootargs console=${console} " \
                "${optargs} " \
 +              "mtdparts=${mtdparts} " \
                "root=${nandroot} " \
                "rootfstype=${nandrootfstype}\0" \
        "nandroot=ubi0:root rw ubi.mtd=nandrootfs\0" \
Quoted 3 lines

that I already removed in the commit:
bede82f75075 ("configs: imx8mn_bsh_smm_s2: remove console from bootargs"). This is why I decided to add the fix tag.

Understood.

It would be nice to have such an explanation in the commit log.