Skip to contentSkip to conversation

nghttp2: Always enable python bindings

PATCH In review Khem Raj 1 participant 2 messages Jan 28, 2023 – Jan 29, 2023

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 nghttp2: Always enable python bindings

This makes the build host agnostic, otherwise on some hosts e.g. (archlinux) it ends up using cython compiler from build host, mixing python3-native and cython from host is not a tested combination and can result in obscure errors. Lets make it use cython from OE native packages and also enable the bindings explicitly.

---
 meta/recipes-support/nghttp2/nghttp2_1.51.0.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-support/nghttp2/nghttp2_1.51.0.bb +3 -1
index fc1a592200..4402b80d1a 100644
@@ -4,6 +4,8 @@ SECTION = "libs"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://COPYING;md5=764abdf30b2eadd37ce47dcbce0ea1ec"
 
+DEPENDS += "python3-cython-native"
+
 SRC_URI = "\
     ${GITHUB_BASE_URI}/download/v${PV}/nghttp2-${PV}.tar.xz \
     file://0001-fetch-ocsp-response-use-python3.patch \
@@ -15,7 +17,7 @@ PACKAGECONFIG[manpages] = ""
 
 # examples are never installed, and don't need to be built in the
 # first place
-EXTRA_OECMAKE = "-DENABLE_EXAMPLES=OFF -DENABLE_APP=OFF -DENABLE_HPACK_TOOLS=OFF"
+EXTRA_OECMAKE = "-DENABLE_EXAMPLES=OFF -DENABLE_APP=OFF -DENABLE_HPACK_TOOLS=OFF -DENABLE_PYTHON_BINDINGS=ON"
 
 PACKAGES =+ "lib${BPN} ${PN}-client ${PN}-proxy ${PN}-server"
 
Signature · 1 line
2.39.1
author
#1 lore raw

I have sent a v2, please disregard this one.

Quoted 37 lines · Khem Raj

This makes the build host agnostic, otherwise on some hosts e.g. (archlinux) it ends up using cython compiler from build host, mixing python3-native and cython from host is not a tested combination and can result in obscure errors. Lets make it use cython from OE native packages and also enable the bindings explicitly.

---
 meta/recipes-support/nghttp2/nghttp2_1.51.0.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-support/nghttp2/nghttp2_1.51.0.bb +3 -2
index fc1a592200..4402b80d1a 100644
@@ -4,6 +4,8 @@ SECTION = "libs"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://COPYING;md5=764abdf30b2eadd37ce47dcbce0ea1ec"
 
+DEPENDS += "python3-cython-native"
+
 SRC_URI = "\
     ${GITHUB_BASE_URI}/download/v${PV}/nghttp2-${PV}.tar.xz \
     file://0001-fetch-ocsp-response-use-python3.patch \
@@ -15,7 +17,7 @@ PACKAGECONFIG[manpages] = ""
 
 # examples are never installed, and don't need to be built in the
 # first place
-EXTRA_OECMAKE = "-DENABLE_EXAMPLES=OFF -DENABLE_APP=OFF -DENABLE_HPACK_TOOLS=OFF"
+EXTRA_OECMAKE = "-DENABLE_EXAMPLES=OFF -DENABLE_APP=OFF -DENABLE_HPACK_TOOLS=OFF -DENABLE_PYTHON_BINDINGS=ON"
 
 PACKAGES =+ "lib${BPN} ${PN}-client ${PN}-proxy ${PN}-server"
 
--

2.39.1