Skip to contentSkip to conversation

dt-bindings: mmc: Add cap-aggressive-pm property

PATCH Superseded Hermes Zhang 3 participants 5 messages Jan 29, 2023 – Feb 2, 2023 1 message not in the archive

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: mmc: Add cap-aggressive-pm property

This commit add a new property: cap-aggressive-pm to enable the MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.

---
 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/mmc/mmc-controller.yaml +5 -0
index 86c73fd825fd..7ca674263dba 100644
@@ -177,6 +177,11 @@ properties:
     description:
       enable SDIO IRQ signalling on this interface
 
+  cap-aggressive-pm:
+    $ref: /schemas/types.yaml#/definitions/flag
+    description:
+      enable MMC_CAP_AGGRESSIVE_PM feature
+
   full-pwr-cycle:
     $ref: /schemas/types.yaml#/definitions/flag
     description:
Signature · 1 line
2.30.2
#1 lore raw
Quoted 1 line · Hermes Zhang

This commit add a new property: cap-aggressive-pm to enable the

Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

Quoted 1 line

MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.

Why this is a property suitable for DT? IOW, why this isn't enabled always?

Quoted 5 lines
---
 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Best regards,
Krzysztof

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 8 lines · Hermes Zhang
Quoted 4 lines · Krzysztof Kozlowski
Quoted 1 line · Hermes Zhang

This commit add a new property: cap-aggressive-pm to enable the

Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

Done

Quoted 8 lines
Quoted 2 lines
Quoted 1 line

MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.

Why this is a property suitable for DT? IOW, why this isn't enabled always?

This property will benfit for the power consumption, but it also may degradation in performance as it will prevent the

the card from executing internal house-keeping operations in idle mode. So it's better to config it from DT.

Why? DT is not for policy. How you described it, this is policy or system tuning choice thus the job for Linux (OS), not for DT. So I will repeat - why this property fits the purpose of DT (describe the hardware).

Best regards,
Krzysztof

#4 lore raw
Quoted 16 lines · Krzysztof Kozlowski
Quoted 14 lines · Hermes Zhang
Quoted 4 lines · Krzysztof Kozlowski
Quoted 1 line · Hermes Zhang

This commit add a new property: cap-aggressive-pm to enable the

Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

Done

Quoted 2 lines
Quoted 1 line

MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.

Why this is a property suitable for DT? IOW, why this isn't enabled always?

This property will benfit for the power consumption, but it also may degradation in performance as it will prevent the

Quoted 7 lines
Quoted 2 lines

the card from executing internal house-keeping operations in idle mode. So it's better to config it from DT.

Why? DT is not for policy. How you described it, this is policy or system tuning choice thus the job for Linux (OS), not for DT. So I will repeat - why this property fits the purpose of DT (describe the hardware).

I guess the HW perspective here, is that it might not fit all platforms nor the actual eMMC/SD card to support this feature. However, it still seems like a policy rather than a strict HW constraint.

Perhaps there is a way to figure out in the host driver, to conditionally set the MMC_CAP_AGGRESSIVE_PM for the host, when needed instead?

Kind regards
Uffe

#5 lore raw
Quoted 26 lines · Ulf Hansson
Quoted 16 lines · Krzysztof Kozlowski
Quoted 14 lines · Hermes Zhang
Quoted 4 lines · Krzysztof Kozlowski
Quoted 1 line · Hermes Zhang

This commit add a new property: cap-aggressive-pm to enable the

Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

Done

Quoted 2 lines
Quoted 1 line

MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.

Why this is a property suitable for DT? IOW, why this isn't enabled always?

This property will benfit for the power consumption, but it also may degradation in performance as it will prevent the

Quoted 7 lines
Quoted 2 lines

the card from executing internal house-keeping operations in idle mode. So it's better to config it from DT.

Why? DT is not for policy. How you described it, this is policy or system tuning choice thus the job for Linux (OS), not for DT. So I will repeat - why this property fits the purpose of DT (describe the hardware).

Quoted 8 lines

I guess the HW perspective here, is that it might not fit all platforms nor the actual eMMC/SD card to support this feature. However, it still seems like a policy rather than a strict HW constraint.

Perhaps there is a way to figure out in the host driver, to conditionally set the MMC_CAP_AGGRESSIVE_PM for the host, when needed instead?

What also worries me is that there is no user of this property: no DTS, no driver, so it is tricky to deduct out when it is applicable.

Anyway things which might be obvious for the submitter, might not be for the reviewer, thus I would really like to see justification why different boards (or memories) need this property.

Best regards,
Krzysztof