Skip to contentSkip to conversation

Documentation: riscv: fix insufficient list item indent

PATCH Applied Conor Dooley 6 participants 9 messages Jan 29, 2023 – Feb 15, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation: riscv: fix insufficient list item indent

From: Conor Dooley <[email protected]>

When adding the ISA string ordering rules, I didn't sufficiently indent one of the list items.

Fixes f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
---
 Documentation/riscv/uabi.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Documentation/riscv/uabi.rst +4 -4
index 2ebec4c52230..8960fac42c40 100644
@@ -21,10 +21,10 @@ so for our purposes the following rules apply:
    single-letter extensions and before any higher-privileged extensions.
 
 #. For additional standard extensions, the first letter following the 'Z'
-  conventionally indicates the most closely related alphabetical
-  extension category. If multiple 'Z' extensions are named, they will be ordered
-  first by category, in canonical order, as listed above, then alphabetically
-  within a category.
+   conventionally indicates the most closely related alphabetical
+   extension category. If multiple 'Z' extensions are named, they will be
+   ordered first by category, in canonical order, as listed above, then
+   alphabetically within a category.
 
 #. Standard supervisor-level extensions (starting with 'S') will be listed
    after standard unprivileged extensions.  If multiple supervisor-level
Signature · 1 line
2.39.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Conor Dooley

From: Conor Dooley <[email protected]>

When adding the ISA string ordering rules, I didn't sufficiently indent one of the list items.

Fixes f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")

Seems like you forget to add link to the report:

Quoted 13 lines
---
 Documentation/riscv/uabi.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Documentation/riscv/uabi.rst +0 -1
index 2ebec4c52230..8960fac42c40 100644
@@ -21,10 +21,10 @@ so for our purposes the following rules apply:
    single-letter extensions and before any higher-privileged extensions.
 
 #. For additional standard extensions, the first letter following the 'Z'
-  conventionally indicates the most closely related alphabetical

Documentation/riscv/uabi.rst so for our purposes the following rules apply: · line 30

Quoted 10 lines
Documentation/riscv/uabi.rst +4 -3
-  extension category. If multiple 'Z' extensions are named, they will be ordered
-  first by category, in canonical order, as listed above, then alphabetically
-  within a category.
+   conventionally indicates the most closely related alphabetical
+   extension category. If multiple 'Z' extensions are named, they will be
+   ordered first by category, in canonical order, as listed above, then
+   alphabetically within a category.
 
 #. Standard supervisor-level extensions (starting with 'S') will be listed
    after standard unprivileged extensions.  If multiple supervisor-level

The warning is fixed, thanks!

Signature · 1 line
An old man doll... just what I always wanted! - Clara
#2 lore raw
Quoted 6 lines · Bagas Sanjaya
Quoted 5 lines · Conor Dooley

From: Conor Dooley <[email protected]>

When adding the ISA string ordering rules, I didn't sufficiently indent one of the list items.

Quoted 7 lines
Quoted 3 lines
Fixes f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")

Seems like you forget to add link to the report:

No, I didn't forget actually. I just didn't think it added any useful information. No harm having it though I suppose, but I'll not resend to add it.

Thanks,
Conor.

#5 lore raw
In reply to Conor Dooley

Hey Palmer,

If you do end up having WiFi could you pick this up so that the regressions report thingy stops whining at me?

Thanks!

Quoted 40 lines · Conor Dooley

From: Conor Dooley <[email protected]>

When adding the ISA string ordering rules, I didn't sufficiently indent one of the list items.

Fixes f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
---
 Documentation/riscv/uabi.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Documentation/riscv/uabi.rst +4 -4
index 2ebec4c52230..8960fac42c40 100644
@@ -21,10 +21,10 @@ so for our purposes the following rules apply:
    single-letter extensions and before any higher-privileged extensions.
 
 #. For additional standard extensions, the first letter following the 'Z'
-  conventionally indicates the most closely related alphabetical
-  extension category. If multiple 'Z' extensions are named, they will be ordered
-  first by category, in canonical order, as listed above, then alphabetically
-  within a category.
+   conventionally indicates the most closely related alphabetical
+   extension category. If multiple 'Z' extensions are named, they will be
+   ordered first by category, in canonical order, as listed above, then
+   alphabetically within a category.
 
 #. Standard supervisor-level extensions (starting with 'S') will be listed
    after standard unprivileged extensions.  If multiple supervisor-level
Signature · 7 lines
2.39.1


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

maintainer
#6 lore raw
In reply to Conor Dooley
Quoted 4 lines · Conor Dooley

Hey Palmer,

If you do end up having WiFi could you pick this up so that the regressions report thingy stops whining at me?

Sorry I forgot about this one, it's on for-next.

Quoted 44 lines

Thanks!

Quoted 40 lines · Conor Dooley

From: Conor Dooley <[email protected]>

When adding the ISA string ordering rules, I didn't sufficiently indent one of the list items.

Fixes f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
---
 Documentation/riscv/uabi.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Documentation/riscv/uabi.rst +4 -4
index 2ebec4c52230..8960fac42c40 100644
@@ -21,10 +21,10 @@ so for our purposes the following rules apply:
    single-letter extensions and before any higher-privileged extensions.
 
 #. For additional standard extensions, the first letter following the 'Z'
-  conventionally indicates the most closely related alphabetical
-  extension category. If multiple 'Z' extensions are named, they will be ordered
-  first by category, in canonical order, as listed above, then alphabetically
-  within a category.
+   conventionally indicates the most closely related alphabetical
+   extension category. If multiple 'Z' extensions are named, they will be
+   ordered first by category, in canonical order, as listed above, then
+   alphabetically within a category.
 
 #. Standard supervisor-level extensions (starting with 'S') will be listed
    after standard unprivileged extensions.  If multiple supervisor-level
Signature · 7 lines
2.39.1


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
maintainer
#3 lore raw
In reply to Bagas Sanjaya
Quoted 6 lines · On Sun, 29 Jan 2023 19:05:53 PST (-0800), [email protected] wrote:
Quoted 5 lines · Conor Dooley

From: Conor Dooley <[email protected]>

When adding the ISA string ordering rules, I didn't sufficiently indent one of the list items.

Quoted 7 lines
Quoted 3 lines
Fixes f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")

Seems like you forget to add link to the report:

Is that the normal way to do it? I've only been adding the Reported-by like the bot suggests, but I guess it's kind of nice information to have the bug report as well. From looking at git history it's kind of a mix.

Maybe the bot should suggest this in the bug report, right next to the other tag?

Quoted 30 lines
Quoted 13 lines
---
 Documentation/riscv/uabi.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Documentation/riscv/uabi.rst +0 -1
index 2ebec4c52230..8960fac42c40 100644
@@ -21,10 +21,10 @@ so for our purposes the following rules apply:
    single-letter extensions and before any higher-privileged extensions.
 
 #. For additional standard extensions, the first letter following the 'Z'
-  conventionally indicates the most closely related alphabetical

Documentation/riscv/uabi.rst so for our purposes the following rules apply: · line 30

Quoted 10 lines
Documentation/riscv/uabi.rst +4 -3
-  extension category. If multiple 'Z' extensions are named, they will be ordered
-  first by category, in canonical order, as listed above, then alphabetically
-  within a category.
+   conventionally indicates the most closely related alphabetical
+   extension category. If multiple 'Z' extensions are named, they will be
+   ordered first by category, in canonical order, as listed above, then
+   alphabetically within a category.
 
 #. Standard supervisor-level extensions (starting with 'S') will be listed
    after standard unprivileged extensions.  If multiple supervisor-level

The warning is fixed, thanks!

Signature · 1 line
An old man doll... just what I always wanted! - Clara
#4 lore raw
Quoted 11 lines · Palmer Dabbelt
Quoted 10 lines · On Sun, 29 Jan 2023 19:05:53 PST (-0800), [email protected] wrote:
Quoted 8 lines · Conor Dooley

From: Conor Dooley <[email protected]>

When adding the ISA string ordering rules, I didn't sufficiently indent one of the list items.

Fixes f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")
Quoted 7 lines
Quoted 3 lines

Seems like you forget to add link to the report:

Is that the normal way to do it? I've only been adding the Reported-by like the bot suggests, but I guess it's kind of nice information to have the bug report as well. From looking at git history it's kind of a mix.

IMO it totally depends on whether there is something useful in the thread on lore. I see no point adding the links if they're just a regurgitation of something conveyed in a commit message.

But then again, I don't bother adding a lore link to patchsets I apply either. I'm in the Torvald's camp of only using those tags to link to things containing "actual new information". There was a discussion of that a while back, see [1] & [2] if you care, although it was largely born out of frustration at links added by maintainers to original submissions, not subjectively redundant bot emails.

Following that logic, I didn't bother adding one here, just as I wouldn't for a compilation error if I included it in the commit log.

We've probably spent more time typing emails about it than the issue warrants, but that's par for the course I suppose!

1 - https://lore.kernel.org/all/CAHk-=wj9zKJGA_6SJOMPiQEoYke6cKX-FV3X_5zNXOcFJX1kOQ@mail.gmail.com/
2 - https://lore.kernel.org/all/CAHk-=wgzRUT1fBpuz3xcN+YdsX0SxqOzHWRtj0ReHpUBb5TKbA@mail.gmail.com/

Quoted 2 lines

Maybe the bot should suggest this in the bug report, right next to the other tag?

Iff the bot knows its own message-id before sending, I think that could be nice to have. Does Intel's mail system may support that?

#8 lore raw
In reply to Conor Dooley
This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:

Hello:

This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt <[email protected]>:

Quoted 10 lines · On Sun, 29 Jan 2023 23:57:01 +0000 you wrote:

From: Conor Dooley <[email protected]>

When adding the ISA string ordering rules, I didn't sufficiently indent one of the list items.

Fixes f07b2b3f9d47 ("Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo")

[...]

Here is the summary with links:
- Documentation: riscv: fix insufficient list item indent

    https://git.kernel.org/riscv/c/2a5303b499b1

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html