drm/i915/ttm: fix sparse warning
Subsystems (7)
Matthew Auld
reviewerPATCH v2 1/6 drm/i915/ttm: fix sparse warning
Sparse complains with:
drivers/gpu/drm/i915/gem/i915_gem_ttm.c:1066:21: sparse:
expected restricted vm_fault_t [assigned] [usertype] retdrivers/gpu/drm/i915/gem/i915_gem_ttm.c:1066:21: sparse: got int
--- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +3 -2
@@ -1067,11 +1067,12 @@ static vm_fault_t vm_fault_ttm(struct vm_fault *vmf) .interruptible = true, .no_wait_gpu = true, /* should be idle already */ }; +int err;GEM_BUG_ON (!bo->ttm || !(bo->ttm->page_flags &TTM_TT_FLAG_SWAPPED )); - ret =ttm_bo_validate (bo,i915_ttm_sys_placement (), &ctx); -if (ret) { + err =ttm_bo_validate (bo,i915_ttm_sys_placement (), &ctx); +if (err) {dma_resv_unlock (bo->base.resv);return VM_FAULT_SIGBUS ; }
Signature · 1 line
2.39.1
Matthew Auld
reviewerPATCH v2 2/6 drm/i915/ttm: audit remaining bo->resource
In the near future TTM will have NULL bo->resource when the object is initially created, plus after calling into pipeline-gutting. Try to handle the remaining cases. In practice NULL bo->resource should be taken to mean swapped-out or purged object.
v2 (Andrzej):
- Rather make i915_ttm_cpu_maps_iomem() return false with NULL resource.
References: 516198d317d8 ("drm/i915: audit bo->resource usage v3")
--- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 10 ++++++++-- drivers/gpu/drm/i915/gem/i915_gem_ttm.h | 2 +- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 4 ++++ drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 7 +++++-- 4 files changed, 18 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +8 -2
@@ -472,7 +472,7 @@ static int i915_ttm_shrink(struct drm_i915_gem_object *obj, unsigned int flags)struct ttm_placement place = {};int ret; -if (!bo->ttm || bo->resource->mem_type !=TTM_PL_SYSTEM ) +if (!bo->ttm ||i915_ttm_cpu_maps_iomem (bo->resource))return 0 ;GEM_BUG_ON (!i915_tt->is_shmem);
@@ -511,7 +511,13 @@ static void i915_ttm_delete_mem_notify(struct ttm_buffer_object *bo) {struct drm_i915_gem_object *obj =i915_ttm_to_gem (bo); -if (bo->resource && !i915_ttm_is_ghost_object (bo)) { +/* +* This gets called twice by ttm, so long as we have a ttm resource or +* ttm_tt then we can still safely call this. Due to pipeline-gutting, +* we maybe have NULL bo->resource, but in that case we should always +* have a ttm alive (like if the pages are swapped out). +*/ +if ((bo->resource || bo->ttm) && !i915_ttm_is_ghost_object (bo)) {__i915_gem_object_pages_fini (obj);i915_ttm_free_cached_io_rsgt (obj); }
drivers/gpu/drm/i915/gem/i915_gem_ttm.h +1 -1
@@ -98,7 +98,7 @@ static inline bool i915_ttm_gtt_binds_lmem(struct ttm_resource *mem)static inline bool i915_ttm_cpu_maps_iomem (struct ttm_resource *mem) {/* Once / if we support GGTT, this is also false for cached ttm_tts */ -return mem->mem_type !=I915_PL_SYSTEM ; +return mem && mem->mem_type !=I915_PL_SYSTEM ; }bool i915_ttm_resource_mappable (struct ttm_resource *res);
drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c +4 -0
@@ -711,6 +711,10 @@ int i915_gem_obj_copy_ttm(struct drm_i915_gem_object *dst,assert_object_held (dst);assert_object_held (src); + +if (GEM_WARN_ON (!src_bo->resource || !dst_bo->resource)) +return -EINVAL ; +i915_deps_init (&deps,GFP_KERNEL | __GFP_NORETRY | __GFP_NOWARN); ret =dma_resv_reserve_fences (src_bo->base.resv,1 );
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c +5 -2
@@ -53,7 +53,7 @@ static int i915_ttm_backup(struct i915_gem_apply_to_region *apply,unsigned int flags;int err =0 ; -if (bo->resource->mem_type ==I915_PL_SYSTEM || obj->ttm.backup) +if (!i915_ttm_cpu_maps_iomem (bo->resource) || obj->ttm.backup)return 0 ;if (pm_apply->allow_gpu &&i915_gem_object_evictable (obj))
@@ -187,7 +187,10 @@ static int i915_ttm_restore(struct i915_gem_apply_to_region *apply,return err;/* Content may have been swapped. */ - err =ttm_tt_populate (backup_bo->bdev, backup_bo->ttm, &ctx); +if (!backup_bo->resource) + err =ttm_bo_validate (backup_bo,i915_ttm_sys_placement (), &ctx); +if (!err) + err =ttm_tt_populate (backup_bo->bdev, backup_bo->ttm, &ctx);if (!err) { err =i915_gem_obj_copy_ttm (obj, backup, pm_apply->allow_gpu, false);
Signature · 1 line
2.39.1
Re: [Intel-gfx] [PATCH v2 2/6] drm/i915/ttm: audit remaining bo->resource
Quoted 9 lines · Matthew Auld
In the near future TTM will have NULL
bo->resourcewhen the object is initially created, plus after calling into pipeline-gutting. Try to handle the remaining cases. In practice NULLbo->resourceshould be taken to mean swapped-out or purged object.v2 (Andrzej):
- Rather makei915_ttm_cpu_maps_iomem()return false with NULL resource.
Quoted 5 lines
References:
516198d317d8("drm/i915: auditbo->resourceusage v3")Signed-off-by Matthew Auld <[email protected]>Cc Christian König <[email protected]>Cc Nirmoy Das <[email protected]>Reviewed-by Andrzej Hajda <[email protected]>
Quoted 88 lines
--- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 10 ++++++++-- drivers/gpu/drm/i915/gem/i915_gem_ttm.h | 2 +- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 4 ++++ drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 7 +++++-- 4 files changed, 18 insertions(+), 5 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_ttm.c +8
-2@@ -472,7 +472,7 @@ static int i915_ttm_shrink(struct drm_i915_gem_object *obj, unsigned int flags)struct ttm_placement place = {};int ret; -if (!bo->ttm || bo->resource->mem_type !=TTM_PL_SYSTEM ) +if (!bo->ttm ||i915_ttm_cpu_maps_iomem (bo->resource))return 0 ;GEM_BUG_ON (!i915_tt->is_shmem);@@ -511,7 +511,13 @@ static void i915_ttm_delete_mem_notify(struct ttm_buffer_object *bo) {struct drm_i915_gem_object *obj =i915_ttm_to_gem (bo); -if (bo->resource && !i915_ttm_is_ghost_object (bo)) { +/* +* This gets called twice by ttm, so long as we have a ttm resource or +* ttm_tt then we can still safely call this. Due to pipeline-gutting, +* we maybe have NULL bo->resource, but in that case we should always +* have a ttm alive (like if the pages are swapped out). +*/ +if ((bo->resource || bo->ttm) && !i915_ttm_is_ghost_object (bo)) {__i915_gem_object_pages_fini (obj);i915_ttm_free_cached_io_rsgt (obj); }drivers/gpu/drm/i915/gem/i915_gem_ttm.h +1
-1@@ -98,7 +98,7 @@ static inline bool i915_ttm_gtt_binds_lmem(struct ttm_resource *mem)static inline bool i915_ttm_cpu_maps_iomem (struct ttm_resource *mem) {/* Once / if we support GGTT, this is also false for cached ttm_tts */ -return mem->mem_type !=I915_PL_SYSTEM ; +return mem && mem->mem_type !=I915_PL_SYSTEM ; }bool i915_ttm_resource_mappable (struct ttm_resource *res);drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c +4
-0@@ -711,6 +711,10 @@ int i915_gem_obj_copy_ttm(struct drm_i915_gem_object *dst,assert_object_held (dst);assert_object_held (src); + +if (GEM_WARN_ON (!src_bo->resource || !dst_bo->resource)) +return -EINVAL ; +i915_deps_init (&deps,GFP_KERNEL | __GFP_NORETRY | __GFP_NOWARN); ret =dma_resv_reserve_fences (src_bo->base.resv,1 );drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c +5
-2@@ -53,7 +53,7 @@ static int i915_ttm_backup(struct i915_gem_apply_to_region *apply,unsigned int flags;int err =0 ; -if (bo->resource->mem_type ==I915_PL_SYSTEM || obj->ttm.backup) +if (!i915_ttm_cpu_maps_iomem (bo->resource) || obj->ttm.backup)return 0 ;if (pm_apply->allow_gpu &&i915_gem_object_evictable (obj))@@ -187,7 +187,10 @@ static int i915_ttm_restore(struct i915_gem_apply_to_region *apply,return err;/* Content may have been swapped. */ - err =ttm_tt_populate (backup_bo->bdev, backup_bo->ttm, &ctx); +if (!backup_bo->resource) + err =ttm_bo_validate (backup_bo,i915_ttm_sys_placement (), &ctx); +if (!err) + err =ttm_tt_populate (backup_bo->bdev, backup_bo->ttm, &ctx);if (!err) { err =i915_gem_obj_copy_ttm (obj, backup, pm_apply->allow_gpu, false);
Matthew Auld
reviewerPATCH v2 3/6 drm/ttm: clear the ttm_tt when bo->resource is NULL
In reply to Matthew AuldIn the next few patches, when initially creating a ttm BO, the bo->resource is NULL, and the driver is then expected to handle the initial dummy move. However, if this is created as a system resource the first ttm_tt we create will always have the clear value set to false. Previously the initial ttm_tt would be created in ttm_bo_validate() with the clear parameter always set to true.
--- drivers/gpu/drm/ttm/ttm_bo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/ttm/ttm_bo.c +1 -2
@@ -120,8 +120,7 @@ static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo,bool old_use_tt, new_use_tt;int ret; - old_use_tt = bo->resource && -ttm_manager_type (bdev, bo->resource->mem_type)->use_tt; + old_use_tt = !bo->resource ||ttm_manager_type (bdev, bo->resource->mem_type)->use_tt; new_use_tt =ttm_manager_type (bdev, mem->mem_type)->use_tt;ttm_bo_unmap_virtual (bo);
Signature · 1 line
2.39.1
Re: [PATCH v2 3/6] drm/ttm: clear the ttm_tt when bo->resource is NULL
Quoted 10 lines · Matthew Auld
In the next few patches, when initially creating a ttm BO, the
bo->resourceis NULL, and the driver is then expected to handle the initial dummy move. However, if this is created as a system resource the firstttm_ttwe create will always have the clear value set to false. Previously the initialttm_ttwould be created inttm_bo_validate()with the clear parameter always set to true.Signed-off-by Matthew Auld <[email protected]>Cc Christian König <[email protected]>Reviewed-by Christian König <[email protected]>
Quoted 18 lines
--- drivers/gpu/drm/ttm/ttm_bo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/gpu/drm/ttm/ttm_bo.c +1
-2@@ -120,8 +120,7 @@ static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo,bool old_use_tt, new_use_tt;int ret; - old_use_tt = bo->resource && -ttm_manager_type (bdev, bo->resource->mem_type)->use_tt; + old_use_tt = !bo->resource ||ttm_manager_type (bdev, bo->resource->mem_type)->use_tt; new_use_tt =ttm_manager_type (bdev, mem->mem_type)->use_tt;ttm_bo_unmap_virtual (bo);
Matthew Auld
reviewerPATCH v2 4/6 drm/ttm: stop allocating dummy resources during BO creation
In reply to Matthew AuldFrom: Christian König <[email protected]>
That should not be necessary any more when drivers should at least be able to handle the move without a resource.
--- drivers/gpu/drm/ttm/ttm_bo.c | 7 ------- 1 file changed, 7 deletions(-)
drivers/gpu/drm/ttm/ttm_bo.c +0 -7
@@ -952,7 +952,6 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo, struct sg_table *sg, struct dma_resv *resv, void (*destroy) (struct ttm_buffer_object *)) { - static const struct ttm_place sys_mem = { .mem_type = TTM_PL_SYSTEM }; int ret;kref_init (&bo->kref);
@@ -969,12 +968,6 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo, bo->base.resv = &bo->base._resv;atomic_inc (&ttm_glob.bo_count); - ret =ttm_resource_alloc (bo, &sys_mem, &bo->resource); -if (unlikely (ret)) { -ttm_bo_put (bo); -return ret; - } -/* * For ttm_bo_type_device buffers, allocate * address space from the device.
Signature · 1 line
2.39.1
Re: [PATCH v2 4/6] drm/ttm: stop allocating dummy resources during BO creation
Quoted 8 lines · Matthew Auld
From: Christian König <[email protected]>
That should not be necessary any more when drivers should at least be able to handle the move without a resource.
Signed-off-by Christian König <[email protected]>Reviewed-by Matthew Auld <[email protected]>Signed-off-by Matthew Auld <[email protected]>
Quoted 29 lines
--- drivers/gpu/drm/ttm/ttm_bo.c | 7 ------- 1 file changed, 7 deletions(-)drivers/gpu/drm/ttm/ttm_bo.c +0
-7@@ -952,7 +952,6 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo, struct sg_table *sg, struct dma_resv *resv, void (*destroy) (struct ttm_buffer_object *)) { - static const struct ttm_place sys_mem = { .mem_type = TTM_PL_SYSTEM }; int ret;kref_init (&bo->kref);@@ -969,12 +968,6 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo, bo->base.resv = &bo->base._resv;atomic_inc (&ttm_glob.bo_count); - ret =ttm_resource_alloc (bo, &sys_mem, &bo->resource); -if (unlikely (ret)) { -ttm_bo_put (bo); -return ret; - } -/* * For ttm_bo_type_device buffers, allocate * address space from the device.
Matthew Auld
reviewerPATCH v2 5/6 drm/ttm: stop allocating a dummy resource for pipelined gutting
In reply to Matthew AuldFrom: Christian König <[email protected]>
That should not be necessary any more when drivers should at least be able to handle a move without a resource.
--- drivers/gpu/drm/ttm/ttm_bo_util.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-)
drivers/gpu/drm/ttm/ttm_bo_util.c +2 -13
@@ -704,30 +704,23 @@ EXPORT_SYMBOL(ttm_bo_move_sync_cleanup);*/ int ttm_bo_pipeline_gutting (struct ttm_buffer_object *bo) { -static const struct ttm_place sys_mem = { .mem_type =TTM_PL_SYSTEM };struct ttm_buffer_object *ghost; -struct ttm_resource *sys_res;struct ttm_tt *ttm;int ret; - ret =ttm_resource_alloc (bo, &sys_mem, &sys_res); -if (ret) -return ret; -/* If already idle, no need for ghost object dance. */ if (dma_resv_test_signaled (bo->base.resv,DMA_RESV_USAGE_BOOKKEEP )) {if (!bo->ttm) {/* See comment below about clearing. */ ret =ttm_tt_create (bo, true);if (ret) - goto error_free_sys_mem; +return ret; }else {ttm_tt_unpopulate (bo->bdev, bo->ttm);if (bo->type == ttm_bo_type_device)ttm_tt_mark_for_clear (bo->ttm); }ttm_resource_free (bo, &bo->resource); -ttm_bo_assign_mem (bo, sys_res);return 0 ; }
@@ -744,7 +737,7 @@ int ttm_bo_pipeline_gutting(struct ttm_buffer_object *bo) ret =ttm_tt_create (bo, true);swap (bo->ttm, ttm);if (ret) - goto error_free_sys_mem; +return ret; ret =ttm_buffer_object_transfer (bo, &ghost);if (ret)
@@ -760,13 +753,9 @@ int ttm_bo_pipeline_gutting(struct ttm_buffer_object *bo)dma_resv_unlock (&ghost->base._resv);ttm_bo_put (ghost); bo->ttm = ttm; -ttm_bo_assign_mem (bo, sys_res);return 0 ; error_destroy_tt:ttm_tt_destroy (bo->bdev, ttm); - -error_free_sys_mem: -ttm_resource_free (bo, &sys_res);return ret; }
Signature · 1 line
2.39.1
Re: [PATCH v2 5/6] drm/ttm: stop allocating a dummy resource for pipelined gutting
Quoted 8 lines · Matthew Auld
From: Christian König <[email protected]>
That should not be necessary any more when drivers should at least be able to handle a move without a resource.
Signed-off-by Christian König <[email protected]>Reviewed-by Matthew Auld <[email protected]>Signed-off-by Matthew Auld <[email protected]>
Quoted 63 lines
--- drivers/gpu/drm/ttm/ttm_bo_util.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-)drivers/gpu/drm/ttm/ttm_bo_util.c +2
-13@@ -704,30 +704,23 @@ EXPORT_SYMBOL(ttm_bo_move_sync_cleanup);*/ int ttm_bo_pipeline_gutting (struct ttm_buffer_object *bo) { -static const struct ttm_place sys_mem = { .mem_type =TTM_PL_SYSTEM };struct ttm_buffer_object *ghost; -struct ttm_resource *sys_res;struct ttm_tt *ttm;int ret; - ret =ttm_resource_alloc (bo, &sys_mem, &sys_res); -if (ret) -return ret; -/* If already idle, no need for ghost object dance. */ if (dma_resv_test_signaled (bo->base.resv,DMA_RESV_USAGE_BOOKKEEP )) {if (!bo->ttm) {/* See comment below about clearing. */ ret =ttm_tt_create (bo, true);if (ret) - goto error_free_sys_mem; +return ret; }else {ttm_tt_unpopulate (bo->bdev, bo->ttm);if (bo->type == ttm_bo_type_device)ttm_tt_mark_for_clear (bo->ttm); }ttm_resource_free (bo, &bo->resource); -ttm_bo_assign_mem (bo, sys_res);return 0 ; }@@ -744,7 +737,7 @@ int ttm_bo_pipeline_gutting(struct ttm_buffer_object *bo) ret =ttm_tt_create (bo, true);swap (bo->ttm, ttm);if (ret) - goto error_free_sys_mem; +return ret; ret =ttm_buffer_object_transfer (bo, &ghost);if (ret)@@ -760,13 +753,9 @@ int ttm_bo_pipeline_gutting(struct ttm_buffer_object *bo)dma_resv_unlock (&ghost->base._resv);ttm_bo_put (ghost); bo->ttm = ttm; -ttm_bo_assign_mem (bo, sys_res);return 0 ; error_destroy_tt:ttm_tt_destroy (bo->bdev, ttm); - -error_free_sys_mem: -ttm_resource_free (bo, &sys_res);return ret; }
Matthew Auld
reviewerPATCH v2 6/6 drm/ttm: prevent moving of pinned BOs
In reply to Matthew AuldFrom: Christian König <[email protected]>
We have checks for this in the individual drivers move callback, but it's probably better to generally forbid that on a higher level.
Also stops exporting ttm_resource_compat() since that's not necessary any more after removing the extra checks in vmwgfx.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ---- drivers/gpu/drm/nouveau/nouveau_bo.c | 3 --- drivers/gpu/drm/radeon/radeon_ttm.c | 4 ---- drivers/gpu/drm/ttm/ttm_bo.c | 20 ++++++++++++-------- drivers/gpu/drm/ttm/ttm_resource.c | 1 - drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 19 ++----------------- 6 files changed, 14 insertions(+), 37 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +0 -4
@@ -466,11 +466,7 @@ static int amdgpu_bo_move(struct ttm_buffer_object *bo, bool evict,return r; } -/* Can't move a pinned BO */ abo =ttm_to_amdgpu_bo (bo); -if (WARN_ON_ONCE (abo->tbo.pin_count >0 )) -return -EINVAL ; - adev =amdgpu_ttm_adev (bo->bdev); if (!old_mem || (old_mem->mem_type == TTM_PL_SYSTEM &&
drivers/gpu/drm/nouveau/nouveau_bo.c +0 -3
@@ -1015,9 +1015,6 @@ nouveau_bo_move(struct ttm_buffer_object *bo, bool evict,if (ret) goto out_ntfy; -if (nvbo->bo.pin_count) -NV_WARN (drm,"Moving pinned object %p!\n" , nvbo); -if (drm->client.device.info.family <NV_DEVICE_INFO_V0_TESLA ) { ret =nouveau_bo_vm_bind (bo, new_reg, &new_tile);if (ret)
drivers/gpu/drm/radeon/radeon_ttm.c +0 -4
@@ -211,11 +211,7 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,if (r)return r; -/* Can't move a pinned BO */ rbo = container_of(bo, struct radeon_bo, tbo); -if (WARN_ON_ONCE (rbo->tbo.pin_count >0 )) -return -EINVAL ; - rdev =radeon_get_rdev (bo->bdev);if (old_mem->mem_type ==TTM_PL_SYSTEM && bo->ttm ==NULL ) {ttm_bo_move_null (bo, new_mem);
drivers/gpu/drm/ttm/ttm_bo.c +12 -8
@@ -893,14 +893,18 @@ int ttm_bo_validate(struct ttm_buffer_object *bo,if (!placement->num_placement && !placement->num_busy_placement)return ttm_bo_pipeline_gutting (bo); -/* -* Check whether we need to move buffer. -*/ -if (!bo->resource || !ttm_resource_compat (bo->resource, placement)) { - ret =ttm_bo_move_buffer (bo, placement, ctx); -if (ret) -return ret; - } +/* Check whether we need to move buffer. */ +if (bo->resource &&ttm_resource_compat (bo->resource, placement)) +return 0 ; + +/* Moving of pinned BOs is forbidden */ +if (bo->pin_count) +return -EINVAL ; + + ret =ttm_bo_move_buffer (bo, placement, ctx); +if (ret) +return ret; +/* * We might need to add a TTM. */
drivers/gpu/drm/ttm/ttm_resource.c +0 -1
@@ -361,7 +361,6 @@ bool ttm_resource_compat(struct ttm_resource *res,return false; } -EXPORT_SYMBOL (ttm_resource_compat);void ttm_resource_set_bo (struct ttm_resource *res,struct ttm_buffer_object *bo)
drivers/gpu/drm/vmwgfx/vmwgfx_bo.c +2 -17
@@ -87,12 +87,7 @@ int vmw_bo_pin_in_placement(struct vmw_private *dev_priv,if (unlikely (ret !=0 )) goto err; -if (buf->base.pin_count >0 ) - ret =ttm_resource_compat (bo->resource, placement) - ?0 : -EINVAL ; -else - ret =ttm_bo_validate (bo, placement, &ctx); - + ret =ttm_bo_validate (bo, placement, &ctx);if (!ret)vmw_bo_pin_reserved (buf, true);
@@ -128,12 +123,6 @@ int vmw_bo_pin_in_vram_or_gmr(struct vmw_private *dev_priv,if (unlikely (ret !=0 )) goto err; -if (buf->base.pin_count >0 ) { - ret =ttm_resource_compat (bo->resource, &vmw_vram_gmr_placement) - ?0 : -EINVAL ; - goto out_unreserve; - } - ret =ttm_bo_validate (bo, &vmw_vram_gmr_placement, &ctx);if (likely (ret ==0 ) || ret == -ERESTARTSYS ) goto out_unreserve;
@@ -218,11 +207,7 @@ int vmw_bo_pin_in_start_of_vram(struct vmw_private *dev_priv, (void )ttm_bo_validate (bo, &vmw_sys_placement, &ctx); } -if (buf->base.pin_count >0 ) - ret =ttm_resource_compat (bo->resource, &placement) - ?0 : -EINVAL ; -else - ret =ttm_bo_validate (bo, &placement, &ctx); + ret =ttm_bo_validate (bo, &placement, &ctx);/* For some reason we didn't end up at the start of vram */ WARN_ON (ret ==0 && bo->resource->start !=0 );
Signature · 1 line
2.39.1
Quoted 11 lines · Matthew Auld
Sparse complains with:
drivers/gpu/drm/i915/gem/i915_gem_ttm.c:1066:21: sparse:
expected restrictedvm_fault_t[assigned] [usertype] retdrivers/gpu/drm/i915/gem/i915_gem_ttm.c:1066:21: sparse: got intFixes 516198d317d8 ("drm/i915: audit bo->resource usage v3")Reported-by kernel test robot <[email protected]>Signed-off-by Matthew Auld <[email protected]>Cc Christian König <[email protected]>Reviewed-by Andrzej Hajda <[email protected]>
Quoted 23 lines
--- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_ttm.c +3
-2@@ -1067,11 +1067,12 @@ static vm_fault_t vm_fault_ttm(struct vm_fault *vmf) .interruptible = true, .no_wait_gpu = true, /* should be idle already */ }; +int err;GEM_BUG_ON (!bo->ttm || !(bo->ttm->page_flags &TTM_TT_FLAG_SWAPPED )); - ret =ttm_bo_validate (bo,i915_ttm_sys_placement (), &ctx); -if (ret) { + err =ttm_bo_validate (bo,i915_ttm_sys_placement (), &ctx); +if (err) {dma_resv_unlock (bo->base.resv);return VM_FAULT_SIGBUS ; }
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/6] drm/i915/ttm: fix sparse warning
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [v2,1/6] drm/i915/ttm: fix sparse warning
URL : https://patchwork.freedesktop.org/series/113484/
State : warning
== Summary ==
Error: dim checkpatch failedb61deae6cd53 drm/i915/ttm: fix sparse warning
-:4: WARNING:EMAIL_SUBJECT: A patch subject line should describe the change not the tool that found it #4:
Subject: [PATCH] drm/i915/ttm: fix sparse warning
total: 0 errors, 1 warnings, 0 checks, 14 lines checkedb01ce1ac0799 drm/i915/ttm: audit remaining bo->resource
-:18: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 516198d317d8 ("drm/i915: audit bo->resource usage v3")' #18:
References: 516198d317d8 ("drm/i915: audit bo->resource usage v3")
total: 1 errors, 0 warnings, 0 checks, 59 lines checked 40dfa7888d44 drm/ttm: clear the ttm_tt when bo->resource is NULL 613ca8d70136 drm/ttm: stop allocating dummy resources during BO creation 652f0970e275 drm/ttm: stop allocating a dummy resource for pipelined gutting e257da7a88a8 drm/ttm: prevent moving of pinned BOs
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/6] drm/i915/ttm: fix sparse warning
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [v2,1/6] drm/i915/ttm: fix sparse warning
URL : https://patchwork.freedesktop.org/series/113484/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12666 -> Patchwork_113484v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/index.html
Participating hosts (25 -> 24)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_113484v1 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][1] ([i915#5334]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@slpc:
- {bat-adlp-6}: [DMESG-FAIL][3] ([i915#6367] / [i915#7913]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/bat-adlp-6/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/bat-adlp-6/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
Build changes
-------------
* Linux: CI_DRM_12666 -> Patchwork_113484v1
CI-20190529: 20190529
CI_DRM_12666: 908c84b836ee39b5565561a0b352c2dc18378215 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7142: adeeb8527422eeee155ff4039aed34a922da4a7d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113484v1: 908c84b836ee39b5565561a0b352c2dc18378215 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
eb29c526bc38 drm/ttm: prevent moving of pinned BOs6f65d4b71375 drm/ttm: stop allocating a dummy resource for pipelined gutting 4f490e93000d drm/ttm: stop allocating dummy resources during BO creation e46562673b6e drm/ttm: clear the ttm_tt when bo->resource is NULL a97096bdbf82 drm/i915/ttm: audit remaining bo->resource e5538d79c03c drm/i915/ttm: fix sparse warning
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,1/6] drm/i915/ttm: fix sparse warning
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [v2,1/6] drm/i915/ttm: fix sparse warning
URL : https://patchwork.freedesktop.org/series/113484/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12666_full -> Patchwork_113484v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/index.html
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_113484v1_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@perf@oa-exponents:
- {shard-rkl}: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-rkl-1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-rkl-3/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_113484v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2842])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-glk5/igt@gem_exec_fair@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-glk3/igt@gem_exec_fair@[email protected]
* igt@gem_userptr_blits@vma-merge:
- shard-glk: NOTRUN -> [FAIL][5] ([i915#3318])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-glk8/igt@[email protected]
* igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#3886]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-glk8/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-glk: NOTRUN -> [SKIP][7] ([fdo#109271]) +42 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-glk8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
#### Possible fixes ####
* igt@api_intel_bb@object-reloc-keep-cache:
- {shard-rkl}: [SKIP][8] ([i915#3281]) -> [PASS][9] +6 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-rkl-6/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-rkl-5/igt@[email protected]
* igt@core_hotunplug@unbind-rebind:
- {shard-dg1}: [DMESG-WARN][10] ([i915#4391]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-dg1-16/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-dg1-17/igt@[email protected]
* igt@fbdev@info:
- {shard-rkl}: [SKIP][12] ([i915#2582]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-rkl-3/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-rkl-6/igt@[email protected]
* igt@feature_discovery@psr2:
- {shard-rkl}: [SKIP][14] ([i915#658]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-rkl-5/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-rkl-6/igt@[email protected]
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][16] ([i915#6268]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-rkl-6/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-rkl-3/igt@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [FAIL][18] ([i915#2842]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-glk9/igt@gem_exec_fair@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-glk5/igt@gem_exec_fair@[email protected]
* igt@gem_tiled_partial_pwrite_pread@writes:
- {shard-rkl}: [SKIP][20] ([i915#3282]) -> [PASS][21] +2 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-rkl-1/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-rkl-5/igt@[email protected]
* igt@gen9_exec_parse@secure-batches:
- {shard-rkl}: [SKIP][22] ([i915#2527]) -> [PASS][23] +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-rkl-1/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-rkl-5/igt@[email protected]
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-rkl}: [SKIP][24] ([i915#1397]) -> [PASS][25] +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-rkl-3/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-rkl-6/igt@[email protected]
* igt@i915_pm_rpm@dpms-non-lpsp:
- {shard-dg1}: [SKIP][26] ([i915#1397]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-dg1-14/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-dg1-18/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- {shard-rkl}: [SKIP][28] ([i915#1845] / [i915#4098]) -> [PASS][29] +18 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-rkl-5/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-rkl-6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_dp_aux_dev:
- {shard-rkl}: [SKIP][30] ([i915#1257]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-rkl-3/igt@kms_dp_aux_dev.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-rkl-6/igt@kms_dp_aux_dev.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2:
- shard-glk: [FAIL][32] ([i915#2122]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-glk2/igt@kms_flip@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-glk2/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- {shard-rkl}: [SKIP][34] ([i915#1849] / [i915#4098]) -> [PASS][35] +9 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-rkl-5/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-rkl-6/igt@[email protected]
* igt@kms_psr@cursor_mmap_gtt:
- {shard-rkl}: [SKIP][36] ([i915#1072]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-rkl-3/igt@kms_psr@cursor_mmap_gtt.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-rkl-6/igt@kms_psr@cursor_mmap_gtt.html
* igt@perf_pmu@idle@rcs0:
- {shard-rkl}: [FAIL][38] ([i915#4349]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-rkl-2/igt@perf_pmu@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-rkl-5/igt@perf_pmu@[email protected]
* igt@prime_vgem@basic-fence-read:
- {shard-rkl}: [SKIP][40] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][41] +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12666/shard-rkl-1/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/shard-rkl-5/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3639]: https://gitlab.freedesktop.org/drm/intel/issues/3639
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
[i915#7076]: https://gitlab.freedesktop.org/drm/intel/issues/7076
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7330]: https://gitlab.freedesktop.org/drm/intel/issues/7330
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
Build changes
-------------
* Linux: CI_DRM_12666 -> Patchwork_113484v1
CI-20190529: 20190529
CI_DRM_12666: 908c84b836ee39b5565561a0b352c2dc18378215 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7142: adeeb8527422eeee155ff4039aed34a922da4a7d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113484v1: 908c84b836ee39b5565561a0b352c2dc18378215 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113484v1/index.html