Skip to contentSkip to conversation

dt-bindings: watchdog: qcom-wdt: add the interrupts property

PATCH In review Bartosz Golaszewski 3 participants 3 messages Jan 30, 2023 – Feb 2, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: watchdog: qcom-wdt: add the interrupts property

From: Bartosz Golaszewski <[email protected]>

The interrupts property is used in all nodes using this binding but not defined in the document itself - hence dtbs_check fails for them. Add the property and update the example.

---
 .../devicetree/bindings/watchdog/qcom-wdt.yaml        | 11 +++++++++++
 1 file changed, 11 insertions(+)
Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml +11 -0
index 27fb484d5f8d..45940d643b92 100644
@@ -46,6 +46,10 @@ properties:
   clocks:
     maxItems: 1
 
+  interrupts:
+    minItems: 1
+    maxItems: 5
+
 required:
   - compatible
   - reg
@@ -55,9 +59,16 @@ unevaluatedProperties: false
 
 examples:
   - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+
     watchdog@208a038 {
       compatible = "qcom,kpss-wdt-ipq8064";
       reg = <0x0208a038 0x40>;
       clocks = <&sleep_clk>;
       timeout-sec = <10>;
+      interrupts = <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>,
+                   <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>,
+                   <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>,
+                   <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>,
+                   <GIC_PPI 5 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>;
     };
Signature · 1 line
2.37.2
maintainer
#1 lore raw
Quoted 16 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

The interrupts property is used in all nodes using this binding but not defined in the document itself - hence dtbs_check fails for them. Add the property and update the example.

---
 .../devicetree/bindings/watchdog/qcom-wdt.yaml        | 11 +++++++++++
 1 file changed, 11 insertions(+)
Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml +0 -0
index 27fb484d5f8d..45940d643b92 100644

Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml properties: · line 51

Quoted 6 lines
Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml +3 -0
@@ -46,6 +46,10 @@ properties:
   clocks:
     maxItems: 1
 
+  interrupts:
+    minItems: 1
+    maxItems: 5

What is each interrupt?

Quoted 24 lines
Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml +8 -0
+
 required:
   - compatible
   - reg
@@ -55,9 +59,16 @@ unevaluatedProperties: false
 
 examples:
   - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+
     watchdog@208a038 {
       compatible = "qcom,kpss-wdt-ipq8064";
       reg = <0x0208a038 0x40>;
       clocks = <&sleep_clk>;
       timeout-sec = <10>;
+      interrupts = <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>,
+                   <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>,
+                   <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>,
+                   <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>,
+                   <GIC_PPI 5 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>;
     };
Signature · 1 line
2.37.2
#2 lore raw
In reply to Bartosz Golaszewski
Quoted 10 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

The interrupts property is used in all nodes using this binding but not defined in the document itself - hence dtbs_check fails for them. Add the property and update the example.

---
 .../devicetree/bindings/watchdog/qcom-wdt.yaml        | 11 +++++++++++
 1 file changed, 11 insertions(+)

dfn in lore would save you some effort (or my pending branch which I shared on IRC):

https://lore.kernel.org/all/[email protected]/

Best regards,
Krzysztof