Skip to contentSkip to conversation

clk: qcom: gcc-qcs404: fix duplicate initializer warning

PATCH Applied Arnd Bergmann 4 participants 4 messages Jan 30, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: qcom: gcc-qcs404: fix duplicate initializer warning

From: Arnd Bergmann <[email protected]>

In one of the clocks, a redundant initialization for .num_parents got left behind by a recent patch:

drivers/clk/qcom/gcc-qcs404.c:63:32: error: initialized field overwritten [-Werror=override-init]
63 | .num_parents = 1,
| ^

Fixes 2ce81afa0c7c ("clk: qcom: gcc-qcs404: sort out the cxo clock")
---
 drivers/clk/qcom/gcc-qcs404.c | 1 -
 1 file changed, 1 deletion(-)
drivers/clk/qcom/gcc-qcs404.c +0 -1
index 5f58dd82d3fe..a39c4990b29d 100644
@@ -60,7 +60,6 @@ static struct clk_fixed_factor cxo = {
 		.name = "cxo",
 		.parent_data = gcc_parent_data_1,
 		.num_parents = ARRAY_SIZE(gcc_parent_data_1),
-		.num_parents = 1,
 		.ops = &clk_fixed_factor_ops,
 	},
 };
Signature · 1 line
2.39.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

In one of the clocks, a redundant initialization for .num_parents got left behind by a recent patch:

Quoted 7 lines

drivers/clk/qcom/gcc-qcs404.c:63:32: error: initialized field overwritten [-Werror=override-init]
63 | .num_parents = 1,
| ^

Fixes 2ce81afa0c7c ("clk: qcom: gcc-qcs404: sort out the cxo clock")

---

Konrad

Quoted 15 lines
 drivers/clk/qcom/gcc-qcs404.c | 1 -
 1 file changed, 1 deletion(-)
drivers/clk/qcom/gcc-qcs404.c +0 -1
index 5f58dd82d3fe..a39c4990b29d 100644
@@ -60,7 +60,6 @@ static struct clk_fixed_factor cxo = {
 		.name = "cxo",
 		.parent_data = gcc_parent_data_1,
 		.num_parents = ARRAY_SIZE(gcc_parent_data_1),
-		.num_parents = 1,
 		.ops = &clk_fixed_factor_ops,
 	},
 };
maintainer
#2 lore raw
In reply to Arnd Bergmann

Quoting Arnd Bergmann (2023-01-30 05:55:47)

Quoted 5 lines

From: Arnd Bergmann <[email protected]>

In one of the clocks, a redundant initialization for .num_parents got left behind by a recent patch:

Quoted 7 lines

drivers/clk/qcom/gcc-qcs404.c:63:32: error: initialized field overwritten [-Werror=override-init]
63 | .num_parents = 1,
| ^

Fixes 2ce81afa0c7c ("clk: qcom: gcc-qcs404: sort out the cxo clock")

---

This is https://lore.kernel.org/r/[email protected]

maintainer Applied
#3 lore raw
In reply to Arnd Bergmann
Quoted 10 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

In one of the clocks, a redundant initialization for .num_parents got left behind by a recent patch:

drivers/clk/qcom/gcc-qcs404.c:63:32: error: initialized field overwritten [-Werror=override-init]
63 | .num_parents = 1,
| ^

[...]

Applied, thanks!

[1/1] clk: qcom: gcc-qcs404: fix duplicate initializer warning

      commit: d4cb3e7113f82f7378527890aa7b4006234665fe

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>