vfio: fix deadlock between group lock and kvm lock
Subsystems (3)
PATCH v2 1/1 vfio: fix deadlock between group lock and kvm lock
After 51cdc8bc120e, we have another deadlock scenario between the kvm->lock and the vfio group_lock with two different codepaths acquiring the locks in different order. Specifically in vfio_open_device, vfio holds the vfio group_lock when issuing device->ops->open_device but some drivers (like vfio-ap) need to acquire kvm->lock during their open_device routine; Meanwhile, kvm_vfio_release will acquire the kvm->lock first before calling vfio_file_set_kvm which will acquire the vfio group_lock.
To resolve this, let's remove the need for the vfio group_lock from the kvm_vfio_release codepath. This is done by introducing a new spinlock to protect modifications to the vfio group kvm pointer, and acquiring a kvm ref from within vfio while holding this spinlock, with the reference held until the last close for the device in question.
---
Changes from v1:
* use spin_lock instead of spin_lock_irqsave (Jason)
* clear device->kvm_put as part of vfio_kvm_put_kvm (Yi)
* Re-arrange code to avoid referencing the group contents from within vfio_main (Kevin) which meant moving most of the code in this patch to group.c along with getting/dropping of the dev_set lock
--- drivers/vfio/group.c | 90 +++++++++++++++++++++++++++++++++++++--- drivers/vfio/vfio.h | 1 + drivers/vfio/vfio_main.c | 11 ++--- include/linux/vfio.h | 2 +- 4 files changed, 91 insertions(+), 13 deletions(-)
drivers/vfio/group.c +85 -5
@@ -13,6 +13,9 @@#include <linux/vfio.h> #include <linux/iommufd.h> #include <linux/anon_inodes.h> +#ifdef CONFIG_HAVE_KVM +#include <linux/kvm_host.h> +#endif #include "vfio.h" static struct vfio {
@@ -154,6 +157,55 @@ static int vfio_group_ioctl_set_container(struct vfio_group *group,return ret; } +#ifdef CONFIG_HAVE_KVM +static bool vfio_kvm_get_kvm_safe (struct vfio_device *device,struct kvm *kvm) +{ +void (*pfn)(struct kvm *kvm); +bool (*fn)(struct kvm *kvm); +bool ret; + + pfn =symbol_get (kvm_put_kvm); +if (WARN_ON (!pfn)) +return false; + + fn =symbol_get (kvm_get_kvm_safe); +if (WARN_ON (!fn)) { +symbol_put (kvm_put_kvm); +return false; + } + + ret =fn (kvm); +if (ret) + device->put_kvm = pfn; +else +symbol_put (kvm_put_kvm); + +symbol_put (kvm_get_kvm_safe); + +return ret; +} + +static void vfio_kvm_put_kvm (struct vfio_device *device) +{ +if (WARN_ON (!device->kvm || !device->put_kvm)) +return ; + + device->put_kvm (device->kvm); + device->put_kvm =NULL ; +symbol_put (kvm_put_kvm); +} + +#else +static bool vfio_kvm_get_kvm_safe (struct vfio_device *device,struct kvm *kvm) +{ +return false; +} + +static void vfio_kvm_put_kvm (struct vfio_device *device) +{ +} +#endif +static int vfio_device_group_open (struct vfio_device *device) {int ret;
@@ -164,14 +216,32 @@ static int vfio_device_group_open(struct vfio_device *device) goto out_unlock; } +mutex_lock (&device->dev_set->lock); +/* -* Here we pass the KVM pointer with the group under the lock. If the -* device driver will use it, it must obtain a reference and release it -* during close_device. +* Before the first device open, get the KVM pointer currently +* associated with the group (if there is one) and obtain a reference +* now that will be held until the open_count reaches 0 again. Save +* the pointer in the device for use by drivers. */ +if (device->open_count ==0 ) { +spin_lock (&device->group->kvm_ref_lock); +if (device->group->kvm && +vfio_kvm_get_kvm_safe (device, device->group->kvm)) + device->kvm = device->group->kvm; +spin_unlock (&device->group->kvm_ref_lock); + } + ret =vfio_device_open (device, device->group->iommufd, device->group->kvm); +if (ret && device->kvm && device->open_count ==0 ) { +vfio_kvm_put_kvm (device); + device->kvm =NULL ; + } + +mutex_unlock (&device->dev_set->lock); + out_unlock:mutex_unlock (&device->group->group_lock);return ret;
@@ -180,7 +250,16 @@ static int vfio_device_group_open(struct vfio_device *device)void vfio_device_group_close (struct vfio_device *device) {mutex_lock (&device->group->group_lock); +mutex_lock (&device->dev_set->lock); +vfio_device_close (device, device->group->iommufd); + +if (device->kvm && device->open_count ==0 ) { +vfio_kvm_put_kvm (device); + device->kvm =NULL ; + } + +mutex_unlock (&device->dev_set->lock);mutex_unlock (&device->group->group_lock); }
@@ -450,6 +529,7 @@ static struct vfio_group *vfio_group_alloc(struct iommu_group *iommu_group,refcount_set (&group->drivers,1 );mutex_init (&group->group_lock); +spin_lock_init (&group->kvm_ref_lock);INIT_LIST_HEAD (&group->device_list);mutex_init (&group->device_lock); group->iommu_group = iommu_group;
@@ -803,9 +883,9 @@ void vfio_file_set_kvm(struct file *file, struct kvm *kvm)if (!vfio_file_is_group (file))return ; -mutex_lock (&group->group_lock); +spin_lock (&group->kvm_ref_lock); group->kvm = kvm; -mutex_unlock (&group->group_lock); +spin_unlock (&group->kvm_ref_lock); }EXPORT_SYMBOL_GPL (vfio_file_set_kvm);
drivers/vfio/vfio.h +1 -0
@@ -74,6 +74,7 @@ struct vfio_group {struct file *opened_file;struct blocking_notifier_head notifier;struct iommufd_ctx *iommufd; +spinlock_t kvm_ref_lock; }; int vfio_device_set_group(struct vfio_device *device,
drivers/vfio/vfio_main.c +4 -7
@@ -361,7 +361,6 @@ static int vfio_device_first_open(struct vfio_device *device,if (ret) goto err_module_put; - device->kvm = kvm;if (device->ops->open_device) { ret = device->ops->open_device (device);if (ret)
@@ -370,7 +369,6 @@ static int vfio_device_first_open(struct vfio_device *device,return 0 ; err_unuse_iommu: - device->kvm =NULL ;if (iommufd)vfio_iommufd_unbind (device);else
@@ -387,7 +385,6 @@ static void vfio_device_last_close(struct vfio_device *device,if (device->ops->close_device) device->ops->close_device (device); - device->kvm =NULL ;if (iommufd)vfio_iommufd_unbind (device);else
@@ -400,14 +397,14 @@ int vfio_device_open(struct vfio_device *device, {int ret =0 ; -mutex_lock (&device->dev_set->lock); +lockdep_assert_held (&device->dev_set->lock); + device->open_count++;if (device->open_count ==1 ) { ret =vfio_device_first_open (device, iommufd, kvm);if (ret) device->open_count--; } -mutex_unlock (&device->dev_set->lock);return ret; }
@@ -415,12 +412,12 @@ int vfio_device_open(struct vfio_device *device,void vfio_device_close (struct vfio_device *device,struct iommufd_ctx *iommufd) { -mutex_lock (&device->dev_set->lock); +lockdep_assert_held (&device->dev_set->lock); +vfio_assert_device_open (device);if (device->open_count ==1 )vfio_device_last_close (device, iommufd); device->open_count--; -mutex_unlock (&device->dev_set->lock); }/*
include/linux/vfio.h +1 -1
@@ -46,7 +46,6 @@ struct vfio_device {struct vfio_device_set *dev_set;struct list_head dev_set_list;unsigned int migration_flags; -/* Driver must reference the kvm during open_device or never touch it */ struct kvm *kvm;/* Members below here are private, not for driver use */
@@ -58,6 +57,7 @@ struct vfio_device {struct list_head group_next;struct list_head iommu_entry;struct iommufd_access *iommufd_access; +void (*put_kvm)(struct kvm *kvm);#if IS_ENABLED (CONFIG_IOMMUFD )struct iommufd_device *iommufd_device;struct iommufd_ctx *iommufd_ictx;
Signature · 1 line
2.39.1
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for vfio: fix deadlock between group lock and kvm lock (rev2)
== Series Details ==
== Series Details ==
Series: vfio: fix deadlock between group lock and kvm lock (rev2)
URL : https://patchwork.freedesktop.org/series/113535/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12680 -> Patchwork_113535v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/index.html
Participating hosts (26 -> 25)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_113535v2 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_selftest@live@gt_pm:
- {bat-rpls-2}: [DMESG-FAIL][1] ([i915#4258]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@migrate:
- {bat-dg2-11}: [DMESG-WARN][3] ([i915#7699]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/bat-dg2-11/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/bat-dg2-11/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6311]: https://gitlab.freedesktop.org/drm/intel/issues/6311
[i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
Build changes
-------------
* Linux: CI_DRM_12680 -> Patchwork_113535v2
CI-20190529: 20190529
CI_DRM_12680: 06086656e6f03cbcbb4b99273734a7943e923fc9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7143: c7b12dcc460fc2348e1fa7f4dcb791bb82e29e44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113535v2: 06086656e6f03cbcbb4b99273734a7943e923fc9 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
a4f804de37f7 vfio: fix deadlock between group lock and kvm lock
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for vfio: fix deadlock between group lock and kvm lock (rev2)
In reply to Matthew Rosato== Series Details ==
== Series Details ==
Series: vfio: fix deadlock between group lock and kvm lock (rev2)
URL : https://patchwork.freedesktop.org/series/113535/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12680_full -> Patchwork_113535v2_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/index.html
Participating hosts (11 -> 10)
------------------------------
Missing (1): shard-rkl0
Known issues
------------
Here are the changes found in Patchwork_113535v2_full that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-check-all@rcs0:
- {shard-rkl}: [FAIL][1] ([i915#7742]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/shard-rkl-4/igt@drm_fdinfo@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/shard-rkl-2/igt@drm_fdinfo@[email protected]
* igt@feature_discovery@psr2:
- {shard-rkl}: [SKIP][3] ([i915#658]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/shard-rkl-3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/shard-rkl-6/igt@[email protected]
* igt@gem_bad_reloc@negative-reloc-lut:
- {shard-rkl}: [SKIP][5] ([i915#3281]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/shard-rkl-4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/shard-rkl-5/igt@[email protected]
* igt@gem_ctx_persistence@engines-hang@bcs0:
- {shard-rkl}: [SKIP][7] ([i915#6252]) -> [PASS][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/shard-rkl-5/igt@gem_ctx_persistence@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/shard-rkl-4/igt@gem_ctx_persistence@[email protected]
* igt@gem_exec_endless@dispatch@bcs0:
- {shard-rkl}: [SKIP][9] ([i915#6247]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/shard-rkl-5/igt@gem_exec_endless@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/shard-rkl-6/igt@gem_exec_endless@[email protected]
* igt@gem_exec_fair@basic-none-vip@rcs0:
- {shard-rkl}: [FAIL][11] ([i915#2842]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/shard-rkl-4/igt@gem_exec_fair@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/shard-rkl-5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: [FAIL][13] ([i915#2842]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/shard-glk3/igt@gem_exec_fair@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/shard-glk5/igt@gem_exec_fair@[email protected]
* igt@gen9_exec_parse@bb-large:
- {shard-rkl}: [SKIP][15] ([i915#2527]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/shard-rkl-4/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/shard-rkl-5/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- {shard-rkl}: [SKIP][17] ([i915#3361]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/shard-rkl-5/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/shard-rkl-2/igt@[email protected]
* igt@i915_pm_rpm@cursor:
- {shard-rkl}: [SKIP][19] ([i915#1849]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/shard-rkl-5/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/shard-rkl-6/igt@[email protected]
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-rkl}: [SKIP][21] ([i915#1397]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/shard-rkl-3/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/shard-rkl-6/igt@[email protected]
* igt@kms_big_fb@x-tiled-32bpp-rotate-0:
- {shard-rkl}: [SKIP][23] ([i915#1845] / [i915#4098]) -> [PASS][24] +24 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/shard-rkl-3/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][25] ([i915#2346]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/shard-glk6/igt@kms_cursor_legacy@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/shard-glk7/igt@kms_cursor_legacy@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
- shard-glk: [FAIL][27] ([i915#79]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/shard-glk3/igt@kms_flip@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/shard-glk5/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-tiling-linear:
- {shard-rkl}: [SKIP][29] ([i915#1849] / [i915#4098]) -> [PASS][30] +17 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/shard-rkl-5/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/shard-rkl-6/igt@[email protected]
* igt@kms_psr@cursor_mmap_gtt:
- {shard-rkl}: [SKIP][31] ([i915#1072]) -> [PASS][32] +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/shard-rkl-3/igt@kms_psr@cursor_mmap_gtt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/shard-rkl-6/igt@kms_psr@cursor_mmap_gtt.html
* igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-a:
- {shard-rkl}: [SKIP][33] ([i915#4098]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/shard-rkl-5/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-a.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/shard-rkl-6/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-a.html
* igt@prime_vgem@basic-fence-flip:
- {shard-rkl}: [SKIP][35] ([fdo#109295] / [i915#3708] / [i915#4098]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12680/shard-rkl-4/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/shard-rkl-6/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
Build changes
-------------
* Linux: CI_DRM_12680 -> Patchwork_113535v2
CI-20190529: 20190529
CI_DRM_12680: 06086656e6f03cbcbb4b99273734a7943e923fc9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7143: c7b12dcc460fc2348e1fa7f4dcb791bb82e29e44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113535v2: 06086656e6f03cbcbb4b99273734a7943e923fc9 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v2/index.html
Quoted 47 lines · On Wed, 1 Feb 2023 14:20:10 -0500 Matthew Rosato <[email protected]>…
After
51cdc8bc120e, we have another deadlock scenario between thekvm->lockand the vfiogroup_lockwith two different codepaths acquiring the locks in different order. Specifically invfio_open_device, vfio holds the vfiogroup_lockwhen issuingdevice->ops->open_devicebut some drivers (like vfio-ap) need to acquirekvm->lockduring theiropen_deviceroutine; Meanwhile,kvm_vfio_releasewill acquire thekvm->lockfirst before callingvfio_file_set_kvmwhich will acquire the vfiogroup_lock.To resolve this, let's remove the need for the vfio
group_lockfrom thekvm_vfio_releasecodepath. This is done by introducing a new spinlock to protect modifications to the vfio group kvm pointer, and acquiring a kvm ref from within vfio while holding this spinlock, with the reference held until the last close for the device in question.Fixes 51cdc8bc120e ("kvm/vfio: Fix potential deadlock on vfio group_lock")Reported-by Anthony Krowiak <[email protected]>Suggested-by Jason Gunthorpe <[email protected]>Signed-off-by Matthew Rosato <[email protected]>---
Changes from v1:
* usespin_lockinstead ofspin_lock_irqsave(Jason)
* cleardevice->kvm_putas part ofvfio_kvm_put_kvm(Yi)
* Re-arrange code to avoid referencing the group contents from withinvfio_main(Kevin) which meant moving most of the code in this patch togroup.calong with getting/dropping of thedev_setlock--- drivers/vfio/group.c | 90 +++++++++++++++++++++++++++++++++++++--- drivers/vfio/vfio.h | 1 + drivers/vfio/vfio_main.c | 11 ++--- include/linux/vfio.h | 2 +- 4 files changed, 91 insertions(+), 13 deletions(-)drivers/vfio/group.c +3
-0@@ -13,6 +13,9 @@#include <linux/vfio.h> #include <linux/iommufd.h> #include <linux/anon_inodes.h> +#ifdef CONFIG_HAVE_KVM +#include <linux/kvm_host.h> +#endif #include "vfio.h" static struct vfio {
drivers/vfio/group.c static int vfio_group_ioctl_set_container(struct vfio_group *group, · line 161
Quoted 5 lines
drivers/vfio/group.c +2
-0@@ -154,6 +157,55 @@ static int vfio_group_ioctl_set_container(struct vfio_group *group,return ret; } +#ifdef CONFIG_HAVE_KVM +static bool vfio_kvm_get_kvm_safe (struct vfio_device *device,struct kvm *kvm)
I'm tempted to name these vfio_device_get_kvm_safe() and only pass the vfio_device, where of course we can get the kvm pointer from the group internally.
drivers/vfio/group.c static int vfio_group_ioctl_set_container(struct vfio_group *group, · line 166
Quoted 5 lines
drivers/vfio/group.c +5
-0+{ +void (*pfn)(struct kvm *kvm); +bool (*fn)(struct kvm *kvm); +bool ret; +
We should assert_lockdep_held(&device->dev_set->lock) in both of these since that seems to be what's protecting device->kvm and device->put_kvm.
If we change as above to get the kvm pointer from the group within this function, we can also move the kvm_ref_lock here, which seems to simplify the caller quite a bit.
Quoted 15 lines
drivers/vfio/group.c +15
-0+ pfn =symbol_get (kvm_put_kvm); +if (WARN_ON (!pfn)) +return false; + + fn =symbol_get (kvm_get_kvm_safe); +if (WARN_ON (!fn)) { +symbol_put (kvm_put_kvm); +return false; + } + + ret =fn (kvm); +if (ret) + device->put_kvm = pfn; +else +symbol_put (kvm_put_kvm);
drivers/vfio/group.c static int vfio_group_ioctl_set_container(struct vfio_group *group, · line 191
Quoted 10 lines
drivers/vfio/group.c +10
-0+ +symbol_put (kvm_get_kvm_safe); + +return ret; +} + +static void vfio_kvm_put_kvm (struct vfio_device *device) +{ +if (WARN_ON (!device->kvm || !device->put_kvm)) +return ;
It simplifies the caller if we can use this even in the !device->kvm case.
Quoted 35 lines
drivers/vfio/group.c +23
-3+ + device->put_kvm (device->kvm); + device->put_kvm =NULL ; + symbol_put(kvm_put_kvm); +} + +#else +static bool vfio_kvm_get_kvm_safe (struct vfio_device *device,struct kvm *kvm) +{ +return false; +} + +static void vfio_kvm_put_kvm (struct vfio_device *device) +{ +} +#endif +static int vfio_device_group_open (struct vfio_device *device) {int ret;@@ -164,14 +216,32 @@ static int vfio_device_group_open(struct vfio_device *device) goto out_unlock; } +mutex_lock (&device->dev_set->lock); +/* -* Here we pass the KVM pointer with the group under the lock. If the -* device driver will use it, it must obtain a reference and release it -* during close_device. +* Before the first device open, get the KVM pointer currently +* associated with the group (if there is one) and obtain a reference +* now that will be held until the open_count reaches 0 again. Save +* the pointer in the device for use by drivers. */
drivers/vfio/group.c static int vfio_device_group_open(struct vfio_device *device) · line 236
Quoted 10 lines
drivers/vfio/group.c +8
-0+if (device->open_count ==0 ) { +spin_lock (&device->group->kvm_ref_lock); +if (device->group->kvm && +vfio_kvm_get_kvm_safe (device, device->group->kvm)) + device->kvm = device->group->kvm; +spin_unlock (&device->group->kvm_ref_lock); + } + ret =vfio_device_open (device, device->group->iommufd, device->group->kvm);
We're using device->group->kvm outside of kvm_ref_lock here, it should be using device->kvm.
drivers/vfio/group.c static int vfio_device_group_open(struct vfio_device *device) · line 237
Quoted 2 lines
drivers/vfio/group.c +1
-0+if (ret && device->kvm && device->open_count ==0 ) {
Slightly redundant, if device->open_count == 0 here, we can infer ret is non-zero.
I fiddled with it a little further, see if you like anything from the version below and incorporate what you do. Thanks,
Alex
drivers/vfio/group.c +86 -7
@@ -13,6 +13,9 @@#include <linux/vfio.h> #include <linux/iommufd.h> #include <linux/anon_inodes.h> +#ifdef CONFIG_HAVE_KVM +#include <linux/kvm_host.h> +#endif #include "vfio.h" static struct vfio {
@@ -154,6 +157,64 @@ static int vfio_group_ioctl_set_container(struct vfio_group *group,return ret; } +#ifdef CONFIG_HAVE_KVM +static void vfio_device_get_kvm_safe (struct vfio_device *device) +{ +void (*pfn)(struct kvm *kvm); +bool (*fn)(struct kvm *kvm); +bool ret; + +lockdep_assert_held (&device->dev_set->lock); + +spin_lock (&device->group->kvm_ref_lock); +if (!device->group->kvm) + goto unlock; + + pfn =symbol_get (kvm_put_kvm); +if (WARN_ON (!pfn)) + goto unlock; + + fn =symbol_get (kvm_get_kvm_safe); +if (WARN_ON (!fn)) { +symbol_put (kvm_put_kvm); + goto unlock; + } + + ret =fn (device->group->kvm); +symbol_put (kvm_get_kvm_safe); +if (!ret) { +symbol_put (kvm_put_kvm); + goto unlock; + } + + device->put_kvm = pfn; + device->kvm = device->group->kvm; +unlock: +spin_unlock (&device->group->kvm_ref_lock); +} + +static void vfio_device_put_kvm (struct vfio_device *device) +{ +lockdep_assert_held (&device->dev_set->lock); + +if (!device->kvm) +return ; + +if (WARN_ON (!device->put_kvm)) + goto clear; + + device->put_kvm (device->kvm); + device->put_kvm =NULL ; +symbol_put (kvm_put_kvm); + +clear: + device->kvm =NULL ; +} +#else +static void vfio_device_get_kvm_safe (struct vfio_device *device) {} +static void vfio_device_put_kvm (struct vfio_device *device) {} +#endif +static int vfio_device_group_open (struct vfio_device *device) {int ret;
@@ -164,13 +225,23 @@ static int vfio_device_group_open(struct vfio_device *device) goto out_unlock; } +mutex_lock (&device->dev_set->lock); +/* -* Here we pass the KVM pointer with the group under the lock. If the -* device driver will use it, it must obtain a reference and release it -* during close_device. +* Before the first device open, get the KVM pointer currently +* associated with the group (if there is one) and obtain a reference +* now that will be held until the open_count reaches 0 again. Save +* the pointer in the device for use by drivers. */ - ret =vfio_device_open (device, device->group->iommufd, - device->group->kvm); +if (device->open_count ==0 ) +vfio_device_get_kvm_safe (device); + + ret =vfio_device_open (device, device->group->iommufd, device->kvm); + +if (device->open_count ==0 ) +vfio_device_put_kvm (device); + +mutex_unlock (&device->dev_set->lock); out_unlock:mutex_unlock (&device->group->group_lock);
@@ -180,7 +251,14 @@ static int vfio_device_group_open(struct vfio_device *device)void vfio_device_group_close (struct vfio_device *device) {mutex_lock (&device->group->group_lock); +mutex_lock (&device->dev_set->lock); +vfio_device_close (device, device->group->iommufd); + +if (device->open_count ==0 ) +vfio_device_put_kvm (device); + +mutex_unlock (&device->dev_set->lock);mutex_unlock (&device->group->group_lock); }
@@ -450,6 +528,7 @@ static struct vfio_group *vfio_group_alloc(struct iommu_group *iommu_group,refcount_set (&group->drivers,1 );mutex_init (&group->group_lock); +spin_lock_init (&group->kvm_ref_lock);INIT_LIST_HEAD (&group->device_list);mutex_init (&group->device_lock); group->iommu_group = iommu_group;
@@ -803,9 +882,9 @@ void vfio_file_set_kvm(struct file *file, struct kvm *kvm)if (!vfio_file_is_group (file))return ; -mutex_lock (&group->group_lock); +spin_lock (&group->kvm_ref_lock); group->kvm = kvm; -mutex_unlock (&group->group_lock); +spin_unlock (&group->kvm_ref_lock); }EXPORT_SYMBOL_GPL (vfio_file_set_kvm);
drivers/vfio/vfio.h +1 -0
@@ -74,6 +74,7 @@ struct vfio_group {struct file *opened_file;struct blocking_notifier_head notifier;struct iommufd_ctx *iommufd; +spinlock_t kvm_ref_lock; }; int vfio_device_set_group(struct vfio_device *device,
drivers/vfio/vfio_main.c +4 -7
@@ -361,7 +361,6 @@ static int vfio_device_first_open(struct vfio_device *device,if (ret) goto err_module_put; - device->kvm = kvm;if (device->ops->open_device) { ret = device->ops->open_device (device);if (ret)
@@ -370,7 +369,6 @@ static int vfio_device_first_open(struct vfio_device *device,return 0 ; err_unuse_iommu: - device->kvm =NULL ;if (iommufd)vfio_iommufd_unbind (device);else
@@ -387,7 +385,6 @@ static void vfio_device_last_close(struct vfio_device *device,if (device->ops->close_device) device->ops->close_device (device); - device->kvm =NULL ;if (iommufd)vfio_iommufd_unbind (device);else
@@ -400,14 +397,14 @@ int vfio_device_open(struct vfio_device *device, {int ret =0 ; -mutex_lock (&device->dev_set->lock); +lockdep_assert_held (&device->dev_set->lock); + device->open_count++;if (device->open_count ==1 ) { ret =vfio_device_first_open (device, iommufd, kvm);if (ret) device->open_count--; } -mutex_unlock (&device->dev_set->lock);return ret; }
@@ -415,12 +412,12 @@ int vfio_device_open(struct vfio_device *device,void vfio_device_close (struct vfio_device *device,struct iommufd_ctx *iommufd) { -mutex_lock (&device->dev_set->lock); +lockdep_assert_held (&device->dev_set->lock); +vfio_assert_device_open (device);if (device->open_count ==1 )vfio_device_last_close (device, iommufd); device->open_count--; -mutex_unlock (&device->dev_set->lock); }/*
include/linux/vfio.h +1 -1
@@ -46,7 +46,6 @@ struct vfio_device {struct vfio_device_set *dev_set;struct list_head dev_set_list;unsigned int migration_flags; -/* Driver must reference the kvm during open_device or never touch it */ struct kvm *kvm;/* Members below here are private, not for driver use */
@@ -58,6 +57,7 @@ struct vfio_device {struct list_head group_next;struct list_head iommu_entry;struct iommufd_access *iommufd_access; +void (*put_kvm)(struct kvm *kvm);#if IS_ENABLED (CONFIG_IOMMUFD )struct iommufd_device *iommufd_device;struct iommufd_ctx *iommufd_ictx;
Quoted 153 lines
From: Alex Williamson <[email protected]>
Sent: Thursday, February 2, 2023 7:28 AMQuoted 4 lines · On Wed, 1 Feb 2023 14:20:10 -0500 Matthew Rosato <[email protected]>…
After
51cdc8bc120e, we have another deadlock scenario between thekvm->lockand the vfiogroup_lockwith two different codepaths acquiring the locks in different order. Specifically invfio_open_device, vfio holds the vfiogroup_lockwhen issuingdevice->ops->open_devicebutsome
Quoted 21 lines
drivers (like vfio-ap) need to acquire
kvm->lockduring theiropen_deviceroutine; Meanwhile,kvm_vfio_releasewill acquire thekvm->lockfirst before callingvfio_file_set_kvmwhich will acquire the vfiogroup_lock.To resolve this, let's remove the need for the vfio
group_lockfrom thekvm_vfio_releasecodepath. This is done by introducing a new spinlock to protect modifications to the vfio group kvm pointer, and acquiring a kvm ref from within vfio while holding this spinlock, with the reference held until the last close for the device in question.Fixes 51cdc8bc120e ("kvm/vfio: Fix potential deadlock on vfio group_lock")Reported-by Anthony Krowiak <[email protected]>Suggested-by Jason Gunthorpe <[email protected]>Signed-off-by Matthew Rosato <[email protected]>---
Changes from v1:
* usespin_lockinstead ofspin_lock_irqsave(Jason)
* cleardevice->kvm_putas part ofvfio_kvm_put_kvm(Yi)
* Re-arrange code to avoid referencing the group contents from withinvfio_main(Kevin) which meant moving most of the code in this patch togroup.calong with getting/dropping of thedev_setlockQuoted 2 lines
--- drivers/vfio/group.c | 90+++++++++++++++++++++++++++++++++++++---
drivers/vfio/group.c static int vfio_group_ioctl_set_container(struct
Quoted 20 lines
drivers/vfio/vfio.h | 1 + drivers/vfio/vfio_main.c | 11 ++--- include/linux/vfio.h | 2 +- 4 files changed, 91 insertions(+), 13 deletions(-)drivers/vfio/group.c +3
-0@@ -13,6 +13,9 @@#include <linux/vfio.h> #include <linux/iommufd.h> #include <linux/anon_inodes.h> +#ifdef CONFIG_HAVE_KVM +#include <linux/kvm_host.h> +#endif #include "vfio.h" static struct vfio {@@ -154,6 +157,55 @@ static int vfio_group_ioctl_set_container(struct
vfio_group*group,drivers/vfio/group.c static int vfio_group_ioctl_set_container(struct vfio_group *group,
Quoted 5 lines
drivers/vfio/group.c +2
-0return ret; } +#ifdef CONFIG_HAVE_KVM +static bool vfio_kvm_get_kvm_safe(struct vfio_device *device, structkvm *kvm)
I'm tempted to name these
vfio_device_get_kvm_safe()and only pass thevfio_device, where of course we can get the kvm pointer from the group internally.drivers/vfio/group.c static int vfio_group_ioctl_set_container(struct vfio_group *group, · line 166
Quoted 5 lines
drivers/vfio/group.c +5
-0+{ +void (*pfn)(struct kvm *kvm); +bool (*fn)(struct kvm *kvm); +bool ret; +We should
assert_lockdep_held(&device->dev_set->lock)in both of these since that seems to be what's protectingdevice->kvmanddevice->put_kvm.If we change as above to get the kvm pointer from the group within this function, we can also move the
kvm_ref_lockhere, which seems to simplify the caller quite a bit.Quoted 15 lines
drivers/vfio/group.c +15
-0+ pfn =symbol_get (kvm_put_kvm); +if (WARN_ON (!pfn)) +return false; + + fn =symbol_get (kvm_get_kvm_safe); +if (WARN_ON (!fn)) { +symbol_put (kvm_put_kvm); +return false; + } + + ret =fn (kvm); +if (ret) + device->put_kvm = pfn; +else +symbol_put (kvm_put_kvm);drivers/vfio/group.c static int vfio_group_ioctl_set_container(struct · line 191
Quoted 10 lines
drivers/vfio/group.c +10
-0+ +symbol_put (kvm_get_kvm_safe); + +return ret; +} + +static void vfio_kvm_put_kvm (struct vfio_device *device) +{ +if (WARN_ON (!device->kvm || !device->put_kvm)) +return ;It simplifies the caller if we can use this even in the !device->kvm case.
drivers/vfio/group.c static int vfio_group_ioctl_set_container(struct vfio_group *group,
Quoted 8 lines
drivers/vfio/group.c +8
-0+ + device->put_kvm (device->kvm); + device->put_kvm =NULL ; +symbol_put (kvm_put_kvm); +} + +#else +static bool vfio_kvm_get_kvm_safe(struct vfio_device *device, structkvm *kvm)
drivers/vfio/group.c static int vfio_device_group_open(struct
Quoted 13 lines
drivers/vfio/group.c +9
-0+{ +return false; +} + +static void vfio_kvm_put_kvm (struct vfio_device *device) +{ +} +#endif +static int vfio_device_group_open (struct vfio_device *device) {int ret;@@ -164,14 +216,32 @@ static int vfio_device_group_open(struct
vfio_device*device)drivers/vfio/group.c static int vfio_device_group_open(struct vfio_device *device)
Quoted 7 lines
drivers/vfio/group.c +2
-1goto out_unlock; } +mutex_lock (&device->dev_set->lock); +/* -* Here we pass the KVM pointer with the group under the lock. If the
Quoted 12 lines
drivers/vfio/group.c +9
-2-* device driver will use it, it must obtain a reference and release it -* during close_device. +* Before the first device open, get the KVM pointer currently +* associated with the group (if there is one) and obtain a reference +* now that will be held until the open_count reaches 0 again. Save +* the pointer in the device for use by drivers. */ +if (device->open_count ==0 ) { +spin_lock (&device->group->kvm_ref_lock); +if (device->group->kvm && +vfio_kvm_get_kvm_safe (device, device->group->kvm)) + device->kvm = device->group->kvm;
Quoted 8 lines
drivers/vfio/group.c static int vfio_group_ioctl_set_container(struct vfio_group *group,
Quoted 5 lines
drivers/vfio/group.c +3
-0+spin_unlock (&device->group->kvm_ref_lock); + } + ret =vfio_device_open (device, device->group->iommufd, device->group->kvm);We're using
device->group->kvmoutside ofkvm_ref_lockhere, it should be usingdevice->kvm.
Existing code set device->kvm in the vfio_device_first_open() which is called by vfio_device_open(). After above change, seems not necessary to pass kvm pointer into the call chain. Isn't it?
Regards,
Yi Liu
Quoted 5 lines
From: Liu, Yi L <[email protected]>
Sent: Thursday, February 2, 2023 11:47 AMQuoted 3 lines
Quoted 2 lines
(quoted diff) +0
-0ret = vfio_device_open(device, device->group->iommufd, device->group->kvm);
Quoted 7 lines
Quoted 2 lines
We're using
device->group->kvmoutside ofkvm_ref_lockhere, it should be usingdevice->kvm.Existing code set
device->kvmin thevfio_device_first_open()which is called byvfio_device_open(). After above change, seems not necessary to pass kvm pointer into the call chain. Isn't it?
Looks so.
Quoted 162 lines · Yi L
Quoted 153 lines
From: Alex Williamson <[email protected]>
Sent: Thursday, February 2, 2023 7:28 AMQuoted 4 lines · On Wed, 1 Feb 2023 14:20:10 -0500 Matthew Rosato <[email protected]>…
After
51cdc8bc120e, we have another deadlock scenario between thekvm->lockand the vfiogroup_lockwith two different codepaths acquiring the locks in different order. Specifically invfio_open_device, vfio holds the vfiogroup_lockwhen issuingdevice->ops->open_devicebutsome
Quoted 21 lines
drivers (like vfio-ap) need to acquire
kvm->lockduring theiropen_deviceroutine; Meanwhile,kvm_vfio_releasewill acquire thekvm->lockfirst before callingvfio_file_set_kvmwhich will acquire the vfiogroup_lock.To resolve this, let's remove the need for the vfio
group_lockfrom thekvm_vfio_releasecodepath. This is done by introducing a new spinlock to protect modifications to the vfio group kvm pointer, and acquiring a kvm ref from within vfio while holding this spinlock, with the reference held until the last close for the device in question.Fixes 51cdc8bc120e ("kvm/vfio: Fix potential deadlock on vfio group_lock")Reported-by Anthony Krowiak <[email protected]>Suggested-by Jason Gunthorpe <[email protected]>Signed-off-by Matthew Rosato <[email protected]>---
Changes from v1:
* usespin_lockinstead ofspin_lock_irqsave(Jason)
* cleardevice->kvm_putas part ofvfio_kvm_put_kvm(Yi)
* Re-arrange code to avoid referencing the group contents from withinvfio_main(Kevin) which meant moving most of the code in this patch togroup.calong with getting/dropping of thedev_setlockQuoted 2 lines
--- drivers/vfio/group.c | 90+++++++++++++++++++++++++++++++++++++---
drivers/vfio/group.c static int vfio_group_ioctl_set_container(struct
Quoted 20 lines
drivers/vfio/vfio.h | 1 + drivers/vfio/vfio_main.c | 11 ++--- include/linux/vfio.h | 2 +- 4 files changed, 91 insertions(+), 13 deletions(-)drivers/vfio/group.c +3
-0@@ -13,6 +13,9 @@#include <linux/vfio.h> #include <linux/iommufd.h> #include <linux/anon_inodes.h> +#ifdef CONFIG_HAVE_KVM +#include <linux/kvm_host.h> +#endif #include "vfio.h" static struct vfio {@@ -154,6 +157,55 @@ static int vfio_group_ioctl_set_container(struct
vfio_group*group,drivers/vfio/group.c static int vfio_group_ioctl_set_container(struct vfio_group *group,
Quoted 5 lines
drivers/vfio/group.c +2
-0return ret; } +#ifdef CONFIG_HAVE_KVM +static bool vfio_kvm_get_kvm_safe(struct vfio_device *device, structkvm *kvm)
I'm tempted to name these
vfio_device_get_kvm_safe()and only pass thevfio_device, where of course we can get the kvm pointer from the group internally.drivers/vfio/group.c static int vfio_group_ioctl_set_container(struct vfio_group *group, · line 166
Quoted 5 lines
drivers/vfio/group.c +5
-0+{ +void (*pfn)(struct kvm *kvm); +bool (*fn)(struct kvm *kvm); +bool ret; +We should
assert_lockdep_held(&device->dev_set->lock)in both of these since that seems to be what's protectingdevice->kvmanddevice->put_kvm.If we change as above to get the kvm pointer from the group within this function, we can also move the
kvm_ref_lockhere, which seems to simplify the caller quite a bit.Quoted 15 lines
drivers/vfio/group.c +15
-0+ pfn =symbol_get (kvm_put_kvm); +if (WARN_ON (!pfn)) +return false; + + fn =symbol_get (kvm_get_kvm_safe); +if (WARN_ON (!fn)) { +symbol_put (kvm_put_kvm); +return false; + } + + ret =fn (kvm); +if (ret) + device->put_kvm = pfn; +else +symbol_put (kvm_put_kvm);drivers/vfio/group.c static int vfio_group_ioctl_set_container(struct · line 191
Quoted 10 lines
drivers/vfio/group.c +10
-0+ +symbol_put (kvm_get_kvm_safe); + +return ret; +} + +static void vfio_kvm_put_kvm (struct vfio_device *device) +{ +if (WARN_ON (!device->kvm || !device->put_kvm)) +return ;It simplifies the caller if we can use this even in the !device->kvm case.
drivers/vfio/group.c static int vfio_group_ioctl_set_container(struct vfio_group *group,
Quoted 8 lines
drivers/vfio/group.c +8
-0+ + device->put_kvm (device->kvm); + device->put_kvm =NULL ; +symbol_put (kvm_put_kvm); +} + +#else +static bool vfio_kvm_get_kvm_safe(struct vfio_device *device, structkvm *kvm)
drivers/vfio/group.c static int vfio_device_group_open(struct
Quoted 13 lines
drivers/vfio/group.c +9
-0+{ +return false; +} + +static void vfio_kvm_put_kvm (struct vfio_device *device) +{ +} +#endif +static int vfio_device_group_open (struct vfio_device *device) {int ret;@@ -164,14 +216,32 @@ static int vfio_device_group_open(struct
vfio_device*device)drivers/vfio/group.c static int vfio_device_group_open(struct vfio_device *device)
Quoted 7 lines
drivers/vfio/group.c +2
-1goto out_unlock; } +mutex_lock (&device->dev_set->lock); +/* -* Here we pass the KVM pointer with the group under the lock. If the
Quoted 12 lines
drivers/vfio/group.c +9
-2-* device driver will use it, it must obtain a reference and release it -* during close_device. +* Before the first device open, get the KVM pointer currently +* associated with the group (if there is one) and obtain a reference +* now that will be held until the open_count reaches 0 again. Save +* the pointer in the device for use by drivers. */ +if (device->open_count ==0 ) { +spin_lock (&device->group->kvm_ref_lock); +if (device->group->kvm && +vfio_kvm_get_kvm_safe (device, device->group->kvm)) + device->kvm = device->group->kvm;Quoted 8 lines
drivers/vfio/group.c static int vfio_group_ioctl_set_container(struct vfio_group *group,
Quoted 5 lines
drivers/vfio/group.c +3
-0+spin_unlock (&device->group->kvm_ref_lock); + } + ret =vfio_device_open (device, device->group->iommufd, device->group->kvm);We're using
device->group->kvmoutside ofkvm_ref_lockhere, it should be usingdevice->kvm.
Quoted 3 lines
Existing code set
device->kvmin thevfio_device_first_open()which is called byvfio_device_open(). After above change, seems not necessary to pass kvm pointer into the call chain. Isn't it?
Yes, we can get it from the device. I didn't check how much this bloats the patch though. As a fix, it might make sense to save that refactoring for a follow-on patch. Thanks,
Alex
Quoted 196 lines
-----Original Message-----
From: Alex Williamson <[email protected]>
Sent: Thursday, February 2, 2023 12:15 PM
To: Liu, Yi L <[email protected]>
Cc: Matthew Rosato <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Wang, Zhi A <[email protected]>; Christopherson,, Sean <[email protected]>; Tian, Kevin <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]
Subject: Re: [PATCH v2] vfio: fix deadlock between group lock and kvm lockQuoted 8 lines · Yi L
Quoted 8 lines
From: Alex Williamson <[email protected]>
Sent: Thursday, February 2, 2023 7:28 AMQuoted 2 lines · On Wed, 1 Feb 2023 14:20:10 -0500 Matthew Rosato <[email protected]>…
After
51cdc8bc120e, we have another deadlock scenario between thekvm->lockand the vfiogroup_lockwith two different codepathsacquiring
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
the locks in different order. Specifically in
vfio_open_device, vfio holds the vfiogroup_lockwhen issuingdevice->ops->open_devicebutsome
Quoted 1 line
drivers (like vfio-ap) need to acquire
kvm->lockduring their
open_deviceQuoted 5 lines
Quoted 5 lines
Quoted 5 lines
routine; Meanwhile,
kvm_vfio_releasewill acquire thekvm->lockfirst before callingvfio_file_set_kvmwhich will acquire the vfiogroup_lock.To resolve this, let's remove the need for the vfio
group_lockfrom thekvm_vfio_releasecodepath. This is done by introducing a newspinlock to
Quoted 1 line
Quoted 1 line
Quoted 1 line
protect modifications to the vfio group kvm pointer, and acquiring a
kvm
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
ref from within vfio while holding this spinlock, with the reference held until the last close for the device in question.
Fixes 51cdc8bc120e ("kvm/vfio: Fix potential deadlock on vfio
group_lock")Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Reported-by Anthony Krowiak <[email protected]>Suggested-by Jason Gunthorpe <[email protected]>Signed-off-by Matthew Rosato <[email protected]>---
Changes from v1:
* usespin_lockinstead ofspin_lock_irqsave(Jason)
* cleardevice->kvm_putas part ofvfio_kvm_put_kvm(Yi)
* Re-arrange code to avoid referencing the group contents fromwithin
Quoted 23 lines
Quoted 23 lines
Quoted 4 lines
vfio_main(Kevin) which meant moving most of the code in this patch togroup.calong with getting/dropping of thedev_setlock--- drivers/vfio/group.c | 90+++++++++++++++++++++++++++++++++++++---
Quoted 18 lines
drivers/vfio/vfio.h | 1 + drivers/vfio/vfio_main.c | 11 ++--- include/linux/vfio.h | 2 +- 4 files changed, 91 insertions(+), 13 deletions(-)drivers/vfio/group.c +3
-0@@ -13,6 +13,9 @@#include <linux/vfio.h> #include <linux/iommufd.h> #include <linux/anon_inodes.h> +#ifdef CONFIG_HAVE_KVM +#include <linux/kvm_host.h> +#endif #include "vfio.h" Quoted 2 lines
Quoted 2 lines
drivers/vfio/group.c static int
Quoted 2 lines
drivers/vfio/group.c +0
-0static struct vfio {@@ -154,6 +157,55 @@ static intvfio_group_ioctl_set_container(struct
Quoted 6 lines
Quoted 6 lines
vfio_group*group,drivers/vfio/group.c static int · line 161
Quoted 5 lines
drivers/vfio/group.c +2
-0return ret; } +#ifdef CONFIG_HAVE_KVM +static bool vfio_kvm_get_kvm_safe(struct vfio_device *device,struct
Quoted 3 lines
Quoted 3 lines
kvm *kvm)
I'm tempted to name these
vfio_device_get_kvm_safe()and only passthe
Quoted 1 line
Quoted 1 line
vfio_device, where of course we can get the kvm pointer from thegroup
Quoted 9 lines
Quoted 9 lines
internally.
drivers/vfio/group.c static int · line 166
Quoted 5 lines
drivers/vfio/group.c +5
-0+{ +void (*pfn)(struct kvm *kvm); +bool (*fn)(struct kvm *kvm); +bool ret; +We should
assert_lockdep_held(&device->dev_set->lock)in both ofthese
Quoted 36 lines
Quoted 36 lines
since that seems to be what's protecting
device->kvmanddevice->put_kvm.If we change as above to get the kvm pointer from the group within this function, we can also move the
kvm_ref_lockhere, which seems to simplify the caller quite a bit.Quoted 15 lines
drivers/vfio/group.c +15
-0+ pfn =symbol_get (kvm_put_kvm); +if (WARN_ON (!pfn)) +return false; + + fn =symbol_get (kvm_get_kvm_safe); +if (WARN_ON (!fn)) { +symbol_put (kvm_put_kvm); +return false; + } + + ret =fn (kvm); +if (ret) + device->put_kvm = pfn; +else +symbol_put (kvm_put_kvm);drivers/vfio/group.c static int · line 191
Quoted 10 lines
drivers/vfio/group.c +10
-0+ +symbol_put (kvm_get_kvm_safe); + +return ret; +} + +static void vfio_kvm_put_kvm (struct vfio_device *device) +{ +if (WARN_ON (!device->kvm || !device->put_kvm)) +return ;It simplifies the caller if we can use this even in the !device->kvm case.
Quoted 8 lines
Quoted 8 lines
drivers/vfio/group.c static int · line 199
Quoted 8 lines
drivers/vfio/group.c +8
-0+ + device->put_kvm (device->kvm); + device->put_kvm =NULL ; +symbol_put (kvm_put_kvm); +} + +#else +static bool vfio_kvm_get_kvm_safe(struct vfio_device *device,struct
Quoted 34 lines
Quoted 34 lines
kvm *kvm)
drivers/vfio/group.c static int vfio_device_group_open(struct
Quoted 13 lines
drivers/vfio/group.c +9
-0+{ +return false; +} + +static void vfio_kvm_put_kvm (struct vfio_device *device) +{ +} +#endif +static int vfio_device_group_open (struct vfio_device *device) {int ret;@@ -164,14 +216,32 @@ static int vfio_device_group_open(struct
vfio_device*device)drivers/vfio/group.c static int vfio_device_group_open(struct · line 168
Quoted 7 lines
drivers/vfio/group.c +2
-1goto out_unlock; } +mutex_lock (&device->dev_set->lock); +/* -* Here we pass the KVM pointer with the group under the lock. If the
Quoted 11 lines
drivers/vfio/group.c +8
-2-* device driver will use it, it must obtain a reference and release it -* during close_device. +* Before the first device open, get the KVM pointer currently +* associated with the group (if there is one) and obtain a reference +* now that will be held until the open_count reaches 0 again. Save +* the pointer in the device for use by drivers. */ +if (device->open_count ==0 ) { +spin_lock (&device->group->kvm_ref_lock); +if (device->group->kvm && +vfio_kvm_get_kvm_safe (device, device->group->kvm))Quoted 8 lines
Quoted 8 lines
drivers/vfio/group.c static int vfio_device_group_open(struct · line 236
Quoted 6 lines
drivers/vfio/group.c +4
-0+ device->kvm = device->group->kvm; +spin_unlock (&device->group->kvm_ref_lock); + } + ret =vfio_device_open (device, device->group->iommufd, device->group->kvm);We're using
device->group->kvmoutside ofkvm_ref_lockhere, itshould
Quoted 2 lines
Quoted 1 line
be using
device->kvm.
Quoted 7 lines
Quoted 3 lines
Existing code set
device->kvmin thevfio_device_first_open()which is called byvfio_device_open(). After above change, seems not necessary to pass kvm pointer into the call chain. Isn't it?Yes, we can get it from the device. I didn't check how much this bloats the patch though. As a fix, it might make sense to save that refactoring for a follow-on patch. Thanks,
65 lines diff file. 😊 follow-on path works well.
drivers/vfio/group.c +1 -2
@@ -169,8 +169,7 @@ static int vfio_device_group_open(struct vfio_device *device)* device driver will use it, it must obtain a reference and release it * during close_device. */ - ret =vfio_device_open (device, device->group->iommufd, - device->group->kvm); + ret =vfio_device_open (device, device->group->iommufd); out_unlock:mutex_unlock (&device->group->group_lock);
drivers/vfio/vfio.h +1 -1
@@ -19,7 +19,7 @@ struct vfio_container;void vfio_device_put_registration (struct vfio_device *device);bool vfio_device_try_get_registration (struct vfio_device *device);int vfio_device_open (struct vfio_device *device, -struct iommufd_ctx *iommufd,struct kvm *kvm); +struct iommufd_ctx *iommufd);void vfio_device_close (struct vfio_device *device,struct iommufd_ctx *iommufd);
drivers/vfio/vfio_main.c +3 -4
@@ -345,7 +345,7 @@ static bool vfio_assert_device_open(struct vfio_device *device) }static int vfio_device_first_open (struct vfio_device *device, -struct iommufd_ctx *iommufd,struct kvm *kvm) +struct iommufd_ctx *iommufd) {int ret;
@@ -361,7 +361,6 @@ static int vfio_device_first_open(struct vfio_device *device,if (ret) goto err_module_put; - device->kvm = kvm;if (device->ops->open_device) { ret = device->ops->open_device (device);if (ret)
@@ -396,14 +395,14 @@ static void vfio_device_last_close(struct vfio_device *device, }int vfio_device_open (struct vfio_device *device, -struct iommufd_ctx *iommufd,struct kvm *kvm) +struct iommufd_ctx *iommufd) {int ret =0 ;mutex_lock (&device->dev_set->lock); device->open_count++;if (device->open_count ==1 ) { - ret =vfio_device_first_open (device, iommufd, kvm); + ret =vfio_device_first_open (device, iommufd);if (ret) device->open_count--; }
Quoted 11 lines
From: Alex Williamson <[email protected]>
Sent: Thursday, February 2, 2023 7:28 AMReview
Quoted 3 lines
(quoted diff) +2
-0+#ifdef CONFIG_HAVE_KVM +static bool vfio_kvm_get_kvm_safe(struct vfio_device *device, struct kvm*kvm)
I'm tempted to name these
vfio_device_get_kvm_safe()and only pass thevfio_device, where of course we can get the kvm pointer from the group internally.
I have a different thought. In the end the cdev series also need the similar safe get/put logic then it's better to keep it in vfio_main.c called by the group/cdev path individually.
Quoted 7 lines · Kevin
Quoted 7 lines
From: Alex Williamson <[email protected]>
Sent: Thursday, February 2, 2023 7:28 AMReview
Quoted 3 lines
(quoted diff) +2
-0+#ifdef CONFIG_HAVE_KVM +static bool vfio_kvm_get_kvm_safe(struct vfio_device *device, struct kvm*kvm)
Quoted 8 lines
Quoted 4 lines
I'm tempted to name these
vfio_device_get_kvm_safe()and only pass thevfio_device, where of course we can get the kvm pointer from the group internally.I have a different thought. In the end the cdev series also need the similar safe get/put logic then it's better to keep it in
vfio_main.ccalled by the group/cdev path individually.
Ah, I hadn't considered the cdev series - OK, I can move the functions back into vfio_main and externalize both via drivers/vfio/vfio.h so they can be called from group.c for this fix and then available to vfio_main.c already for cdev.
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for vfio: fix deadlock between group lock and kvm lock (rev3)
In reply to Matthew Rosato== Series Details ==
== Series Details ==
Series: vfio: fix deadlock between group lock and kvm lock (rev3)
URL : https://patchwork.freedesktop.org/series/113535/
State : warning
== Summary ==
Error: dim checkpatch failedc2474b730a36 vfio: fix deadlock between group lock and kvm lock
-:23: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #23:
Quoted 1 line
Fixes 51cdc8bc120e ("kvm/vfio: Fix potential deadlock on vfio group_lock")
-:320: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #320: FILE: drivers/vfio/vfio.h:77:
+ spinlock_t kvm_ref_lock;
-:403: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 1 errors, 1 warnings, 1 checks, 205 lines checked
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for vfio: fix deadlock between group lock and kvm lock (rev3)
In reply to Matthew Rosato== Series Details ==
== Series Details ==
Series: vfio: fix deadlock between group lock and kvm lock (rev3)
URL : https://patchwork.freedesktop.org/series/113535/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12681 -> Patchwork_113535v3
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/index.html
Participating hosts (25 -> 25)
------------------------------
Additional (1): fi-apl-guc
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_113535v3:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-adlp-6}: [PASS][1] -> [DMESG-WARN][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/bat-adlp-6/igt@gem_exec_suspend@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/bat-adlp-6/igt@gem_exec_suspend@[email protected]
Known issues
------------
Here are the changes found in Patchwork_113535v3 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@write:
- fi-blb-e6850: [PASS][3] -> [SKIP][4] ([fdo#109271]) +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/fi-blb-e6850/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/fi-blb-e6850/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- fi-apl-guc: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/fi-apl-guc/igt@[email protected]
* igt@kms_chamelium_hpd@vga-hpd-fast:
- fi-apl-guc: NOTRUN -> [SKIP][6] ([fdo#109271]) +21 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/fi-apl-guc/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6311]: https://gitlab.freedesktop.org/drm/intel/issues/6311
[i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
Build changes
-------------
* Linux: CI_DRM_12681 -> Patchwork_113535v3
CI-20190529: 20190529
CI_DRM_12681: 8ee2ec597aa4b8331124bf852432c2ca2fd7b8d1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7143: c7b12dcc460fc2348e1fa7f4dcb791bb82e29e44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113535v3: 8ee2ec597aa4b8331124bf852432c2ca2fd7b8d1 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
603f233f2121 vfio: fix deadlock between group lock and kvm lock
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for vfio: fix deadlock between group lock and kvm lock (rev3)
In reply to Matthew Rosato== Series Details ==
== Series Details ==
Series: vfio: fix deadlock between group lock and kvm lock (rev3)
URL : https://patchwork.freedesktop.org/series/113535/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12681_full -> Patchwork_113535v3_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/index.html
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_113535v3_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc:
- {shard-dg1}: NOTRUN -> [DMESG-WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-dg1-13/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-wc.html
Known issues
------------
Here are the changes found in Patchwork_113535v3_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][2] -> [FAIL][3] ([i915#2842])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-glk7/igt@gem_exec_fair@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-glk4/igt@gem_exec_fair@[email protected]
* igt@kms_cursor_legacy@single-bo@pipe-b:
- shard-glk: [PASS][4] -> [DMESG-WARN][5] ([i915#118])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-glk3/igt@kms_cursor_legacy@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-glk8/igt@kms_cursor_legacy@[email protected]
#### Possible fixes ####
* igt@drm_fdinfo@virtual-idle:
- {shard-rkl}: [FAIL][6] ([i915#7742]) -> [PASS][7] +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-2/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-rkl-3/igt@[email protected]
* igt@drm_read@short-buffer-block:
- {shard-tglu}: [SKIP][8] ([i915#7651]) -> [PASS][9] +6 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-tglu-6/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-tglu-3/igt@[email protected]
* igt@fbdev@write:
- {shard-tglu}: [SKIP][10] ([i915#2582]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-tglu-6/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-tglu-3/igt@[email protected]
* igt@feature_discovery@psr2:
- {shard-rkl}: [SKIP][12] ([i915#658]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-1/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-rkl-6/igt@[email protected]
* igt@gem_exec_endless@dispatch@bcs0:
- {shard-rkl}: [SKIP][14] ([i915#6247]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-5/igt@gem_exec_endless@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-rkl-6/igt@gem_exec_endless@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- {shard-rkl}: [FAIL][16] ([i915#2842]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-5/igt@gem_exec_fair@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-rkl-5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_reloc@basic-write-gtt:
- {shard-rkl}: [SKIP][18] ([i915#3281]) -> [PASS][19] +3 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-6/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-rkl-5/igt@[email protected]
* igt@gem_pread@uncached:
- {shard-rkl}: [SKIP][20] ([i915#3282]) -> [PASS][21] +2 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-2/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-rkl-5/igt@[email protected]
* igt@gen9_exec_parse@bb-chained:
- {shard-rkl}: [SKIP][22] ([i915#2527]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-2/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-rkl-5/igt@[email protected]
* igt@i915_pm_rpm@cursor:
- {shard-rkl}: [SKIP][24] ([i915#1849]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-5/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-rkl-6/igt@[email protected]
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-rkl}: [SKIP][26] ([i915#1397]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-1/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-rkl-6/igt@[email protected]
* igt@i915_pm_rpm@modeset-lpsp-stress:
- {shard-tglu}: [SKIP][28] ([i915#1397]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-tglu-6/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-tglu-3/igt@[email protected]
* igt@kms_big_fb@x-tiled-32bpp-rotate-0:
- {shard-rkl}: [SKIP][30] ([i915#1845] / [i915#4098]) -> [PASS][31] +13 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-1/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][32] ([i915#2346]) -> [PASS][33] +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-glk4/igt@kms_cursor_legacy@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-glk1/igt@kms_cursor_legacy@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- {shard-tglu}: [SKIP][34] ([i915#1849]) -> [PASS][35] +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-tglu-6/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-tglu-3/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-tiling-linear:
- {shard-rkl}: [SKIP][36] ([i915#1849] / [i915#4098]) -> [PASS][37] +12 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-5/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-rkl-6/igt@[email protected]
* igt@kms_psr@cursor_mmap_gtt:
- {shard-rkl}: [SKIP][38] ([i915#1072]) -> [PASS][39] +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-1/igt@kms_psr@cursor_mmap_gtt.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-rkl-6/igt@kms_psr@cursor_mmap_gtt.html
* igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-a:
- {shard-rkl}: [SKIP][40] ([i915#4098]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-5/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-a.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-rkl-6/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-a.html
* igt@kms_universal_plane@universal-plane-pipe-c-sanity:
- {shard-tglu}: [SKIP][42] ([fdo#109274]) -> [PASS][43] +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-tglu-6/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-tglu-3/igt@[email protected]
* igt@kms_vblank@pipe-d-wait-forked-busy:
- {shard-tglu}: [SKIP][44] ([i915#1845] / [i915#7651]) -> [PASS][45] +2 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-tglu-6/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-tglu-3/igt@[email protected]
* igt@prime_vgem@basic-write:
- {shard-rkl}: [SKIP][46] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-2/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/shard-rkl-5/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
[i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
[i915#7984]: https://gitlab.freedesktop.org/drm/intel/issues/7984
Build changes
-------------
* Linux: CI_DRM_12681 -> Patchwork_113535v3
CI-20190529: 20190529
CI_DRM_12681: 8ee2ec597aa4b8331124bf852432c2ca2fd7b8d1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7143: c7b12dcc460fc2348e1fa7f4dcb791bb82e29e44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113535v3: 8ee2ec597aa4b8331124bf852432c2ca2fd7b8d1 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v3/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for vfio: fix deadlock between group lock and kvm lock (rev4)
In reply to Matthew Rosato== Series Details ==
== Series Details ==
Series: vfio: fix deadlock between group lock and kvm lock (rev4)
URL : https://patchwork.freedesktop.org/series/113535/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12681 -> Patchwork_113535v4
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/index.html
Participating hosts (25 -> 25)
------------------------------
Additional (1): fi-apl-guc
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_113535v4 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@write:
- fi-blb-e6850: [PASS][1] -> [SKIP][2] ([fdo#109271]) +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/fi-blb-e6850/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/fi-blb-e6850/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- fi-apl-guc: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/fi-apl-guc/igt@[email protected]
* igt@kms_chamelium_hpd@vga-hpd-fast:
- fi-apl-guc: NOTRUN -> [SKIP][4] ([fdo#109271]) +21 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/fi-apl-guc/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
Build changes
-------------
* Linux: CI_DRM_12681 -> Patchwork_113535v4
CI-20190529: 20190529
CI_DRM_12681: 8ee2ec597aa4b8331124bf852432c2ca2fd7b8d1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7143: c7b12dcc460fc2348e1fa7f4dcb791bb82e29e44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113535v4: 8ee2ec597aa4b8331124bf852432c2ca2fd7b8d1 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
811a6b4b6999 vfio: fix deadlock between group lock and kvm lock
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for vfio: fix deadlock between group lock and kvm lock (rev4)
In reply to Matthew Rosato== Series Details ==
== Series Details ==
Series: vfio: fix deadlock between group lock and kvm lock (rev4)
URL : https://patchwork.freedesktop.org/series/113535/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12681_full -> Patchwork_113535v4_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_113535v4_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_113535v4_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/index.html
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_113535v4_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@execlists:
- shard-glk: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-glk4/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-glk3/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in Patchwork_113535v4_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@perf@stress-open-close:
- shard-glk: [PASS][3] -> [ABORT][4] ([i915#5213])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-glk9/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-glk6/igt@[email protected]
#### Possible fixes ####
* igt@drm_fdinfo@virtual-idle:
- {shard-rkl}: [FAIL][5] ([i915#7742]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-rkl-5/igt@[email protected]
* igt@drm_read@short-buffer-block:
- {shard-tglu}: [SKIP][7] ([i915#7651]) -> [PASS][8] +6 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-tglu-6/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-tglu-2/igt@[email protected]
* igt@fbdev@nullptr:
- {shard-rkl}: [SKIP][9] ([i915#2582]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-rkl-6/igt@[email protected]
* igt@fbdev@write:
- {shard-tglu}: [SKIP][11] ([i915#2582]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-tglu-6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-tglu-2/igt@[email protected]
* igt@gem_eio@in-flight-suspend:
- {shard-rkl}: [FAIL][13] ([fdo#103375]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-3/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-rkl-5/igt@[email protected]
* igt@gem_exec_endless@dispatch@bcs0:
- {shard-rkl}: [SKIP][15] ([i915#6247]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-5/igt@gem_exec_endless@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-rkl-3/igt@gem_exec_endless@[email protected]
* igt@gem_exec_fair@basic-deadline:
- {shard-rkl}: [FAIL][17] ([i915#2846]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-1/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-rkl-4/igt@[email protected]
* igt@gem_exec_reloc@basic-wc-read-noreloc:
- {shard-rkl}: [SKIP][19] ([i915#3281]) -> [PASS][20] +10 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-3/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-rkl-5/igt@[email protected]
* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- {shard-rkl}: [SKIP][21] ([i915#3282]) -> [PASS][22] +8 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-3/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-rkl-5/igt@[email protected]
* igt@gen9_exec_parse@bb-start-far:
- {shard-rkl}: [SKIP][23] ([i915#2527]) -> [PASS][24] +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-rkl-5/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- {shard-rkl}: [SKIP][25] ([i915#658]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-4/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-rkl-6/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- {shard-rkl}: [SKIP][27] ([i915#3361]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-5/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-rkl-2/igt@[email protected]
* igt@i915_pm_rpm@fences-dpms:
- {shard-rkl}: [SKIP][29] ([i915#1849]) -> [PASS][30] +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-2/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-rkl-6/igt@[email protected]
* igt@i915_pm_rpm@modeset-lpsp-stress:
- {shard-tglu}: [SKIP][31] ([i915#1397]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-tglu-6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-tglu-2/igt@[email protected]
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- {shard-rkl}: [SKIP][33] ([i915#1397]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-2/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-rkl-6/igt@[email protected]
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- {shard-dg1}: [SKIP][35] ([i915#1397]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-dg1-14/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-dg1-15/igt@[email protected]
* igt@i915_pm_rpm@pm-tiling:
- {shard-rkl}: [SKIP][37] ([fdo#109308]) -> [PASS][38] +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-4/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-rkl-6/igt@[email protected]
* igt@kms_big_fb@linear-32bpp-rotate-0:
- {shard-rkl}: [SKIP][39] ([i915#1845] / [i915#4098]) -> [PASS][40] +18 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-4/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-rkl-6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
- {shard-rkl}: [SKIP][41] ([i915#1849] / [i915#4098]) -> [PASS][42] +9 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-4/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-rkl-6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- {shard-tglu}: [SKIP][43] ([i915#1849]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-tglu-6/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-tglu-2/igt@[email protected]
* igt@kms_psr@dpms:
- {shard-rkl}: [SKIP][45] ([i915#1072]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-2/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-rkl-6/igt@[email protected]
* igt@kms_universal_plane@universal-plane-pipe-c-sanity:
- {shard-tglu}: [SKIP][47] ([fdo#109274]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-tglu-6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-tglu-2/igt@[email protected]
* igt@kms_vblank@pipe-d-wait-forked-busy:
- {shard-tglu}: [SKIP][49] ([i915#1845] / [i915#7651]) -> [PASS][50] +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-tglu-6/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-tglu-2/igt@[email protected]
* igt@prime_vgem@basic-read:
- {shard-rkl}: [SKIP][51] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12681/shard-rkl-1/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/shard-rkl-5/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#5099]: https://gitlab.freedesktop.org/drm/intel/issues/5099
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
[i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
[i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
[i915#7984]: https://gitlab.freedesktop.org/drm/intel/issues/7984
Build changes
-------------
* Linux: CI_DRM_12681 -> Patchwork_113535v4
CI-20190529: 20190529
CI_DRM_12681: 8ee2ec597aa4b8331124bf852432c2ca2fd7b8d1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7143: c7b12dcc460fc2348e1fa7f4dcb791bb82e29e44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113535v4: 8ee2ec597aa4b8331124bf852432c2ca2fd7b8d1 @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113535v4/index.html