Skip to contentSkip to conversation

ACPI: video: Fix Lenovo Ideapad Z570 DMI match

PATCH Applied Hans de Goede 2 participants 2 messages Feb 2, 2023 – Feb 6, 2023 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: video: Fix Lenovo Ideapad Z570 DMI match

Multiple Ideapad Z570 variants need acpi_backlight=native to force native use on these pre Windows 8 machines since acpi_video backlight control does not work here.

The original DMI quirk matches on a product_name of "102434U" but other variants may have different product_name-s such as e.g. "1024D9U".

Move to checking product_version instead as is more or less standard for Lenovo DMI quirks for similar reasons.

---
 drivers/acpi/video_detect.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/video_detect.c +1 -1
index a8c02608dde4..710ac640267d 100644
@@ -434,7 +434,7 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
 	 /* Lenovo Ideapad Z570 */
 	 .matches = {
 		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-		DMI_MATCH(DMI_PRODUCT_NAME, "102434U"),
+		DMI_MATCH(DMI_PRODUCT_VERSION, "Ideapad Z570"),
 		},
 	},
 	{
Signature · 1 line
2.39.1
maintainer Applied
#1 lore raw
Quoted 21 lines · Hans de Goede

Multiple Ideapad Z570 variants need acpi_backlight=native to force native use on these pre Windows 8 machines since acpi_video backlight control does not work here.

The original DMI quirk matches on a product_name of "102434U" but other variants may have different product_name-s such as e.g. "1024D9U".

Move to checking product_version instead as is more or less standard for Lenovo DMI quirks for similar reasons.

---
 drivers/acpi/video_detect.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/video_detect.c +0 -0
index a8c02608dde4..710ac640267d 100644

drivers/acpi/video_detect.c static const struct dmi_system_id video_detect_dmi_table[] = {

Quoted 9 lines
drivers/acpi/video_detect.c +1 -2
@@ -434,7 +434,7 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
         /* Lenovo Ideapad Z570 */
         .matches = {
                DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-               DMI_MATCH(DMI_PRODUCT_NAME, "102434U"),
+               DMI_MATCH(DMI_PRODUCT_VERSION, "Ideapad Z570"),
                },
        },
        {
--

Applied as 6.3 material, thanks!