Skip to contentSkip to conversation

kernel/time/test_udelay.c: fix memory leak with using debugfs_lookup()

PATCH Applied Greg Kroah-Hartman 2 participants 2 messages Feb 2, 2023 – Feb 9, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel/time/test_udelay.c: fix memory leak with using debugfs_lookup()

When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once.

---
 kernel/time/test_udelay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/time/test_udelay.c +1 -1
index 13b11eb62685..20d5df631570 100644
@@ -149,7 +149,7 @@ module_init(udelay_test_init);
 static void __exit udelay_test_exit(void)
 {
 	mutex_lock(&udelay_test_lock);
-	debugfs_remove(debugfs_lookup(DEBUGFS_FILENAME, NULL));
+	debugfs_lookup_and_remove(DEBUGFS_FILENAME, NULL);
 	mutex_unlock(&udelay_test_lock);
 }
 
Signature · 1 line
2.39.1
#1 lore raw

[tip: timers/core] time/debug: Fix memory leak with using debugfs_lookup()

The following commit has been merged into the timers/core branch of tip:

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     5b268d8abaec6cbd4bd70d062e769098d96670aa
Gitweb:        https://git.kernel.org/tip/5b268d8abaec6cbd4bd70d062e769098d96670aa
Author:        Greg Kroah-Hartman <[email protected]>
AuthorDate:    Thu, 02 Feb 2023 16:12:14 +01:00
Committer:     Thomas Gleixner <[email protected]>
CommitterDate: Thu, 09 Feb 2023 20:12:27 +01:00

time/debug: Fix memory leak with using debugfs_lookup()

When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once.

---
 kernel/time/test_udelay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/time/test_udelay.c +1 -1
index 13b11eb..20d5df6 100644
@@ -149,7 +149,7 @@ module_init(udelay_test_init);
 static void __exit udelay_test_exit(void)
 {
 	mutex_lock(&udelay_test_lock);
-	debugfs_remove(debugfs_lookup(DEBUGFS_FILENAME, NULL));
+	debugfs_lookup_and_remove(DEBUGFS_FILENAME, NULL);
 	mutex_unlock(&udelay_test_lock);
 }