kernel/power/energy_model.c: fix memory leak with using debugfs_lookup()
Subsystems (3)
PATCH 1/1 kernel/power/energy_model.c: fix memory leak with using debugfs_lookup()
When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once.
Cc "Rafael J. Wysocki" <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Len Brown <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- kernel/power/energy_model.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
kernel/power/energy_model.c +1 -4
@@ -87,10 +87,7 @@ static void em_debug_create_pd(struct device *dev)static void em_debug_remove_pd (struct device *dev) { -struct dentry *debug_dir; - - debug_dir =debugfs_lookup (dev_name (dev), rootdir); -debugfs_remove_recursive (debug_dir); +debugfs_lookup_and_remove (dev_name (dev), rootdir); }static int __init em_debug_init (void )
Signature · 1 line
2.39.1
Quoted 23 lines · Greg Kroah-Hartman
When calling
debugfs_lookup()the result must havedput()called on it, otherwise the memory will leak over time. To make things simpler, just calldebugfs_lookup_and_remove()instead which handles all of the logic at once.Cc "Rafael J. Wysocki" <[email protected]>Cc Pavel Machek <[email protected]>Cc Len Brown <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- kernel/power/energy_model.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)kernel/power/energy_model.c +0
-0@@ -87,10 +87,7 @@ static void em_debug_create_pd(struct device *dev)static void em_debug_remove_pd (struct device *dev)
kernel/power/energy_model.c static void em_debug_create_pd(struct device *dev)
Quoted 10 lines
kernel/power/energy_model.c +1
-5{ -struct dentry *debug_dir; - - debug_dir =debugfs_lookup (dev_name (dev), rootdir); -debugfs_remove_recursive (debug_dir); +debugfs_lookup_and_remove (dev_name (dev), rootdir); }static int __init em_debug_init (void ) --
Applied as 6.3 material, thanks!