Skip to contentSkip to conversation

mm-compaction-remove-redundant-vm_bug_on-in-compact_zone.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Feb 3, 2023

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm: compaction: remove redundant VM_BUG_ON() in compact_zone()
has been removed from the -mm tree. Its filename was
mm-compaction-remove-redundant-vm_bug_on-in-compact_zone.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Baolin Wang <[email protected]>
Subject: mm: compaction: remove redundant VM_BUG_ON() in compact_zone()
Date: Tue, 10 Jan 2023 21:36:18 +0800

Patch series "Some small improvements for compaction".

When I did some compaction testing, I found some small room for improvement as well as some code cleanups.

This patch (of 5):

The compaction_suitable() will never return values other than COMPACT_SUCCESS, COMPACT_SKIPPED and COMPACT_CONTINUE, so after validation of COMPACT_SUCCESS and COMPACT_SKIPPED, we will never hit other unexpected case. Thus remove the redundant VM_BUG_ON() validation for the return values of compaction_suitable().

---

mm/compaction.c renamed from mm/compaction.c~mm-compaction-remove-redundant-vm_bug_on-in-compact_zone +0 -3
@@ -2313,9 +2313,6 @@ compact_zone(struct compact_control *cc,
 	if (ret == COMPACT_SUCCESS || ret == COMPACT_SKIPPED)
 		return ret;
 
-	/* huh, compaction_suitable is returning something unexpected */
-	VM_BUG_ON(ret != COMPACT_CONTINUE);
-
 	/*
 	 * Clear pageblock skip if there were failures recently and compaction
 	 * is about to be retried after being deferred.

_

Patches currently in -mm which might be from [email protected] are