Skip to contentSkip to conversation

mm-sparse-fix-unused-function-pgdat_to_phys-warning.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Feb 3, 2023

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm/sparse: fix "unused function 'pgdat_to_phys'" warning
has been removed from the -mm tree. Its filename was
mm-sparse-fix-unused-function-pgdat_to_phys-warning.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Mike Rapoport <[email protected]>
Subject: mm/sparse: fix "unused function 'pgdat_to_phys'" warning
Date: Sat, 21 Jan 2023 12:11:51 +0200

W=1 build with clangs complains:

mm/sparse.c:347:27: warning: unused function 'pgdat_to_phys' [-Wunused-function] static inline phys_addr_t pgdat_to_phys(struct pglist_data *pgdat)

                             ^

1 warning generated.

pgdat_to_phys() is only used by functions defined when CONFIG_MEMORY_HOTREMOVE=y.

Move pgdat_to_phys() under #ifdef CONFIG_MEMORY_HOTREMOVE to make clang happy.

---

mm/sparse.c renamed from mm/sparse.c~mm-sparse-fix-unused-function-pgdat_to_phys-warning +1 -1
@@ -318,6 +318,7 @@ size_t mem_section_usage_size(void)
 	return sizeof(struct mem_section_usage) + usemap_size();
 }
 
+#ifdef CONFIG_MEMORY_HOTREMOVE
 static inline phys_addr_t pgdat_to_phys(struct pglist_data *pgdat)
 {
 #ifndef CONFIG_NUMA
@@ -328,7 +329,6 @@ static inline phys_addr_t pgdat_to_phys(
 #endif
 }
 
-#ifdef CONFIG_MEMORY_HOTREMOVE
 static struct mem_section_usage * __init
 sparse_early_usemaps_alloc_pgdat_section(struct pglist_data *pgdat,
 					 unsigned long size)

_

Patches currently in -mm which might be from [email protected] are

arm-include-asm-generic-memory_modelh-from-pageh-rather-than-memoryh.patch m68k-use-asm-generic-memory_modelh-for-both-mmu-and-mmu.patch mips-drop-definition-of-pfn_valid-for-discontigmem.patch mm-arch-add-generic-implementation-of-pfn_valid-for-flatmem.patch mm-arch-add-generic-implementation-of-pfn_valid-for-flatmem-fix.patch