usb: host: USB_XHCI_RZV2M depends on USB_GADGET

PATCH In review Tom Rix 2 participants 3 messages Feb 5, 2023 USB

Share & tools

Tom Rix

author

2023-02-05 02:13 UTC #0 lore raw

PATCH 1/1 usb: host: USB_XHCI_RZV2M depends on USB_GADGET

A rand config causes this link error
ld: drivers/usb/host/xhci-rzv2m.o: in function `xhci_rzv2m_init_quirk':
xhci-rzv2m.c:(.text+0x13): undefined reference to `rzv2m_usb3drd_reset'

xhci_rzv2m_init_quirk build is controlled by USB_XHCI_RZV2M rzv2m_usb3drd_reset build is controlled by USB_RZV2M_USB3DRD

USE_XHCI_RZV2M does select USB_RZV2M_USB3DRD, but USB_RZV2M_USB3DRD depends on USB_GADGET, so now does USE_XHCI_RZV2M.

Signed-off-by Tom Rix <[email protected]>

---
 drivers/usb/host/Kconfig | 1 +
 1 file changed, 1 insertion(+)

drivers/usb/host/Kconfig +1 -0

index 2b80ce9587c1..2dd9e95a5b86 100644
@@ -100,6 +100,7 @@ config USB_XHCI_RZV2M
 	tristate "xHCI support for Renesas RZ/V2M SoC"
 	depends on USB_XHCI_PLATFORM
 	depends on ARCH_R9A09G011 || COMPILE_TEST
+	depends on USB_GADGET
 	select USB_RZV2M_USB3DRD
 	help
 	  Say 'Y' to enable the support for the xHCI host controller

Signature · 1 line

2.27.0

Biju Das

2023-02-05 08:52 UTC #1 lore raw

Hi Tom,

Thanks for the patch.

Arnd send a patch for refactoring the USB_XHCI_RZV2M KConfig dependencies related to USB_GADGET on [1] and is in usb-next. Do you see this issue after applying[1]?

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=ec5499d338ece9db9b7590649d3cfcc4d7f9603d

Cheers,
Biju

Quoted 39 lines

-----Original Message-----
From: Tom Rix <[email protected]>
Sent: Sunday, February 5, 2023 2:12 AM
To: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Biju Das <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; Tom Rix <[email protected]>
Subject: [PATCH] usb: host: USB_XHCI_RZV2M depends on USB_GADGET
A rand config causes this link error
ld: drivers/usb/host/xhci-rzv2m.o: in function `xhci_rzv2m_init_quirk':
xhci-rzv2m.c:(.text+0x13): undefined reference to `rzv2m_usb3drd_reset'
xhci_rzv2m_init_quirk build is controlled by USB_XHCI_RZV2M rzv2m_usb3drd_reset build is controlled by USB_RZV2M_USB3DRD
USE_XHCI_RZV2M does select USB_RZV2M_USB3DRD, but USB_RZV2M_USB3DRD depends on USB_GADGET, so now does USE_XHCI_RZV2M.
Signed-off-by Tom Rix <[email protected]>
---
 drivers/usb/host/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/host/Kconfig index renamed from drivers/usb/host/Kconfig +0 -0
2b80ce9587c1..2dd9e95a5b86 100644
drivers/usb/host/Kconfig +1 -1
@@ -100,6 +100,7 @@ config USB_XHCI_RZV2M
 	tristate "xHCI support for Renesas RZ/V2M SoC"
 	depends on USB_XHCI_PLATFORM
 	depends on ARCH_R9A09G011 || COMPILE_TEST
+	depends on USB_GADGET
 	select USB_RZV2M_USB3DRD
 	help
 	  Say 'Y' to enable the support for the xHCI host controller
--
2.27.0

Tom Rix

author

2023-02-05 14:27 UTC #2 lore raw

Quoted 8 lines · Biju Das

Hi Tom,
Thanks for the patch.
Arnd send a patch for refactoring the USB_XHCI_RZV2M KConfig dependencies related to USB_GADGET on [1] and is in usb-next. Do you see this issue after applying[1]?
[1] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=ec5499d338ece9db9b7590649d3cfcc4d7f9603d

From reviewing, it will likely work.

Tom

Quoted 42 lines

Cheers,
Biju
Quoted 39 lines
-----Original Message-----
From: Tom Rix <[email protected]>
Sent: Sunday, February 5, 2023 2:12 AM
To: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Biju Das <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; Tom Rix <[email protected]>
Subject: [PATCH] usb: host: USB_XHCI_RZV2M depends on USB_GADGET
A rand config causes this link error
ld: drivers/usb/host/xhci-rzv2m.o: in function `xhci_rzv2m_init_quirk':
xhci-rzv2m.c:(.text+0x13): undefined reference to `rzv2m_usb3drd_reset'
xhci_rzv2m_init_quirk build is controlled by USB_XHCI_RZV2M rzv2m_usb3drd_reset build is controlled by USB_RZV2M_USB3DRD
USE_XHCI_RZV2M does select USB_RZV2M_USB3DRD, but USB_RZV2M_USB3DRD depends on USB_GADGET, so now does USE_XHCI_RZV2M.
Signed-off-by Tom Rix <[email protected]>
---
  drivers/usb/host/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/usb/host/Kconfig index renamed from drivers/usb/host/Kconfig +0 -0
2b80ce9587c1..2dd9e95a5b86 100644
drivers/usb/host/Kconfig +1 -1
@@ -100,6 +100,7 @@ config USB_XHCI_RZV2M
  	tristate "xHCI support for Renesas RZ/V2M SoC"
  	depends on USB_XHCI_PLATFORM
  	depends on ARCH_R9A09G011 || COMPILE_TEST
+	depends on USB_GADGET
  	select USB_RZV2M_USB3DRD
  	help
  	  Say 'Y' to enable the support for the xHCI host controller
--
2.27.0