Bluetooth: btrtl: Add support for RTL8852BS
PATCH RESEND 1/1 Bluetooth: btrtl: Add support for RTL8852BS
Add the support for RTL8852BS BT controller on UART interface. The necessary firmware file will be submitted to linux-firmware.
--- drivers/bluetooth/btrtl.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/bluetooth/btrtl.c +10 -0
@@ -198,6 +198,14 @@ static const struct id_table ic_id_table[] = { .fw_name = "rtl_bt/rtl8852bu_fw.bin", .cfg_name = "rtl_bt/rtl8852bu_config" }, +/* 8852B with UART interface */ + { IC_INFO(RTL_ROM_LMP_8852A, 0xb, 0xb, HCI_UART), + .config_needed = true, + .has_rom_version = true, + .has_msft_ext = true, + .fw_name = "rtl_bt/rtl8852bs_fw.bin", + .cfg_name = "rtl_bt/rtl8852bs_config" }, + /* 8852C */ { IC_INFO(RTL_ROM_LMP_8852A, 0xc, 0xc, HCI_USB), .config_needed = false,
@@ -965,5 +973,7 @@ MODULE_FIRMWARE("rtl_bt/rtl8852au_fw.bin");MODULE_FIRMWARE ("rtl_bt/rtl8852au_config.bin" );MODULE_FIRMWARE ("rtl_bt/rtl8852bu_fw.bin" );MODULE_FIRMWARE ("rtl_bt/rtl8852bu_config.bin" ); +MODULE_FIRMWARE ("rtl_bt/rtl8852bs_fw.bin" ); +MODULE_FIRMWARE ("rtl_bt/rtl8852bs_config.bin" );MODULE_FIRMWARE ("rtl_bt/rtl8852cu_fw.bin" );MODULE_FIRMWARE ("rtl_bt/rtl8852cu_config.bin" );
Signature · 1 line
2.29.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=719009
---Test result---
Test Summary:
CheckPatch PASS 0.98 seconds GitLint PASS 0.37 seconds SubjectPrefix PASS 0.11 seconds BuildKernel PASS 31.72 seconds CheckAllWarning PASS 34.55 seconds CheckSparse WARNING 38.58 seconds CheckSmatch WARNING 107.40 seconds BuildKernel32 PASS 30.13 seconds TestRunnerSetup PASS 434.48 seconds TestRunner_l2cap-tester PASS 16.45 seconds TestRunner_iso-tester PASS 16.78 seconds TestRunner_bnep-tester PASS 5.42 seconds TestRunner_mgmt-tester PASS 109.76 seconds TestRunner_rfcomm-tester PASS 8.72 seconds TestRunner_sco-tester PASS 8.08 seconds TestRunner_ioctl-tester PASS 9.43 seconds TestRunner_mesh-tester PASS 6.93 seconds TestRunner_smp-tester PASS 7.90 seconds TestRunner_userchan-tester PASS 5.72 seconds IncrementalBuild PASS 28.52 seconds
Details
##############################
Test: CheckSparse - WARNING
Desc: Run sparse tool with linux kernel
Output:drivers/bluetooth/btrtl.c: note: in included file:drivers/bluetooth/btrtl.h:47:45: warning: array of flexible structures
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:drivers/bluetooth/btrtl.c: note: in included file:drivers/bluetooth/btrtl.h:47:45: warning: array of flexible structures
---
Regards,
Linux Bluetooth
Dear Victor,
Thank you for your patch.
Am 06.02.23 um 07:33 schrieb Victor Hassan:
Quoted 14 lines
Add the support for RTL8852BS BT controller on UART interface. The necessary firmware file will be submitted to linux-firmware.
Signed-off-by Victor Hassan <[email protected]>--- drivers/bluetooth/btrtl.c | 10 ++++++++++ 1 file changed, 10 insertions(+)drivers/bluetooth/btrtl.c +0
-0@@ -198,6 +198,14 @@ static const struct id_table ic_id_table[] = { .fw_name = "rtl_bt/rtl8852bu_fw.bin",
drivers/bluetooth/btrtl.c static const struct id_table ic_id_table[] = { · line 208
Quoted 10 lines
drivers/bluetooth/btrtl.c +8
-0.cfg_name = "rtl_bt/rtl8852bu_config" }, +/* 8852B with UART interface */ + { IC_INFO(RTL_ROM_LMP_8852A, 0xb, 0xb, HCI_UART), + .config_needed = true, + .has_rom_version = true, + .has_msft_ext = true, + .fw_name = "rtl_bt/rtl8852bs_fw.bin", + .cfg_name = "rtl_bt/rtl8852bs_config" }, +
I’d sort *bs* before *bu*.
drivers/bluetooth/btrtl.c MODULE_FIRMWARE("rtl_bt/rtl8852au_fw.bin"); · line 979
Quoted 11 lines
drivers/bluetooth/btrtl.c +2
-0/* 8852C */ { IC_INFO(RTL_ROM_LMP_8852A, 0xc, 0xc, HCI_USB), .config_needed = false,@@ -965,5 +973,7 @@ MODULE_FIRMWARE("rtl_bt/rtl8852au_fw.bin");MODULE_FIRMWARE ("rtl_bt/rtl8852au_config.bin" );MODULE_FIRMWARE ("rtl_bt/rtl8852bu_fw.bin" );MODULE_FIRMWARE ("rtl_bt/rtl8852bu_config.bin" ); +MODULE_FIRMWARE ("rtl_bt/rtl8852bs_fw.bin" ); +MODULE_FIRMWARE ("rtl_bt/rtl8852bs_config.bin" );MODULE_FIRMWARE ("rtl_bt/rtl8852cu_fw.bin" );MODULE_FIRMWARE ("rtl_bt/rtl8852cu_config.bin" );
Ditto.
Kind regards,
Paul
Dear Paul:
Thank you for your advises. I had send PATCH-v2 to fix it. Can you
give me more advises?
Quoted 50 lines · Paul Menzel
Dear Victor,
Thank you for your patch.
Am 06.02.23 um 07:33 schrieb Victor Hassan:
Quoted 13 lines
Add the support for RTL8852BS BT controller on UART interface. The necessary firmware file will be submitted to linux-firmware.
Signed-off-by Victor Hassan <[email protected]>---
drivers/bluetooth/btrtl.c| 10 ++++++++++1 file changed, 10 insertions(+)drivers/bluetooth/btrtl.c +0
-0drivers/bluetooth/btrtl.c static const struct id_table ic_id_table[] = { · line 207
Quoted 10 lines
drivers/bluetooth/btrtl.c +8
-0@@ -198,6 +198,14 @@ static const struct id_table ic_id_table[] = { .fw_name = "rtl_bt/rtl8852bu_fw.bin", .cfg_name = "rtl_bt/rtl8852bu_config" }, + /* 8852B with UART interface */ + { IC_INFO(RTL_ROM_LMP_8852A, 0xb, 0xb, HCI_UART), + .config_needed = true, + .has_rom_version = true, + .has_msft_ext = true, + .fw_name = "rtl_bt/rtl8852bs_fw.bin", + .cfg_name = "rtl_bt/rtl8852bs_config" }, +I’d sort *bs* before *bu*.
drivers/bluetooth/btrtl.c MODULE_FIRMWARE("rtl_bt/rtl8852au_fw.bin"); · line 979
Quoted 11 lines
drivers/bluetooth/btrtl.c +2
-0/* 8852C */ { IC_INFO(RTL_ROM_LMP_8852A, 0xc, 0xc, HCI_USB), .config_needed = false,@@ -965,5 +973,7 @@ MODULE_FIRMWARE("rtl_bt/rtl8852au_fw.bin"); MODULE_FIRMWARE("rtl_bt/rtl8852au_config.bin"); MODULE_FIRMWARE("rtl_bt/rtl8852bu_fw.bin"); MODULE_FIRMWARE("rtl_bt/rtl8852bu_config.bin"); +MODULE_FIRMWARE ("rtl_bt/rtl8852bs_fw.bin" ); +MODULE_FIRMWARE ("rtl_bt/rtl8852bs_config.bin" ); MODULE_FIRMWARE("rtl_bt/rtl8852cu_fw.bin"); MODULE_FIRMWARE("rtl_bt/rtl8852cu_config.bin");Ditto.
Kind regards,
Paul