Skip to contentSkip to conversation

KVM: arm64: Fix non-kerneldoc comments

PATCH Applied Marc Zyngier 2 participants 2 messages Feb 7, 2023 – Feb 8, 2023

Subsystems (3)
lore
Share & tools
lore

Marc Zyngier

author maintainer
#0 lore raw

PATCH 1/1 KVM: arm64: Fix non-kerneldoc comments

The robots amongts us have started spitting out irritating emails about random errors such as:

<quote>
arch/arm64/kvm/arm.c:2207: warning: expecting prototype for Initialize Hyp(). Prototype was for kvm_arm_init() instead
</quote>

which makes little sense until you finally grok what they are on about:
comments that look like a kerneldoc, but that aren't.

Let's address this before I get even more irritated... ;-)

---
 arch/arm64/kvm/arm.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
arch/arm64/kvm/arm.c +2 -6
index 9c5573bc4614..6b59d89811be 100644
@@ -1909,9 +1909,7 @@ static int kvm_hyp_init_protection(u32 hyp_va_bits)
 	return 0;
 }
 
-/**
- * Inits Hyp-mode on all online CPUs
- */
+/* Inits Hyp-mode on all online CPUs */
 static int init_hyp_mode(void)
 {
 	u32 hyp_va_bits;
@@ -2187,9 +2185,7 @@ void kvm_arch_irq_bypass_start(struct irq_bypass_consumer *cons)
 	kvm_arm_resume_guest(irqfd->kvm);
 }
 
-/**
- * Initialize Hyp-mode and memory mappings on all CPUs.
- */
+/* Initialize Hyp-mode and memory mappings on all CPUs */
 int kvm_arch_init(void *opaque)
 {
 	int err;
Signature · 1 line
2.34.1
Applied
#1 lore raw
Quoted 9 lines · Marc Zyngier

The robots amongts us have started spitting out irritating emails about random errors such as:

<quote>
arch/arm64/kvm/arm.c:2207: warning: expecting prototype for Initialize Hyp(). Prototype was for kvm_arm_init() instead
</quote>

[...]

Applied to kvmarm/next, thanks!

[1/1] KVM: arm64: Fix non-kerneldoc comments

      https://git.kernel.org/kvmarm/kvmarm/c/67d953d4d7be

--
Best,
Oliver