DPDK Coverity issue 381631, 381646
v2 cover DPDK Coverity issue 381631, 381646
v2: Split code unrelated to coverity fix in separate commit.
v1: Upstream fix to 23.03 for potential issue of dereferencing a pointer before null check.
Hernan Vargas (2):
baseband/acc: fix check after deref and dead code baseband/acc: add check for empty queue
drivers/baseband/acc/rte_acc100_pmd.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
Signature · 1 line
2.37.1
PATCH v2 1/2 baseband/acc: fix check after deref and dead code
Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null.
Coverity issue: 381646, 381631
--- drivers/baseband/acc/rte_acc100_pmd.c | 2 -- 1 file changed, 2 deletions(-)
drivers/baseband/acc/rte_acc100_pmd.c +0 -2
@@ -4106,8 +4106,6 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data,int ret, cbm;struct rte_bbdev_enc_op *op; -if (q ==NULL ) -return 0 ;#ifdef RTE_LIBRTE_BBDEV_DEBUG if (unlikely (ops ==0 ))return 0 ;
Signature · 1 line
2.37.1
Re: [PATCH v2 1/2] baseband/acc: fix check after deref and dead code
Quoted 17 lines · Hernan Vargas
Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null.
Coverity issue: 381646, 381631
Fixes 989dec301a9 ("baseband/acc100: add ring companion address")Signed-off-by Hernan Vargas <[email protected]>--- drivers/baseband/acc/rte_acc100_pmd.c | 2 -- 1 file changed, 2 deletions(-)drivers/baseband/acc/rte_acc100_pmd.c +0
-0
drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, · line 4111
Quoted 8 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-2@@ -4106,8 +4106,6 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data,int ret, cbm;struct rte_bbdev_enc_op *op; -if (q ==NULL ) -return 0 ;#ifdef RTE_LIBRTE_BBDEV_DEBUG if (unlikely (ops ==0 ))return 0 ;
Thanks,
Maxime
PATCH v2 2/2 baseband/acc: add check for empty queue
In reply to Hernan VargasAdd optimization to return early if there are no available descriptors in ring to dequeue.
--- drivers/baseband/acc/rte_acc100_pmd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/baseband/acc/rte_acc100_pmd.c +2 -3
@@ -4106,10 +4106,9 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data,int ret, cbm;struct rte_bbdev_enc_op *op; -#ifdef RTE_LIBRTE_BBDEV_DEBUG -if (unlikely (ops ==0 )) +if (avail ==0 )return 0 ; -#endif + op =acc_op_tail (q,0 );if (unlikely (ops ==NULL || op ==NULL ))return 0 ;
Signature · 1 line
2.37.1
Re: [PATCH v2 2/2] baseband/acc: add check for empty queue
Hi Hernan,
Quoted 13 lines · Hernan Vargas
Add optimization to return early if there are no available descriptors in ring to dequeue.
Signed-off-by Hernan Vargas <[email protected]>--- drivers/baseband/acc/rte_acc100_pmd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/baseband/acc/rte_acc100_pmd.c +0
-0
drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, · line 4111
Quoted 9 lines
drivers/baseband/acc/rte_acc100_pmd.c +2
-3@@ -4106,10 +4106,9 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data,int ret, cbm;struct rte_bbdev_enc_op *op; -#ifdef RTE_LIBRTE_BBDEV_DEBUG -if (unlikely (ops ==0 )) +if (avail ==0 )return 0 ; -#endif +
Again, this is doing more than advertised.
The patch intent is about returning early if no available descriptors, but here you also remove some debug checks.
At least please mention in in the commit message & title.
drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, · line 4114
Quoted 3 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-0op =acc_op_tail (q,0 );if (unlikely (ops ==NULL || op ==NULL ))return 0 ;
Thanks,
Maxime