Skip to contentSkip to conversation

staging: rtl8192e: Use BIT() instead of << for bit field MSR_LINK_MASK

PATCH New Philipp Hortmann 1 participant 1 message Feb 8, 2023 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: rtl8192e: Use BIT() instead of << for bit field MSR_LINK_MASK

Use commonly used BIT() macro to define MSR_LINK_MASK. Equation is not accepted by checkpatch because of missing spaces. Therefore line needs to change anyhow.

---
V1->V2: Changed patch, title and description
Calculate MSR_LINK_MASK ((1<<0)|(1<<1)) = 3 is not wanted for bit fields
Old patch name: Calculate definition of MSR_LINK_MASK

---
 drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h +1 -1
index 8b8a870fcbbd..99640c4779f7 100644
@@ -170,7 +170,7 @@ enum _RTL8192PCI_HW {
 #define	BW_OPMODE_20MHZ			BIT2
 	IC_VERRSION		= 0x301,
 	MSR			= 0x303,
-#define MSR_LINK_MASK      ((1<<0)|(1<<1))
+#define MSR_LINK_MASK		(BIT(1) | BIT(0))
 #define MSR_LINK_MANAGED   2
 #define MSR_LINK_ADHOC     1
 #define MSR_LINK_MASTER    3
Signature · 1 line
2.39.1