Skip to contentSkip to conversation

selftests/bpf: Fix out-of-srctree build

PATCH Applied Ilya Leoshkevich 2 participants 2 messages Feb 8, 2023 – Feb 13, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/bpf: Fix out-of-srctree build

Building eBPF selftests out of srctree fails with:

make: *** No rule to make target '/linux-build//ima_setup.sh', needed by 'ima_setup.sh'. Stop.

The culprit is the rule that defines convenient shorthands like "make test_progs", which builds $(OUTPUT)/test_progs. These shorthands make sense only for binaries that are built though; scripts that live in the source tree do not end up in $(OUTPUT).

Therefore drop $(TEST_PROGS) and $(TEST_PROGS_EXTENDED) from the rule.

The issue exists for a while, but it became a problem only after commit d68ae4982cb7 ("selftests/bpf: Install all required files to run selftests"), which added dependencies on these scripts.

Fixes 03dcb78460c2 ("selftests/bpf: Add simple per-test targets to Makefile")
---
 tools/testing/selftests/bpf/Makefile | 2 --
 1 file changed, 2 deletions(-)
tools/testing/selftests/bpf/Makefile +0 -2
index b2eb3201b85a..5182c0044dbb 100644
@@ -151,8 +151,6 @@ endif
 # NOTE: Semicolon at the end is critical to override lib.mk's default static
 # rule for binaries.
 $(notdir $(TEST_GEN_PROGS)						\
-	 $(TEST_PROGS)							\
-	 $(TEST_PROGS_EXTENDED)						\
 	 $(TEST_GEN_PROGS_EXTENDED)					\
 	 $(TEST_CUSTOM_PROGS)): %: $(OUTPUT)/% ;
 
Signature · 1 line
2.39.1
#1 lore raw
This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <[email protected]>:

Quoted 10 lines · On Thu, 9 Feb 2023 00:12:11 +0100 you wrote:

Building eBPF selftests out of srctree fails with:

make: *** No rule to make target '/linux-build//ima_setup.sh', needed by 'ima_setup.sh'. Stop.

The culprit is the rule that defines convenient shorthands like "make test_progs", which builds $(OUTPUT)/test_progs. These shorthands make sense only for binaries that are built though; scripts that live in the source tree do not end up in $(OUTPUT).

[...]

Here is the summary with links:
- [bpf-next] selftests/bpf: Fix out-of-srctree build

    https://git.kernel.org/bpf/bpf-next/c/0b0757244754

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html