Waitboost drm syncobj waits
Subsystems (5)
v2 cover Waitboost drm syncobj waits
From: Tvrtko Ursulin <[email protected]>
In i915 we have this concept of "wait boosting" where we give a priority boost for instance to fences which are actively waited upon from userspace. This has it's pros and cons and can certainly be discussed at lenght. However fact is some workloads really like it.
Problem is that with the arrival of drm syncobj and a new userspace waiting entry point it added, the waitboost mechanism was bypassed. Hence I cooked up this mini series really (really) quickly to see if some discussion can be had.
It adds a concept of "wait count" to dma fence, which is incremented for every explicit dma_fence_enable_sw_signaling and dma_fence_add_wait_callback (like dma_fence_add_callback but from explicit/userspace wait paths).
Individual drivers can then inspect this via dma_fence_wait_count() and decide to wait boost the waits on such fences.
Again, quickly put together and smoke tested only - no guarantees whatsoever and I will rely on interested parties to test and report if it even works or how well.
v2:
* Small fixups based on CI feedback:
* Handle decrement correctly for already signalled case while adding callback.
* Remove i915 assert which was making sure struct i915_request does not grow.
* Split out the i915 patch into three separate functional changes.
Tvrtko Ursulin (5):
dma-fence: Track explicit waiters drm/syncobj: Mark syncobj waits as external waiters drm/i915: Waitboost external waits drm/i915: Mark waits as explicit
drm/i915: Wait boost requests waited upon by others
drivers/dma-buf/dma-fence.c | 102 ++++++++++++++++------ drivers/gpu/drm/drm_syncobj.c | 6 +- drivers/gpu/drm/i915/gt/intel_engine_pm.c | 1 - drivers/gpu/drm/i915/i915_request.c | 13 ++- include/linux/dma-fence.h | 14 +++ 5 files changed, 101 insertions(+), 35 deletions(-)
Signature · 1 line
2.34.1
RFC v2 1/5 dma-fence: Track explicit waiters
From: Tvrtko Ursulin <[email protected]>
Track how many callers are explicity waiting on a fence to signal and allow querying that via new dma_fence_wait_count() API.
This provides infrastructure on top of which generic "waitboost" concepts can be implemented by individual drivers. Wait-boosting is any reactive activity, such as raising the GPU clocks, which happens while there are active external waiters.
--- drivers/dma-buf/dma-fence.c | 102 ++++++++++++++++------ drivers/gpu/drm/i915/gt/intel_engine_pm.c | 1 - include/linux/dma-fence.h | 14 +++ 3 files changed, 88 insertions(+), 29 deletions(-)
drivers/dma-buf/dma-fence.c +74 -28
@@ -344,6 +344,24 @@ void __dma_fence_might_wait(void) }#endif +static void incr_wait_count (struct dma_fence *fence,struct dma_fence_cb *cb) +{ +lockdep_assert_held (fence->lock); + +__set_bit (DMA_FENCE_CB_FLAG_WAITCOUNT_BIT , &cb->flags); + fence->waitcount++; +WARN_ON_ONCE (!fence->waitcount); +} + +static void decr_wait_count (struct dma_fence *fence,struct dma_fence_cb *cb) +{ +lockdep_assert_held (fence->lock); + +if (__test_and_clear_bit (DMA_FENCE_CB_FLAG_WAITCOUNT_BIT , &cb->flags)) { +WARN_ON_ONCE (!fence->waitcount); + fence->waitcount--; + } +}/** * dma_fence_signal_timestamp_locked - signal completion of a fence
@@ -384,6 +402,7 @@ int dma_fence_signal_timestamp_locked(struct dma_fence *fence,list_for_each_entry_safe (cur, tmp, &cb_list, node) {INIT_LIST_HEAD (&cur->node); +decr_wait_count (fence, cur); cur->func (fence, cur); }
@@ -612,35 +631,15 @@ void dma_fence_enable_sw_signaling(struct dma_fence *fence)unsigned long flags;spin_lock_irqsave (fence->lock, flags); + fence->waitcount++; +WARN_ON_ONCE (!fence->waitcount);__dma_fence_enable_signaling (fence);spin_unlock_irqrestore (fence->lock, flags); }EXPORT_SYMBOL (dma_fence_enable_sw_signaling); -/** -* dma_fence_add_callback - add a callback to be called when the fence -* is signaled -* @fence: the fence to wait on -* @cb: the callback to register -* @func: the function to call -* -* Add a software callback to the fence. The caller should keep a reference to -* the fence. -* -* @cb will be initialized by dma_fence_add_callback(), no initialization -* by the caller is required. Any number of callbacks can be registered -* to a fence, but a callback can only be registered to one fence at a time. -* -* If fence is already signaled, this function will return -ENOENT (and -* *not* call the callback). -* -* Note that the callback can be called from an atomic context or irq context. -* -* Returns 0 in case of success, -ENOENT if the fence is already signaled -* and -EINVAL in case of error. -*/ -int dma_fence_add_callback (struct dma_fence *fence,struct dma_fence_cb *cb, -dma_fence_func_t func) +static int add_callback (struct dma_fence *fence,struct dma_fence_cb *cb, +dma_fence_func_t func,bool wait) {unsigned long flags;int ret =0 ;
@@ -655,10 +654,15 @@ int dma_fence_add_callback(struct dma_fence *fence, struct dma_fence_cb *cb,spin_lock_irqsave (fence->lock, flags); +if (wait) +incr_wait_count (fence, cb); +if (__dma_fence_enable_signaling (fence)) { cb->func = func;list_add_tail (&cb->node, &fence->cb_list); }else { +if (test_bit (DMA_FENCE_CB_FLAG_WAITCOUNT_BIT , &cb->flags)) +decr_wait_count (fence, cb);INIT_LIST_HEAD (&cb->node); ret = -ENOENT ; }
@@ -667,8 +671,44 @@ int dma_fence_add_callback(struct dma_fence *fence, struct dma_fence_cb *cb,return ret; } + +/** +* dma_fence_add_callback - add a callback to be called when the fence +* is signaled +* @fence: the fence to wait on +* @cb: the callback to register +* @func: the function to call +* +* Add a software callback to the fence. The caller should keep a reference to +* the fence. +* +* @cb will be initialized by dma_fence_add_callback(), no initialization +* by the caller is required. Any number of callbacks can be registered +* to a fence, but a callback can only be registered to one fence at a time. +* +* If fence is already signaled, this function will return -ENOENT (and +* *not* call the callback). +* +* Note that the callback can be called from an atomic context or irq context. +* +* Returns 0 in case of success, -ENOENT if the fence is already signaled +* and -EINVAL in case of error. +*/ +int dma_fence_add_callback (struct dma_fence *fence,struct dma_fence_cb *cb, +dma_fence_func_t func) +{ +return add_callback (fence, cb, func, false); +}EXPORT_SYMBOL (dma_fence_add_callback); +int dma_fence_add_wait_callback (struct dma_fence *fence, +struct dma_fence_cb *cb, +dma_fence_func_t func) +{ +return add_callback (fence, cb, func, true); +} +EXPORT_SYMBOL (dma_fence_add_wait_callback); +/** * dma_fence_get_status - returns the status upon completion * @fence: the dma_fence to query
@@ -721,8 +761,10 @@ dma_fence_remove_callback(struct dma_fence *fence, struct dma_fence_cb *cb)spin_lock_irqsave (fence->lock, flags); ret = !list_empty (&cb->node); -if (ret) +if (ret) { +decr_wait_count (fence, cb);list_del_init (&cb->node); + }spin_unlock_irqrestore (fence->lock, flags);
@@ -780,6 +822,7 @@ dma_fence_default_wait(struct dma_fence *fence, bool intr, signed long timeout) cb.base.func = dma_fence_default_wait_cb; cb.task = current; +incr_wait_count (fence, &cb.base);list_add (&cb.base.node, &fence->cb_list);while (!test_bit (DMA_FENCE_FLAG_SIGNALED_BIT , &fence->flags) && ret >0 ) {
@@ -796,8 +839,10 @@ dma_fence_default_wait(struct dma_fence *fence, bool intr, signed long timeout) ret = -ERESTARTSYS ; } -if (!list_empty (&cb.base.node)) +if (!list_empty (&cb.base.node)) { +decr_wait_count (fence, &cb.base);list_del (&cb.base.node); + }__set_current_state (TASK_RUNNING ); out:
@@ -875,8 +920,8 @@ dma_fence_wait_any_timeout(struct dma_fence **fences, uint32_t count,struct dma_fence *fence = fences[i]; cb[i].task = current; -if (dma_fence_add_callback (fence, &cb[i].base, - dma_fence_default_wait_cb)) { +if (dma_fence_add_wait_callback (fence, &cb[i].base, + dma_fence_default_wait_cb)) {/* This fence is already signaled */ if (idx) *idx = i;
@@ -957,6 +1002,7 @@ dma_fence_init(struct dma_fence *fence, const struct dma_fence_ops *ops, fence->context = context; fence->seqno = seqno; fence->flags =0UL ; + fence->waitcount =0 ; fence->error =0 ;trace_dma_fence_init (fence);
drivers/gpu/drm/i915/gt/intel_engine_pm.c +0 -1
@@ -218,7 +218,6 @@ static bool switch_to_kernel_context(struct intel_engine_cs *engine)* until the background request retirement running every * second or two). */ -BUILD_BUG_ON (sizeof (rq->duration) >sizeof (rq->submitq));dma_fence_add_callback (&rq->fence, &rq->duration.cb, duration); rq->duration.emitted =ktime_get (); }
include/linux/dma-fence.h +14 -0
@@ -92,6 +92,7 @@ struct dma_fence {u64 seqno;unsigned long flags;struct kref refcount; +unsigned int waitcount;int error; };
@@ -116,6 +117,11 @@ typedef void (*dma_fence_func_t)(struct dma_fence *fence,struct dma_fence_cb {struct list_head node;dma_fence_func_t func; +unsigned long flags; +}; + +enum dma_fence_cb_flag_bits { +DMA_FENCE_CB_FLAG_WAITCOUNT_BIT , };/**
@@ -377,6 +383,9 @@ signed long dma_fence_default_wait(struct dma_fence *fence,int dma_fence_add_callback (struct dma_fence *fence,struct dma_fence_cb *cb,dma_fence_func_t func); +int dma_fence_add_wait_callback (struct dma_fence *fence, +struct dma_fence_cb *cb, +dma_fence_func_t func);bool dma_fence_remove_callback (struct dma_fence *fence,struct dma_fence_cb *cb);void dma_fence_enable_sw_signaling (struct dma_fence *fence);
@@ -528,6 +537,11 @@ static inline int dma_fence_get_status_locked(struct dma_fence *fence)int dma_fence_get_status (struct dma_fence *fence); +static inline unsigned int dma_fence_wait_count (struct dma_fence *fence) +{ +return fence->waitcount; +} +/** * dma_fence_set_error - flag an error condition on the fence * @fence: the dma_fence
Signature · 1 line
2.34.1
RFC v2 2/5 drm/syncobj: Mark syncobj waits as external waiters
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Use the previously added dma-fence tracking of explicit waiters.
--- drivers/gpu/drm/drm_syncobj.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_syncobj.c +3 -3
@@ -1065,9 +1065,9 @@ static signed long drm_syncobj_array_wait_timeout(struct drm_syncobj **syncobjs,if ((flags &DRM_SYNCOBJ_WAIT_FLAGS_WAIT_AVAILABLE ) ||dma_fence_is_signaled (fence) || (!entries[i].fence_cb.func && -dma_fence_add_callback (fence, - &entries[i].fence_cb, - syncobj_wait_fence_func))) { +dma_fence_add_wait_callback (fence, + &entries[i].fence_cb, + syncobj_wait_fence_func))) {/* The fence has been signaled */ if (flags &DRM_SYNCOBJ_WAIT_FLAGS_WAIT_ALL ) { signaled_count++;
Signature · 1 line
2.34.1
RFC v2 3/5 drm/i915: Waitboost external waits
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Userspace waits coming via the drm_syncobj route have so far been bypassing the waitboost mechanism.
Use the previously added dma-fence wait tracking API and apply the same waitboosting logic which applies to other entry points.
This should fix the perfomance regressions experience by clvk and similar userspace which relies on drm_syncobj.
--- drivers/gpu/drm/i915/i915_request.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_request.c +6 -1
@@ -94,7 +94,12 @@ static bool i915_fence_signaled(struct dma_fence *fence)static bool i915_fence_enable_signaling (struct dma_fence *fence) { -return i915_request_enable_breadcrumb (to_request (fence)); +struct i915_request *rq =to_request (fence); + +if (dma_fence_wait_count (&rq->fence) && !i915_request_started (rq)) +intel_rps_boost (rq); + +return i915_request_enable_breadcrumb (rq); } static signed long i915_fence_wait(struct dma_fence *fence,
Signature · 1 line
2.34.1
RFC v2 4/5 drm/i915: Mark waits as explicit
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Use the previously added dma-fence API to mark the direct i915 waits as explicit. This has no significant effect apart from following the new pattern.
--- drivers/gpu/drm/i915/i915_request.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_request.c +2 -1
@@ -2046,7 +2046,8 @@ long i915_request_wait_timeout(struct i915_request *rq,intel_rps_boost (rq); wait.tsk = current; -if (dma_fence_add_callback (&rq->fence, &wait.cb, request_wait_wake)) +if (dma_fence_add_wait_callback (&rq->fence, &wait.cb, + request_wait_wake)) goto out;/*
Signature · 1 line
2.34.1
RFC v2 5/5 drm/i915: Wait boost requests waited upon by others
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Use the newly added dma-fence API to apply waitboost not only requests which have been marked with I915_WAIT_PRIORITY by i915, but which may be waited upon by others (such as for instance buffer sharing in multi-GPU scenarios).
--- drivers/gpu/drm/i915/i915_request.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_request.c +2 -1
@@ -2042,7 +2042,8 @@ long i915_request_wait_timeout(struct i915_request *rq,* but at a cost of spending more power processing the workload * (bad for battery). */ -if (flags &I915_WAIT_PRIORITY && !i915_request_started (rq)) +if (((flags &I915_WAIT_PRIORITY ) ||dma_fence_wait_count (&rq->fence)) + && !i915_request_started (rq))intel_rps_boost (rq); wait.tsk = current;
Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Waitboost drm syncobj waits (rev2)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: Waitboost drm syncobj waits (rev2)
URL : https://patchwork.freedesktop.org/series/113846/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for Waitboost drm syncobj waits (rev2)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: Waitboost drm syncobj waits (rev2)
URL : https://patchwork.freedesktop.org/series/113846/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12727 -> Patchwork_113846v2
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_113846v2 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_113846v2, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/index.html
Participating hosts (40 -> 38)
------------------------------
Missing (2): bat-atsm-1 fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_113846v2:
### IGT changes ###
#### Possible regressions ####
* igt@gem_busy@busy@all-engines:
- fi-ivb-3770: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-ivb-3770/igt@gem_busy@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-ivb-3770/igt@gem_busy@[email protected]
* igt@i915_module_load@load:
- fi-ilk-650: [PASS][3] -> [ABORT][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-ilk-650/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-ilk-650/igt@[email protected]
- fi-blb-e6850: [PASS][5] -> [ABORT][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-blb-e6850/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-blb-e6850/igt@[email protected]
- fi-bsw-n3050: [PASS][7] -> [ABORT][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-bsw-n3050/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-bsw-n3050/igt@[email protected]
- fi-rkl-11600: [PASS][9] -> [ABORT][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-rkl-11600/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-rkl-11600/igt@[email protected]
- fi-skl-6600u: [PASS][11] -> [ABORT][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-skl-6600u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-skl-6600u/igt@[email protected]
- fi-apl-guc: [PASS][13] -> [ABORT][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-apl-guc/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-apl-guc/igt@[email protected]
- bat-dg1-5: [PASS][15] -> [ABORT][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/bat-dg1-5/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/bat-dg1-5/igt@[email protected]
- fi-pnv-d510: [PASS][17] -> [ABORT][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-pnv-d510/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-pnv-d510/igt@[email protected]
- fi-glk-j4005: [PASS][19] -> [ABORT][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-glk-j4005/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-glk-j4005/igt@[email protected]
- fi-skl-guc: [PASS][21] -> [ABORT][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-skl-guc/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-skl-guc/igt@[email protected]
- bat-dg1-6: [PASS][23] -> [ABORT][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/bat-dg1-6/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/bat-dg1-6/igt@[email protected]
- fi-kbl-7567u: [PASS][25] -> [ABORT][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-kbl-7567u/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-kbl-7567u/igt@[email protected]
- fi-cfl-8700k: [PASS][27] -> [ABORT][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-cfl-8700k/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-cfl-8700k/igt@[email protected]
- fi-elk-e7500: [PASS][29] -> [ABORT][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-elk-e7500/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-elk-e7500/igt@[email protected]
- fi-bsw-nick: [PASS][31] -> [ABORT][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-bsw-nick/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-bsw-nick/igt@[email protected]
- fi-tgl-1115g4: [PASS][33] -> [ABORT][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-tgl-1115g4/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-tgl-1115g4/igt@[email protected]
- fi-kbl-x1275: [PASS][35] -> [ABORT][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-kbl-x1275/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-kbl-x1275/igt@[email protected]
- fi-hsw-4770: [PASS][37] -> [ABORT][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-hsw-4770/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-hsw-4770/igt@[email protected]
- fi-cfl-8109u: [PASS][39] -> [ABORT][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-cfl-8109u/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-cfl-8109u/igt@[email protected]
- fi-kbl-guc: [PASS][41] -> [ABORT][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-kbl-guc/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-kbl-guc/igt@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_module_load@load:
- {bat-jsl-1}: [PASS][43] -> [ABORT][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/bat-jsl-1/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/bat-jsl-1/igt@[email protected]
- {bat-rpls-1}: [PASS][45] -> [ABORT][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/bat-rpls-1/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/bat-rpls-1/igt@[email protected]
- {bat-adlp-6}: [PASS][47] -> [ABORT][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/bat-adlp-6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/bat-adlp-6/igt@[email protected]
- {bat-adls-5}: [PASS][49] -> [ABORT][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/bat-adls-5/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/bat-adls-5/igt@[email protected]
- {bat-dg1-7}: [PASS][51] -> [ABORT][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/bat-dg1-7/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/bat-dg1-7/igt@[email protected]
- {bat-jsl-3}: [PASS][53] -> [ABORT][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/bat-jsl-3/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/bat-jsl-3/igt@[email protected]
- {bat-adlp-9}: [PASS][55] -> [ABORT][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/bat-adlp-9/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/bat-adlp-9/igt@[email protected]
- {bat-dg2-11}: [PASS][57] -> [ABORT][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/bat-dg2-11/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/bat-dg2-11/igt@[email protected]
- {bat-adln-1}: [PASS][59] -> [ABORT][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/bat-adln-1/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/bat-adln-1/igt@[email protected]
- {bat-adlm-1}: [PASS][61] -> [ABORT][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/bat-adlm-1/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/bat-adlm-1/igt@[email protected]
- {bat-rplp-1}: [PASS][63] -> [ABORT][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/bat-rplp-1/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/bat-rplp-1/igt@[email protected]
- {bat-dg2-9}: [PASS][65] -> [ABORT][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/bat-dg2-9/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/bat-dg2-9/igt@[email protected]
- {bat-rpls-2}: [PASS][67] -> [ABORT][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/bat-rpls-2/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/bat-rpls-2/igt@[email protected]
- {bat-dg2-8}: [PASS][69] -> [ABORT][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/bat-dg2-8/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/bat-dg2-8/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_113846v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@load:
- fi-cfl-guc: [PASS][71] -> [ABORT][72] ([i915#8141])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12727/fi-cfl-guc/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/fi-cfl-guc/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#8141]: https://gitlab.freedesktop.org/drm/intel/issues/8141
Build changes
-------------
* Linux: CI_DRM_12727 -> Patchwork_113846v2
CI-20190529: 20190529
CI_DRM_12727: 571111c8567d76c5a5ec4641ba771bb1bdd278fc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7156: d10786443fef434534ec4d08e93db92dfad84c7b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113846v2: 571111c8567d76c5a5ec4641ba771bb1bdd278fc @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
7a08fd7f270f drm/i915: Wait boost requests waited upon by others 8c687c784061 drm/i915: Mark waits as explicit 119d3caa3ca6 drm/i915: Waitboost external waits dfadc3ae295a drm/syncobj: Mark syncobj waits as external waiters 9729003feb78 dma-fence: Track explicit waiters
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113846v2/index.html
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
In i915 we have this concept of "wait boosting" where we give a priority boost for instance to fences which are actively waited upon from userspace. This has it's pros and cons and can certainly be discussed at lenght. However fact is some workloads really like it.
Quoted 7 lines
Problem is that with the arrival of drm syncobj and a new userspace waiting entry point it added, the waitboost mechanism was bypassed. Hence I cooked up this mini series really (really) quickly to see if some discussion can be had.
It adds a concept of "wait count" to dma fence, which is incremented for every explicit
dma_fence_enable_sw_signalinganddma_fence_add_wait_callback(likedma_fence_add_callbackbut from explicit/userspace wait paths).
I was thinking about a similar thing, but in the context of dma_fence (or rather sync_file) fd poll()ing. How does the kernel differentiate between "housekeeping" poll()ers that don't want to trigger boost but simply know when to do cleanup, and waiters who are waiting with some urgency. I think we could use EPOLLPRI for this purpose.
Not sure how that translates to waits via the syncobj. But I think we want to let userspace give some hint about urgent vs housekeeping waits.
Also, on a related topic: https://lwn.net/Articles/868468/
BR,
-R
Quoted 30 lines
Individual drivers can then inspect this via
dma_fence_wait_count()and decide to wait boost the waits on such fences.Again, quickly put together and smoke tested only - no guarantees whatsoever and I will rely on interested parties to test and report if it even works or how well.
v2:
* Small fixups based on CI feedback:
* Handle decrement correctly for already signalled case while adding callback.
* Remove i915 assert which was making sure structi915_requestdoes not grow.
* Split out the i915 patch into three separate functional changes.Tvrtko Ursulin (5):
dma-fence: Track explicit waiters drm/syncobj: Mark syncobj waits as external waiters drm/i915: Waitboost external waits drm/i915: Mark waits as explicit
drm/i915: Wait boost requests waited upon by othersdrivers/dma-buf/dma-fence.c | 102 ++++++++++++++++------ drivers/gpu/drm/drm_syncobj.c | 6 +- drivers/gpu/drm/i915/gt/intel_engine_pm.c | 1 - drivers/gpu/drm/i915/i915_request.c | 13 ++- include/linux/dma-fence.h | 14 +++ 5 files changed, 101 insertions(+), 35 deletions(-)--
2.34.1
Quoted 25 lines · Rob Clark
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
In i915 we have this concept of "wait boosting" where we give a priority boost for instance to fences which are actively waited upon from userspace. This has it's pros and cons and can certainly be discussed at lenght. However fact is some workloads really like it.
Quoted 7 lines
Problem is that with the arrival of drm syncobj and a new userspace waiting entry point it added, the waitboost mechanism was bypassed. Hence I cooked up this mini series really (really) quickly to see if some discussion can be had.
It adds a concept of "wait count" to dma fence, which is incremented for every explicit
dma_fence_enable_sw_signalinganddma_fence_add_wait_callback(likedma_fence_add_callbackbut from explicit/userspace wait paths).I was thinking about a similar thing, but in the context of
dma_fence(or rathersync_file) fd poll()ing. How does the kernel differentiate between "housekeeping" poll()ers that don't want to trigger boost but simply know when to do cleanup, and waiters who are waiting with some urgency. I think we could use EPOLLPRI for this purpose.
Quoted 3 lines
Not sure how that translates to waits via the syncobj. But I think we want to let userspace give some hint about urgent vs housekeeping waits.
So probably the syncobj equiv of this would be to add something along the lines of DRM_SYNCOBJ_WAIT_FLAGS_WAIT_PRI
BR,
-R
Quoted 35 lines
Also, on a related topic: https://lwn.net/Articles/868468/
BR,
-RQuoted 30 lines
Individual drivers can then inspect this via
dma_fence_wait_count()and decide to wait boost the waits on such fences.Again, quickly put together and smoke tested only - no guarantees whatsoever and I will rely on interested parties to test and report if it even works or how well.
v2:
* Small fixups based on CI feedback:
* Handle decrement correctly for already signalled case while adding callback.
* Remove i915 assert which was making sure structi915_requestdoes not grow.
* Split out the i915 patch into three separate functional changes.Tvrtko Ursulin (5):
dma-fence: Track explicit waiters drm/syncobj: Mark syncobj waits as external waiters drm/i915: Waitboost external waits drm/i915: Mark waits as explicit
drm/i915: Wait boost requests waited upon by othersdrivers/dma-buf/dma-fence.c | 102 ++++++++++++++++------ drivers/gpu/drm/drm_syncobj.c | 6 +- drivers/gpu/drm/i915/gt/intel_engine_pm.c | 1 - drivers/gpu/drm/i915/i915_request.c | 13 ++- include/linux/dma-fence.h | 14 +++ 5 files changed, 101 insertions(+), 35 deletions(-)--
2.34.1
Quoted 18 lines · Rob Clark
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
In i915 we have this concept of "wait boosting" where we give a priority boost for instance to fences which are actively waited upon from userspace. This has it's pros and cons and can certainly be discussed at lenght. However fact is some workloads really like it.
Quoted 7 lines
Problem is that with the arrival of drm syncobj and a new userspace waiting entry point it added, the waitboost mechanism was bypassed. Hence I cooked up this mini series really (really) quickly to see if some discussion can be had.
It adds a concept of "wait count" to dma fence, which is incremented for every explicit
dma_fence_enable_sw_signalinganddma_fence_add_wait_callback(likedma_fence_add_callbackbut from explicit/userspace wait paths).
Quoted 5 lines
I was thinking about a similar thing, but in the context of
dma_fence(or rathersync_file) fd poll()ing. How does the kernel differentiate between "housekeeping" poll()ers that don't want to trigger boost but simply know when to do cleanup, and waiters who are waiting with some urgency. I think we could use EPOLLPRI for this purpose.
Sounds plausible to allow distinguishing the two.
I wasn't aware one can set POLLPRI in pollfd.events but it appears it could be allowed:
/* Event types that can be polled for. These bits may be set in `events'
to indicate the interesting event types; they will appear in `revents' to indicate the status of the file descriptor. */
#define POLLIN 0x001 /* There is data to read. */ #define POLLPRI 0x002 /* There is urgent data to read. */ #define POLLOUT 0x004 /* Writing now will not block. */
Quoted 3 lines
Not sure how that translates to waits via the syncobj. But I think we want to let userspace give some hint about urgent vs housekeeping waits.
Probably DRM_SYNCOBJ_WAIT_FLAGS_<something>.
Both look easy additions on top of my series. It would be just a matter of dma_fence_add_callback vs dma_fence_add_wait_callback based on flags, as that's how I called the "explicit userspace wait" one.
It would require userspace changes to make use of it but that is probably okay, or even preferable, since it makes the thing less of a heuristic. What I don't know however is how feasible is to wire it up with say OpenCL, OpenGL or Vulkan, to allow application writers distinguish between house keeping vs performance sensitive waits.
Quoted 1 line
Also, on a related topic: https://lwn.net/Articles/868468/
Right, I missed that one.
One thing to mention is that my motivation here wasn't strictly waits relating to frame presentation but clvk workloads which constantly move between the CPU and GPU. Even outside the compute domain, I think this is a workload characteristic where waitboost in general helps. The concept of deadline could still be used I guess, just setting it for some artificially early value, when the actual time does not exist. But scanning that discussion seems the proposal got bogged down in interactions between mode setting and stuff?
Regards,
Tvrtko
Quoted 42 lines · Tvrtko Ursulin
Quoted 18 lines · Rob Clark
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
In i915 we have this concept of "wait boosting" where we give a priority boost for instance to fences which are actively waited upon from userspace. This has it's pros and cons and can certainly be discussed at lenght. However fact is some workloads really like it.
Quoted 7 lines
Problem is that with the arrival of drm syncobj and a new userspace waiting entry point it added, the waitboost mechanism was bypassed. Hence I cooked up this mini series really (really) quickly to see if some discussion can be had.
It adds a concept of "wait count" to dma fence, which is incremented for every explicit
dma_fence_enable_sw_signalinganddma_fence_add_wait_callback(likedma_fence_add_callbackbut from explicit/userspace wait paths).Quoted 5 lines
I was thinking about a similar thing, but in the context of
dma_fence(or rathersync_file) fd poll()ing. How does the kernel differentiate between "housekeeping" poll()ers that don't want to trigger boost but simply know when to do cleanup, and waiters who are waiting with some urgency. I think we could use EPOLLPRI for this purpose.Sounds plausible to allow distinguishing the two.
I wasn't aware one can set POLLPRI in pollfd.events but it appears it could be allowed:
/* Event types that can be polled for. These bits may be set in `events'
to indicate the interesting event types; they will appear in `revents' to indicate the status of the file descriptor. */#define POLLIN 0x001 /* There is data to read. */ #define POLLPRI 0x002 /* There is urgent data to read. */ #define POLLOUT 0x004 /* Writing now will not block. */Quoted 3 lines
Not sure how that translates to waits via the syncobj. But I think we want to let userspace give some hint about urgent vs housekeeping waits.
Quoted 6 lines
Probably DRM_SYNCOBJ_WAIT_FLAGS_<something>.
Both look easy additions on top of my series. It would be just a matter of
dma_fence_add_callbackvsdma_fence_add_wait_callbackbased on flags, as that's how I called the "explicit userspace wait" one.It would require userspace changes to make use of it but that is probably okay, or even preferable, since it makes the thing less of a heuristic. What I don't know however is how feasible is to wire it up with say OpenCL, OpenGL or Vulkan, to allow application writers distinguish between house keeping vs performance sensitive waits.
I think to start with, we consider API level waits as POLLPRI/DRM_SYNCOBJ_WAIT_PRI until someone types up an extension to give the app control. I guess most housekeeping waits will be within the driver.
(I could see the argument for making "PRI" the default and having a new flag for non-boosting waits.. but POLLPRI is also some sort of precedent)
Quoted 6 lines
Quoted 1 line
Also, on a related topic: https://lwn.net/Articles/868468/
Right, I missed that one.
One thing to mention is that my motivation here wasn't strictly waits relating to frame presentation but clvk workloads which constantly move between the CPU and GPU. Even outside the compute domain, I think this is a workload characteristic where waitboost in general helps. The concept of deadline could still be used I guess, just setting it for some artificially early value, when the actual time does not exist. But scanning that discussion seems the proposal got bogged down in interactions between mode setting and stuff?
Yeah, it isn't _exactly_ the same thing but it is the same class of problem where GPU stalling on something else sends the freq in the wrong direction. Probably we could consider wait-boosting as simply an immediate deadline to unify the two things.
BR,
-R
Quoted 3 lines
Regards,
Tvrtko
Rodrigo Vivi
maintainerQuoted 24 lines · Rob Clark
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
In i915 we have this concept of "wait boosting" where we give a priority boost for instance to fences which are actively waited upon from userspace. This has it's pros and cons and can certainly be discussed at lenght. However fact is some workloads really like it.
Quoted 7 lines
Problem is that with the arrival of drm syncobj and a new userspace waiting entry point it added, the waitboost mechanism was bypassed. Hence I cooked up this mini series really (really) quickly to see if some discussion can be had.
It adds a concept of "wait count" to dma fence, which is incremented for every explicit
dma_fence_enable_sw_signalinganddma_fence_add_wait_callback(likedma_fence_add_callbackbut from explicit/userspace wait paths).I was thinking about a similar thing, but in the context of
dma_fence(or rathersync_file) fd poll()ing. How does the kernel differentiate between "housekeeping" poll()ers that don't want to trigger boost but simply know when to do cleanup, and waiters who are waiting with some urgency. I think we could use EPOLLPRI for this purpose.
Quoted 3 lines
Not sure how that translates to waits via the syncobj. But I think we want to let userspace give some hint about urgent vs housekeeping waits.
Should the hint be on the waits, or should the hints be on the executed context?
In the end we need some way to quickly ramp-up the frequency to avoid the execution bubbles.
waitboost is trying to guess that, but in some cases it guess wrong and waste power.
btw, this is something that other drivers might need:
https://gitlab.freedesktop.org/drm/amd/-/issues/1500#note_825883
Cc: Alex Deucher <[email protected]>
Quoted 36 lines
Also, on a related topic: https://lwn.net/Articles/868468/
BR,
-RQuoted 30 lines
Individual drivers can then inspect this via
dma_fence_wait_count()and decide to wait boost the waits on such fences.Again, quickly put together and smoke tested only - no guarantees whatsoever and I will rely on interested parties to test and report if it even works or how well.
v2:
* Small fixups based on CI feedback:
* Handle decrement correctly for already signalled case while adding callback.
* Remove i915 assert which was making sure structi915_requestdoes not grow.
* Split out the i915 patch into three separate functional changes.Tvrtko Ursulin (5):
dma-fence: Track explicit waiters drm/syncobj: Mark syncobj waits as external waiters drm/i915: Waitboost external waits drm/i915: Mark waits as explicit
drm/i915: Wait boost requests waited upon by othersdrivers/dma-buf/dma-fence.c | 102 ++++++++++++++++------ drivers/gpu/drm/drm_syncobj.c | 6 +- drivers/gpu/drm/i915/gt/intel_engine_pm.c | 1 - drivers/gpu/drm/i915/i915_request.c | 13 ++- include/linux/dma-fence.h | 14 +++ 5 files changed, 101 insertions(+), 35 deletions(-)--
2.34.1
Quoted 26 lines · Rodrigo Vivi
Quoted 24 lines · Rob Clark
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
In i915 we have this concept of "wait boosting" where we give a priority boost for instance to fences which are actively waited upon from userspace. This has it's pros and cons and can certainly be discussed at lenght. However fact is some workloads really like it.
Quoted 7 lines
Problem is that with the arrival of drm syncobj and a new userspace waiting entry point it added, the waitboost mechanism was bypassed. Hence I cooked up this mini series really (really) quickly to see if some discussion can be had.
It adds a concept of "wait count" to dma fence, which is incremented for every explicit
dma_fence_enable_sw_signalinganddma_fence_add_wait_callback(likedma_fence_add_callbackbut from explicit/userspace wait paths).I was thinking about a similar thing, but in the context of
dma_fence(or rathersync_file) fd poll()ing. How does the kernel differentiate between "housekeeping" poll()ers that don't want to trigger boost but simply know when to do cleanup, and waiters who are waiting with some urgency. I think we could use EPOLLPRI for this purpose.
Quoted 6 lines
Quoted 3 lines
Not sure how that translates to waits via the syncobj. But I think we want to let userspace give some hint about urgent vs housekeeping waits.
Should the hint be on the waits, or should the hints be on the executed context?
I think it should be on the wait, because different waits may be for different purposes. Ideally this could be exposed at the app API level, but I guess first step is to expose it to userspace.
BR,
-R
Quoted 47 lines
In the end we need some way to quickly ramp-up the frequency to avoid the execution bubbles.
waitboost is trying to guess that, but in some cases it guess wrong and waste power.
btw, this is something that other drivers might need:
https://gitlab.freedesktop.org/drm/amd/-/issues/1500#note_825883
Cc: Alex Deucher <[email protected]>Quoted 36 lines
Also, on a related topic: https://lwn.net/Articles/868468/
BR,
-RQuoted 30 lines
Individual drivers can then inspect this via
dma_fence_wait_count()and decide to wait boost the waits on such fences.Again, quickly put together and smoke tested only - no guarantees whatsoever and I will rely on interested parties to test and report if it even works or how well.
v2:
* Small fixups based on CI feedback:
* Handle decrement correctly for already signalled case while adding callback.
* Remove i915 assert which was making sure structi915_requestdoes not grow.
* Split out the i915 patch into three separate functional changes.Tvrtko Ursulin (5):
dma-fence: Track explicit waiters drm/syncobj: Mark syncobj waits as external waiters drm/i915: Waitboost external waits drm/i915: Mark waits as explicit
drm/i915: Wait boost requests waited upon by othersdrivers/dma-buf/dma-fence.c | 102 ++++++++++++++++------ drivers/gpu/drm/drm_syncobj.c | 6 +- drivers/gpu/drm/i915/gt/intel_engine_pm.c | 1 - drivers/gpu/drm/i915/i915_request.c | 13 ++- include/linux/dma-fence.h | 14 +++ 5 files changed, 101 insertions(+), 35 deletions(-)--
2.34.1
Quoted 29 lines · Rodrigo Vivi
Quoted 24 lines · Rob Clark
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
In i915 we have this concept of "wait boosting" where we give a priority boost for instance to fences which are actively waited upon from userspace. This has it's pros and cons and can certainly be discussed at lenght. However fact is some workloads really like it.
Quoted 7 lines
Problem is that with the arrival of drm syncobj and a new userspace waiting entry point it added, the waitboost mechanism was bypassed. Hence I cooked up this mini series really (really) quickly to see if some discussion can be had.
It adds a concept of "wait count" to dma fence, which is incremented for every explicit
dma_fence_enable_sw_signalinganddma_fence_add_wait_callback(likedma_fence_add_callbackbut from explicit/userspace wait paths).I was thinking about a similar thing, but in the context of
dma_fence(or rathersync_file) fd poll()ing. How does the kernel differentiate between "housekeeping" poll()ers that don't want to trigger boost but simply know when to do cleanup, and waiters who are waiting with some urgency. I think we could use EPOLLPRI for this purpose.Quoted 3 lines
Not sure how that translates to waits via the syncobj. But I think we want to let userspace give some hint about urgent vs housekeeping waits.
Quoted 8 lines
Should the hint be on the waits, or should the hints be on the executed context?
In the end we need some way to quickly ramp-up the frequency to avoid the execution bubbles.
waitboost is trying to guess that, but in some cases it guess wrong and waste power.
Do we have a list of workloads which shows who benefits and who loses from the current implementation of waitboost?
Quoted 4 lines
btw, this is something that other drivers might need:
https://gitlab.freedesktop.org/drm/amd/-/issues/1500#note_825883
Cc: Alex Deucher <[email protected]>
I have several issues with the context hint if it would directly influence frequency selection in the "more power" direction.
First of all, assume a context hint would replace the waitboost. Which applications would need to set it to restore the lost performance and how would they set it?
Then I don't even think userspace necessarily knows. Think of a layer like OpenCL. It doesn't really know in advance the profile of submissions vs waits. It depends on the CPU vs GPU speed, so hardware generation, and the actual size of the workload which can be influenced by the application (or user) and not the library.
The approach also lends itself well for the "arms race" where every application can say "Me me me, I am the most important workload there is!".
The last concern is for me shared with the proposal to expose deadlines or high priority waits as explicit uapi knobs. Both come under the "what application told us it will do" category vs what it actually does. So I think it is slightly weaker than basing decisions of waits.
The current waitboost is a bit detached from that problem because when we waitboost for flips we _know_ it is an actual framebuffer in the flip chain. When we waitboost for waits we also know someone is waiting. We are not trusting userspace telling us this will be a buffer in the flip chain or that this is a context which will have a certain duty-cycle.
But yes, even if the input is truthful, latter is still only a heuristics because nothing says all waits are important. AFAIU it just happened to work well in the past.
I do understand I am effectively arguing for more heuristics, which may sound a bit against the common wisdom. This is because in general I think the logic to do the right thing, be it in the driver or in the firmware, can work best if it has a holistic view. Simply put it needs to have more inputs to the decisions it is making.
That is what my series is proposing - adding a common signal of "someone in userspace is waiting". What happens with that signal needs not be defined (promised) in the uapi contract.
Say you route it to SLPC logic. It doesn't need to do with it what legacy i915 is doing today. It just needs to do something which works best for majority of workloads. It can even ignore it if that works for it.
Finally, back to the immediate problem is when people replace the OpenCL NEO driver with clvk that performance tanks. Because former does waits using i915 specific ioctls and so triggers waitboost, latter waits on syncobj so no waitboost and performance is bad. What short term solution can we come up with? Or we say to not use clvk? I also wonder if other Vulkan based stuff is perhaps missing those easy performance gains..
Perhaps strictly speaking Rob's and mine proposal are not mutually exclusive. Yes I could piggy back on his with an "immediate deadline for waits" idea, but they could also be separate concepts if we concluded "someone is waiting" signal is useful to have. Or it takes to long to upstream the full deadline idea.
Regards,
Tvrtko
Quoted 36 lines
Quoted 36 lines
Also, on a related topic: https://lwn.net/Articles/868468/
BR,
-RQuoted 30 lines
Individual drivers can then inspect this via
dma_fence_wait_count()and decide to wait boost the waits on such fences.Again, quickly put together and smoke tested only - no guarantees whatsoever and I will rely on interested parties to test and report if it even works or how well.
v2:
* Small fixups based on CI feedback:
* Handle decrement correctly for already signalled case while adding callback.
* Remove i915 assert which was making sure structi915_requestdoes not grow.
* Split out the i915 patch into three separate functional changes.Tvrtko Ursulin (5):
dma-fence: Track explicit waiters drm/syncobj: Mark syncobj waits as external waiters drm/i915: Waitboost external waits drm/i915: Mark waits as explicit
drm/i915: Wait boost requests waited upon by othersdrivers/dma-buf/dma-fence.c | 102 ++++++++++++++++------ drivers/gpu/drm/drm_syncobj.c | 6 +- drivers/gpu/drm/i915/gt/intel_engine_pm.c | 1 - drivers/gpu/drm/i915/i915_request.c | 13 ++- include/linux/dma-fence.h | 14 +++ 5 files changed, 101 insertions(+), 35 deletions(-)--
2.34.1
Quoted 55 lines · Tvrtko Ursulin
Quoted 29 lines · Rodrigo Vivi
Quoted 24 lines · Rob Clark
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
In i915 we have this concept of "wait boosting" where we give a priority boost for instance to fences which are actively waited upon from userspace. This has it's pros and cons and can certainly be discussed at lenght. However fact is some workloads really like it.
Quoted 7 lines
Problem is that with the arrival of drm syncobj and a new userspace waiting entry point it added, the waitboost mechanism was bypassed. Hence I cooked up this mini series really (really) quickly to see if some discussion can be had.
It adds a concept of "wait count" to dma fence, which is incremented for every explicit
dma_fence_enable_sw_signalinganddma_fence_add_wait_callback(likedma_fence_add_callbackbut from explicit/userspace wait paths).I was thinking about a similar thing, but in the context of
dma_fence(or rathersync_file) fd poll()ing. How does the kernel differentiate between "housekeeping" poll()ers that don't want to trigger boost but simply know when to do cleanup, and waiters who are waiting with some urgency. I think we could use EPOLLPRI for this purpose.Quoted 3 lines
Not sure how that translates to waits via the syncobj. But I think we want to let userspace give some hint about urgent vs housekeeping waits.
Quoted 8 lines
Should the hint be on the waits, or should the hints be on the executed context?
In the end we need some way to quickly ramp-up the frequency to avoid the execution bubbles.
waitboost is trying to guess that, but in some cases it guess wrong and waste power.
Do we have a list of workloads which shows who benefits and who loses from the current implementation of waitboost?
Quoted 4 lines
btw, this is something that other drivers might need:
https://gitlab.freedesktop.org/drm/amd/-/issues/1500#note_825883
Cc: Alex Deucher <[email protected]>I have several issues with the context hint if it would directly influence frequency selection in the "more power" direction.
First of all, assume a context hint would replace the waitboost. Which applications would need to set it to restore the lost performance and how would they set it?
Quoted 8 lines
Then I don't even think userspace necessarily knows. Think of a layer like OpenCL. It doesn't really know in advance the profile of submissions vs waits. It depends on the CPU vs GPU speed, so hardware generation, and the actual size of the workload which can be influenced by the application (or user) and not the library.
The approach also lends itself well for the "arms race" where every application can say "Me me me, I am the most important workload there is!".
since there is discussion happening in two places:
https://gitlab.freedesktop.org/drm/intel/-/issues/8014#note_1777433
What I think you might want is a ctx boost_mask which lets an app or driver disable certain boost signals/classes. Where fence waits is one class of boost, but hypothetical other signals like touchscreen (or other) input events could be another class of boost. A compute workload might be interested in fence wait boosts but could care less about input events.
Quoted 36 lines
The last concern is for me shared with the proposal to expose deadlines or high priority waits as explicit uapi knobs. Both come under the "what application told us it will do" category vs what it actually does. So I think it is slightly weaker than basing decisions of waits.
The current waitboost is a bit detached from that problem because when we waitboost for flips we _know_ it is an actual framebuffer in the flip chain. When we waitboost for waits we also know someone is waiting. We are not trusting userspace telling us this will be a buffer in the flip chain or that this is a context which will have a certain duty-cycle.
But yes, even if the input is truthful, latter is still only a heuristics because nothing says all waits are important. AFAIU it just happened to work well in the past.
I do understand I am effectively arguing for more heuristics, which may sound a bit against the common wisdom. This is because in general I think the logic to do the right thing, be it in the driver or in the firmware, can work best if it has a holistic view. Simply put it needs to have more inputs to the decisions it is making.
That is what my series is proposing - adding a common signal of "someone in userspace is waiting". What happens with that signal needs not be defined (promised) in the uapi contract.
Say you route it to SLPC logic. It doesn't need to do with it what legacy i915 is doing today. It just needs to do something which works best for majority of workloads. It can even ignore it if that works for it.
Finally, back to the immediate problem is when people replace the OpenCL NEO driver with clvk that performance tanks. Because former does waits using i915 specific ioctls and so triggers waitboost, latter waits on syncobj so no waitboost and performance is bad. What short term solution can we come up with? Or we say to not use clvk? I also wonder if other Vulkan based stuff is perhaps missing those easy performance gains..
Quoted 5 lines
Perhaps strictly speaking Rob's and mine proposal are not mutually exclusive. Yes I could piggy back on his with an "immediate deadline for waits" idea, but they could also be separate concepts if we concluded "someone is waiting" signal is useful to have. Or it takes to long to upstream the full deadline idea.
Let me re-spin my series and add the syncobj wait flag and i915 bits adapted from your patches.. I think the basic idea of deadlines (which includes "I want it NOW" ;-)) isn't controversial, but the original idea got caught up in some bikeshed (what about compositors that wait on fences in userspace to decide which surfaces to update in the next frame), plus me getting busy and generally not having a good plan for how to leverage this from VM guests (which is becoming increasingly important for CrOS). I think I can build on some ongoing virtgpu fencing improvement work to solve the latter. But now that we have a 2nd use-case for this, it makes sense to respin.
BR,
-R
Quoted 40 lines
Regards,
Tvrtko
Quoted 36 lines
Quoted 36 lines
Also, on a related topic: https://lwn.net/Articles/868468/
BR,
-RQuoted 30 lines
Individual drivers can then inspect this via
dma_fence_wait_count()and decide to wait boost the waits on such fences.Again, quickly put together and smoke tested only - no guarantees whatsoever and I will rely on interested parties to test and report if it even works or how well.
v2:
* Small fixups based on CI feedback:
* Handle decrement correctly for already signalled case while adding callback.
* Remove i915 assert which was making sure structi915_requestdoes not grow.
* Split out the i915 patch into three separate functional changes.Tvrtko Ursulin (5):
dma-fence: Track explicit waiters drm/syncobj: Mark syncobj waits as external waiters drm/i915: Waitboost external waits drm/i915: Mark waits as explicit
drm/i915: Wait boost requests waited upon by othersdrivers/dma-buf/dma-fence.c | 102 ++++++++++++++++------ drivers/gpu/drm/drm_syncobj.c | 6 +- drivers/gpu/drm/i915/gt/intel_engine_pm.c | 1 - drivers/gpu/drm/i915/i915_request.c | 13 ++- include/linux/dma-fence.h | 14 +++ 5 files changed, 101 insertions(+), 35 deletions(-)--
2.34.1
Quoted 68 lines · Rob Clark
Quoted 55 lines · Tvrtko Ursulin
Quoted 29 lines · Rodrigo Vivi
Quoted 24 lines · Rob Clark
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
In i915 we have this concept of "wait boosting" where we give a priority boost for instance to fences which are actively waited upon from userspace. This has it's pros and cons and can certainly be discussed at lenght. However fact is some workloads really like it.
Quoted 7 lines
Problem is that with the arrival of drm syncobj and a new userspace waiting entry point it added, the waitboost mechanism was bypassed. Hence I cooked up this mini series really (really) quickly to see if some discussion can be had.
It adds a concept of "wait count" to dma fence, which is incremented for every explicit
dma_fence_enable_sw_signalinganddma_fence_add_wait_callback(likedma_fence_add_callbackbut from explicit/userspace wait paths).I was thinking about a similar thing, but in the context of
dma_fence(or rathersync_file) fd poll()ing. How does the kernel differentiate between "housekeeping" poll()ers that don't want to trigger boost but simply know when to do cleanup, and waiters who are waiting with some urgency. I think we could use EPOLLPRI for this purpose.Quoted 3 lines
Not sure how that translates to waits via the syncobj. But I think we want to let userspace give some hint about urgent vs housekeeping waits.
Quoted 8 lines
Should the hint be on the waits, or should the hints be on the executed context?
In the end we need some way to quickly ramp-up the frequency to avoid the execution bubbles.
waitboost is trying to guess that, but in some cases it guess wrong and waste power.
Do we have a list of workloads which shows who benefits and who loses from the current implementation of waitboost?
Quoted 4 lines
btw, this is something that other drivers might need:
https://gitlab.freedesktop.org/drm/amd/-/issues/1500#note_825883
Cc: Alex Deucher <[email protected]>I have several issues with the context hint if it would directly influence frequency selection in the "more power" direction.
First of all, assume a context hint would replace the waitboost. Which applications would need to set it to restore the lost performance and how would they set it?
Quoted 8 lines
Then I don't even think userspace necessarily knows. Think of a layer like OpenCL. It doesn't really know in advance the profile of submissions vs waits. It depends on the CPU vs GPU speed, so hardware generation, and the actual size of the workload which can be influenced by the application (or user) and not the library.
The approach also lends itself well for the "arms race" where every application can say "Me me me, I am the most important workload there is!".
since there is discussion happening in two places:
Quoted 8 lines
https://gitlab.freedesktop.org/drm/intel/-/issues/8014#note_1777433
What I think you might want is a ctx
boost_maskwhich lets an app or driver disable certain boost signals/classes. Where fence waits is one class of boost, but hypothetical other signals like touchscreen (or other) input events could be another class of boost. A compute workload might be interested in fence wait boosts but could care less about input events.
I think it can only be apps which could have any chance knowing whether their use of a library is latency sensitive or not. Which means new library extensions and their adoption. So I have some strong reservation that route is feasible.
Or we tie with priority which many drivers do. Normal and above gets the boosting and what lowered itself does not (aka SCHED_IDLE/SCHED_BATCH).
Related note is that we lack any external control of our scheduling decisions so we really do suck compared to other scheduling domains like CPU and IO etc.
Quoted 36 lines
Quoted 36 lines
The last concern is for me shared with the proposal to expose deadlines or high priority waits as explicit uapi knobs. Both come under the "what application told us it will do" category vs what it actually does. So I think it is slightly weaker than basing decisions of waits.
The current waitboost is a bit detached from that problem because when we waitboost for flips we _know_ it is an actual framebuffer in the flip chain. When we waitboost for waits we also know someone is waiting. We are not trusting userspace telling us this will be a buffer in the flip chain or that this is a context which will have a certain duty-cycle.
But yes, even if the input is truthful, latter is still only a heuristics because nothing says all waits are important. AFAIU it just happened to work well in the past.
I do understand I am effectively arguing for more heuristics, which may sound a bit against the common wisdom. This is because in general I think the logic to do the right thing, be it in the driver or in the firmware, can work best if it has a holistic view. Simply put it needs to have more inputs to the decisions it is making.
That is what my series is proposing - adding a common signal of "someone in userspace is waiting". What happens with that signal needs not be defined (promised) in the uapi contract.
Say you route it to SLPC logic. It doesn't need to do with it what legacy i915 is doing today. It just needs to do something which works best for majority of workloads. It can even ignore it if that works for it.
Finally, back to the immediate problem is when people replace the OpenCL NEO driver with clvk that performance tanks. Because former does waits using i915 specific ioctls and so triggers waitboost, latter waits on syncobj so no waitboost and performance is bad. What short term solution can we come up with? Or we say to not use clvk? I also wonder if other Vulkan based stuff is perhaps missing those easy performance gains..
Quoted 7 lines
Quoted 5 lines
Perhaps strictly speaking Rob's and mine proposal are not mutually exclusive. Yes I could piggy back on his with an "immediate deadline for waits" idea, but they could also be separate concepts if we concluded "someone is waiting" signal is useful to have. Or it takes to long to upstream the full deadline idea.
Let me re-spin my series and add the syncobj wait flag and i915 bits
I think wait flag is questionable unless it is inverted to imply waits which can be de-prioritized (again same parallel with SCHED_IDLE/BATCH). Having a flag which "makes things faster" IMO should require elevated privilege (to avoid the "arms race") at which point I fear it quickly becomes uninteresting.
Quoted 9 lines
adapted from your patches.. I think the basic idea of deadlines (which includes "I want it NOW" ;-)) isn't controversial, but the original idea got caught up in some bikeshed (what about compositors that wait on fences in userspace to decide which surfaces to update in the next frame), plus me getting busy and generally not having a good plan for how to leverage this from VM guests (which is becoming increasingly important for CrOS). I think I can build on some ongoing virtgpu fencing improvement work to solve the latter. But now that we have a 2nd use-case for this, it makes sense to respin.
Sure, I was looking at the old version already. It is interesting. But also IMO needs quite a bit more work to approach achieving what is implied from the name of the feature. It would need proper deadline based sched job picking, and even then drm sched is mostly just a frontend. So once past runnable status and jobs handed over to backend, without further driver work it probably wouldn't be very effective past very lightly loaded systems.
Then if we fast forward to a world where schedulers perhaps become fully deadline aware (we even had this for i915 few years back) then the question will be does equating waits with immediate deadlines still works. Maybe not too well because we wouldn't have the ability to distinguish between the "someone is waiting" signal from the otherwise propagated deadlines.
Regards,
Tvrtko
Quoted 80 lines · Tvrtko Ursulin
Quoted 68 lines · Rob Clark
Quoted 55 lines · Tvrtko Ursulin
Quoted 29 lines · Rodrigo Vivi
Quoted 24 lines · Rob Clark
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
In i915 we have this concept of "wait boosting" where we give a priority boost for instance to fences which are actively waited upon from userspace. This has it's pros and cons and can certainly be discussed at lenght. However fact is some workloads really like it.
Quoted 7 lines
Problem is that with the arrival of drm syncobj and a new userspace waiting entry point it added, the waitboost mechanism was bypassed. Hence I cooked up this mini series really (really) quickly to see if some discussion can be had.
It adds a concept of "wait count" to dma fence, which is incremented for every explicit
dma_fence_enable_sw_signalinganddma_fence_add_wait_callback(likedma_fence_add_callbackbut from explicit/userspace wait paths).I was thinking about a similar thing, but in the context of
dma_fence(or rathersync_file) fd poll()ing. How does the kernel differentiate between "housekeeping" poll()ers that don't want to trigger boost but simply know when to do cleanup, and waiters who are waiting with some urgency. I think we could use EPOLLPRI for this purpose.Quoted 3 lines
Not sure how that translates to waits via the syncobj. But I think we want to let userspace give some hint about urgent vs housekeeping waits.
Quoted 8 lines
Should the hint be on the waits, or should the hints be on the executed context?
In the end we need some way to quickly ramp-up the frequency to avoid the execution bubbles.
waitboost is trying to guess that, but in some cases it guess wrong and waste power.
Do we have a list of workloads which shows who benefits and who loses from the current implementation of waitboost?
Quoted 4 lines
btw, this is something that other drivers might need:
https://gitlab.freedesktop.org/drm/amd/-/issues/1500#note_825883
Cc: Alex Deucher <[email protected]>I have several issues with the context hint if it would directly influence frequency selection in the "more power" direction.
First of all, assume a context hint would replace the waitboost. Which applications would need to set it to restore the lost performance and how would they set it?
Quoted 8 lines
Then I don't even think userspace necessarily knows. Think of a layer like OpenCL. It doesn't really know in advance the profile of submissions vs waits. It depends on the CPU vs GPU speed, so hardware generation, and the actual size of the workload which can be influenced by the application (or user) and not the library.
The approach also lends itself well for the "arms race" where every application can say "Me me me, I am the most important workload there is!".
since there is discussion happening in two places:
Quoted 8 lines
https://gitlab.freedesktop.org/drm/intel/-/issues/8014#note_1777433
What I think you might want is a ctx
boost_maskwhich lets an app or driver disable certain boost signals/classes. Where fence waits is one class of boost, but hypothetical other signals like touchscreen (or other) input events could be another class of boost. A compute workload might be interested in fence wait boosts but could care less about input events.
Quoted 7 lines
I think it can only be apps which could have any chance knowing whether their use of a library is latency sensitive or not. Which means new library extensions and their adoption. So I have some strong reservation that route is feasible.
Or we tie with priority which many drivers do. Normal and above gets the boosting and what lowered itself does not (aka SCHED_IDLE/SCHED_BATCH).
yeah, that sounds reasonable.
Quoted 46 lines
Related note is that we lack any external control of our scheduling decisions so we really do suck compared to other scheduling domains like CPU and IO etc.
Quoted 42 lines
Quoted 41 lines
The last concern is for me shared with the proposal to expose deadlines or high priority waits as explicit uapi knobs. Both come under the "what application told us it will do" category vs what it actually does. So I think it is slightly weaker than basing decisions of waits.
The current waitboost is a bit detached from that problem because when we waitboost for flips we _know_ it is an actual framebuffer in the flip chain. When we waitboost for waits we also know someone is waiting. We are not trusting userspace telling us this will be a buffer in the flip chain or that this is a context which will have a certain duty-cycle.
But yes, even if the input is truthful, latter is still only a heuristics because nothing says all waits are important. AFAIU it just happened to work well in the past.
I do understand I am effectively arguing for more heuristics, which may sound a bit against the common wisdom. This is because in general I think the logic to do the right thing, be it in the driver or in the firmware, can work best if it has a holistic view. Simply put it needs to have more inputs to the decisions it is making.
That is what my series is proposing - adding a common signal of "someone in userspace is waiting". What happens with that signal needs not be defined (promised) in the uapi contract.
Say you route it to SLPC logic. It doesn't need to do with it what legacy i915 is doing today. It just needs to do something which works best for majority of workloads. It can even ignore it if that works for it.
Finally, back to the immediate problem is when people replace the OpenCL NEO driver with clvk that performance tanks. Because former does waits using i915 specific ioctls and so triggers waitboost, latter waits on syncobj so no waitboost and performance is bad. What short term solution can we come up with? Or we say to not use clvk? I also wonder if other Vulkan based stuff is perhaps missing those easy performance gains..
Perhaps strictly speaking Rob's and mine proposal are not mutually exclusive. Yes I could piggy back on his with an "immediate deadline for waits" idea, but they could also be separate concepts if we concluded "someone is waiting" signal is useful to have. Or it takes to long to upstream the full deadline idea.
Quoted 7 lines
Quoted 1 line
Let me re-spin my series and add the syncobj wait flag and i915 bits
I think wait flag is questionable unless it is inverted to imply waits which can be de-prioritized (again same parallel with SCHED_IDLE/BATCH). Having a flag which "makes things faster" IMO should require elevated privilege (to avoid the "arms race") at which point I fear it quickly becomes uninteresting.
I guess you could make the argument in either direction. Making the default behavior ramp up clocks could be a power regression.
I also think the "arms race" scenario isn't really as much of a problem as you think. There aren't _that_ many things using the GPU
at the same time (compared to # of things using CPU). And a lot of
mobile games throttle framerate to avoid draining your battery too quickly (after all, if your battery is dead you can't keep buying loot boxes or whatever).
Quoted 10 lines
Quoted 9 lines
adapted from your patches.. I think the basic idea of deadlines (which includes "I want it NOW" ;-)) isn't controversial, but the original idea got caught up in some bikeshed (what about compositors that wait on fences in userspace to decide which surfaces to update in the next frame), plus me getting busy and generally not having a good plan for how to leverage this from VM guests (which is becoming increasingly important for CrOS). I think I can build on some ongoing virtgpu fencing improvement work to solve the latter. But now that we have a 2nd use-case for this, it makes sense to respin.
Quoted 7 lines
Sure, I was looking at the old version already. It is interesting. But also IMO needs quite a bit more work to approach achieving what is implied from the name of the feature. It would need proper deadline based sched job picking, and even then drm sched is mostly just a frontend. So once past runnable status and jobs handed over to backend, without further driver work it probably wouldn't be very effective past very lightly loaded systems.
Yes, but all of that is not part of dma_fence ;-)
A pretty common challenging usecase is still the single fullscreen game, where scheduling isn't the problem, but landing at an appropriate GPU freq absolutely is. (UI workloads are perhaps more interesting from a scheduler standpoint, but they generally aren't challenging from a load/freq standpoint.)
Fwiw, the original motivation of the series was to implement something akin to i915 pageflip boosting without having to abandon the atomic helpers. (And, I guess it would also let i915 preserve that feature if it switched to atomic helpers.. I'm unsure if there are still other things blocking i915's migration.)
Quoted 6 lines
Then if we fast forward to a world where schedulers perhaps become fully deadline aware (we even had this for i915 few years back) then the question will be does equating waits with immediate deadlines still works. Maybe not too well because we wouldn't have the ability to distinguish between the "someone is waiting" signal from the otherwise propagated deadlines.
Is there any other way to handle a wait boost than expressing it as an ASAP deadline?
BR,
-R
Quoted 4 lines
Regards,
Tvrtko
Rodrigo Vivi
maintainerQuoted 87 lines · Rob Clark
Quoted 85 lines · Tvrtko Ursulin
Quoted 68 lines · Rob Clark
Quoted 55 lines · Tvrtko Ursulin
Quoted 29 lines · Rodrigo Vivi
Quoted 24 lines · Rob Clark
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
In i915 we have this concept of "wait boosting" where we give a priority boost for instance to fences which are actively waited upon from userspace. This has it's pros and cons and can certainly be discussed at lenght. However fact is some workloads really like it.
Quoted 7 lines
Problem is that with the arrival of drm syncobj and a new userspace waiting entry point it added, the waitboost mechanism was bypassed. Hence I cooked up this mini series really (really) quickly to see if some discussion can be had.
It adds a concept of "wait count" to dma fence, which is incremented for every explicit
dma_fence_enable_sw_signalinganddma_fence_add_wait_callback(likedma_fence_add_callbackbut from explicit/userspace wait paths).I was thinking about a similar thing, but in the context of
dma_fence(or rathersync_file) fd poll()ing. How does the kernel differentiate between "housekeeping" poll()ers that don't want to trigger boost but simply know when to do cleanup, and waiters who are waiting with some urgency. I think we could use EPOLLPRI for this purpose.Quoted 3 lines
Not sure how that translates to waits via the syncobj. But I think we want to let userspace give some hint about urgent vs housekeeping waits.
Quoted 8 lines
Should the hint be on the waits, or should the hints be on the executed context?
In the end we need some way to quickly ramp-up the frequency to avoid the execution bubbles.
waitboost is trying to guess that, but in some cases it guess wrong and waste power.
Do we have a list of workloads which shows who benefits and who loses from the current implementation of waitboost?
Quoted 4 lines
btw, this is something that other drivers might need:
https://gitlab.freedesktop.org/drm/amd/-/issues/1500#note_825883
Cc: Alex Deucher <[email protected]>I have several issues with the context hint if it would directly influence frequency selection in the "more power" direction.
First of all, assume a context hint would replace the waitboost. Which applications would need to set it to restore the lost performance and how would they set it?
Quoted 8 lines
Then I don't even think userspace necessarily knows. Think of a layer like OpenCL. It doesn't really know in advance the profile of submissions vs waits. It depends on the CPU vs GPU speed, so hardware generation, and the actual size of the workload which can be influenced by the application (or user) and not the library.
The approach also lends itself well for the "arms race" where every application can say "Me me me, I am the most important workload there is!".
since there is discussion happening in two places:
Quoted 8 lines
https://gitlab.freedesktop.org/drm/intel/-/issues/8014#note_1777433
What I think you might want is a ctx
boost_maskwhich lets an app or driver disable certain boost signals/classes. Where fence waits is one class of boost, but hypothetical other signals like touchscreen (or other) input events could be another class of boost. A compute workload might be interested in fence wait boosts but could care less about input events.I think it can only be apps which could have any chance knowing whether their use of a library is latency sensitive or not. Which means new library extensions and their adoption. So I have some strong reservation that route is feasible.
Quoted 5 lines
Quoted 2 lines
Or we tie with priority which many drivers do. Normal and above gets the boosting and what lowered itself does not (aka SCHED_IDLE/SCHED_BATCH).
yeah, that sounds reasonable.
on that gitlab-issue discussion Emma Anholt was against using the priority to influence frequency since that should be more about latency.
or we are talking about something different priority here?
Quoted 48 lines
Quoted 48 lines
Related note is that we lack any external control of our scheduling decisions so we really do suck compared to other scheduling domains like CPU and IO etc.
Quoted 43 lines
Quoted 36 lines
The last concern is for me shared with the proposal to expose deadlines or high priority waits as explicit uapi knobs. Both come under the "what application told us it will do" category vs what it actually does. So I think it is slightly weaker than basing decisions of waits.
The current waitboost is a bit detached from that problem because when we waitboost for flips we _know_ it is an actual framebuffer in the flip chain. When we waitboost for waits we also know someone is waiting. We are not trusting userspace telling us this will be a buffer in the flip chain or that this is a context which will have a certain duty-cycle.
But yes, even if the input is truthful, latter is still only a heuristics because nothing says all waits are important. AFAIU it just happened to work well in the past.
I do understand I am effectively arguing for more heuristics, which may sound a bit against the common wisdom. This is because in general I think the logic to do the right thing, be it in the driver or in the firmware, can work best if it has a holistic view. Simply put it needs to have more inputs to the decisions it is making.
That is what my series is proposing - adding a common signal of "someone in userspace is waiting". What happens with that signal needs not be defined (promised) in the uapi contract.
Say you route it to SLPC logic. It doesn't need to do with it what legacy i915 is doing today. It just needs to do something which works best for majority of workloads. It can even ignore it if that works for it.
Finally, back to the immediate problem is when people replace the OpenCL NEO driver with clvk that performance tanks. Because former does waits using i915 specific ioctls and so triggers waitboost, latter waits on syncobj so no waitboost and performance is bad. What short term solution can we come up with? Or we say to not use clvk? I also wonder if other Vulkan based stuff is perhaps missing those easy performance gains..
Quoted 5 lines
Perhaps strictly speaking Rob's and mine proposal are not mutually exclusive. Yes I could piggy back on his with an "immediate deadline for waits" idea, but they could also be separate concepts if we concluded "someone is waiting" signal is useful to have. Or it takes to long to upstream the full deadline idea.
Let me re-spin my series and add the syncobj wait flag and i915 bits
Quoted 8 lines
Quoted 5 lines
I think wait flag is questionable unless it is inverted to imply waits which can be de-prioritized (again same parallel with SCHED_IDLE/BATCH). Having a flag which "makes things faster" IMO should require elevated privilege (to avoid the "arms race") at which point I fear it quickly becomes uninteresting.
I guess you could make the argument in either direction. Making the default behavior ramp up clocks could be a power regression.
yeap, exactly the media / video conference case.
Quoted 7 lines
I also think the "arms race" scenario isn't really as much of a problem as you think. There aren't _that_ many things using the GPU
at the same time (compared to # of things using CPU). And a lot of
mobile games throttle framerate to avoid draining your battery too quickly (after all, if your battery is dead you can't keep buying loot boxes or whatever).
Very good point.
And in the GPU case they rely a lot on the profiles. Which btw, seems to be the Radeon solution. They boost the freq if the high performance profile is selected and don't care about the execution bubbles if low or mid profiles are selected, or something like that.
Quoted 50 lines
Quoted 11 lines
Quoted 10 lines
adapted from your patches.. I think the basic idea of deadlines (which includes "I want it NOW" ;-)) isn't controversial, but the original idea got caught up in some bikeshed (what about compositors that wait on fences in userspace to decide which surfaces to update in the next frame), plus me getting busy and generally not having a good plan for how to leverage this from VM guests (which is becoming increasingly important for CrOS). I think I can build on some ongoing virtgpu fencing improvement work to solve the latter. But now that we have a 2nd use-case for this, it makes sense to respin.
Quoted 7 lines
Sure, I was looking at the old version already. It is interesting. But also IMO needs quite a bit more work to approach achieving what is implied from the name of the feature. It would need proper deadline based sched job picking, and even then drm sched is mostly just a frontend. So once past runnable status and jobs handed over to backend, without further driver work it probably wouldn't be very effective past very lightly loaded systems.
Yes, but all of that is not part of
dma_fence;-)A pretty common challenging usecase is still the single fullscreen game, where scheduling isn't the problem, but landing at an appropriate GPU freq absolutely is. (UI workloads are perhaps more interesting from a scheduler standpoint, but they generally aren't challenging from a load/freq standpoint.)
Fwiw, the original motivation of the series was to implement something akin to i915 pageflip boosting without having to abandon the atomic helpers. (And, I guess it would also let i915 preserve that feature if it switched to atomic helpers.. I'm unsure if there are still other things blocking i915's migration.)
Quoted 6 lines
Then if we fast forward to a world where schedulers perhaps become fully deadline aware (we even had this for i915 few years back) then the question will be does equating waits with immediate deadlines still works. Maybe not too well because we wouldn't have the ability to distinguish between the "someone is waiting" signal from the otherwise propagated deadlines.
Is there any other way to handle a wait boost than expressing it as an ASAP deadline?
BR,
-RQuoted 4 lines
Regards,
Tvrtko
Quoted 92 lines · Rodrigo Vivi
Quoted 90 lines · Rob Clark
Quoted 87 lines · Tvrtko Ursulin
Quoted 68 lines · Rob Clark
Quoted 55 lines · Tvrtko Ursulin
Quoted 29 lines · Rodrigo Vivi
Quoted 24 lines · Rob Clark
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
In i915 we have this concept of "wait boosting" where we give a priority boost for instance to fences which are actively waited upon from userspace. This has it's pros and cons and can certainly be discussed at lenght. However fact is some workloads really like it.
Quoted 7 lines
Problem is that with the arrival of drm syncobj and a new userspace waiting entry point it added, the waitboost mechanism was bypassed. Hence I cooked up this mini series really (really) quickly to see if some discussion can be had.
It adds a concept of "wait count" to dma fence, which is incremented for every explicit
dma_fence_enable_sw_signalinganddma_fence_add_wait_callback(likedma_fence_add_callbackbut from explicit/userspace wait paths).I was thinking about a similar thing, but in the context of
dma_fence(or rathersync_file) fd poll()ing. How does the kernel differentiate between "housekeeping" poll()ers that don't want to trigger boost but simply know when to do cleanup, and waiters who are waiting with some urgency. I think we could use EPOLLPRI for this purpose.Quoted 3 lines
Not sure how that translates to waits via the syncobj. But I think we want to let userspace give some hint about urgent vs housekeeping waits.
Quoted 8 lines
Should the hint be on the waits, or should the hints be on the executed context?
In the end we need some way to quickly ramp-up the frequency to avoid the execution bubbles.
waitboost is trying to guess that, but in some cases it guess wrong and waste power.
Do we have a list of workloads which shows who benefits and who loses from the current implementation of waitboost?
Quoted 4 lines
btw, this is something that other drivers might need:
https://gitlab.freedesktop.org/drm/amd/-/issues/1500#note_825883
Cc: Alex Deucher <[email protected]>I have several issues with the context hint if it would directly influence frequency selection in the "more power" direction.
First of all, assume a context hint would replace the waitboost. Which applications would need to set it to restore the lost performance and how would they set it?
Quoted 8 lines
Then I don't even think userspace necessarily knows. Think of a layer like OpenCL. It doesn't really know in advance the profile of submissions vs waits. It depends on the CPU vs GPU speed, so hardware generation, and the actual size of the workload which can be influenced by the application (or user) and not the library.
The approach also lends itself well for the "arms race" where every application can say "Me me me, I am the most important workload there is!".
since there is discussion happening in two places:
Quoted 8 lines
https://gitlab.freedesktop.org/drm/intel/-/issues/8014#note_1777433
What I think you might want is a ctx
boost_maskwhich lets an app or driver disable certain boost signals/classes. Where fence waits is one class of boost, but hypothetical other signals like touchscreen (or other) input events could be another class of boost. A compute workload might be interested in fence wait boosts but could care less about input events.I think it can only be apps which could have any chance knowing whether their use of a library is latency sensitive or not. Which means new library extensions and their adoption. So I have some strong reservation that route is feasible.
Or we tie with priority which many drivers do. Normal and above gets the boosting and what lowered itself does not (aka SCHED_IDLE/SCHED_BATCH).
Quoted 7 lines
Quoted 2 lines
yeah, that sounds reasonable.
on that gitlab-issue discussion Emma Anholt was against using the priority to influence frequency since that should be more about latency.
or we are talking about something different priority here?
I was thinking to only _not_ boost on the lowest priority, but boost on norm/high priority.
But not something I feel too strongly about. Ie. deciding on policy doesn't affect or need to block getting the dma_fence and syncobj plumbing in place.
BR,
-R
Quoted 124 lines
Quoted 48 lines
Quoted 48 lines
Related note is that we lack any external control of our scheduling decisions so we really do suck compared to other scheduling domains like CPU and IO etc.
Quoted 43 lines
Quoted 36 lines
The last concern is for me shared with the proposal to expose deadlines or high priority waits as explicit uapi knobs. Both come under the "what application told us it will do" category vs what it actually does. So I think it is slightly weaker than basing decisions of waits.
The current waitboost is a bit detached from that problem because when we waitboost for flips we _know_ it is an actual framebuffer in the flip chain. When we waitboost for waits we also know someone is waiting. We are not trusting userspace telling us this will be a buffer in the flip chain or that this is a context which will have a certain duty-cycle.
But yes, even if the input is truthful, latter is still only a heuristics because nothing says all waits are important. AFAIU it just happened to work well in the past.
I do understand I am effectively arguing for more heuristics, which may sound a bit against the common wisdom. This is because in general I think the logic to do the right thing, be it in the driver or in the firmware, can work best if it has a holistic view. Simply put it needs to have more inputs to the decisions it is making.
That is what my series is proposing - adding a common signal of "someone in userspace is waiting". What happens with that signal needs not be defined (promised) in the uapi contract.
Say you route it to SLPC logic. It doesn't need to do with it what legacy i915 is doing today. It just needs to do something which works best for majority of workloads. It can even ignore it if that works for it.
Finally, back to the immediate problem is when people replace the OpenCL NEO driver with clvk that performance tanks. Because former does waits using i915 specific ioctls and so triggers waitboost, latter waits on syncobj so no waitboost and performance is bad. What short term solution can we come up with? Or we say to not use clvk? I also wonder if other Vulkan based stuff is perhaps missing those easy performance gains..
Quoted 5 lines
Perhaps strictly speaking Rob's and mine proposal are not mutually exclusive. Yes I could piggy back on his with an "immediate deadline for waits" idea, but they could also be separate concepts if we concluded "someone is waiting" signal is useful to have. Or it takes to long to upstream the full deadline idea.
Let me re-spin my series and add the syncobj wait flag and i915 bits
Quoted 8 lines
Quoted 5 lines
I think wait flag is questionable unless it is inverted to imply waits which can be de-prioritized (again same parallel with SCHED_IDLE/BATCH). Having a flag which "makes things faster" IMO should require elevated privilege (to avoid the "arms race") at which point I fear it quickly becomes uninteresting.
I guess you could make the argument in either direction. Making the default behavior ramp up clocks could be a power regression.
yeap, exactly the media / video conference case.
Quoted 7 lines
I also think the "arms race" scenario isn't really as much of a problem as you think. There aren't _that_ many things using the GPU
at the same time (compared to # of things using CPU). And a lot of
mobile games throttle framerate to avoid draining your battery too quickly (after all, if your battery is dead you can't keep buying loot boxes or whatever).Very good point.
And in the GPU case they rely a lot on the profiles. Which btw, seems to be the Radeon solution. They boost the freq if the high performance profile is selected and don't care about the execution bubbles if low or mid profiles are selected, or something like that.
Quoted 50 lines
Quoted 11 lines
Quoted 10 lines
adapted from your patches.. I think the basic idea of deadlines (which includes "I want it NOW" ;-)) isn't controversial, but the original idea got caught up in some bikeshed (what about compositors that wait on fences in userspace to decide which surfaces to update in the next frame), plus me getting busy and generally not having a good plan for how to leverage this from VM guests (which is becoming increasingly important for CrOS). I think I can build on some ongoing virtgpu fencing improvement work to solve the latter. But now that we have a 2nd use-case for this, it makes sense to respin.
Quoted 7 lines
Sure, I was looking at the old version already. It is interesting. But also IMO needs quite a bit more work to approach achieving what is implied from the name of the feature. It would need proper deadline based sched job picking, and even then drm sched is mostly just a frontend. So once past runnable status and jobs handed over to backend, without further driver work it probably wouldn't be very effective past very lightly loaded systems.
Yes, but all of that is not part of
dma_fence;-)A pretty common challenging usecase is still the single fullscreen game, where scheduling isn't the problem, but landing at an appropriate GPU freq absolutely is. (UI workloads are perhaps more interesting from a scheduler standpoint, but they generally aren't challenging from a load/freq standpoint.)
Fwiw, the original motivation of the series was to implement something akin to i915 pageflip boosting without having to abandon the atomic helpers. (And, I guess it would also let i915 preserve that feature if it switched to atomic helpers.. I'm unsure if there are still other things blocking i915's migration.)
Quoted 6 lines
Then if we fast forward to a world where schedulers perhaps become fully deadline aware (we even had this for i915 few years back) then the question will be does equating waits with immediate deadlines still works. Maybe not too well because we wouldn't have the ability to distinguish between the "someone is waiting" signal from the otherwise propagated deadlines.
Is there any other way to handle a wait boost than expressing it as an ASAP deadline?
BR,
-RQuoted 4 lines
Regards,
Tvrtko
Quoted 91 lines · Rodrigo Vivi
Quoted 90 lines · Rob Clark
Quoted 87 lines · Tvrtko Ursulin
Quoted 68 lines · Rob Clark
Quoted 55 lines · Tvrtko Ursulin
Quoted 29 lines · Rodrigo Vivi
Quoted 24 lines · Rob Clark
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
In i915 we have this concept of "wait boosting" where we give a priority boost for instance to fences which are actively waited upon from userspace. This has it's pros and cons and can certainly be discussed at lenght. However fact is some workloads really like it.
Quoted 7 lines
Problem is that with the arrival of drm syncobj and a new userspace waiting entry point it added, the waitboost mechanism was bypassed. Hence I cooked up this mini series really (really) quickly to see if some discussion can be had.
It adds a concept of "wait count" to dma fence, which is incremented for every explicit
dma_fence_enable_sw_signalinganddma_fence_add_wait_callback(likedma_fence_add_callbackbut from explicit/userspace wait paths).I was thinking about a similar thing, but in the context of
dma_fence(or rathersync_file) fd poll()ing. How does the kernel differentiate between "housekeeping" poll()ers that don't want to trigger boost but simply know when to do cleanup, and waiters who are waiting with some urgency. I think we could use EPOLLPRI for this purpose.Quoted 3 lines
Not sure how that translates to waits via the syncobj. But I think we want to let userspace give some hint about urgent vs housekeeping waits.
Quoted 8 lines
Should the hint be on the waits, or should the hints be on the executed context?
In the end we need some way to quickly ramp-up the frequency to avoid the execution bubbles.
waitboost is trying to guess that, but in some cases it guess wrong and waste power.
Do we have a list of workloads which shows who benefits and who loses from the current implementation of waitboost?
Quoted 4 lines
btw, this is something that other drivers might need:
https://gitlab.freedesktop.org/drm/amd/-/issues/1500#note_825883
Cc: Alex Deucher <[email protected]>I have several issues with the context hint if it would directly influence frequency selection in the "more power" direction.
First of all, assume a context hint would replace the waitboost. Which applications would need to set it to restore the lost performance and how would they set it?
Quoted 8 lines
Then I don't even think userspace necessarily knows. Think of a layer like OpenCL. It doesn't really know in advance the profile of submissions vs waits. It depends on the CPU vs GPU speed, so hardware generation, and the actual size of the workload which can be influenced by the application (or user) and not the library.
The approach also lends itself well for the "arms race" where every application can say "Me me me, I am the most important workload there is!".
since there is discussion happening in two places:
Quoted 8 lines
https://gitlab.freedesktop.org/drm/intel/-/issues/8014#note_1777433
What I think you might want is a ctx
boost_maskwhich lets an app or driver disable certain boost signals/classes. Where fence waits is one class of boost, but hypothetical other signals like touchscreen (or other) input events could be another class of boost. A compute workload might be interested in fence wait boosts but could care less about input events.I think it can only be apps which could have any chance knowing whether their use of a library is latency sensitive or not. Which means new library extensions and their adoption. So I have some strong reservation that route is feasible.
Or we tie with priority which many drivers do. Normal and above gets the boosting and what lowered itself does not (aka SCHED_IDLE/SCHED_BATCH).
Quoted 7 lines
Quoted 2 lines
yeah, that sounds reasonable.
on that gitlab-issue discussion Emma Anholt was against using the priority to influence frequency since that should be more about latency.
or we are talking about something different priority here?
As Rob already explained - I was suggesting skipping waitboost for contexts which explicitly made themselves low priority. I don't see a controversial angle there.
Quoted 54 lines
Quoted 54 lines
Quoted 53 lines
Related note is that we lack any external control of our scheduling decisions so we really do suck compared to other scheduling domains like CPU and IO etc.
Quoted 36 lines
Quoted 36 lines
The last concern is for me shared with the proposal to expose deadlines or high priority waits as explicit uapi knobs. Both come under the "what application told us it will do" category vs what it actually does. So I think it is slightly weaker than basing decisions of waits.
The current waitboost is a bit detached from that problem because when we waitboost for flips we _know_ it is an actual framebuffer in the flip chain. When we waitboost for waits we also know someone is waiting. We are not trusting userspace telling us this will be a buffer in the flip chain or that this is a context which will have a certain duty-cycle.
But yes, even if the input is truthful, latter is still only a heuristics because nothing says all waits are important. AFAIU it just happened to work well in the past.
I do understand I am effectively arguing for more heuristics, which may sound a bit against the common wisdom. This is because in general I think the logic to do the right thing, be it in the driver or in the firmware, can work best if it has a holistic view. Simply put it needs to have more inputs to the decisions it is making.
That is what my series is proposing - adding a common signal of "someone in userspace is waiting". What happens with that signal needs not be defined (promised) in the uapi contract.
Say you route it to SLPC logic. It doesn't need to do with it what legacy i915 is doing today. It just needs to do something which works best for majority of workloads. It can even ignore it if that works for it.
Finally, back to the immediate problem is when people replace the OpenCL NEO driver with clvk that performance tanks. Because former does waits using i915 specific ioctls and so triggers waitboost, latter waits on syncobj so no waitboost and performance is bad. What short term solution can we come up with? Or we say to not use clvk? I also wonder if other Vulkan based stuff is perhaps missing those easy performance gains..
Quoted 7 lines
Quoted 5 lines
Perhaps strictly speaking Rob's and mine proposal are not mutually exclusive. Yes I could piggy back on his with an "immediate deadline for waits" idea, but they could also be separate concepts if we concluded "someone is waiting" signal is useful to have. Or it takes to long to upstream the full deadline idea.
Let me re-spin my series and add the syncobj wait flag and i915 bits
I think wait flag is questionable unless it is inverted to imply waits which can be de-prioritized (again same parallel with SCHED_IDLE/BATCH). Having a flag which "makes things faster" IMO should require elevated privilege (to avoid the "arms race") at which point I fear it quickly becomes uninteresting.
Quoted 4 lines
Quoted 2 lines
I guess you could make the argument in either direction. Making the default behavior ramp up clocks could be a power regression.
yeap, exactly the media / video conference case.
Yeah I agree. And as not all media use cases are the same, as are not all compute contexts someone somewhere will need to run a series of workloads for power and performance numbers. Ideally that someone would be the entity for which it makes sense to look at all use cases, from server room to client, 3d, media and compute for both. If we could get the capability to run this in some automated fashion, akin to CI, we would even have a chance to keep making good decisions in the future.
Or we do some one off testing for this instance, but we still need a range of workloads and parts to do it properly..
Quoted 8 lines
Quoted 6 lines
I also think the "arms race" scenario isn't really as much of a problem as you think. There aren't _that_ many things using the GPU
at the same time (compared to # of things using CPU). And a lot of
mobile games throttle framerate to avoid draining your battery too quickly (after all, if your battery is dead you can't keep buying loot boxes or whatever).Very good point.
On this one I still disagree from the point of view that it does not make it good uapi if we allow everyone to select themselves for priority handling (one flavour or the other).
Quoted 4 lines
And in the GPU case they rely a lot on the profiles. Which btw, seems to be the Radeon solution. They boost the freq if the high performance profile is selected and don't care about the execution bubbles if low or mid profiles are selected, or something like that.
Profile as something which controls the waitboost globally? What would be the mechanism for communicating it to the driver?
Also, how would that reconcile the fact waitboost harms some workloads but helps others? If the latter not only improves the performance but also efficiency then assuming "battery" profile must mean "waitboost off" would be leaving battery life on the table. Conversely, if the "on a/c - max performance", would be global "waitboost on", then it could even be possible it wouldn't always be truly best performance if it causes thermal throttling.
Regards,
Tvrtko
Quoted 183 lines · Tvrtko Ursulin
Quoted 91 lines · Rodrigo Vivi
Quoted 90 lines · Rob Clark
Quoted 87 lines · Tvrtko Ursulin
Quoted 68 lines · Rob Clark
Quoted 55 lines · Tvrtko Ursulin
Quoted 29 lines · Rodrigo Vivi
Quoted 24 lines · Rob Clark
Quoted 8 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
In i915 we have this concept of "wait boosting" where we give a priority boost for instance to fences which are actively waited upon from userspace. This has it's pros and cons and can certainly be discussed at lenght. However fact is some workloads really like it.
Quoted 7 lines
Problem is that with the arrival of drm syncobj and a new userspace waiting entry point it added, the waitboost mechanism was bypassed. Hence I cooked up this mini series really (really) quickly to see if some discussion can be had.
It adds a concept of "wait count" to dma fence, which is incremented for every explicit
dma_fence_enable_sw_signalinganddma_fence_add_wait_callback(likedma_fence_add_callbackbut from explicit/userspace wait paths).I was thinking about a similar thing, but in the context of
dma_fence(or rathersync_file) fd poll()ing. How does the kernel differentiate between "housekeeping" poll()ers that don't want to trigger boost but simply know when to do cleanup, and waiters who are waiting with some urgency. I think we could use EPOLLPRI for this purpose.Quoted 3 lines
Not sure how that translates to waits via the syncobj. But I think we want to let userspace give some hint about urgent vs housekeeping waits.
Quoted 8 lines
Should the hint be on the waits, or should the hints be on the executed context?
In the end we need some way to quickly ramp-up the frequency to avoid the execution bubbles.
waitboost is trying to guess that, but in some cases it guess wrong and waste power.
Do we have a list of workloads which shows who benefits and who loses from the current implementation of waitboost?
Quoted 4 lines
btw, this is something that other drivers might need:
https://gitlab.freedesktop.org/drm/amd/-/issues/1500#note_825883
Cc: Alex Deucher <[email protected]>I have several issues with the context hint if it would directly influence frequency selection in the "more power" direction.
First of all, assume a context hint would replace the waitboost. Which applications would need to set it to restore the lost performance and how would they set it?
Quoted 8 lines
Then I don't even think userspace necessarily knows. Think of a layer like OpenCL. It doesn't really know in advance the profile of submissions vs waits. It depends on the CPU vs GPU speed, so hardware generation, and the actual size of the workload which can be influenced by the application (or user) and not the library.
The approach also lends itself well for the "arms race" where every application can say "Me me me, I am the most important workload there is!".
since there is discussion happening in two places:
Quoted 8 lines
https://gitlab.freedesktop.org/drm/intel/-/issues/8014#note_1777433
What I think you might want is a ctx
boost_maskwhich lets an app or driver disable certain boost signals/classes. Where fence waits is one class of boost, but hypothetical other signals like touchscreen (or other) input events could be another class of boost. A compute workload might be interested in fence wait boosts but could care less about input events.I think it can only be apps which could have any chance knowing whether their use of a library is latency sensitive or not. Which means new library extensions and their adoption. So I have some strong reservation that route is feasible.
Or we tie with priority which many drivers do. Normal and above gets the boosting and what lowered itself does not (aka SCHED_IDLE/SCHED_BATCH).
Quoted 7 lines
Quoted 2 lines
yeah, that sounds reasonable.
on that gitlab-issue discussion Emma Anholt was against using the priority to influence frequency since that should be more about latency.
or we are talking about something different priority here?
As Rob already explained - I was suggesting skipping waitboost for contexts which explicitly made themselves low priority. I don't see a controversial angle there.
Quoted 54 lines
Quoted 54 lines
Quoted 53 lines
Related note is that we lack any external control of our scheduling decisions so we really do suck compared to other scheduling domains like CPU and IO etc.
Quoted 36 lines
Quoted 36 lines
The last concern is for me shared with the proposal to expose deadlines or high priority waits as explicit uapi knobs. Both come under the "what application told us it will do" category vs what it actually does. So I think it is slightly weaker than basing decisions of waits.
The current waitboost is a bit detached from that problem because when we waitboost for flips we _know_ it is an actual framebuffer in the flip chain. When we waitboost for waits we also know someone is waiting. We are not trusting userspace telling us this will be a buffer in the flip chain or that this is a context which will have a certain duty-cycle.
But yes, even if the input is truthful, latter is still only a heuristics because nothing says all waits are important. AFAIU it just happened to work well in the past.
I do understand I am effectively arguing for more heuristics, which may sound a bit against the common wisdom. This is because in general I think the logic to do the right thing, be it in the driver or in the firmware, can work best if it has a holistic view. Simply put it needs to have more inputs to the decisions it is making.
That is what my series is proposing - adding a common signal of "someone in userspace is waiting". What happens with that signal needs not be defined (promised) in the uapi contract.
Say you route it to SLPC logic. It doesn't need to do with it what legacy i915 is doing today. It just needs to do something which works best for majority of workloads. It can even ignore it if that works for it.
Finally, back to the immediate problem is when people replace the OpenCL NEO driver with clvk that performance tanks. Because former does waits using i915 specific ioctls and so triggers waitboost, latter waits on syncobj so no waitboost and performance is bad. What short term solution can we come up with? Or we say to not use clvk? I also wonder if other Vulkan based stuff is perhaps missing those easy performance gains..
Quoted 7 lines
Quoted 5 lines
Perhaps strictly speaking Rob's and mine proposal are not mutually exclusive. Yes I could piggy back on his with an "immediate deadline for waits" idea, but they could also be separate concepts if we concluded "someone is waiting" signal is useful to have. Or it takes to long to upstream the full deadline idea.
Let me re-spin my series and add the syncobj wait flag and i915 bits
I think wait flag is questionable unless it is inverted to imply waits which can be de-prioritized (again same parallel with SCHED_IDLE/BATCH). Having a flag which "makes things faster" IMO should require elevated privilege (to avoid the "arms race") at which point I fear it quickly becomes uninteresting.
Quoted 4 lines
Quoted 2 lines
I guess you could make the argument in either direction. Making the default behavior ramp up clocks could be a power regression.
yeap, exactly the media / video conference case.
Yeah I agree. And as not all media use cases are the same, as are not all compute contexts someone somewhere will need to run a series of workloads for power and performance numbers. Ideally that someone would be the entity for which it makes sense to look at all use cases, from server room to client, 3d, media and compute for both. If we could get the capability to run this in some automated fashion, akin to CI, we would even have a chance to keep making good decisions in the future.
Or we do some one off testing for this instance, but we still need a range of workloads and parts to do it properly..
Quoted 7 lines
Quoted 6 lines
I also think the "arms race" scenario isn't really as much of a problem as you think. There aren't _that_ many things using the GPU
at the same time (compared to # of things using CPU). And a lot of
mobile games throttle framerate to avoid draining your battery too quickly (after all, if your battery is dead you can't keep buying loot boxes or whatever).
Quoted 5 lines
Quoted 1 line
Very good point.
On this one I still disagree from the point of view that it does not make it good uapi if we allow everyone to select themselves for priority handling (one flavour or the other).
There is plenty of precedent for userspace giving hints to the kernel about scheduling and freq mgmt. Like schedutil uclamp stuff. Although I think that is all based on cgroups.
In the fence/syncobj case, I think we need per-wait hints.. because for a single process the driver will be doing both housekeeping waits and potentially urgent waits. There may also be some room for some cgroup or similar knobs to control things like what max priority an app can ask for, and whether or how aggressively the kernel responds to the "deadline" hints. So as far as "arms race", I don't think I'd change anything about my "fence deadline" proposal.. but that it might just be one piece of the overall puzzle.
BR,
-R
Quoted 19 lines
Quoted 4 lines
And in the GPU case they rely a lot on the profiles. Which btw, seems to be the Radeon solution. They boost the freq if the high performance profile is selected and don't care about the execution bubbles if low or mid profiles are selected, or something like that.
Profile as something which controls the waitboost globally? What would be the mechanism for communicating it to the driver?
Also, how would that reconcile the fact waitboost harms some workloads but helps others? If the latter not only improves the performance but also efficiency then assuming "battery" profile must mean "waitboost off" would be leaving battery life on the table. Conversely, if the "on a/c - max performance", would be global "waitboost on", then it could even be possible it wouldn't always be truly best performance if it causes thermal throttling.
Regards,
Tvrtko
Quoted 5 lines · Rob Clark
Quoted 3 lines · Tvrtko Ursulin
On 17/02/2023 20:45, Rodrigo Vivi wrote:
[snip]
Quoted 20 lines
Quoted 20 lines
Yeah I agree. And as not all media use cases are the same, as are not all compute contexts someone somewhere will need to run a series of workloads for power and performance numbers. Ideally that someone would be the entity for which it makes sense to look at all use cases, from server room to client, 3d, media and compute for both. If we could get the capability to run this in some automated fashion, akin to CI, we would even have a chance to keep making good decisions in the future.
Or we do some one off testing for this instance, but we still need a range of workloads and parts to do it properly..
Quoted 8 lines
Quoted 6 lines
I also think the "arms race" scenario isn't really as much of a problem as you think. There aren't _that_ many things using the GPU
at the same time (compared to # of things using CPU). And a lot of
mobile games throttle framerate to avoid draining your battery too quickly (after all, if your battery is dead you can't keep buying loot boxes or whatever).Very good point.
Quoted 7 lines
Quoted 3 lines
On this one I still disagree from the point of view that it does not make it good uapi if we allow everyone to select themselves for priority handling (one flavour or the other).
There is plenty of precedent for userspace giving hints to the kernel about scheduling and freq mgmt. Like schedutil uclamp stuff. Although I think that is all based on cgroups.
I knew about SCHED_DEADLINE and that it requires CAP_SYS_NICE, but I did not know about uclamp. Quick experiment with uclampset suggests it indeed does not require elevated privilege. If that is indeed so, it is good enough for me as a precedent.
It appears to work using sched_setscheduler so maybe could define something similar in i915/xe, per context or per client, not sure.
Maybe it would start as a primitive implementation but the uapi would not preclude making it smart(er) afterwards. Or passing along to GuC to do it's thing with it.
Quoted 6 lines
In the fence/syncobj case, I think we need per-wait hints.. because for a single process the driver will be doing both housekeeping waits and potentially urgent waits. There may also be some room for some cgroup or similar knobs to control things like what max priority an app can ask for, and whether or how aggressively the kernel responds to the "deadline" hints. So as far as "arms race", I don't think I'd
Per wait hints are okay I guess even with "I am important" in their name if sched_setscheduler allows raising uclamp.min just like that. In which case cgroup limits to mimick cpu uclamp also make sense.
Quoted 2 lines
change anything about my "fence deadline" proposal.. but that it might just be one piece of the overall puzzle.
That SCHED_DEADLINE requires CAP_SYS_NICE does not worry you?
Regards,
Tvrtko
Quoted 38 lines · Tvrtko Ursulin
Quoted 5 lines · Rob Clark
Quoted 3 lines · Tvrtko Ursulin
On 17/02/2023 20:45, Rodrigo Vivi wrote:
[snip]
Quoted 20 lines
Quoted 20 lines
Yeah I agree. And as not all media use cases are the same, as are not all compute contexts someone somewhere will need to run a series of workloads for power and performance numbers. Ideally that someone would be the entity for which it makes sense to look at all use cases, from server room to client, 3d, media and compute for both. If we could get the capability to run this in some automated fashion, akin to CI, we would even have a chance to keep making good decisions in the future.
Or we do some one off testing for this instance, but we still need a range of workloads and parts to do it properly..
Quoted 8 lines
Quoted 6 lines
I also think the "arms race" scenario isn't really as much of a problem as you think. There aren't _that_ many things using the GPU at the same time (compared to # of things using CPU). And a lot of mobile games throttle framerate to avoid draining your battery too quickly (after all, if your battery is dead you can't keep buying loot boxes or whatever).
Very good point.
Quoted 7 lines
Quoted 3 lines
On this one I still disagree from the point of view that it does not make it good uapi if we allow everyone to select themselves for priority handling (one flavour or the other).
There is plenty of precedent for userspace giving hints to the kernel about scheduling and freq mgmt. Like schedutil uclamp stuff. Although I think that is all based on cgroups.
Quoted 5 lines
I knew about
SCHED_DEADLINEand that it requiresCAP_SYS_NICE, but I did not know about uclamp. Quick experiment with uclampset suggests it indeed does not require elevated privilege. If that is indeed so, it is good enough for me as a precedent.It appears to work using
sched_setschedulerso maybe could define something similar in i915/xe, per context or per client, not sure.Maybe it would start as a primitive implementation but the uapi would not preclude making it smart(er) afterwards. Or passing along to GuC to do it's thing with it.
Hmmm having said that, how would we fix clvk performance using that? We would either need the library to do a new step when creating contexts, or allow external control so outside entity can do it. And then the question is based on what it decides to do it? Is it possible to know which, for instance, Chrome tab will be (or is) using clvk so that tab management code does it?
Regards,
Tvrtko
Quoted 17 lines
Quoted 6 lines
In the fence/syncobj case, I think we need per-wait hints.. because for a single process the driver will be doing both housekeeping waits and potentially urgent waits. There may also be some room for some cgroup or similar knobs to control things like what max priority an app can ask for, and whether or how aggressively the kernel responds to the "deadline" hints. So as far as "arms race", I don't think I'd
Per wait hints are okay I guess even with "I am important" in their name if
sched_setschedulerallows raising uclamp.min just like that. In which case cgroup limits to mimick cpu uclamp also make sense.Quoted 2 lines
change anything about my "fence deadline" proposal.. but that it might just be one piece of the overall puzzle.
That
SCHED_DEADLINErequiresCAP_SYS_NICEdoes not worry you?Regards,
Tvrtko
Quoted 53 lines · Tvrtko Ursulin
Quoted 43 lines · Tvrtko Ursulin
Quoted 5 lines · Rob Clark
Quoted 3 lines · Tvrtko Ursulin
On 17/02/2023 20:45, Rodrigo Vivi wrote:
[snip]
Quoted 20 lines
Quoted 20 lines
Yeah I agree. And as not all media use cases are the same, as are not all compute contexts someone somewhere will need to run a series of workloads for power and performance numbers. Ideally that someone would be the entity for which it makes sense to look at all use cases, from server room to client, 3d, media and compute for both. If we could get the capability to run this in some automated fashion, akin to CI, we would even have a chance to keep making good decisions in the future.
Or we do some one off testing for this instance, but we still need a range of workloads and parts to do it properly..
Quoted 8 lines
Quoted 6 lines
I also think the "arms race" scenario isn't really as much of a problem as you think. There aren't _that_ many things using the GPU
at the same time (compared to # of things using CPU). And a lot of
mobile games throttle framerate to avoid draining your battery too quickly (after all, if your battery is dead you can't keep buying loot boxes or whatever).Very good point.
Quoted 7 lines
Quoted 3 lines
On this one I still disagree from the point of view that it does not make it good uapi if we allow everyone to select themselves for priority handling (one flavour or the other).
There is plenty of precedent for userspace giving hints to the kernel about scheduling and freq mgmt. Like schedutil uclamp stuff. Although I think that is all based on cgroups.
I knew about
SCHED_DEADLINEand that it requiresCAP_SYS_NICE, but I did not know about uclamp. Quick experiment with uclampset suggests it indeed does not require elevated privilege. If that is indeed so, it is good enough for me as a precedent.Quoted 6 lines
It appears to work using
sched_setschedulerso maybe could define something similar in i915/xe, per context or per client, not sure.Maybe it would start as a primitive implementation but the uapi would not preclude making it smart(er) afterwards. Or passing along to GuC to do it's thing with it.
Quoted 6 lines
Hmmm having said that, how would we fix clvk performance using that? We would either need the library to do a new step when creating contexts, or allow external control so outside entity can do it. And then the question is based on what it decides to do it? Is it possible to know which, for instance, Chrome tab will be (or is) using clvk so that tab management code does it?
I am not sure.. the clvk usage is, I think, not actually in chrome itself, but something camera related?
Presumably we could build some cgroup knobs to control how the driver reacts to the "deadline" hints (ie. ignore them completely, or impose some upper limit on how much freq boost will be applied, etc). I think this sort of control of how the driver responds to hints probably fits best with cgroups, as that is how we are already implementing similar tuning for cpufreq/sched. (Ie. foreground app or tab gets moved to a different cgroup.) But admittedly I haven't looked too closely at how cgroups work on the kernel side.
BR,
-R
Quoted 23 lines
Regards,
Tvrtko
Quoted 19 lines
Quoted 6 lines
In the fence/syncobj case, I think we need per-wait hints.. because for a single process the driver will be doing both housekeeping waits and potentially urgent waits. There may also be some room for some cgroup or similar knobs to control things like what max priority an app can ask for, and whether or how aggressively the kernel responds to the "deadline" hints. So as far as "arms race", I don't think I'd
Per wait hints are okay I guess even with "I am important" in their name if
sched_setschedulerallows raising uclamp.min just like that. In which case cgroup limits to mimick cpu uclamp also make sense.Quoted 2 lines
change anything about my "fence deadline" proposal.. but that it might just be one piece of the overall puzzle.
That
SCHED_DEADLINErequiresCAP_SYS_NICEdoes not worry you?Regards,
Tvrtko
Quoted 58 lines · Tvrtko Ursulin
Quoted 5 lines · Rob Clark
Quoted 3 lines · Tvrtko Ursulin
On 17/02/2023 20:45, Rodrigo Vivi wrote:
[snip]
Quoted 20 lines
Quoted 20 lines
Yeah I agree. And as not all media use cases are the same, as are not all compute contexts someone somewhere will need to run a series of workloads for power and performance numbers. Ideally that someone would be the entity for which it makes sense to look at all use cases, from server room to client, 3d, media and compute for both. If we could get the capability to run this in some automated fashion, akin to CI, we would even have a chance to keep making good decisions in the future.
Or we do some one off testing for this instance, but we still need a range of workloads and parts to do it properly..
Quoted 8 lines
Quoted 6 lines
I also think the "arms race" scenario isn't really as much of a problem as you think. There aren't _that_ many things using the GPU
at the same time (compared to # of things using CPU). And a lot of
mobile games throttle framerate to avoid draining your battery too quickly (after all, if your battery is dead you can't keep buying loot boxes or whatever).Very good point.
Quoted 7 lines
Quoted 3 lines
On this one I still disagree from the point of view that it does not make it good uapi if we allow everyone to select themselves for priority handling (one flavour or the other).
There is plenty of precedent for userspace giving hints to the kernel about scheduling and freq mgmt. Like schedutil uclamp stuff. Although I think that is all based on cgroups.
I knew about
SCHED_DEADLINEand that it requiresCAP_SYS_NICE, but I did not know about uclamp. Quick experiment with uclampset suggests it indeed does not require elevated privilege. If that is indeed so, it is good enough for me as a precedent.It appears to work using
sched_setschedulerso maybe could define something similar in i915/xe, per context or per client, not sure.Maybe it would start as a primitive implementation but the uapi would not preclude making it smart(er) afterwards. Or passing along to GuC to do it's thing with it.
Quoted 6 lines
In the fence/syncobj case, I think we need per-wait hints.. because for a single process the driver will be doing both housekeeping waits and potentially urgent waits. There may also be some room for some cgroup or similar knobs to control things like what max priority an app can ask for, and whether or how aggressively the kernel responds to the "deadline" hints. So as far as "arms race", I don't think I'd
Quoted 8 lines
Per wait hints are okay I guess even with "I am important" in their name if
sched_setschedulerallows raising uclamp.min just like that. In which case cgroup limits to mimick cpu uclamp also make sense.Quoted 2 lines
change anything about my "fence deadline" proposal.. but that it might just be one piece of the overall puzzle.
That
SCHED_DEADLINErequiresCAP_SYS_NICEdoes not worry you?
This gets to why the name "fence deadline" is perhaps not the best.. it really isn't meant to be analogous to SCHED_DEADLINE, but rather just a hint to the driver about what userspace is doing. Maybe we just document it more strongly as a hint?
BR,
-R
Quoted 3 lines
Regards,
Tvrtko
Quoted 2 lines · Rob Clark
On Fri, Feb 17, 2023 at 8:03 AM Tvrtko Ursulin
<[email protected]> wrote:
[snip]
Quoted 18 lines
Quoted 10 lines
Quoted 9 lines
adapted from your patches.. I think the basic idea of deadlines (which includes "I want it NOW" ;-)) isn't controversial, but the original idea got caught up in some bikeshed (what about compositors that wait on fences in userspace to decide which surfaces to update in the next frame), plus me getting busy and generally not having a good plan for how to leverage this from VM guests (which is becoming increasingly important for CrOS). I think I can build on some ongoing virtgpu fencing improvement work to solve the latter. But now that we have a 2nd use-case for this, it makes sense to respin.
Quoted 7 lines
Sure, I was looking at the old version already. It is interesting. But also IMO needs quite a bit more work to approach achieving what is implied from the name of the feature. It would need proper deadline based sched job picking, and even then drm sched is mostly just a frontend. So once past runnable status and jobs handed over to backend, without further driver work it probably wouldn't be very effective past very lightly loaded systems.
Quoted 1 line
Yes, but all of that is not part of
dma_fence;-)
:) Okay.
Having said that, do we need a step back to think about whether adding deadline to dma-fences is not making them something too much different to what they were? Going from purely synchronisation primitive more towards scheduling paradigms. Just to brainstorm if there will not be any unintended consequences. I should mention this in your RFC thread actually.
Quoted 5 lines
A pretty common challenging usecase is still the single fullscreen game, where scheduling isn't the problem, but landing at an appropriate GPU freq absolutely is. (UI workloads are perhaps more interesting from a scheduler standpoint, but they generally aren't challenging from a load/freq standpoint.)
Challenging as in picking the right operating point? Might be latency impacted (and so user perceived UI smoothness) due missing waitboost for anything syncobj related. I don't know if anything to measure that exists currently though. Assuming it is measurable then the question would be is it perceivable.
Quoted 5 lines
Fwiw, the original motivation of the series was to implement something akin to i915 pageflip boosting without having to abandon the atomic helpers. (And, I guess it would also let i915 preserve that feature if it switched to atomic helpers.. I'm unsure if there are still other things blocking i915's migration.)
Question for display folks I guess.
Quoted 9 lines
Quoted 6 lines
Then if we fast forward to a world where schedulers perhaps become fully deadline aware (we even had this for i915 few years back) then the question will be does equating waits with immediate deadlines still works. Maybe not too well because we wouldn't have the ability to distinguish between the "someone is waiting" signal from the otherwise propagated deadlines.
Is there any other way to handle a wait boost than expressing it as an ASAP deadline?
A leading question or just a question? Nothing springs to my mind at the moment.
Regards,
Tvrtko
Quoted 28 lines · Tvrtko Ursulin
Quoted 2 lines · Rob Clark
On Fri, Feb 17, 2023 at 8:03 AM Tvrtko Ursulin
<[email protected]> wrote:[snip]
Quoted 18 lines
Quoted 10 lines
Quoted 9 lines
adapted from your patches.. I think the basic idea of deadlines (which includes "I want it NOW" ;-)) isn't controversial, but the original idea got caught up in some bikeshed (what about compositors that wait on fences in userspace to decide which surfaces to update in the next frame), plus me getting busy and generally not having a good plan for how to leverage this from VM guests (which is becoming increasingly important for CrOS). I think I can build on some ongoing virtgpu fencing improvement work to solve the latter. But now that we have a 2nd use-case for this, it makes sense to respin.
Quoted 7 lines
Sure, I was looking at the old version already. It is interesting. But also IMO needs quite a bit more work to approach achieving what is implied from the name of the feature. It would need proper deadline based sched job picking, and even then drm sched is mostly just a frontend. So once past runnable status and jobs handed over to backend, without further driver work it probably wouldn't be very effective past very lightly loaded systems.
Quoted 1 line
Yes, but all of that is not part of
dma_fence;-)
Quoted 8 lines
:) Okay.
Having said that, do we need a step back to think about whether adding deadline to dma-fences is not making them something too much different to what they were? Going from purely synchronisation primitive more towards scheduling paradigms. Just to brainstorm if there will not be any unintended consequences. I should mention this in your RFC thread actually.
Perhaps "deadline" isn't quite the right name, but I haven't thought of anything better. It is really a hint to the fence signaller about how soon it is interested in a result so the driver can factor that into freq scaling decisions. Maybe "goal" or some other term would be better?
I guess that can factor into scheduling decisions as well.. but we already have priority for that. My main interest is freq mgmt.
(Thankfully we don't have performance and efficiency cores to worry about, like CPUs ;-))
Quoted 26 lines
Quoted 5 lines
A pretty common challenging usecase is still the single fullscreen game, where scheduling isn't the problem, but landing at an appropriate GPU freq absolutely is. (UI workloads are perhaps more interesting from a scheduler standpoint, but they generally aren't challenging from a load/freq standpoint.)
Challenging as in picking the right operating point? Might be latency impacted (and so user perceived UI smoothness) due missing waitboost for anything syncobj related. I don't know if anything to measure that exists currently though. Assuming it is measurable then the question would be is it perceivable.
Quoted 5 lines
Fwiw, the original motivation of the series was to implement something akin to i915 pageflip boosting without having to abandon the atomic helpers. (And, I guess it would also let i915 preserve that feature if it switched to atomic helpers.. I'm unsure if there are still other things blocking i915's migration.)
Question for display folks I guess.
Quoted 7 lines
Quoted 6 lines
Then if we fast forward to a world where schedulers perhaps become fully deadline aware (we even had this for i915 few years back) then the question will be does equating waits with immediate deadlines still works. Maybe not too well because we wouldn't have the ability to distinguish between the "someone is waiting" signal from the otherwise propagated deadlines.
Quoted 5 lines
Quoted 2 lines
Is there any other way to handle a wait boost than expressing it as an ASAP deadline?
A leading question or just a question? Nothing springs to my mind at the moment.
Just a question. The immediate deadline is the only thing that makes sense to me, but that could be because I'm looking at it from the perspective of also trying to handle the case where missing vblank reduces utilization and provides the wrong signal to gpufreq.. i915 already has a way to handle this internally, but it involves bypassing the atomic helpers, which isn't a thing I want to encourage other drivers to do. And completely doesn't work for situations where the gpu and display are separate devices.
BR,
-R
Quoted 3 lines
Regards,
Tvrtko
Quoted 39 lines · Rob Clark
Quoted 28 lines · Tvrtko Ursulin
Quoted 2 lines · Rob Clark
On Fri, Feb 17, 2023 at 8:03 AM Tvrtko Ursulin
<[email protected]> wrote:[snip]
Quoted 18 lines
Quoted 10 lines
Quoted 9 lines
adapted from your patches.. I think the basic idea of deadlines (which includes "I want it NOW" ;-)) isn't controversial, but the original idea got caught up in some bikeshed (what about compositors that wait on fences in userspace to decide which surfaces to update in the next frame), plus me getting busy and generally not having a good plan for how to leverage this from VM guests (which is becoming increasingly important for CrOS). I think I can build on some ongoing virtgpu fencing improvement work to solve the latter. But now that we have a 2nd use-case for this, it makes sense to respin.
Quoted 7 lines
Sure, I was looking at the old version already. It is interesting. But also IMO needs quite a bit more work to approach achieving what is implied from the name of the feature. It would need proper deadline based sched job picking, and even then drm sched is mostly just a frontend. So once past runnable status and jobs handed over to backend, without further driver work it probably wouldn't be very effective past very lightly loaded systems.
Quoted 1 line
Yes, but all of that is not part of
dma_fence;-)Quoted 8 lines
:) Okay.
Having said that, do we need a step back to think about whether adding deadline to dma-fences is not making them something too much different to what they were? Going from purely synchronisation primitive more towards scheduling paradigms. Just to brainstorm if there will not be any unintended consequences. I should mention this in your RFC thread actually.
Quoted 5 lines
Perhaps "deadline" isn't quite the right name, but I haven't thought of anything better. It is really a hint to the fence signaller about how soon it is interested in a result so the driver can factor that into freq scaling decisions. Maybe "goal" or some other term would be better?
Don't know, no strong opinion on the name at the moment. For me it was more about the change of what type of side channel data is getting attached to dma-fence and whether it changes what the primitive is for.
Quoted 38 lines
I guess that can factor into scheduling decisions as well.. but we already have priority for that. My main interest is freq mgmt.
(Thankfully we don't have performance and efficiency cores to worry about, like CPUs ;-))
Quoted 26 lines
Quoted 5 lines
A pretty common challenging usecase is still the single fullscreen game, where scheduling isn't the problem, but landing at an appropriate GPU freq absolutely is. (UI workloads are perhaps more interesting from a scheduler standpoint, but they generally aren't challenging from a load/freq standpoint.)
Challenging as in picking the right operating point? Might be latency impacted (and so user perceived UI smoothness) due missing waitboost for anything syncobj related. I don't know if anything to measure that exists currently though. Assuming it is measurable then the question would be is it perceivable.
Quoted 5 lines
Fwiw, the original motivation of the series was to implement something akin to i915 pageflip boosting without having to abandon the atomic helpers. (And, I guess it would also let i915 preserve that feature if it switched to atomic helpers.. I'm unsure if there are still other things blocking i915's migration.)
Question for display folks I guess.
Quoted 7 lines
Quoted 6 lines
Then if we fast forward to a world where schedulers perhaps become fully deadline aware (we even had this for i915 few years back) then the question will be does equating waits with immediate deadlines still works. Maybe not too well because we wouldn't have the ability to distinguish between the "someone is waiting" signal from the otherwise propagated deadlines.
Quoted 5 lines
Quoted 2 lines
Is there any other way to handle a wait boost than expressing it as an ASAP deadline?
A leading question or just a question? Nothing springs to my mind at the moment.
Quoted 8 lines
Just a question. The immediate deadline is the only thing that makes sense to me, but that could be because I'm looking at it from the perspective of also trying to handle the case where missing vblank reduces utilization and provides the wrong signal to gpufreq.. i915 already has a way to handle this internally, but it involves bypassing the atomic helpers, which isn't a thing I want to encourage other drivers to do. And completely doesn't work for situations where the gpu and display are separate devices.
Right, there is yet another angle to discuss with Daniel here who AFAIR was a bit against i915 priority inheritance going past a single device instance. In which case DRI_PRIME=1 would lose the ability to boost frame buffer dependency chains. Opens up the question of deadline inheritance across different drivers too. Or perhaps Daniel would be okay with this working if implemented at the dma-fence layer.
Regards,
Tvrtko