Skip to contentSkip to conversation

dmaengine: Actually use devm_add_action_or_reset()

PATCH Applied Andy Shevchenko 2 participants 3 messages Feb 13, 2023 – Mar 17, 2023 dmaengine

lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 dmaengine: Actually use devm_add_action_or_reset()

It appears that the commit a1beaa50b583 ("dmaengine: Simplify dmaenginem_async_device_register() function") mentions devm_add_action_or_reset() the actual change utilised devm_add_action() call by mistake.

Fix the issue by switching to devm_add_action_or_reset().

Fixes a1beaa50b583 ("dmaengine: Simplify dmaenginem_async_device_register() function")
Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/dma/dmaengine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/dmaengine.c +1 -1
index c24bca210104..826b98284fa1 100644
@@ -1342,7 +1342,7 @@ int dmaenginem_async_device_register(struct dma_device *device)
 	if (ret)
 		return ret;
 
-	return devm_add_action(device->dev, dmaenginem_async_device_unregister, device);
+	return devm_add_action_or_reset(device->dev, dmaenginem_async_device_unregister, device);
 }
 EXPORT_SYMBOL(dmaenginem_async_device_register);
Signature · 1 line
2.39.1
author
#1 lore raw
Quoted 6 lines · Andy Shevchenko

It appears that the commit a1beaa50b583 ("dmaengine: Simplify dmaenginem_async_device_register() function") mentions devm_add_action_or_reset() the actual change utilised devm_add_action() call by mistake.

Fix the issue by switching to devm_add_action_or_reset().

Vinod, are you okay with this fix?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer Applied
#2 lore raw
In reply to Andy Shevchenko
Quoted 6 lines · Andy Shevchenko

It appears that the commit a1beaa50b583 ("dmaengine: Simplify dmaenginem_async_device_register() function") mentions devm_add_action_or_reset() the actual change utilised devm_add_action() call by mistake.

Fix the issue by switching to devm_add_action_or_reset().

Applied, thanks

Signature · 1 line
~Vinod