Skip to contentSkip to conversation

power: reset: at91-poweroff: Use devm_platform_get_and_ioremap_resource()

PATCH In review [email protected] 2 participants 2 messages Feb 15, 2023 – Feb 16, 2023

Subsystems (2)
Arm/Microchip (AT91) SoC support System reset/shutdown drivers
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 power: reset: at91-poweroff: Use devm_platform_get_and_ioremap_resource()

From: Ye Xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.

Signed-off-by Ye Xingchen <[email protected]>
---
 drivers/power/reset/at91-poweroff.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/power/reset/at91-poweroff.c +1 -3
index 9e74e131c675..b7e17afe30e2 100644
@@ -151,13 +151,11 @@ static void at91_poweroff_dt_set_wakeup_mode(struct platform_device *pdev)
 
 static int __init at91_poweroff_probe(struct platform_device *pdev)
 {
-	struct resource *res;
 	struct device_node *np;
 	u32 ddr_type;
 	int ret;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	at91_shdwc.shdwc_base = devm_ioremap_resource(&pdev->dev, res);
+	at91_shdwc.shdwc_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
 	if (IS_ERR(at91_shdwc.shdwc_base))
 		return PTR_ERR(at91_shdwc.shdwc_base);
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · On 15.02.2023 08:49, [email protected] wrote:

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

From: Ye Xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.

Signed-off-by Ye Xingchen <[email protected]>
Reviewed-by Claudiu Beznea <[email protected]>
Quoted 25 lines
---
 drivers/power/reset/at91-poweroff.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/power/reset/at91-poweroff.c +1 -4
index 9e74e131c675..b7e17afe30e2 100644
@@ -151,13 +151,11 @@ static void at91_poweroff_dt_set_wakeup_mode(struct platform_device *pdev)
 
 static int __init at91_poweroff_probe(struct platform_device *pdev)
 {
-       struct resource *res;
        struct device_node *np;
        u32 ddr_type;
        int ret;
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       at91_shdwc.shdwc_base = devm_ioremap_resource(&pdev->dev, res);
+       at91_shdwc.shdwc_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
        if (IS_ERR(at91_shdwc.shdwc_base))
                return PTR_ERR(at91_shdwc.shdwc_base);
 
--

2.25.1