net/gve: fix Rx no mbufs stats counter update
PATCH 1/1 net/gve: fix Rx no mbufs stats counter update
rx no_mbufs stats counter update is added for another error case.
--- drivers/net/gve/gve_rx.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/net/gve/gve_rx.c +6 -1
@@ -24,6 +24,7 @@ gve_rx_refill(struct gve_rx_queue *rxq) nmb =rte_pktmbuf_alloc (rxq->mpool);if (!nmb)break ; + rxq->sw_ring[idx + i] = nmb; }if (i != nb_alloc) {
@@ -59,9 +60,13 @@ gve_rx_refill(struct gve_rx_queue *rxq) nmb =rte_pktmbuf_alloc (rxq->mpool);if (!nmb)break ; + rxq->sw_ring[idx + i] = nmb; } - nb_alloc = i; +if (i != nb_alloc) { + rxq->no_mbufs += nb_alloc - i; + nb_alloc = i; + } } rxq->nb_avail -= nb_alloc; next_avail += nb_alloc;
Signature · 1 line
2.37.1 (Apple Git-137.1)
Quoted 15 lines · On Sun, 19 Feb 2023 03:30:59 +0300 Levend Sayar <[email protected]> wrote:
rx
no_mbufsstats counter update is added for another error case.Fixes 4f6b1dd8240c ("net/gve: support basic statistics")Signed-off-by Levend Sayar <[email protected]>--- drivers/net/gve/gve_rx.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/net/gve/gve_rx.c +0
-0
drivers/net/gve/gve_rx.c gve_rx_refill(struct gve_rx_queue *rxq) · line 30
Quoted 7 lines
drivers/net/gve/gve_rx.c +1
-0@@ -24,6 +24,7 @@ gve_rx_refill(struct gve_rx_queue *rxq) nmb =rte_pktmbuf_alloc (rxq->mpool);if (!nmb)break ; + rxq->sw_ring[idx + i] = nmb; }if (i != nb_alloc) {
Looks like accidental whitespace change included in this patch.
drivers/net/gve/gve_rx.c gve_rx_refill(struct gve_rx_queue *rxq) · line 69
Quoted 12 lines
drivers/net/gve/gve_rx.c +5
-1@@ -59,9 +60,13 @@ gve_rx_refill(struct gve_rx_queue *rxq) nmb =rte_pktmbuf_alloc (rxq->mpool);if (!nmb)break ; + rxq->sw_ring[idx + i] = nmb; } - nb_alloc = i; +if (i != nb_alloc) { + rxq->no_mbufs += nb_alloc - i; + nb_alloc = i; + }
Would be better to add unlikely() here like:
if (unlikely(i < nb_alloc)) {
rxq->no_mbufs += nb_alloc - i;
nb_alloc = i;
}Or eliminate conditional branch in hot path completely.
rxq->no_mbufs += nb_alloc - i; nb_alloc = i;
Or better yet refactor code here to use rte_pktmbuf_alloc_bulk() which does single ring operation.
Quoted 3 lines
drivers/net/gve/gve_rx.c +0
-0} rxq->nb_avail -= nb_alloc; next_avail += nb_alloc;
Quoted 17 lines · Stephen Hemminger
Quoted 10 lines · On Sun, 19 Feb 2023 03:30:59 +0300 Levend Sayar <[email protected]…
rx
no_mbufsstats counter update is added for another error case.Fixes 4f6b1dd8240c ("net/gve: support basic statistics")Signed-off-by Levend Sayar <[email protected]>---
drivers/net/gve/gve_rx.c| 7 ++++++-1 file changed, 6 insertions(+), 1 deletion(-)
Quoted 14 lines
drivers/net/gve/gve_rx.c gve_rx_refill(struct gve_rx_queue *rxq) · line 30
Quoted 12 lines
drivers/net/gve/gve_rx.c +1
-0@@ -24,6 +24,7 @@ gve_rx_refill(struct gve_rx_queue *rxq) nmb =rte_pktmbuf_alloc (rxq->mpool);if (!nmb)break ; + rxq->sw_ring[idx + i] = nmb; }if (i != nb_alloc) {Looks like accidental whitespace change included in this patch.
LS: Right. Let me correct.
Quoted 19 lines
drivers/net/gve/gve_rx.c gve_rx_refill(struct gve_rx_queue *rxq) · line 69
Quoted 12 lines
drivers/net/gve/gve_rx.c +5
-1@@ -59,9 +60,13 @@ gve_rx_refill(struct gve_rx_queue *rxq) nmb =rte_pktmbuf_alloc (rxq->mpool);if (!nmb)break ; + rxq->sw_ring[idx + i] = nmb; } - nb_alloc = i; +if (i != nb_alloc) { + rxq->no_mbufs += nb_alloc - i; + nb_alloc = i; + }Would be better to add
unlikely()here like:if (unlikely(i < nb_alloc)) { rxq->no_mbufs += nb_alloc - i; nb_alloc = i; }
Quoted 10 lines
Or eliminate conditional branch in hot path completely.
rxq->no_mbufs += nb_alloc - i; nb_alloc = i;Or better yet refactor code here to use
rte_pktmbuf_alloc_bulk()which does single ring operation.Quoted 3 lines
drivers/net/gve/gve_rx.c +0
-0} rxq->nb_avail -= nb_alloc; next_avail += nb_alloc;
LS: “unlikely” can be added. You’re right. Code already tries to make a bulk allocation first. If that bulk allocation does not work, it tries to allocate one my one.
I will supersede this one and create v2.
Thanks Stephen.
Best,
Levend
Quoted 2 lines · On Sun, 19 Feb 2023 23:43:08 +0300 Levend Sayar <[email protected]> wrote:
LS: “unlikely” can be added. You’re right. Code already tries to make a bulk allocation first. If that bulk allocation does not work, it tries to allocate one my one.
That seems like a unnecessary step and unlikely to help. Unless the user abuses driver by giving a very small mbuf pool.
PATCH v2 1/1 net/gve: fix Rx no mbufs stats counter update
In reply to Levend Sayarrx no_mbufs stats counter update is added for another error case.
--- drivers/net/gve/gve_rx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/net/gve/gve_rx.c +4 -1
@@ -61,7 +61,10 @@ gve_rx_refill(struct gve_rx_queue *rxq)break ; rxq->sw_ring[idx + i] = nmb; } - nb_alloc = i; +if (i != nb_alloc) { + rxq->no_mbufs += nb_alloc - i; + nb_alloc = i; + } } rxq->nb_avail -= nb_alloc; next_avail += nb_alloc;
Signature · 1 line
2.37.1 (Apple Git-137.1)
PATCH v3 1/2 net/gve: fix Rx no mbufs stats counter update
rx no_mbufs stats counter update is added for another error case.
--- drivers/net/gve/gve_rx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/net/gve/gve_rx.c +4 -1
@@ -61,7 +61,10 @@ gve_rx_refill(struct gve_rx_queue *rxq)break ; rxq->sw_ring[idx + i] = nmb; } - nb_alloc = i; +if (i != nb_alloc) { + rxq->no_mbufs += nb_alloc - i; + nb_alloc = i; + } } rxq->nb_avail -= nb_alloc; next_avail += nb_alloc;
Signature · 1 line
2.37.1 (Apple Git-137.1)
PATCH v3 2/2 net/gve: add Rx/Tx queue stats as extended stats
Google Virtual NIC rx/tx queue stats are added as extended stats.
--- drivers/net/gve/gve_ethdev.c | 143 +++++++++++++++++++++++++++++++---- drivers/net/gve/gve_ethdev.h | 27 +++++-- drivers/net/gve/gve_rx.c | 10 +-- drivers/net/gve/gve_tx.c | 11 +-- 4 files changed, 160 insertions(+), 31 deletions(-)
drivers/net/gve/gve_ethdev.c +129 -14
@@ -9,6 +9,18 @@const char gve_version_str[] =GVE_VERSION ;static const char gve_version_prefix[] =GVE_VERSION_PREFIX ; +static const struct gve_xstats_name_offset tx_xstats_name_offset[] = { + {"packets" , offsetof(struct gve_tx_stats , packets) }, + {"bytes" , offsetof(struct gve_tx_stats , bytes) }, + {"errors" , offsetof(struct gve_tx_stats , errors) }, +}; + +static const struct gve_xstats_name_offset rx_xstats_name_offset[] = { + {"packets" , offsetof(struct gve_rx_stats , packets) }, + {"bytes" , offsetof(struct gve_rx_stats , bytes) }, + {"errors" , offsetof(struct gve_rx_stats , errors) }, +}; +static void gve_write_version (uint8_t *driver_version_register) {
@@ -328,9 +340,9 @@ gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)if (txq ==NULL )continue ; - stats->opackets += txq->packets; - stats->obytes += txq->bytes; - stats->oerrors += txq->errors; + stats->opackets += txq->stats.packets; + stats->obytes += txq->stats.bytes; + stats->oerrors += txq->stats.errors; }for (i =0 ; i < dev->data->nb_rx_queues; i++) {
@@ -338,10 +350,10 @@ gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)if (rxq ==NULL )continue ; - stats->ipackets += rxq->packets; - stats->ibytes += rxq->bytes; - stats->ierrors += rxq->errors; - stats->rx_nombuf += rxq->no_mbufs; + stats->ipackets += rxq->stats.packets; + stats->ibytes += rxq->stats.bytes; + stats->ierrors += rxq->stats.errors; + stats->rx_nombuf += rxq->stats.no_mbufs; }return 0 ;
@@ -357,9 +369,7 @@ gve_dev_stats_reset(struct rte_eth_dev *dev)if (txq ==NULL )continue ; - txq->packets =0 ; - txq->bytes =0 ; - txq->errors =0 ; +memset (&txq->stats,0 ,sizeof (txq->stats)); }for (i =0 ; i < dev->data->nb_rx_queues; i++) {
@@ -367,10 +377,7 @@ gve_dev_stats_reset(struct rte_eth_dev *dev)if (rxq ==NULL )continue ; - rxq->packets =0 ; - rxq->bytes =0 ; - rxq->errors =0 ; - rxq->no_mbufs =0 ; +memset (&rxq->stats,0 ,sizeof (rxq->stats)); }return 0 ;
@@ -403,6 +410,112 @@ gve_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)return 0 ; } +static int +gve_xstats_count (struct rte_eth_dev *dev) +{ +uint16_t i, count =0 ; + +for (i =0 ; i < dev->data->nb_tx_queues; i++) { +if (dev->data->tx_queues[i]) + count +=RTE_DIM (tx_xstats_name_offset); + } + +for (i =0 ; i < dev->data->nb_rx_queues; i++) { +if (dev->data->rx_queues[i]) + count +=RTE_DIM (rx_xstats_name_offset); + } + +return count; +} + +static int +gve_xstats_get (struct rte_eth_dev *dev, +struct rte_eth_xstat *xstats, +unsigned int size) +{ +uint16_t i, count =0 ; + +if (!xstats) +return (size ==0 ) ?gve_xstats_count (dev) : -EINVAL ; + +for (i =0 ; i < dev->data->nb_tx_queues; i++) { +const struct gve_tx_queue *txq = dev->data->tx_queues[i]; +if (!txq) +continue ; + +if (count >= size) +break ; + +uint16_t j =0 ; +const char *stats = (const char *)&txq->stats; +for (j =0 ; j <RTE_DIM (tx_xstats_name_offset); j++, count++) { + xstats[count].id = count; + xstats[count].value = *(const uint64_t *) + (stats + tx_xstats_name_offset[j].offset); + } + } + +for (i =0 ; i < dev->data->nb_rx_queues; i++) { +const struct gve_rx_queue *rxq = dev->data->rx_queues[i]; +if (!rxq) +continue ; + +if (count >= size) +break ; + +uint16_t j =0 ; +const char *stats = (const char *)&rxq->stats; +for (j =0 ; j <RTE_DIM (rx_xstats_name_offset); j++, count++) { + xstats[count].id = count; + xstats[count].value = *(const uint64_t *) + (stats + rx_xstats_name_offset[j].offset); + } + } + +return count; +} + +static int +gve_xstats_get_names (struct rte_eth_dev *dev, +struct rte_eth_xstat_name *xstats_names, +unsigned int size) +{ +uint16_t i, count =0 ; + +if (!xstats_names) +return (size ==0 ) ?gve_xstats_count (dev) : -EINVAL ; + +for (i =0 ; i < dev->data->nb_tx_queues; i++) { +if (!dev->data->tx_queues[i]) +continue ; + +if (count >= size) +break ; + +uint16_t j =0 ; +for (; j <RTE_DIM (tx_xstats_name_offset); j++) +snprintf (xstats_names[count++].name, +RTE_ETH_XSTATS_NAME_SIZE , +"tx_q%u_%s" , i, tx_xstats_name_offset[j].name); + } + +for (i =0 ; i < dev->data->nb_rx_queues; i++) { +if (!dev->data->rx_queues[i]) +continue ; + +if (count >= size) +break ; + +uint16_t j =0 ; +for (; j <RTE_DIM (rx_xstats_name_offset); j++) +snprintf (xstats_names[count++].name, +RTE_ETH_XSTATS_NAME_SIZE , +"rx_q%u_%s" , i, rx_xstats_name_offset[j].name); + } + +return count; +} +static const struct eth_dev_ops gve_eth_dev_ops = { .dev_configure = gve_dev_configure, .dev_start = gve_dev_start,
@@ -417,6 +530,8 @@ static const struct eth_dev_ops gve_eth_dev_ops = { .stats_get = gve_dev_stats_get, .stats_reset = gve_dev_stats_reset, .mtu_set = gve_dev_mtu_set, + .xstats_get = gve_xstats_get, + .xstats_get_names = gve_xstats_get_names, }; static void
drivers/net/gve/gve_ethdev.h +20 -7
@@ -67,6 +67,24 @@ struct gve_tx_iovec {uint32_t iov_len; }; +struct gve_tx_stats { +uint64_t packets; +uint64_t bytes; +uint64_t errors; +}; + +struct gve_rx_stats { +uint64_t packets; +uint64_t bytes; +uint64_t errors; +uint64_t no_mbufs; +}; + +struct gve_xstats_name_offset { +char name[RTE_ETH_XSTATS_NAME_SIZE ]; +unsigned int offset; +}; +struct gve_tx_queue {volatile union gve_tx_desc *tx_desc_ring;const struct rte_memzone *mz;
@@ -93,9 +111,7 @@ struct gve_tx_queue {struct gve_tx_iovec *iov_ring;/* stats items */ -uint64_t packets; -uint64_t bytes; -uint64_t errors; +struct gve_tx_stats stats;uint16_t port_id;uint16_t queue_id;
@@ -136,10 +152,7 @@ struct gve_rx_queue {struct gve_queue_page_list *qpl;/* stats items */ -uint64_t packets; -uint64_t bytes; -uint64_t errors; -uint64_t no_mbufs; +struct gve_rx_stats stats;struct gve_priv *hw;const struct rte_memzone *qres_mz;
drivers/net/gve/gve_rx.c +5 -5
@@ -27,7 +27,7 @@ gve_rx_refill(struct gve_rx_queue *rxq) rxq->sw_ring[idx + i] = nmb; }if (i != nb_alloc) { - rxq->no_mbufs += nb_alloc - i; + rxq->stats.no_mbufs += nb_alloc - i; nb_alloc = i; } }
@@ -62,7 +62,7 @@ gve_rx_refill(struct gve_rx_queue *rxq) rxq->sw_ring[idx + i] = nmb; }if (i != nb_alloc) { - rxq->no_mbufs += nb_alloc - i; + rxq->stats.no_mbufs += nb_alloc - i; nb_alloc = i; } }
@@ -106,7 +106,7 @@ gve_rx_burst(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)break ;if (rxd->flags_seq &GVE_RXF_ERR ) { - rxq->errors++; + rxq->stats.errors++;continue ; }
@@ -154,8 +154,8 @@ gve_rx_burst(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)gve_rx_refill (rxq);if (nb_rx) { - rxq->packets += nb_rx; - rxq->bytes += bytes; + rxq->stats.packets += nb_rx; + rxq->stats.bytes += bytes; }return nb_rx;
drivers/net/gve/gve_tx.c +6 -5
@@ -366,9 +366,9 @@ gve_tx_burst_qpl(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) txq->tx_tail = tx_tail; txq->sw_tail = sw_id; - txq->packets += nb_tx; - txq->bytes += bytes; - txq->errors += nb_pkts - nb_tx; + txq->stats.packets += nb_tx; + txq->stats.bytes += bytes; + txq->stats.errors += nb_pkts - nb_tx; }return nb_tx;
@@ -455,8 +455,9 @@ gve_tx_burst_ra(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)rte_write32 (rte_cpu_to_be_32 (tx_tail), txq->qtx_tail); txq->tx_tail = tx_tail; - txq->packets += nb_tx; - txq->bytes += bytes; + txq->stats.packets += nb_tx; + txq->stats.bytes += bytes; + txq->stats.errors += nb_pkts - nb_tx; }return nb_tx;
Signature · 1 line
2.37.1 (Apple Git-137.1)
Re: [PATCH v3 2/2] net/gve: add Rx/Tx queue stats as extended stats
Quoted 3 lines · Levend Sayar
Google Virtual NIC rx/tx queue stats are added as extended stats.
Signed-off-by Levend Sayar <[email protected]>
Thank you for the update, mainly looks good to me, there area a few minor questions/comments below.
<...>
drivers/net/gve/gve_ethdev.c line 17
Quoted 6 lines
drivers/net/gve/gve_ethdev.c +6
-0+static const struct gve_xstats_name_offset tx_xstats_name_offset[] = { + {"packets" , offsetof(struct gve_tx_stats , packets) }, + {"bytes" , offsetof(struct gve_tx_stats , bytes) }, + {"errors" , offsetof(struct gve_tx_stats , errors) }, +}; +
It is possible to create macros to get offsets to prevent any mistakes but not quite sure if it is needed with above limited number of items, so up to you, I mean something like:
#define RX_QUEUE_STATS_OFFSET(x) offsetof(struct gve_rx_stats, X) #define TX_QUEUE_STATS_OFFSET(x) offsetof(struct gve_tx_stats, X)
drivers/net/gve/gve_ethdev.c line 23
Quoted 6 lines
drivers/net/gve/gve_ethdev.c +6
-0+static const struct gve_xstats_name_offset rx_xstats_name_offset[] = { + {"packets" , offsetof(struct gve_rx_stats , packets) }, + {"bytes" , offsetof(struct gve_rx_stats , bytes) }, + {"errors" , offsetof(struct gve_rx_stats , errors) }, +}; +
Is 'no_mbufs' omitted intentionally?
<...>
drivers/net/gve/gve_ethdev.c gve_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) · line 419
Quoted 8 lines
drivers/net/gve/gve_ethdev.c +7
-0+static int +gve_xstats_count (struct rte_eth_dev *dev) +{ +uint16_t i, count =0 ; + +for (i =0 ; i < dev->data->nb_tx_queues; i++) { +if (dev->data->tx_queues[i])
Normally 'dev->data->tx_queues[i]' shouldn't be NULL, but I can see driver checks this in a few locations.
Is there a case that 'dev->data->tx_queues[i]' can be NULL where "0 <= i < dev->data->nb_tx_queues" ?
Quoted 10 lines
drivers/net/gve/gve_ethdev.c +10
-0+ count +=RTE_DIM (tx_xstats_name_offset); + } + +for (i =0 ; i < dev->data->nb_rx_queues; i++) { +if (dev->data->rx_queues[i]) + count +=RTE_DIM (rx_xstats_name_offset); + } + +return count; +}
drivers/net/gve/gve_ethdev.c gve_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) · line 439
Quoted 10 lines
drivers/net/gve/gve_ethdev.c +10
-0+ +static int +gve_xstats_get (struct rte_eth_dev *dev, +struct rte_eth_xstat *xstats, +unsigned int size) +{ +uint16_t i, count =0 ; + +if (!xstats) +return (size ==0 ) ?gve_xstats_count (dev) : -EINVAL ;
Error case (xstats == NULL && size != 0) should be handled by ethdev, so driver can only check "xstats == NULL" case.
btw, although we have mixed usage and not very strict on it, coding convention requires testing against NULL [1] instead of '!'.
[1]
https://doc.dpdk.org/guides/contributing/coding_style.html#null-pointers
drivers/net/gve/gve_ethdev.c gve_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) · line 445
Quoted 6 lines
drivers/net/gve/gve_ethdev.c +6
-0+ +for (i =0 ; i < dev->data->nb_tx_queues; i++) { +const struct gve_tx_queue *txq = dev->data->tx_queues[i]; +if (!txq) +continue ; +
similar to above comment, I expect 'txq' not to be NULL, isn't this correct for the driver?
drivers/net/gve/gve_ethdev.c gve_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) · line 448
Quoted 3 lines
drivers/net/gve/gve_ethdev.c +3
-0+if (count >= size) +break ; +
Instead of above check in a loop, it is possible to check once at the beginning of the function like
count = gve_xstats_count(dev)
if (size < count)
return count;
Because when there is not enough room in the xstats array, API doesn't expect existing elements of array to be correct, returning a value bigger than 'size' indicates error case and content of xstats is invalid anyway.
drivers/net/gve/gve_ethdev.c gve_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) · line 450
Quoted 2 lines
drivers/net/gve/gve_ethdev.c +2
-0+uint16_t j =0 ; +const char *stats = (const char *)&txq->stats;
Can you please move variable declarations at the beginning of the scope, for above variables it is just after for statement, according coding convention.
Quoted 58 lines
drivers/net/gve/gve_ethdev.c +58
-0+for (j =0 ; j <RTE_DIM (tx_xstats_name_offset); j++, count++) { + xstats[count].id = count; + xstats[count].value = *(const uint64_t *) + (stats + tx_xstats_name_offset[j].offset); + } + } + +for (i =0 ; i < dev->data->nb_rx_queues; i++) { +const struct gve_rx_queue *rxq = dev->data->rx_queues[i]; +if (!rxq) +continue ; + +if (count >= size) +break ; + +uint16_t j =0 ; +const char *stats = (const char *)&rxq->stats; +for (j =0 ; j <RTE_DIM (rx_xstats_name_offset); j++, count++) { + xstats[count].id = count; + xstats[count].value = *(const uint64_t *) + (stats + rx_xstats_name_offset[j].offset); + } + } + +return count; +} + +static int +gve_xstats_get_names (struct rte_eth_dev *dev, +struct rte_eth_xstat_name *xstats_names, +unsigned int size) +{ +uint16_t i, count =0 ; + +if (!xstats_names) +return (size ==0 ) ?gve_xstats_count (dev) : -EINVAL ; + +for (i =0 ; i < dev->data->nb_tx_queues; i++) { +if (!dev->data->tx_queues[i]) +continue ; + +if (count >= size) +break ; + +uint16_t j =0 ; +for (; j <RTE_DIM (tx_xstats_name_offset); j++) +snprintf (xstats_names[count++].name, +RTE_ETH_XSTATS_NAME_SIZE , +"tx_q%u_%s" , i, tx_xstats_name_offset[j].name); + } + +for (i =0 ; i < dev->data->nb_rx_queues; i++) { +if (!dev->data->rx_queues[i]) +continue ; + +if (count >= size) +break ; +
drivers/net/gve/gve_ethdev.c gve_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) · line 518
Quoted 10 lines
drivers/net/gve/gve_ethdev.c +10
-0+uint16_t j =0 ; +for (; j <RTE_DIM (rx_xstats_name_offset); j++) +snprintf (xstats_names[count++].name, +RTE_ETH_XSTATS_NAME_SIZE , +"rx_q%u_%s" , i, rx_xstats_name_offset[j].name); + } + +return count; +} +
comments on 'gve_xstats_get()' valid here too.
Quoted 16 lines · Levend Sayar
rx
no_mbufsstats counter update is added for another error case.Fixes 4f6b1dd8240c ("net/gve: support basic statistics")Signed-off-by Levend Sayar <[email protected]>--- drivers/net/gve/gve_rx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/net/gve/gve_rx.c +0
-0@@ -61,7 +61,10 @@ gve_rx_refill(struct gve_rx_queue *rxq)break ;
drivers/net/gve/gve_rx.c gve_rx_refill(struct gve_rx_queue *rxq) · line 70
Quoted 10 lines
drivers/net/gve/gve_rx.c +4
-1rxq->sw_ring[idx + i] = nmb; } - nb_alloc = i; +if (i != nb_alloc) { + rxq->no_mbufs += nb_alloc - i; + nb_alloc = i; + } } rxq->nb_avail -= nb_alloc; next_avail += nb_alloc;
Looks good to me,
there was a comment from Stephen to add 'unlikely()', is that issue resolved?
Not only this if, there can be many places to add such branch prediction helpers On the gve pmd code.
I preferred to patch only the bug here and not used unlikely to minimize noise.
Imho, adding likely/unlikely to all gve pmd code can be topic of another patch maybe.
Levend
Quoted 33 lines · Ferruh Yigit
Quoted 16 lines · Levend Sayar
rx
no_mbufsstats counter update is added for another error case.Fixes 4f6b1dd8240c ("net/gve: support basic statistics")Signed-off-by Levend Sayar <[email protected]>---
drivers/net/gve/gve_rx.c| 5 ++++-1 file changed, 4 insertions(+), 1 deletion(-)drivers/net/gve/gve_rx.c +0
-0@@ -61,7 +61,10 @@ gve_rx_refill(struct gve_rx_queue *rxq)break ;drivers/net/gve/gve_rx.c gve_rx_refill(struct gve_rx_queue *rxq) · line 70
Quoted 10 lines
drivers/net/gve/gve_rx.c +4
-1rxq->sw_ring[idx + i] = nmb; } - nb_alloc = i; +if (i != nb_alloc) { + rxq->no_mbufs += nb_alloc - i; + nb_alloc = i; + } } rxq->nb_avail -= nb_alloc; next_avail += nb_alloc;Looks good to me,
there was a comment from Stephen to add 'unlikely()', is that issue resolved?
Quoted 7 lines · Levend Sayar
Not only this if, there can be many places to add such branch prediction helpers On the gve pmd code.
I preferred to patch only the bug here and not used unlikely to minimize noise.
Imho, adding likely/unlikely to all gve pmd code can be topic of another patch maybe.
ack, sounds reasonable to me
Quoted 36 lines
Levend
Quoted 33 lines · Ferruh Yigit
Quoted 16 lines · Levend Sayar
rx
no_mbufsstats counter update is added for another error case.Fixes 4f6b1dd8240c ("net/gve: support basic statistics")Signed-off-by Levend Sayar <[email protected]>---
drivers/net/gve/gve_rx.c| 5 ++++-1 file changed, 4 insertions(+), 1 deletion(-)drivers/net/gve/gve_rx.c +0
-0@@ -61,7 +61,10 @@ gve_rx_refill(struct gve_rx_queue *rxq)break ;drivers/net/gve/gve_rx.c gve_rx_refill(struct gve_rx_queue *rxq) · line 70
Quoted 10 lines
drivers/net/gve/gve_rx.c +4
-1rxq->sw_ring[idx + i] = nmb; } - nb_alloc = i; +if (i != nb_alloc) { + rxq->no_mbufs += nb_alloc - i; + nb_alloc = i; + } } rxq->nb_avail -= nb_alloc; next_avail += nb_alloc;Looks good to me,
there was a comment from Stephen to add 'unlikely()', is that issue resolved?
Re: [PATCH v3 2/2] net/gve: add Rx/Tx queue stats as extended stats
In reply to Ferruh YigitThanks Ferruh for the review.
My comments are inlined.
Quoted 22 lines · Ferruh Yigit
Quoted 3 lines · Levend Sayar
Google Virtual NIC rx/tx queue stats are added as extended stats.
Signed-off-by Levend Sayar <[email protected]>Thank you for the update, mainly looks good to me, there area a few minor questions/comments below.
<...>
drivers/net/gve/gve_ethdev.c line 17
Quoted 6 lines
drivers/net/gve/gve_ethdev.c +6
-0+static const struct gve_xstats_name_offset tx_xstats_name_offset[] = { + {"packets" , offsetof(struct gve_tx_stats , packets) }, + {"bytes" , offsetof(struct gve_tx_stats , bytes) }, + {"errors" , offsetof(struct gve_tx_stats , errors) }, +}; +It is possible to create macros to get offsets to prevent any mistakes but not quite sure if it is needed with above limited number of items, so up to you, I mean something like:
Quoted 3 lines
#define
RX_QUEUE_STATS_OFFSET(x)offsetof(struct gve_rx_stats, X)#defineTX_QUEUE_STATS_OFFSET(x)offsetof(struct gve_tx_stats, X)
LS: I take dpdk code as reference and mimicked the usage on rte_ethdev.c here.
Your proposal surely applicable.
Quoted 10 lines
drivers/net/gve/gve_ethdev.c line 23
Quoted 6 lines
drivers/net/gve/gve_ethdev.c +6
-0+static const struct gve_xstats_name_offset rx_xstats_name_offset[] = { + {"packets" , offsetof(struct gve_rx_stats , packets) }, + {"bytes" , offsetof(struct gve_rx_stats , bytes) }, + {"errors" , offsetof(struct gve_rx_stats , errors) }, +}; +Is '
no_mbufs' omitted intentionally?<...>
LS: no_mbufs are accumulated as rx_mbuf_allocation_errors on basic stats. But yes, it can be queue based also.
Quoted 12 lines
drivers/net/gve/gve_ethdev.c gve_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) · line 419
Quoted 8 lines
drivers/net/gve/gve_ethdev.c +7
-0+static int +gve_xstats_count (struct rte_eth_dev *dev) +{ +uint16_t i, count =0 ; + +for (i =0 ; i < dev->data->nb_tx_queues; i++) { +if (dev->data->tx_queues[i])Normally 'dev->data->tx_queues[i]' shouldn't be NULL, but I can see driver checks this in a few locations.
Quoted 2 lines
Is there a case that 'dev->data->tx_queues[i]' can be NULL where "0 <= i <
dev->data->nb_tx_queues" ?
LS: You’re right. On my previous patches I erased that checks but that parts are reviewed as noise.
So I am aligned with the rest of the code. In fact, there is no gap like that. In dev_start, Queues are created and whenever queue can not be created, it returns error at that point.
So dev_start will return an error at the end. So if device successfully started, all rx/tx queues must be created Successfully. Therefore no need to check.
Quoted 25 lines
Quoted 11 lines
drivers/net/gve/gve_ethdev.c +10
-0+ count +=RTE_DIM (tx_xstats_name_offset); + } + +for (i =0 ; i < dev->data->nb_rx_queues; i++) { +if (dev->data->rx_queues[i]) + count +=RTE_DIM (rx_xstats_name_offset); + } + +return count; +}drivers/net/gve/gve_ethdev.c gve_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) · line 439
Quoted 10 lines
drivers/net/gve/gve_ethdev.c +10
-0+ +static int +gve_xstats_get (struct rte_eth_dev *dev, +struct rte_eth_xstat *xstats, +unsigned int size) +{ +uint16_t i, count =0 ; + +if (!xstats) +return (size ==0 ) ?gve_xstats_count (dev) : -EINVAL ;Error case (xstats == NULL && size != 0) should be handled by ethdev, so driver can only check "xstats == NULL" case.
Quoted 5 lines
btw, although we have mixed usage and not very strict on it, coding convention requires testing against NULL [1] instead of '!'.
[1]
https://doc.dpdk.org/guides/contributing/coding_style.html#null-pointers
LS: You’re right. rte_eth_xstats_get checks for (xstats == NULL && size != 0).
Let me correct that part and use NULL.
Quoted 18 lines
drivers/net/gve/gve_ethdev.c gve_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) · line 445
Quoted 7 lines
drivers/net/gve/gve_ethdev.c +6
-0+ +for (i =0 ; i < dev->data->nb_tx_queues; i++) { +const struct gve_tx_queue *txq = dev->data->tx_queues[i]; +if (!txq) +continue ; +similar to above comment, I expect 'txq' not to be NULL, isn't this correct for the driver?
drivers/net/gve/gve_ethdev.c gve_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) · line 448
Quoted 3 lines
drivers/net/gve/gve_ethdev.c +3
-0+if (count >= size) +break ; +Instead of above check in a loop, it is possible to check once at the beginning of the function like
Quoted 8 lines
count =
gve_xstats_count(dev)
if (size < count)return count;Because when there is not enough room in the xstats array, API doesn't expect existing elements of array to be correct, returning a value bigger than 'size' indicates error case and content of xstats is invalid anyway.
LS: Let’s say NIC has 20 xstats. Your application allocates xstats memory enough to hold 30 and request 30 xtstats. NIC will return 20 xstats. That’s ok. But if application allocates memory For 10 xstats and request 10, it’s taken as error although Nic can fill first 10 xstats. So size must be higher or equal to number of xstats. Right?
Quoted 7 lines
drivers/net/gve/gve_ethdev.c gve_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) · line 450
Quoted 3 lines
drivers/net/gve/gve_ethdev.c +2
-0+uint16_t j =0 ; +const char *stats = (const char *)&txq->stats;Can you please move variable declarations at the beginning of the scope, for above variables it is just after for statement, according coding convention.
LS: Sure I can do. I supposed minimizing scope is better approach.
But not here I guess. What is the rationale behind not declaring a variable in a for loop like? for (int i =0 ...
That’s a quite surprise for me when I got an error from checkpatches.sh.
Quoted 72 lines
Quoted 59 lines
drivers/net/gve/gve_ethdev.c +58
-0+for (j =0 ; j <RTE_DIM (tx_xstats_name_offset); j++, count++) { + xstats[count].id = count; + xstats[count].value = *(const uint64_t *) + (stats + tx_xstats_name_offset[j].offset); + } + } + +for (i =0 ; i < dev->data->nb_rx_queues; i++) { +const struct gve_rx_queue *rxq = dev->data->rx_queues[i]; +if (!rxq) +continue ; + +if (count >= size) +break ; + +uint16_t j =0 ; +const char *stats = (const char *)&rxq->stats; +for (j =0 ; j <RTE_DIM (rx_xstats_name_offset); j++, count++) { + xstats[count].id = count; + xstats[count].value = *(const uint64_t *) + (stats + rx_xstats_name_offset[j].offset); + } + } + +return count; +} + +static int +gve_xstats_get_names (struct rte_eth_dev *dev, +struct rte_eth_xstat_name *xstats_names, +unsigned int size) +{ +uint16_t i, count =0 ; + +if (!xstats_names) +return (size ==0 ) ?gve_xstats_count (dev) : -EINVAL ; + +for (i =0 ; i < dev->data->nb_tx_queues; i++) { +if (!dev->data->tx_queues[i]) +continue ; + +if (count >= size) +break ; + +uint16_t j =0 ; +for (; j <RTE_DIM (tx_xstats_name_offset); j++) +snprintf (xstats_names[count++].name, +RTE_ETH_XSTATS_NAME_SIZE , +"tx_q%u_%s" , i, tx_xstats_name_offset[j].name); + } + +for (i =0 ; i < dev->data->nb_rx_queues; i++) { +if (!dev->data->rx_queues[i]) +continue ; + +if (count >= size) +break ; +drivers/net/gve/gve_ethdev.c gve_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) · line 518
Quoted 10 lines
drivers/net/gve/gve_ethdev.c +10
-0+uint16_t j =0 ; +for (; j <RTE_DIM (rx_xstats_name_offset); j++) +snprintf (xstats_names[count++].name, +RTE_ETH_XSTATS_NAME_SIZE , +"rx_q%u_%s" , i, rx_xstats_name_offset[j].name); + } + +return count; +} +comments on '
gve_xstats_get()' valid here too.
PATCH v4 1/1 net/gve: add Rx/Tx queue stats as extended stats
In reply to Levend SayarGoogle Virtual NIC rx/tx queue stats are added as extended stats.
--- drivers/net/gve/gve_ethdev.c | 137 +++++++++++++++++++++++++++++++---- drivers/net/gve/gve_ethdev.h | 28 +++++-- drivers/net/gve/gve_rx.c | 12 +-- drivers/net/gve/gve_tx.c | 11 +-- 4 files changed, 157 insertions(+), 31 deletions(-)
drivers/net/gve/gve_ethdev.c +123 -14
@@ -6,9 +6,26 @@#include "base/gve_adminq.h" #include "base/gve_register.h" +#define TX_QUEUE_STATS_OFFSET (x) offsetof(struct gve_tx_stats, x) +#define RX_QUEUE_STATS_OFFSET (x) offsetof(struct gve_rx_stats, x) +const char gve_version_str[] =GVE_VERSION ;static const char gve_version_prefix[] =GVE_VERSION_PREFIX ; +static const struct gve_xstats_name_offset tx_xstats_name_offset[] = { + {"packets" ,TX_QUEUE_STATS_OFFSET (packets) }, + {"bytes" ,TX_QUEUE_STATS_OFFSET (bytes) }, + {"errors" ,TX_QUEUE_STATS_OFFSET (errors) }, +}; + +static const struct gve_xstats_name_offset rx_xstats_name_offset[] = { + {"packets" ,RX_QUEUE_STATS_OFFSET (packets) }, + {"bytes" ,RX_QUEUE_STATS_OFFSET (bytes) }, + {"errors" ,RX_QUEUE_STATS_OFFSET (errors) }, + {"mbuf_alloc_errors" ,RX_QUEUE_STATS_OFFSET (no_mbufs) }, + {"mbuf_alloc_errors_bulk" ,RX_QUEUE_STATS_OFFSET (no_mbufs_bulk) }, +}; +static void gve_write_version (uint8_t *driver_version_register) {
@@ -328,9 +345,9 @@ gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)if (txq ==NULL )continue ; - stats->opackets += txq->packets; - stats->obytes += txq->bytes; - stats->oerrors += txq->errors; + stats->opackets += txq->stats.packets; + stats->obytes += txq->stats.bytes; + stats->oerrors += txq->stats.errors; }for (i =0 ; i < dev->data->nb_rx_queues; i++) {
@@ -338,10 +355,10 @@ gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)if (rxq ==NULL )continue ; - stats->ipackets += rxq->packets; - stats->ibytes += rxq->bytes; - stats->ierrors += rxq->errors; - stats->rx_nombuf += rxq->no_mbufs; + stats->ipackets += rxq->stats.packets; + stats->ibytes += rxq->stats.bytes; + stats->ierrors += rxq->stats.errors; + stats->rx_nombuf += rxq->stats.no_mbufs; }return 0 ;
@@ -357,9 +374,7 @@ gve_dev_stats_reset(struct rte_eth_dev *dev)if (txq ==NULL )continue ; - txq->packets =0 ; - txq->bytes =0 ; - txq->errors =0 ; +memset (&txq->stats,0 ,sizeof (txq->stats)); }for (i =0 ; i < dev->data->nb_rx_queues; i++) {
@@ -367,10 +382,7 @@ gve_dev_stats_reset(struct rte_eth_dev *dev)if (rxq ==NULL )continue ; - rxq->packets =0 ; - rxq->bytes =0 ; - rxq->errors =0 ; - rxq->no_mbufs =0 ; +memset (&rxq->stats,0 ,sizeof (rxq->stats)); }return 0 ;
@@ -403,6 +415,101 @@ gve_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)return 0 ; } +static int +gve_xstats_count (struct rte_eth_dev *dev) +{ +uint16_t i, count =0 ; + +for (i =0 ; i < dev->data->nb_tx_queues; i++) { +if (dev->data->tx_queues[i]) + count +=RTE_DIM (tx_xstats_name_offset); + } + +for (i =0 ; i < dev->data->nb_rx_queues; i++) { +if (dev->data->rx_queues[i]) + count +=RTE_DIM (rx_xstats_name_offset); + } + +return count; +} + +static int +gve_xstats_get (struct rte_eth_dev *dev, +struct rte_eth_xstat *xstats, +unsigned int size) +{ +uint16_t i, j, count =gve_xstats_count (dev); +const char *stats; + +if ((xstats ==NULL ) || (size < count)) +return count; + + count =0 ; + +for (i =0 ; i < dev->data->nb_tx_queues; i++) { +const struct gve_tx_queue *txq = dev->data->tx_queues[i]; +if (txq ==NULL ) +continue ; + + stats = (const char *)&txq->stats; +for (j =0 ; j <RTE_DIM (tx_xstats_name_offset); j++, count++) { + xstats[count].id = count; + xstats[count].value = *(const uint64_t *) + (stats + tx_xstats_name_offset[j].offset); + } + } + +for (i =0 ; i < dev->data->nb_rx_queues; i++) { +const struct gve_rx_queue *rxq = dev->data->rx_queues[i]; +if (rxq ==NULL ) +continue ; + + stats = (const char *)&rxq->stats; +for (j =0 ; j <RTE_DIM (rx_xstats_name_offset); j++, count++) { + xstats[count].id = count; + xstats[count].value = *(const uint64_t *) + (stats + rx_xstats_name_offset[j].offset); + } + } + +return count; +} + +static int +gve_xstats_get_names (struct rte_eth_dev *dev, +struct rte_eth_xstat_name *xstats_names, +unsigned int size) +{ +uint16_t i, j, count =gve_xstats_count (dev); + +if ((xstats_names ==NULL ) || (size < count)) +return count; + + count =0 ; + +for (i =0 ; i < dev->data->nb_tx_queues; i++) { +if (dev->data->tx_queues[i] ==NULL ) +continue ; + +for (j =0 ; j <RTE_DIM (tx_xstats_name_offset); j++) +snprintf (xstats_names[count++].name, +RTE_ETH_XSTATS_NAME_SIZE , +"tx_q%u_%s" , i, tx_xstats_name_offset[j].name); + } + +for (i =0 ; i < dev->data->nb_rx_queues; i++) { +if (dev->data->rx_queues[i] ==NULL ) +continue ; + +for (j =0 ; j <RTE_DIM (rx_xstats_name_offset); j++) +snprintf (xstats_names[count++].name, +RTE_ETH_XSTATS_NAME_SIZE , +"rx_q%u_%s" , i, rx_xstats_name_offset[j].name); + } + +return count; +} +static const struct eth_dev_ops gve_eth_dev_ops = { .dev_configure = gve_dev_configure, .dev_start = gve_dev_start,
@@ -417,6 +524,8 @@ static const struct eth_dev_ops gve_eth_dev_ops = { .stats_get = gve_dev_stats_get, .stats_reset = gve_dev_stats_reset, .mtu_set = gve_dev_mtu_set, + .xstats_get = gve_xstats_get, + .xstats_get_names = gve_xstats_get_names, }; static void
drivers/net/gve/gve_ethdev.h +21 -7
@@ -67,6 +67,25 @@ struct gve_tx_iovec {uint32_t iov_len; }; +struct gve_tx_stats { +uint64_t packets; +uint64_t bytes; +uint64_t errors; +}; + +struct gve_rx_stats { +uint64_t packets; +uint64_t bytes; +uint64_t errors; +uint64_t no_mbufs; +uint64_t no_mbufs_bulk; +}; + +struct gve_xstats_name_offset { +char name[RTE_ETH_XSTATS_NAME_SIZE ]; +unsigned int offset; +}; +struct gve_tx_queue {volatile union gve_tx_desc *tx_desc_ring;const struct rte_memzone *mz;
@@ -93,9 +112,7 @@ struct gve_tx_queue {struct gve_tx_iovec *iov_ring;/* stats items */ -uint64_t packets; -uint64_t bytes; -uint64_t errors; +struct gve_tx_stats stats;uint16_t port_id;uint16_t queue_id;
@@ -136,10 +153,7 @@ struct gve_rx_queue {struct gve_queue_page_list *qpl;/* stats items */ -uint64_t packets; -uint64_t bytes; -uint64_t errors; -uint64_t no_mbufs; +struct gve_rx_stats stats;struct gve_priv *hw;const struct rte_memzone *qres_mz;
drivers/net/gve/gve_rx.c +7 -5
@@ -20,6 +20,7 @@ gve_rx_refill(struct gve_rx_queue *rxq)if (nb_alloc <= rxq->nb_avail) { diag =rte_pktmbuf_alloc_bulk (rxq->mpool, &rxq->sw_ring[idx], nb_alloc);if (diag <0 ) { + rxq->stats.no_mbufs_bulk++;for (i =0 ; i < nb_alloc; i++) { nmb =rte_pktmbuf_alloc (rxq->mpool);if (!nmb)
@@ -27,7 +28,7 @@ gve_rx_refill(struct gve_rx_queue *rxq) rxq->sw_ring[idx + i] = nmb; }if (i != nb_alloc) { - rxq->no_mbufs += nb_alloc - i; + rxq->stats.no_mbufs += nb_alloc - i; nb_alloc = i; } }
@@ -55,6 +56,7 @@ gve_rx_refill(struct gve_rx_queue *rxq) nb_alloc = rxq->nb_rx_desc - idx; diag =rte_pktmbuf_alloc_bulk (rxq->mpool, &rxq->sw_ring[idx], nb_alloc);if (diag <0 ) { + rxq->stats.no_mbufs_bulk++;for (i =0 ; i < nb_alloc; i++) { nmb =rte_pktmbuf_alloc (rxq->mpool);if (!nmb)
@@ -62,7 +64,7 @@ gve_rx_refill(struct gve_rx_queue *rxq) rxq->sw_ring[idx + i] = nmb; }if (i != nb_alloc) { - rxq->no_mbufs += nb_alloc - i; + rxq->stats.no_mbufs += nb_alloc - i; nb_alloc = i; } }
@@ -106,7 +108,7 @@ gve_rx_burst(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)break ;if (rxd->flags_seq &GVE_RXF_ERR ) { - rxq->errors++; + rxq->stats.errors++;continue ; }
@@ -154,8 +156,8 @@ gve_rx_burst(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)gve_rx_refill (rxq);if (nb_rx) { - rxq->packets += nb_rx; - rxq->bytes += bytes; + rxq->stats.packets += nb_rx; + rxq->stats.bytes += bytes; }return nb_rx;
drivers/net/gve/gve_tx.c +6 -5
@@ -366,9 +366,9 @@ gve_tx_burst_qpl(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) txq->tx_tail = tx_tail; txq->sw_tail = sw_id; - txq->packets += nb_tx; - txq->bytes += bytes; - txq->errors += nb_pkts - nb_tx; + txq->stats.packets += nb_tx; + txq->stats.bytes += bytes; + txq->stats.errors += nb_pkts - nb_tx; }return nb_tx;
@@ -455,8 +455,9 @@ gve_tx_burst_ra(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)rte_write32 (rte_cpu_to_be_32 (tx_tail), txq->qtx_tail); txq->tx_tail = tx_tail; - txq->packets += nb_tx; - txq->bytes += bytes; + txq->stats.packets += nb_tx; + txq->stats.bytes += bytes; + txq->stats.errors += nb_pkts - nb_tx; }return nb_tx;
Signature · 1 line
2.37.1 (Apple Git-137.1)
PATCH v5 1/1 net/gve: add Rx/Tx queue stats as extended stats
Google Virtual NIC rx/tx queue stats are added as extended stats.
--- drivers/net/gve/gve_ethdev.c | 137 +++++++++++++++++++++++++++++++---- drivers/net/gve/gve_ethdev.h | 28 +++++-- drivers/net/gve/gve_rx.c | 12 +-- drivers/net/gve/gve_tx.c | 11 +-- 4 files changed, 157 insertions(+), 31 deletions(-)
drivers/net/gve/gve_ethdev.c +123 -14
@@ -6,9 +6,26 @@#include "base/gve_adminq.h" #include "base/gve_register.h" +#define TX_QUEUE_STATS_OFFSET (x) offsetof(struct gve_tx_stats, x) +#define RX_QUEUE_STATS_OFFSET (x) offsetof(struct gve_rx_stats, x) +const char gve_version_str[] =GVE_VERSION ;static const char gve_version_prefix[] =GVE_VERSION_PREFIX ; +static const struct gve_xstats_name_offset tx_xstats_name_offset[] = { + {"packets" ,TX_QUEUE_STATS_OFFSET (packets) }, + {"bytes" ,TX_QUEUE_STATS_OFFSET (bytes) }, + {"errors" ,TX_QUEUE_STATS_OFFSET (errors) }, +}; + +static const struct gve_xstats_name_offset rx_xstats_name_offset[] = { + {"packets" ,RX_QUEUE_STATS_OFFSET (packets) }, + {"bytes" ,RX_QUEUE_STATS_OFFSET (bytes) }, + {"errors" ,RX_QUEUE_STATS_OFFSET (errors) }, + {"mbuf_alloc_errors" ,RX_QUEUE_STATS_OFFSET (no_mbufs) }, + {"mbuf_alloc_errors_bulk" ,RX_QUEUE_STATS_OFFSET (no_mbufs_bulk) }, +}; +static void gve_write_version (uint8_t *driver_version_register) {
@@ -328,9 +345,9 @@ gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)if (txq ==NULL )continue ; - stats->opackets += txq->packets; - stats->obytes += txq->bytes; - stats->oerrors += txq->errors; + stats->opackets += txq->stats.packets; + stats->obytes += txq->stats.bytes; + stats->oerrors += txq->stats.errors; }for (i =0 ; i < dev->data->nb_rx_queues; i++) {
@@ -338,10 +355,10 @@ gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)if (rxq ==NULL )continue ; - stats->ipackets += rxq->packets; - stats->ibytes += rxq->bytes; - stats->ierrors += rxq->errors; - stats->rx_nombuf += rxq->no_mbufs; + stats->ipackets += rxq->stats.packets; + stats->ibytes += rxq->stats.bytes; + stats->ierrors += rxq->stats.errors; + stats->rx_nombuf += rxq->stats.no_mbufs; }return 0 ;
@@ -357,9 +374,7 @@ gve_dev_stats_reset(struct rte_eth_dev *dev)if (txq ==NULL )continue ; - txq->packets =0 ; - txq->bytes =0 ; - txq->errors =0 ; +memset (&txq->stats,0 ,sizeof (txq->stats)); }for (i =0 ; i < dev->data->nb_rx_queues; i++) {
@@ -367,10 +382,7 @@ gve_dev_stats_reset(struct rte_eth_dev *dev)if (rxq ==NULL )continue ; - rxq->packets =0 ; - rxq->bytes =0 ; - rxq->errors =0 ; - rxq->no_mbufs =0 ; +memset (&rxq->stats,0 ,sizeof (rxq->stats)); }return 0 ;
@@ -403,6 +415,101 @@ gve_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)return 0 ; } +static int +gve_xstats_count (struct rte_eth_dev *dev) +{ +uint16_t i, count =0 ; + +for (i =0 ; i < dev->data->nb_tx_queues; i++) { +if (dev->data->tx_queues[i]) + count +=RTE_DIM (tx_xstats_name_offset); + } + +for (i =0 ; i < dev->data->nb_rx_queues; i++) { +if (dev->data->rx_queues[i]) + count +=RTE_DIM (rx_xstats_name_offset); + } + +return count; +} + +static int +gve_xstats_get (struct rte_eth_dev *dev, +struct rte_eth_xstat *xstats, +unsigned int size) +{ +uint16_t i, j, count =gve_xstats_count (dev); +const char *stats; + +if (xstats ==NULL || size < count) +return count; + + count =0 ; + +for (i =0 ; i < dev->data->nb_tx_queues; i++) { +const struct gve_tx_queue *txq = dev->data->tx_queues[i]; +if (txq ==NULL ) +continue ; + + stats = (const char *)&txq->stats; +for (j =0 ; j <RTE_DIM (tx_xstats_name_offset); j++, count++) { + xstats[count].id = count; + xstats[count].value = *(const uint64_t *) + (stats + tx_xstats_name_offset[j].offset); + } + } + +for (i =0 ; i < dev->data->nb_rx_queues; i++) { +const struct gve_rx_queue *rxq = dev->data->rx_queues[i]; +if (rxq ==NULL ) +continue ; + + stats = (const char *)&rxq->stats; +for (j =0 ; j <RTE_DIM (rx_xstats_name_offset); j++, count++) { + xstats[count].id = count; + xstats[count].value = *(const uint64_t *) + (stats + rx_xstats_name_offset[j].offset); + } + } + +return count; +} + +static int +gve_xstats_get_names (struct rte_eth_dev *dev, +struct rte_eth_xstat_name *xstats_names, +unsigned int size) +{ +uint16_t i, j, count =gve_xstats_count (dev); + +if (xstats_names ==NULL || size < count) +return count; + + count =0 ; + +for (i =0 ; i < dev->data->nb_tx_queues; i++) { +if (dev->data->tx_queues[i] ==NULL ) +continue ; + +for (j =0 ; j <RTE_DIM (tx_xstats_name_offset); j++) +snprintf (xstats_names[count++].name, +RTE_ETH_XSTATS_NAME_SIZE , +"tx_q%u_%s" , i, tx_xstats_name_offset[j].name); + } + +for (i =0 ; i < dev->data->nb_rx_queues; i++) { +if (dev->data->rx_queues[i] ==NULL ) +continue ; + +for (j =0 ; j <RTE_DIM (rx_xstats_name_offset); j++) +snprintf (xstats_names[count++].name, +RTE_ETH_XSTATS_NAME_SIZE , +"rx_q%u_%s" , i, rx_xstats_name_offset[j].name); + } + +return count; +} +static const struct eth_dev_ops gve_eth_dev_ops = { .dev_configure = gve_dev_configure, .dev_start = gve_dev_start,
@@ -417,6 +524,8 @@ static const struct eth_dev_ops gve_eth_dev_ops = { .stats_get = gve_dev_stats_get, .stats_reset = gve_dev_stats_reset, .mtu_set = gve_dev_mtu_set, + .xstats_get = gve_xstats_get, + .xstats_get_names = gve_xstats_get_names, }; static void
drivers/net/gve/gve_ethdev.h +21 -7
@@ -67,6 +67,25 @@ struct gve_tx_iovec {uint32_t iov_len; }; +struct gve_tx_stats { +uint64_t packets; +uint64_t bytes; +uint64_t errors; +}; + +struct gve_rx_stats { +uint64_t packets; +uint64_t bytes; +uint64_t errors; +uint64_t no_mbufs; +uint64_t no_mbufs_bulk; +}; + +struct gve_xstats_name_offset { +char name[RTE_ETH_XSTATS_NAME_SIZE ]; +unsigned int offset; +}; +struct gve_tx_queue {volatile union gve_tx_desc *tx_desc_ring;const struct rte_memzone *mz;
@@ -93,9 +112,7 @@ struct gve_tx_queue {struct gve_tx_iovec *iov_ring;/* stats items */ -uint64_t packets; -uint64_t bytes; -uint64_t errors; +struct gve_tx_stats stats;uint16_t port_id;uint16_t queue_id;
@@ -136,10 +153,7 @@ struct gve_rx_queue {struct gve_queue_page_list *qpl;/* stats items */ -uint64_t packets; -uint64_t bytes; -uint64_t errors; -uint64_t no_mbufs; +struct gve_rx_stats stats;struct gve_priv *hw;const struct rte_memzone *qres_mz;
drivers/net/gve/gve_rx.c +7 -5
@@ -20,6 +20,7 @@ gve_rx_refill(struct gve_rx_queue *rxq)if (nb_alloc <= rxq->nb_avail) { diag =rte_pktmbuf_alloc_bulk (rxq->mpool, &rxq->sw_ring[idx], nb_alloc);if (diag <0 ) { + rxq->stats.no_mbufs_bulk++;for (i =0 ; i < nb_alloc; i++) { nmb =rte_pktmbuf_alloc (rxq->mpool);if (!nmb)
@@ -27,7 +28,7 @@ gve_rx_refill(struct gve_rx_queue *rxq) rxq->sw_ring[idx + i] = nmb; }if (i != nb_alloc) { - rxq->no_mbufs += nb_alloc - i; + rxq->stats.no_mbufs += nb_alloc - i; nb_alloc = i; } }
@@ -55,6 +56,7 @@ gve_rx_refill(struct gve_rx_queue *rxq) nb_alloc = rxq->nb_rx_desc - idx; diag =rte_pktmbuf_alloc_bulk (rxq->mpool, &rxq->sw_ring[idx], nb_alloc);if (diag <0 ) { + rxq->stats.no_mbufs_bulk++;for (i =0 ; i < nb_alloc; i++) { nmb =rte_pktmbuf_alloc (rxq->mpool);if (!nmb)
@@ -62,7 +64,7 @@ gve_rx_refill(struct gve_rx_queue *rxq) rxq->sw_ring[idx + i] = nmb; }if (i != nb_alloc) { - rxq->no_mbufs += nb_alloc - i; + rxq->stats.no_mbufs += nb_alloc - i; nb_alloc = i; } }
@@ -106,7 +108,7 @@ gve_rx_burst(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)break ;if (rxd->flags_seq &GVE_RXF_ERR ) { - rxq->errors++; + rxq->stats.errors++;continue ; }
@@ -154,8 +156,8 @@ gve_rx_burst(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)gve_rx_refill (rxq);if (nb_rx) { - rxq->packets += nb_rx; - rxq->bytes += bytes; + rxq->stats.packets += nb_rx; + rxq->stats.bytes += bytes; }return nb_rx;
drivers/net/gve/gve_tx.c +6 -5
@@ -366,9 +366,9 @@ gve_tx_burst_qpl(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) txq->tx_tail = tx_tail; txq->sw_tail = sw_id; - txq->packets += nb_tx; - txq->bytes += bytes; - txq->errors += nb_pkts - nb_tx; + txq->stats.packets += nb_tx; + txq->stats.bytes += bytes; + txq->stats.errors += nb_pkts - nb_tx; }return nb_tx;
@@ -455,8 +455,9 @@ gve_tx_burst_ra(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)rte_write32 (rte_cpu_to_be_32 (tx_tail), txq->qtx_tail); txq->tx_tail = tx_tail; - txq->packets += nb_tx; - txq->bytes += bytes; + txq->stats.packets += nb_tx; + txq->stats.bytes += bytes; + txq->stats.errors += nb_pkts - nb_tx; }return nb_tx;
Signature · 1 line
2.37.1 (Apple Git-137.1)
Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats
Quoted 3 lines · Levend Sayar
Google Virtual NIC rx/tx queue stats are added as extended stats.
Signed-off-by Levend Sayar <[email protected]>
<...>
drivers/net/gve/gve_rx.c gve_rx_refill(struct gve_rx_queue *rxq) · line 23
Quoted 5 lines
drivers/net/gve/gve_rx.c +1
-0@@ -20,6 +20,7 @@ gve_rx_refill(struct gve_rx_queue *rxq)if (nb_alloc <= rxq->nb_avail) { diag =rte_pktmbuf_alloc_bulk (rxq->mpool, &rxq->sw_ring[idx], nb_alloc);if (diag <0 ) { + rxq->stats.no_mbufs_bulk++;
It is not common to record bulk alloc failures, but as 'no_mbufs' already recorded conventionally, I guess it is OK to keep this extra stat if it is helpful.
Quoted 6 lines · Levend Sayar
rx
no_mbufsstats counter update is added for another error case.Fixes 4f6b1dd8240c ("net/gve: support basic statistics")Signed-off-by Levend Sayar <[email protected]>
(No problem for this time, but for future contributions, it is expected to have new versions as a whole patchset, otherwise that becomes too difficult to manage for maintainers to cherry pick various versions of individual patches in a set, specially on peak time of release. Also harder to backtrace from patchwork/list if someone wants the check the history.)
Thanks Ferruh for the heads up.
It was a little confusion for me to decide what to do either. I will do as expected for future. I did not want to overwrite any commit that is already acked.
So pushed new versions only for the ones needs recommits.
Levend
Quoted 20 lines · Ferruh Yigit
Quoted 6 lines · Levend Sayar
rx
no_mbufsstats counter update is added for another error case.Fixes 4f6b1dd8240c ("net/gve: support basic statistics")Signed-off-by Levend Sayar <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>(No problem for this time, but for future contributions, it is expected to have new versions as a whole patchset, otherwise that becomes too difficult to manage for maintainers to cherry pick various versions of individual patches in a set, specially on peak time of release. Also harder to backtrace from patchwork/list if someone wants the check the history.)
Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats
In reply to Ferruh YigitThanks Ferruh for the review.
Quoted 21 lines · Ferruh Yigit
Quoted 3 lines · Levend Sayar
Google Virtual NIC rx/tx queue stats are added as extended stats.
Signed-off-by Levend Sayar <[email protected]>Reviewed-by Ferruh Yigit <[email protected]><...>
drivers/net/gve/gve_rx.c gve_rx_refill(struct gve_rx_queue *rxq) · line 23
Quoted 5 lines
drivers/net/gve/gve_rx.c +1
-0@@ -20,6 +20,7 @@ gve_rx_refill(struct gve_rx_queue *rxq)if (nb_alloc <= rxq->nb_avail) { diag =rte_pktmbuf_alloc_bulk (rxq->mpool, &rxq->sw_ring[idx], nb_alloc);if (diag <0 ) { + rxq->stats.no_mbufs_bulk++;It is not common to record bulk alloc failures, but as '
no_mbufs' already recorded conventionally, I guess it is OK to keep this extra stat if it is helpful.
Guo, Junfeng
Acked-byRE: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats
Thanks!
Quoted 7 lines
-----Original Message-----
From: Levend Sayar <[email protected]>
Sent: Wednesday, February 22, 2023 00:44
To: Ferruh Yigit <[email protected]>
Cc: Guo, Junfeng <[email protected]>; [email protected]
Subject: Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats
Quoted 11 lines
Thanks Ferruh for the review.
Quoted 9 lines · Ferruh Yigit
Quoted 3 lines · Levend Sayar
Google Virtual NIC rx/tx queue stats are added as extended stats.
Signed-off-by Levend Sayar <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>
Quoted 13 lines
Quoted 13 lines
<...>
Review gve_rx_refill(struct gve_rx_queue *rxq) · line 21
Quoted 3 lines
(quoted diff) +0
-0@@ -20,6 +20,7 @@ gve_rx_refill(struct gve_rx_queue *rxq) if (nb_alloc <= rxq->nb_avail) { diag = rte_pktmbuf_alloc_bulk(rxq->mpool, &rxq-sw_ring[idx],
nb_alloc);Review gve_rx_refill(struct gve_rx_queue *rxq) · line 23
Quoted 2 lines
(quoted diff) +1
-0if (diag < 0) { + rxq->stats.no_mbufs_bulk++;It is not common to record bulk alloc failures, but as '
no_mbufs' already recorded conventionally, I guess it is OK to keep this extra stat if it is helpful.
Guo, Junfeng
Acked-byQuoted 10 lines
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Tuesday, February 21, 2023 18:31
To: Levend Sayar <[email protected]>
Cc: Guo, Junfeng <[email protected]>; [email protected]; Stephen Hemminger <[email protected]>
Subject: Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter updateQuoted 1 line · Levend Sayar
Not only this if, there can be many places to add such branch prediction
Quoted 8 lines
helpers
Quoted 3 lines
On the gve pmd code.
I preferred to patch only the bug here and not used unlikely to minimize
noise.
Quoted 2 lines
Imho, adding likely/unlikely to all gve pmd code can be topic of another
patch maybe.
Agreed.
Adding likely/unlikely is more related to the performance with compiler. This can be an optimization for performance. Thanks!
Quoted 40 lines
Quoted 1 line
ack, sounds reasonable to me
Quoted 36 lines
Levend
Quoted 33 lines · Ferruh Yigit
Quoted 16 lines · Levend Sayar
rx
no_mbufsstats counter update is added for another error case.Fixes 4f6b1dd8240c ("net/gve: support basic statistics")Signed-off-by Levend Sayar <[email protected]>---
drivers/net/gve/gve_rx.c| 5 ++++-1 file changed, 4 insertions(+), 1 deletion(-)drivers/net/gve/gve_rx.c +0
-0@@ -61,7 +61,10 @@ gve_rx_refill(struct gve_rx_queue *rxq)break ;drivers/net/gve/gve_rx.c gve_rx_refill(struct gve_rx_queue *rxq) · line 70
Quoted 10 lines
drivers/net/gve/gve_rx.c +4
-1rxq->sw_ring[idx + i] = nmb; } - nb_alloc = i; +if (i != nb_alloc) { + rxq->no_mbufs += nb_alloc - i; + nb_alloc = i; + } } rxq->nb_avail -= nb_alloc; next_avail += nb_alloc;Looks good to me,
there was a comment from Stephen to add 'unlikely()', is that issue resolved?
Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats
In reply to Guo, JunfengThanks Junfeng for acknowledging.
Quoted 39 lines · Junfeng
Thanks!
Quoted 7 lines
-----Original Message-----
From: Levend Sayar <[email protected]>
Sent: Wednesday, February 22, 2023 00:44
To: Ferruh Yigit <[email protected]>
Cc: Guo, Junfeng <[email protected]>; [email protected]
Subject: Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended statsQuoted 11 lines
Thanks Ferruh for the review.
Quoted 9 lines · Ferruh Yigit
Quoted 3 lines · Levend Sayar
Google Virtual NIC rx/tx queue stats are added as extended stats.
Signed-off-by Levend Sayar <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>Acked-by Junfeng Guo <[email protected]>Quoted 13 lines
Quoted 13 lines
<...>
Review gve_rx_refill(struct gve_rx_queue *rxq) · line 21
Quoted 3 lines
(quoted diff) +0
-0@@ -20,6 +20,7 @@ gve_rx_refill(struct gve_rx_queue *rxq) if (nb_alloc <= rxq->nb_avail) { diag = rte_pktmbuf_alloc_bulk(rxq->mpool, &rxq-sw_ring[idx],
nb_alloc);Review gve_rx_refill(struct gve_rx_queue *rxq) · line 23
Quoted 2 lines
(quoted diff) +1
-0if (diag < 0) { + rxq->stats.no_mbufs_bulk++;It is not common to record bulk alloc failures, but as '
no_mbufs' already recorded conventionally, I guess it is OK to keep this extra stat if it is helpful.
Thanks Junfeng for acknowledging.
Quoted 66 lines · Junfeng
Acked-by Junfeng Guo <[email protected] <mailto:[email protected]>>Quoted 10 lines
-----Original Message-----
From: Ferruh Yigit <[email protected] <mailto:[email protected]>>
Sent: Tuesday, February 21, 2023 18:31
To: Levend Sayar <[email protected] <mailto:[email protected]>>
Cc: Guo, Junfeng <[email protected] <mailto:[email protected]>>; [email protected] <mailto:[email protected]>; Stephen Hemminger <[email protected] <mailto:[email protected]>>
Subject: Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter updateQuoted 1 line · Levend Sayar
Not only this if, there can be many places to add such branch prediction
Quoted 8 lines
helpers
Quoted 3 lines
On the gve pmd code.
I preferred to patch only the bug here and not used unlikely to minimize
noise.
Quoted 2 lines
Imho, adding likely/unlikely to all gve pmd code can be topic of another
patch maybe.
Agreed.
Adding likely/unlikely is more related to the performance with compiler. This can be an optimization for performance. Thanks!Quoted 39 lines
Quoted 1 line
ack, sounds reasonable to me
Quoted 35 lines
Levend
Quoted 33 lines · Ferruh Yigit
Quoted 16 lines · Levend Sayar
rx
no_mbufsstats counter update is added for another error case.Fixes 4f6b1dd8240c ("net/gve: support basic statistics")Signed-off-by Levend Sayar <[email protected]>---
drivers/net/gve/gve_rx.c| 5 ++++-1 file changed, 4 insertions(+), 1 deletion(-)drivers/net/gve/gve_rx.c +0
-0@@ -61,7 +61,10 @@ gve_rx_refill(struct gve_rx_queue *rxq)break ;drivers/net/gve/gve_rx.c gve_rx_refill(struct gve_rx_queue *rxq) · line 70
Quoted 10 lines
drivers/net/gve/gve_rx.c +4
-1rxq->sw_ring[idx + i] = nmb; } - nb_alloc = i; +if (i != nb_alloc) { + rxq->no_mbufs += nb_alloc - i; + nb_alloc = i; + } } rxq->nb_avail -= nb_alloc; next_avail += nb_alloc;Looks good to me,
there was a comment from Stephen to add 'unlikely()', is that issue resolved?
Ferruh Yigit
AppliedRe: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats
In reply to Guo, JunfengQuoted 12 lines · Junfeng
Quoted 12 lines
-----Original Message-----
From: Levend Sayar <[email protected]>
Sent: Wednesday, February 22, 2023 00:44
To: Ferruh Yigit <[email protected]>
Cc: Guo, Junfeng <[email protected]>; [email protected]
Subject: Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended statsThanks Ferruh for the review.
Quoted 3 lines · Ferruh Yigit
On 2/21/2023 2:18 PM, Levend Sayar wrote:
Quoted 9 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
Google Virtual NIC rx/tx queue stats are added as extended stats.
Signed-off-by Levend Sayar <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>Acked-by Junfeng Guo <[email protected]>
while merging 'gve_xstats_name_offset' structs moved down to group them with xstats dev_ops.
Applied to dpdk-next-net/main, thanks.
Ferruh Yigit
AppliedQuoted 6 lines · Junfeng
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines · Levend Sayar
Quoted 5 lines
rx
no_mbufsstats counter update is added for another error case.Fixes 4f6b1dd8240c ("net/gve: support basic statistics")
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Signed-off-by Levend Sayar <[email protected]>---
Acked-by Junfeng Guo <[email protected]>Quoted 1 line
Reviewed-by Ferruh Yigit <[email protected]>
Applied to dpdk-next-net/main, thanks.
Thanks Ferruh For applying.
Quoted 20 lines · Ferruh Yigit
Quoted 6 lines · Junfeng
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines · Levend Sayar
Quoted 5 lines
rx
no_mbufsstats counter update is added for another error case.Fixes 4f6b1dd8240c ("net/gve: support basic statistics")Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Signed-off-by Levend Sayar <[email protected]>---
Acked-by Junfeng Guo <[email protected]>Quoted 1 line
Reviewed-by Ferruh Yigit <[email protected]>Applied to dpdk-next-net/main, thanks.
Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats
In reply to Ferruh YigitThanks Ferruh for applying.
Quoted 30 lines · Ferruh Yigit
Quoted 12 lines · Junfeng
Quoted 12 lines
-----Original Message-----
From: Levend Sayar <[email protected]>
Sent: Wednesday, February 22, 2023 00:44
To: Ferruh Yigit <[email protected]>
Cc: Guo, Junfeng <[email protected]>; [email protected]
Subject: Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended statsThanks Ferruh for the review.
Quoted 3 lines · Ferruh Yigit
On 2/21/2023 2:18 PM, Levend Sayar wrote:
Quoted 9 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
Google Virtual NIC rx/tx queue stats are added as extended stats.
Signed-off-by Levend Sayar <[email protected]>Reviewed-by Ferruh Yigit <[email protected]>Acked-by Junfeng Guo <[email protected]>while merging '
gve_xstats_name_offset' structs moved down to group them with xstatsdev_ops.Applied to dpdk-next-net/main, thanks.