Skip to contentSkip to conversation

i2c: gxp: return proper error on address NACK

PATCH Applied Wolfram Sang 1 participant 2 messages Feb 20, 2023 – Mar 3, 2023

Subsystems (2)
I2C subsystem host drivers Arm/hpe gxp architecture
lore
Share & tools
lore

Wolfram Sang

author
#0 lore raw

PATCH 1/1 i2c: gxp: return proper error on address NACK

According to Documentation/i2c/fault-codes.rst, NACK after sending an address should be -ENXIO.

Signed-off-by Wolfram Sang <[email protected]>

---

Depends on: "[PATCH] i2c: gxp: remove "empty" switch statement"

 drivers/i2c/busses/i2c-gxp.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/i2c/busses/i2c-gxp.c +4 -2
index 352dedf6292f..fda7809e72ba 100644
@@ -129,8 +129,10 @@ static int gxp_i2c_master_xfer(struct i2c_adapter *adapter,
 	if (time_left == 0)
 		return -ETIMEDOUT;
 
-	if (drvdata->state == GXP_I2C_ADDR_NACK ||
-	    drvdata->state == GXP_I2C_DATA_NACK)
+	if (drvdata->state == GXP_I2C_ADDR_NACK)
+		return -ENXIO;
+
+	if (drvdata->state == GXP_I2C_DATA_NACK)
 		return -EIO;
 
 	return ret;
Signature · 1 line
2.30.2