Skip to contentSkip to conversation

linux-next: build warning after merge of the driver-core tree

DISCUSSION Stephen Rothwell 4 participants 7 messages Feb 20, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the driver-core tree, today's linux-next build (htmldocs) produced this warning:

Documentation/filesystems/api-summary:146: fs/debugfs/inode.c:804: WARNING: Inline literal start-string without end-string.

Introduced by commit

d3002468cb5d ("debugfs: update comment of debugfs_rename()")

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 10 lines · Stephen Rothwell

Hi all,

After merging the driver-core tree, today's linux-next build (htmldocs) produced this warning:

Documentation/filesystems/api-summary:146: fs/debugfs/inode.c:804: WARNING: Inline literal start-string without end-string.

Introduced by commit

   d3002468cb5d ("debugfs: update comment of debugfs_rename()")

This is just a comment modification. Didn't see where my modification caused this WARNING. :(

Quoted 1 line
Signature · 2 lines
Thanks,
Qi
#2 lore raw
Quoted 8 lines · Qi Zheng
Quoted 5 lines · Stephen Rothwell

Hi all,

After merging the driver-core tree, today's linux-next build (htmldocs) produced this warning:

Quoted 8 lines
Quoted 5 lines

Documentation/filesystems/api-summary:146: fs/debugfs/inode.c:804: WARNING: Inline literal start-string without end-string.

Introduced by commit

   d3002468cb5d ("debugfs: update comment of debugfs_rename()")

This is just a comment modification. Didn't see where my modification caused this WARNING. :(

Yeah, I don't understand either, here's the diff, what's wrong with it?

fs/debugfs/inode.c +2 -2
@@ -802,8 +802,8 @@ EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove);
  * exist for rename to succeed.
  *
  * This function will return a pointer to old_dentry (which is updated to
- * reflect renaming) if it succeeds. If an error occurs, %NULL will be
- * returned.
+ * reflect renaming) if it succeeds. If an error occurs, %ERR_PTR(-ERROR)
+ * will be returned.
  *
  * If debugfs is not enabled in the kernel, the value -%ENODEV will be
  * returned.
#3 lore raw
Quoted 24 lines · Greg KH
Quoted 8 lines · Qi Zheng
Quoted 5 lines · Stephen Rothwell

Hi all,

After merging the driver-core tree, today's linux-next build (htmldocs) produced this warning:

Quoted 8 lines
Quoted 5 lines

Documentation/filesystems/api-summary:146: fs/debugfs/inode.c:804: WARNING: Inline literal start-string without end-string.

Introduced by commit

   d3002468cb5d ("debugfs: update comment of debugfs_rename()")

This is just a comment modification. Didn't see where my modification caused this WARNING. :(

Yeah, I don't understand either, here's the diff, what's wrong with it?

fs/debugfs/inode.c EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove); · line 809

Quoted 10 lines
fs/debugfs/inode.c +2 -2
@@ -802,8 +802,8 @@ EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove);
  * exist for rename to succeed.
  *
  * This function will return a pointer to old_dentry (which is updated to
- * reflect renaming) if it succeeds. If an error occurs, %NULL will be
- * returned.
+ * reflect renaming) if it succeeds. If an error occurs, %ERR_PTR(-ERROR)
+ * will be returned.
  *
  * If debugfs is not enabled in the kernel, the value -%ENODEV will be
  * returned.

Hi Greg and Qi,

The simple fix is to drop the percent (which is an inline code variant):

---- >8 ----

fs/debugfs/inode.c +1 -1
index 58a35afb7c5d89..a7a6a0821605a8 100644
@@ -802,7 +802,7 @@ EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove);
  * exist for rename to succeed.
  *
  * This function will return a pointer to old_dentry (which is updated to
- * reflect renaming) if it succeeds. If an error occurs, %ERR_PTR(-ERROR)
+ * reflect renaming) if it succeeds. If an error occurs, ERR_PTR(-ERROR)
  * will be returned.
  *
  * If debugfs is not enabled in the kernel, the value -%ENODEV will be

Thanks.

Signature · 1 line
An old man doll... just what I always wanted! - Clara
#4 lore raw
Quoted 46 lines · Bagas Sanjaya
Quoted 24 lines · Greg KH
Quoted 8 lines · Qi Zheng
Quoted 5 lines · Stephen Rothwell

Hi all,

After merging the driver-core tree, today's linux-next build (htmldocs) produced this warning:

Quoted 8 lines
Quoted 5 lines

Documentation/filesystems/api-summary:146: fs/debugfs/inode.c:804: WARNING: Inline literal start-string without end-string.

Introduced by commit

    d3002468cb5d ("debugfs: update comment of debugfs_rename()")

This is just a comment modification. Didn't see where my modification caused this WARNING. :(

Yeah, I don't understand either, here's the diff, what's wrong with it?

fs/debugfs/inode.c EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove); · line 809

Quoted 10 lines
fs/debugfs/inode.c +2 -2
@@ -802,8 +802,8 @@ EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove);
   * exist for rename to succeed.
   *
   * This function will return a pointer to old_dentry (which is updated to
- * reflect renaming) if it succeeds. If an error occurs, %NULL will be
- * returned.
+ * reflect renaming) if it succeeds. If an error occurs, %ERR_PTR(-ERROR)
+ * will be returned.
   *
   * If debugfs is not enabled in the kernel, the value -%ENODEV will be
   * returned.

Hi Greg and Qi,

The simple fix is to drop the percent (which is an inline code variant):

---- >8 ----

fs/debugfs/inode.c +0 -0
index 58a35afb7c5d89..a7a6a0821605a8 100644

fs/debugfs/inode.c EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove); · line 808

Quoted 8 lines
fs/debugfs/inode.c +1 -1
@@ -802,7 +802,7 @@ EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove);
   * exist for rename to succeed.
   *
   * This function will return a pointer to old_dentry (which is updated to
- * reflect renaming) if it succeeds. If an error occurs, %ERR_PTR(-ERROR)
+ * reflect renaming) if it succeeds. If an error occurs, ERR_PTR(-ERROR)
   * will be returned.
   *
   * If debugfs is not enabled in the kernel, the value -%ENODEV will be

LGTM, do I need to resend the patch with this fix?

Quoted 3 lines

Thanks.

Signature · 2 lines
Thanks,
Qi
#5 lore raw
Quoted 43 lines · Qi Zheng
Quoted 40 lines · Bagas Sanjaya
Quoted 24 lines · Greg KH
Quoted 8 lines · Qi Zheng
Quoted 5 lines · Stephen Rothwell

Hi all,

After merging the driver-core tree, today's linux-next build (htmldocs) produced this warning:

Quoted 8 lines
Quoted 5 lines

Documentation/filesystems/api-summary:146: fs/debugfs/inode.c:804: WARNING: Inline literal start-string without end-string.

Introduced by commit

    d3002468cb5d ("debugfs: update comment of debugfs_rename()")

This is just a comment modification. Didn't see where my modification caused this WARNING. :(

Yeah, I don't understand either, here's the diff, what's wrong with it?

fs/debugfs/inode.c EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove); · line 809

Quoted 10 lines
fs/debugfs/inode.c +2 -2
@@ -802,8 +802,8 @@ EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove);
   * exist for rename to succeed.
   *
   * This function will return a pointer to old_dentry (which is updated to
- * reflect renaming) if it succeeds. If an error occurs, %NULL will be
- * returned.
+ * reflect renaming) if it succeeds. If an error occurs, %ERR_PTR(-ERROR)
+ * will be returned.
   *
   * If debugfs is not enabled in the kernel, the value -%ENODEV will be
   * returned.

Hi Greg and Qi,

The simple fix is to drop the percent (which is an inline code variant):

Quoted 16 lines
Quoted 6 lines

---- >8 ----

fs/debugfs/inode.c +0 -0
index 58a35afb7c5d89..a7a6a0821605a8 100644

fs/debugfs/inode.c EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove); · line 808

Quoted 8 lines
fs/debugfs/inode.c +1 -1
@@ -802,7 +802,7 @@ EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove);
   * exist for rename to succeed.
   *
   * This function will return a pointer to old_dentry (which is updated to
- * reflect renaming) if it succeeds. If an error occurs, %ERR_PTR(-ERROR)
+ * reflect renaming) if it succeeds. If an error occurs, ERR_PTR(-ERROR)
   * will be returned.
   *
   * If debugfs is not enabled in the kernel, the value -%ENODEV will be

LGTM, do I need to resend the patch with this fix?

Bagas needs to send it as a real fix so that I can apply it.

thanks,

greg k-h

#6 lore raw
Quoted 61 lines · Greg KH
Quoted 43 lines · Qi Zheng
Quoted 40 lines · Bagas Sanjaya
Quoted 24 lines · Greg KH
Quoted 8 lines · Qi Zheng
Quoted 5 lines · Stephen Rothwell

Hi all,

After merging the driver-core tree, today's linux-next build (htmldocs) produced this warning:

Quoted 8 lines
Quoted 5 lines

Documentation/filesystems/api-summary:146: fs/debugfs/inode.c:804: WARNING: Inline literal start-string without end-string.

Introduced by commit

     d3002468cb5d ("debugfs: update comment of debugfs_rename()")

This is just a comment modification. Didn't see where my modification caused this WARNING. :(

Yeah, I don't understand either, here's the diff, what's wrong with it?

fs/debugfs/inode.c EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove); · line 809

Quoted 10 lines
fs/debugfs/inode.c +2 -2
@@ -802,8 +802,8 @@ EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove);
    * exist for rename to succeed.
    *
    * This function will return a pointer to old_dentry (which is updated to
- * reflect renaming) if it succeeds. If an error occurs, %NULL will be
- * returned.
+ * reflect renaming) if it succeeds. If an error occurs, %ERR_PTR(-ERROR)
+ * will be returned.
    *
    * If debugfs is not enabled in the kernel, the value -%ENODEV will be
    * returned.

Hi Greg and Qi,

The simple fix is to drop the percent (which is an inline code variant):

Quoted 16 lines
Quoted 6 lines

---- >8 ----

fs/debugfs/inode.c +0 -0
index 58a35afb7c5d89..a7a6a0821605a8 100644

fs/debugfs/inode.c EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove); · line 808

Quoted 8 lines
fs/debugfs/inode.c +1 -1
@@ -802,7 +802,7 @@ EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove);
    * exist for rename to succeed.
    *
    * This function will return a pointer to old_dentry (which is updated to
- * reflect renaming) if it succeeds. If an error occurs, %ERR_PTR(-ERROR)
+ * reflect renaming) if it succeeds. If an error occurs, ERR_PTR(-ERROR)
    * will be returned.
    *
    * If debugfs is not enabled in the kernel, the value -%ENODEV will be

LGTM, do I need to resend the patch with this fix?

Quoted 1 line

Bagas needs to send it as a real fix so that I can apply it.

Got it. Thank you and Bagas very much.

Quoted 4 lines

thanks,

greg k-h

Signature · 2 lines
Thanks,
Qi