media: v4l2: check null return of kmalloc in format_ref_list_p and format_ref_list_b
PATCH 1/1 media: v4l2: check null return of kmalloc in format_ref_list_p and format_ref_list_b
kmalloc may fails, *out_str might be null and will cause illegal address access later.
Signed-off-by Kang Chen <[email protected]>
--- drivers/media/v4l2-core/v4l2-h264.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/media/v4l2-core/v4l2-h264.c +6 -0
@@ -306,6 +306,9 @@ static const char *format_ref_list_p(const struct v4l2_h264_reflist_builder *bui *out_str =kmalloc (tmp_str_size,GFP_KERNEL ); +if (!*out_str) +return "NOMEM" ; + n +=snprintf (*out_str + n, tmp_str_size - n,"|" );for (i =0 ; i < builder->num_valid; i++) {
@@ -344,6 +347,9 @@ static const char *format_ref_list_b(const struct v4l2_h264_reflist_builder *bui *out_str =kmalloc (tmp_str_size,GFP_KERNEL ); +if (!*out_str) +return "NOMEM" ; + n +=snprintf (*out_str + n, tmp_str_size - n,"|" );for (i =0 ; i < builder->num_valid; i++) {
Signature · 1 line
2.34.1
Hi Kang,
Quoted 4 lines · Kang Chen
kmalloc may fails,
*out_strmight be null and will cause illegal address access later.Signed-off-by Kang Chen <[email protected]>
This seems to have been addressed by commit be3ae7cf4326e95bb1d5413b63baabc26f4a1324 that's already in upstream.
Signature · 3 lines
Kind regards, Sakari Ailus