Skip to contentSkip to conversation

net/idpf: fix datapath function configuration

PATCH Applied Wenjun Wu 2 participants 2 messages Feb 27, 2023 Network drivers

lore
Share & tools
lore

Wenjun Wu

author
#0 lore raw

PATCH 1/1 net/idpf: fix datapath function configuration

Vector datapath is not support any advanced features for now, so disable vector path if TX checksum offload or RX scatter is enabled.

Fixes e528d7c74819 ("common/idpf: add AVX512 data path for split queue model")
---
 drivers/net/idpf/idpf_rxtx_vec_common.h | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
drivers/net/idpf/idpf_rxtx_vec_common.h +8 -1
index 9bb4ce62f8..2787d27616 100644
@@ -25,7 +25,11 @@
 		RTE_ETH_RX_OFFLOAD_TIMESTAMP)
 #define IDPF_TX_NO_VECTOR_FLAGS (		\
 		RTE_ETH_TX_OFFLOAD_TCP_TSO |	\
-		RTE_ETH_TX_OFFLOAD_MULTI_SEGS)
+		RTE_ETH_TX_OFFLOAD_MULTI_SEGS |	\
+		RTE_ETH_TX_OFFLOAD_IPV4_CKSUM |		\
+		RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |		\
+		RTE_ETH_TX_OFFLOAD_UDP_CKSUM |	\
+		RTE_ETH_TX_OFFLOAD_TCP_CKSUM)
 
 static inline int
 idpf_rx_vec_queue_default(struct idpf_rx_queue *rxq)
@@ -80,6 +84,9 @@ idpf_rx_vec_dev_check_default(struct rte_eth_dev *dev)
 	struct idpf_rx_queue *rxq;
 	int i, default_ret, splitq_ret, ret = IDPF_SCALAR_PATH;
 
+	if (dev->data->scattered_rx)
+		return IDPF_SCALAR_PATH;
+
 	for (i = 0; i < dev->data->nb_rx_queues; i++) {
 		rxq = dev->data->rx_queues[i];
 		default_ret = idpf_rx_vec_queue_default(rxq);
Signature · 1 line
2.34.1
Acked-by on v1 1/1 Applied
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: Wu, Wenjun1 <[email protected]>
Sent: Monday, February 27, 2023 1:37 PM
To: [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: Wu, Wenjun1 <[email protected]>
Subject: [PATCH v1] net/idpf: fix datapath function configuration

Quoted 7 lines

Vector datapath is not support any advanced features for now, so disable vector path if TX checksum offload or RX scatter is enabled.

Fixes e528d7c74819 ("common/idpf: add AVX512 data path for split queue

model")

Applied to dpdk-next-net-intel.

Thanks
Qi