mm/mmap.c:516 vma_prepare() error: we previously assumed 'vp->vma' could be null (see line 505)
Dan Carpenter
build botBCC: [email protected]
CC: [email protected]
CC: Ammar Faizi <[email protected]>
CC: "GNU/Weeb Mailing List" <[email protected]>
TO: Suren Baghdasaryan <[email protected]>
CC: Andrew Morton <[email protected]>
CC: Linux Memory Management List <[email protected]>
tree: https://github.com/ammarfaizi2/linux-block akpm/mm/mm-unstable head: 61edd3b68c3185673c9b05dfe48038692964c73b commit: f517f7ae341d933856cdf4d9d773027681ed5dff [82/99] mm/mmap: write-lock VMAs in vma_prepare before modifying them
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20230228/[email protected]/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Link: https://lore.kernel.org/r/[email protected]/
smatch warnings:mm/mmap.c:516 vma_prepare() error: we previously assumed 'vp->vma' could be null (see line 505)
vim +516 mm/mmap.c
68cefec539206e Liam R. Howlett 2023-01-20 497
68cefec539206e Liam R. Howlett 2023-01-20 498
440703e082b9c7 Liam R. Howlett 2023-01-20 499 /*
440703e082b9c7 Liam R. Howlett 2023-01-20 500 * vma_prepare() - Helper function for handling locking VMAs prior to altering
440703e082b9c7 Liam R. Howlett 2023-01-20 501 * @vp: The initialized vma_prepare struct
440703e082b9c7 Liam R. Howlett 2023-01-20 502 */
440703e082b9c7 Liam R. Howlett 2023-01-20 503 static inline void vma_prepare(struct vma_prepare *vp)
440703e082b9c7 Liam R. Howlett 2023-01-20 504 {
f517f7ae341d93 Suren Baghdasaryan 2023-02-27 @505 if (vp->vma)
f517f7ae341d93 Suren Baghdasaryan 2023-02-27 506 vma_start_write(vp->vma);
f517f7ae341d93 Suren Baghdasaryan 2023-02-27 507 if (vp->adj_next)
f517f7ae341d93 Suren Baghdasaryan 2023-02-27 508 vma_start_write(vp->adj_next);
f517f7ae341d93 Suren Baghdasaryan 2023-02-27 509 /* vp->insert is always a newly created VMA, no need for locking */
f517f7ae341d93 Suren Baghdasaryan 2023-02-27 510 if (vp->remove)
f517f7ae341d93 Suren Baghdasaryan 2023-02-27 511 vma_start_write(vp->remove);
f517f7ae341d93 Suren Baghdasaryan 2023-02-27 512 if (vp->remove2)
f517f7ae341d93 Suren Baghdasaryan 2023-02-27 513 vma_start_write(vp->remove2);
f517f7ae341d93 Suren Baghdasaryan 2023-02-27 514
440703e082b9c7 Liam R. Howlett 2023-01-20 515 if (vp->file) {
440703e082b9c7 Liam R. Howlett 2023-01-20 @516 uprobe_munmap(vp->vma, vp->vma->vm_start, vp->vma->vm_end);
440703e082b9c7 Liam R. Howlett 2023-01-20 517
440703e082b9c7 Liam R. Howlett 2023-01-20 518 if (vp->adj_next)
440703e082b9c7 Liam R. Howlett 2023-01-20 519 uprobe_munmap(vp->adj_next, vp->adj_next->vm_start,
440703e082b9c7 Liam R. Howlett 2023-01-20 520 vp->adj_next->vm_end);
440703e082b9c7 Liam R. Howlett 2023-01-20 521
440703e082b9c7 Liam R. Howlett 2023-01-20 522 i_mmap_lock_write(vp->mapping);
440703e082b9c7 Liam R. Howlett 2023-01-20 523 if (vp->insert && vp->insert->vm_file) {
440703e082b9c7 Liam R. Howlett 2023-01-20 524 /*
440703e082b9c7 Liam R. Howlett 2023-01-20 525 * Put into interval tree now, so instantiated pages
440703e082b9c7 Liam R. Howlett 2023-01-20 526 * are visible to arm/parisc __flush_dcache_page
440703e082b9c7 Liam R. Howlett 2023-01-20 527 * throughout; but we cannot insert into address
440703e082b9c7 Liam R. Howlett 2023-01-20 528 * space until vma start or end is updated.
440703e082b9c7 Liam R. Howlett 2023-01-20 529 */
440703e082b9c7 Liam R. Howlett 2023-01-20 530 __vma_link_file(vp->insert,
440703e082b9c7 Liam R. Howlett 2023-01-20 531 vp->insert->vm_file->f_mapping);
440703e082b9c7 Liam R. Howlett 2023-01-20 532 }
440703e082b9c7 Liam R. Howlett 2023-01-20 533 }
440703e082b9c7 Liam R. Howlett 2023-01-20 534
440703e082b9c7 Liam R. Howlett 2023-01-20 535 if (vp->anon_vma) {
440703e082b9c7 Liam R. Howlett 2023-01-20 536 anon_vma_lock_write(vp->anon_vma);
440703e082b9c7 Liam R. Howlett 2023-01-20 537 anon_vma_interval_tree_pre_update_vma(vp->vma);
440703e082b9c7 Liam R. Howlett 2023-01-20 538 if (vp->adj_next)
440703e082b9c7 Liam R. Howlett 2023-01-20 539 anon_vma_interval_tree_pre_update_vma(vp->adj_next);
440703e082b9c7 Liam R. Howlett 2023-01-20 540 }
440703e082b9c7 Liam R. Howlett 2023-01-20 541
440703e082b9c7 Liam R. Howlett 2023-01-20 542 if (vp->file) {
440703e082b9c7 Liam R. Howlett 2023-01-20 543 flush_dcache_mmap_lock(vp->mapping);
440703e082b9c7 Liam R. Howlett 2023-01-20 544 vma_interval_tree_remove(vp->vma, &vp->mapping->i_mmap);
440703e082b9c7 Liam R. Howlett 2023-01-20 545 if (vp->adj_next)
440703e082b9c7 Liam R. Howlett 2023-01-20 546 vma_interval_tree_remove(vp->adj_next,
440703e082b9c7 Liam R. Howlett 2023-01-20 547 &vp->mapping->i_mmap);
440703e082b9c7 Liam R. Howlett 2023-01-20 548 }
440703e082b9c7 Liam R. Howlett 2023-01-20 549 :::::: The code at line 516 was first introduced by commit
:::::: 440703e082b9c79c3d4fffcca8c2dffd621e6dc5 mm/mmap: refactor locking out of __vma_adjust()
:::::: TO: Liam R. Howlett <[email protected]> :::::: CC: Andrew Morton <[email protected]>
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
Quoted 11 lines · Dan Carpenter
tree: https://github.com/ammarfaizi2/linux-block akpm/mm/mm-unstable head: 61edd3b68c3185673c9b05dfe48038692964c73b commit: f517f7ae341d933856cdf4d9d773027681ed5dff [82/99] mm/mmap: write-lock VMAs in vma_prepare before modifying them config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20230228/[email protected]/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Link: https://lore.kernel.org/r/[email protected]/
Thanks for reporting!
Quoted 4 lines
smatch warnings:
mm/mmap.c:516vma_prepare()error: we previously assumed 'vp->vma' could be null (see line 505)
Quoted 8 lines
vim +516
mm/mmap.c440703e082b9c7 Liam R. Howlett 2023-01-20 503 static inline void vma_prepare(struct vma_prepare *vp) 440703e082b9c7 Liam R. Howlett 2023-01-20 504 {
f517f7ae341d93Suren Baghdasaryan 2023-02-27 @505 if (vp->vma)Check presumes that
vp->vmacan be NULL. On my other system (with yesterday's linux-next code)vp->vmacan never be NULL.
I think the check here is not needed since vp->vma should always be non-NULL. I'll double-check and will remove it if that is confirmed. Thanks,
Suren.
Quoted 55 lines
f517f7ae341d93 Suren Baghdasaryan 2023-02-27 506 vma_start_write(vp->vma); f517f7ae341d93 Suren Baghdasaryan 2023-02-27 507 if (vp->adj_next) f517f7ae341d93 Suren Baghdasaryan 2023-02-27 508 vma_start_write(vp->adj_next); f517f7ae341d93 Suren Baghdasaryan 2023-02-27 509 /* vp->insert is always a newly created VMA, no need for locking */ f517f7ae341d93 Suren Baghdasaryan 2023-02-27 510 if (vp->remove) f517f7ae341d93 Suren Baghdasaryan 2023-02-27 511 vma_start_write(vp->remove); f517f7ae341d93 Suren Baghdasaryan 2023-02-27 512 if (vp->remove2) f517f7ae341d93 Suren Baghdasaryan 2023-02-27 513 vma_start_write(vp->remove2); f517f7ae341d93 Suren Baghdasaryan 2023-02-27 514 440703e082b9c7 Liam R. Howlett 2023-01-20 515 if (vp->file) { 440703e082b9c7 Liam R. Howlett 2023-01-20 @516 uprobe_munmap(vp->vma, vp->vma->vm_start, vp->vma->vm_end); ^^^^^^^Uncheck dereference.
440703e082b9c7 Liam R. Howlett 2023-01-20 517 440703e082b9c7 Liam R. Howlett 2023-01-20 518 if (vp->adj_next) 440703e082b9c7 Liam R. Howlett 2023-01-20 519 uprobe_munmap(vp->adj_next, vp->adj_next->vm_start, 440703e082b9c7 Liam R. Howlett 2023-01-20 520 vp->adj_next->vm_end); 440703e082b9c7 Liam R. Howlett 2023-01-20 521 440703e082b9c7 Liam R. Howlett 2023-01-20 522 i_mmap_lock_write(vp->mapping); 440703e082b9c7 Liam R. Howlett 2023-01-20 523 if (vp->insert && vp->insert->vm_file) { 440703e082b9c7 Liam R. Howlett 2023-01-20 524 /* 440703e082b9c7 Liam R. Howlett 2023-01-20 525 * Put into interval tree now, so instantiated pages 440703e082b9c7 Liam R. Howlett 2023-01-20 526 * are visible to arm/parisc __flush_dcache_page 440703e082b9c7 Liam R. Howlett 2023-01-20 527 * throughout; but we cannot insert into address 440703e082b9c7 Liam R. Howlett 2023-01-20 528 * space until vma start or end is updated. 440703e082b9c7 Liam R. Howlett 2023-01-20 529 */ 440703e082b9c7 Liam R. Howlett 2023-01-20 530 __vma_link_file(vp->insert, 440703e082b9c7 Liam R. Howlett 2023-01-20 531 vp->insert->vm_file->f_mapping); 440703e082b9c7 Liam R. Howlett 2023-01-20 532 } 440703e082b9c7 Liam R. Howlett 2023-01-20 533 } 440703e082b9c7 Liam R. Howlett 2023-01-20 534 440703e082b9c7 Liam R. Howlett 2023-01-20 535 if (vp->anon_vma) { 440703e082b9c7 Liam R. Howlett 2023-01-20 536 anon_vma_lock_write(vp->anon_vma); 440703e082b9c7 Liam R. Howlett 2023-01-20 537 anon_vma_interval_tree_pre_update_vma(vp->vma);More unchecked dereferences.
440703e082b9c7 Liam R. Howlett 2023-01-20 538 if (vp->adj_next) 440703e082b9c7 Liam R. Howlett 2023-01-20 539 anon_vma_interval_tree_pre_update_vma(vp->adj_next); 440703e082b9c7 Liam R. Howlett 2023-01-20 540 } 440703e082b9c7 Liam R. Howlett 2023-01-20 541 440703e082b9c7 Liam R. Howlett 2023-01-20 542 if (vp->file) { 440703e082b9c7 Liam R. Howlett 2023-01-20 543 flush_dcache_mmap_lock(vp->mapping); 440703e082b9c7 Liam R. Howlett 2023-01-20 544 vma_interval_tree_remove(vp->vma, &vp->mapping->i_mmap); 440703e082b9c7 Liam R. Howlett 2023-01-20 545 if (vp->adj_next) 440703e082b9c7 Liam R. Howlett 2023-01-20 546 vma_interval_tree_remove(vp->adj_next, 440703e082b9c7 Liam R. Howlett 2023-01-20 547 &vp->mapping->i_mmap); 440703e082b9c7 Liam R. Howlett 2023-01-20 548 }--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
Quoted 26 lines · Suren Baghdasaryan
Quoted 11 lines · Dan Carpenter
tree: https://github.com/ammarfaizi2/linux-block akpm/mm/mm-unstable head: 61edd3b68c3185673c9b05dfe48038692964c73b commit: f517f7ae341d933856cdf4d9d773027681ed5dff [82/99] mm/mmap: write-lock VMAs in vma_prepare before modifying them config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20230228/[email protected]/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Link: https://lore.kernel.org/r/[email protected]/Thanks for reporting!
Quoted 10 lines
smatch warnings:
mm/mmap.c:516vma_prepare()error: we previously assumed 'vp->vma' could be null (see line 505)vim +516
mm/mmap.c440703e082b9c7 Liam R. Howlett 2023-01-20 503 static inline void vma_prepare(struct vma_prepare *vp) 440703e082b9c7 Liam R. Howlett 2023-01-20 504 {
f517f7ae341d93Suren Baghdasaryan 2023-02-27 @505 if (vp->vma)
Quoted 5 lines
Quoted 2 lines
Check presumes that
vp->vmacan be NULL. On my other system (with yesterday's linux-next code)vp->vmacan never be NULL.I think the check here is not needed since
vp->vmashould always be non-NULL. I'll double-check and will remove it if that is confirmed.
Fix is posted at
https://lore.kernel.org/all/[email protected]/
Quoted 58 lines
Thanks,
Suren.Quoted 55 lines
f517f7ae341d93 Suren Baghdasaryan 2023-02-27 506 vma_start_write(vp->vma); f517f7ae341d93 Suren Baghdasaryan 2023-02-27 507 if (vp->adj_next) f517f7ae341d93 Suren Baghdasaryan 2023-02-27 508 vma_start_write(vp->adj_next); f517f7ae341d93 Suren Baghdasaryan 2023-02-27 509 /* vp->insert is always a newly created VMA, no need for locking */ f517f7ae341d93 Suren Baghdasaryan 2023-02-27 510 if (vp->remove) f517f7ae341d93 Suren Baghdasaryan 2023-02-27 511 vma_start_write(vp->remove); f517f7ae341d93 Suren Baghdasaryan 2023-02-27 512 if (vp->remove2) f517f7ae341d93 Suren Baghdasaryan 2023-02-27 513 vma_start_write(vp->remove2); f517f7ae341d93 Suren Baghdasaryan 2023-02-27 514 440703e082b9c7 Liam R. Howlett 2023-01-20 515 if (vp->file) { 440703e082b9c7 Liam R. Howlett 2023-01-20 @516 uprobe_munmap(vp->vma, vp->vma->vm_start, vp->vma->vm_end); ^^^^^^^Uncheck dereference.
440703e082b9c7 Liam R. Howlett 2023-01-20 517 440703e082b9c7 Liam R. Howlett 2023-01-20 518 if (vp->adj_next) 440703e082b9c7 Liam R. Howlett 2023-01-20 519 uprobe_munmap(vp->adj_next, vp->adj_next->vm_start, 440703e082b9c7 Liam R. Howlett 2023-01-20 520 vp->adj_next->vm_end); 440703e082b9c7 Liam R. Howlett 2023-01-20 521 440703e082b9c7 Liam R. Howlett 2023-01-20 522 i_mmap_lock_write(vp->mapping); 440703e082b9c7 Liam R. Howlett 2023-01-20 523 if (vp->insert && vp->insert->vm_file) { 440703e082b9c7 Liam R. Howlett 2023-01-20 524 /* 440703e082b9c7 Liam R. Howlett 2023-01-20 525 * Put into interval tree now, so instantiated pages 440703e082b9c7 Liam R. Howlett 2023-01-20 526 * are visible to arm/parisc __flush_dcache_page 440703e082b9c7 Liam R. Howlett 2023-01-20 527 * throughout; but we cannot insert into address 440703e082b9c7 Liam R. Howlett 2023-01-20 528 * space until vma start or end is updated. 440703e082b9c7 Liam R. Howlett 2023-01-20 529 */ 440703e082b9c7 Liam R. Howlett 2023-01-20 530 __vma_link_file(vp->insert, 440703e082b9c7 Liam R. Howlett 2023-01-20 531 vp->insert->vm_file->f_mapping); 440703e082b9c7 Liam R. Howlett 2023-01-20 532 } 440703e082b9c7 Liam R. Howlett 2023-01-20 533 } 440703e082b9c7 Liam R. Howlett 2023-01-20 534 440703e082b9c7 Liam R. Howlett 2023-01-20 535 if (vp->anon_vma) { 440703e082b9c7 Liam R. Howlett 2023-01-20 536 anon_vma_lock_write(vp->anon_vma); 440703e082b9c7 Liam R. Howlett 2023-01-20 537 anon_vma_interval_tree_pre_update_vma(vp->vma);More unchecked dereferences.
440703e082b9c7 Liam R. Howlett 2023-01-20 538 if (vp->adj_next) 440703e082b9c7 Liam R. Howlett 2023-01-20 539 anon_vma_interval_tree_pre_update_vma(vp->adj_next); 440703e082b9c7 Liam R. Howlett 2023-01-20 540 } 440703e082b9c7 Liam R. Howlett 2023-01-20 541 440703e082b9c7 Liam R. Howlett 2023-01-20 542 if (vp->file) { 440703e082b9c7 Liam R. Howlett 2023-01-20 543 flush_dcache_mmap_lock(vp->mapping); 440703e082b9c7 Liam R. Howlett 2023-01-20 544 vma_interval_tree_remove(vp->vma, &vp->mapping->i_mmap); 440703e082b9c7 Liam R. Howlett 2023-01-20 545 if (vp->adj_next) 440703e082b9c7 Liam R. Howlett 2023-01-20 546 vma_interval_tree_remove(vp->adj_next, 440703e082b9c7 Liam R. Howlett 2023-01-20 547 &vp->mapping->i_mmap); 440703e082b9c7 Liam R. Howlett 2023-01-20 548 }--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
Quoted 27 lines · Suren Baghdasaryan
Quoted 26 lines · Suren Baghdasaryan
Quoted 11 lines · Dan Carpenter
tree: https://github.com/ammarfaizi2/linux-block akpm/mm/mm-unstable head: 61edd3b68c3185673c9b05dfe48038692964c73b commit: f517f7ae341d933856cdf4d9d773027681ed5dff [82/99] mm/mmap: write-lock VMAs in vma_prepare before modifying them config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20230228/[email protected]/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Link: https://lore.kernel.org/r/[email protected]/Thanks for reporting!
Quoted 10 lines
smatch warnings:
mm/mmap.c:516vma_prepare()error: we previously assumed 'vp->vma' could be null (see line 505)vim +516
mm/mmap.c440703e082b9c7 Liam R. Howlett 2023-01-20 503 static inline void vma_prepare(struct vma_prepare *vp) 440703e082b9c7 Liam R. Howlett 2023-01-20 504 {
f517f7ae341d93Suren Baghdasaryan 2023-02-27 @505 if (vp->vma)
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Check presumes that
vp->vmacan be NULL. On my other system (with yesterday's linux-next code)vp->vmacan never be NULL.I think the check here is not needed since
vp->vmashould always be non-NULL. I'll double-check and will remove it if that is confirmed.Fix is posted at
https://lore.kernel.org/all/[email protected]/
Thanks!
regards,
dan carpenter