Skip to contentSkip to conversation

staging: rtl8192e: Remove function ..dm_check_ac_dc_power calling a script

PATCH In review Philipp Hortmann 2 participants 2 messages Feb 28, 2023 – Mar 8, 2023 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8192e: Remove function ..dm_check_ac_dc_power calling a script

Remove function _rtl92e_dm_check_ac_dc_power calling a script /etc/acpi/wireless-rtl-ac-dc-power.sh that is not available. This script is not part of the kernel and it is not available on the www. The result is that this function is just dead code.

---
I found a hint in this blog about the content of the script:
https://www.kubuntuforums.net/forum/archives/eol-releases/-9-10/network-
support-ai/41269-realtek-lan-connection-timeout

If you know more about the purpose and the need for this script please respond.

Tested with rtl8192e
Transferred this patch over wlan connection of rtl8192e

---
 drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 23 ----------------------
 1 file changed, 23 deletions(-)
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +0 -23
index d8455b23e555..c04eb15c4044 100644
@@ -185,7 +185,6 @@ static void _rtl92e_dm_init_fsync(struct net_device *dev);
 static void _rtl92e_dm_deinit_fsync(struct net_device *dev);
 
 static	void _rtl92e_dm_check_txrateandretrycount(struct net_device *dev);
-static  void _rtl92e_dm_check_ac_dc_power(struct net_device *dev);
 static void _rtl92e_dm_check_fsync(struct net_device *dev);
 static void _rtl92e_dm_check_rf_ctrl_gpio(void *data);
 static void _rtl92e_dm_fsync_timer_callback(struct timer_list *t);
@@ -236,8 +235,6 @@ void rtl92e_dm_watchdog(struct net_device *dev)
 	if (priv->being_init_adapter)
 		return;
 
-	_rtl92e_dm_check_ac_dc_power(dev);
-
 	_rtl92e_dm_check_txrateandretrycount(dev);
 	_rtl92e_dm_check_edca_turbo(dev);
 
@@ -255,26 +252,6 @@ void rtl92e_dm_watchdog(struct net_device *dev)
 	_rtl92e_dm_cts_to_self(dev);
 }
 
-static void _rtl92e_dm_check_ac_dc_power(struct net_device *dev)
-{
-	struct r8192_priv *priv = rtllib_priv(dev);
-	static const char ac_dc_script[] = "/etc/acpi/wireless-rtl-ac-dc-power.sh";
-	char *argv[] = {(char *)ac_dc_script, DRV_NAME, NULL};
-	static char *envp[] = {"HOME=/",
-			"TERM=linux",
-			"PATH=/usr/bin:/bin",
-			 NULL};
-
-	if (priv->rst_progress == RESET_TYPE_SILENT)
-		return;
-	if (priv->rtllib->state != RTLLIB_LINKED)
-		return;
-	call_usermodehelper(ac_dc_script, argv, envp, UMH_WAIT_PROC);
-
-	return;
-};
-
-
 void rtl92e_init_adaptive_rate(struct net_device *dev)
 {
 
Signature · 1 line
2.39.2
#1 lore raw
Quoted 5 lines · Philipp Hortmann

Remove function _rtl92e_dm_check_ac_dc_power calling a script /etc/acpi/wireless-rtl-ac-dc-power.sh that is not available. This script is not part of the kernel and it is not available on the www. The result is that this function is just dead code.

Quoted 8 lines

---
I found a hint in this blog about the content of the script:
https://www.kubuntuforums.net/forum/archives/eol-releases/-9-10/network-
support-ai/41269-realtek-lan-connection-timeout

If you know more about the purpose and the need for this script please respond.

Good catch, that shouldn't be there at all.

greg k-h