Skip to contentSkip to conversation

pinctrl: rockchip: support rk3588 pinctrl

PATCH Superseded Eugen Hristev 2 participants 5 messages Mar 1, 2023

Subsystems (2)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: rockchip: support rk3588 pinctrl

From: Jianqun Xu <[email protected]>

Add support for Rockchip rk3588 variant of pinctrl.

The driver is adapted from the Linux driver.

[[email protected]:
port to latest U-boot, bring more changes from Linux]

---
 drivers/pinctrl/rockchip/Makefile           |   1 +
 drivers/pinctrl/rockchip/pinctrl-rk3588.c   | 350 ++++++++++++++++++++
 drivers/pinctrl/rockchip/pinctrl-rockchip.h | 187 +++++++++++
 3 files changed, 538 insertions(+)
 create mode 100644 drivers/pinctrl/rockchip/pinctrl-rk3588.c
drivers/pinctrl/rockchip/Makefile +1 -0
index 90461ae8819a..c91f650b0434 100644
@@ -15,5 +15,6 @@ obj-$(CONFIG_ROCKCHIP_RK3328) += pinctrl-rk3328.o
 obj-$(CONFIG_ROCKCHIP_RK3368) += pinctrl-rk3368.o
 obj-$(CONFIG_ROCKCHIP_RK3399) += pinctrl-rk3399.o
 obj-$(CONFIG_ROCKCHIP_RK3568) += pinctrl-rk3568.o
+obj-$(CONFIG_ROCKCHIP_RK3588) += pinctrl-rk3588.o
 obj-$(CONFIG_ROCKCHIP_RV1108) += pinctrl-rv1108.o
 obj-$(CONFIG_ROCKCHIP_RV1126) += pinctrl-rv1126.o
drivers/pinctrl/rockchip/pinctrl-rk3588.c new file +350 -0

350 lines not on this page · raw message

drivers/pinctrl/rockchip/pinctrl-rockchip.h +187 -0

205 lines not on this page · raw message

Signature · 1 line
2.34.1
#2 lore raw
Quoted 14 lines · Jagan Teki
Quoted 5 lines · Eugen Hristev

From: Jianqun Xu <[email protected]>

Add support for Rockchip rk3588 variant of pinctrl.

Quoted 7 lines

The driver is adapted from the Linux driver.

[[email protected]:
port to latest U-boot, bring more changes from Linux]

---

Quoted 3 lines

It would be good if it tested with any function, does it?

Jagan.

Hello Jagan,

To test it with GPIO, I also added this patch to my test bench :

https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

And then, I was able to test with GPIO : powering up a LED , powering it down, also tested USB host by having the VBUS powered up by GPIO / powered down.

Other pinctrl functions tested were to boot from SD-Card, in which U-boot sets the right pinfunc for the SD pins.

 pinconfig   100  [ + ]   pinconfig             |   |-- sdmmc
 pinconfig   101  [ + ]   pinconfig             |   |   |-- sdmmc-bus4
 pinconfig   102  [ + ]   pinconfig             |   |   |-- sdmmc-clk
 pinconfig   103  [ + ]   pinconfig             |   |   |-- sdmmc-cmd
 pinconfig   104  [ + ]   pinconfig             |   |   `-- sdmmc-det
...
 pinconfig   132  [ + ]   pinconfig             |   |-- uart2
 pinconfig   133  [ + ]   pinconfig             |   |   `-- uart2m0-xfer

=> gpio toggle A15
gpio: pin A15 (gpio 15) value is 1

Eugen

#3 lore raw
Quoted 42 lines · Eugen Hristev
Quoted 14 lines · Jagan Teki
Quoted 5 lines · Eugen Hristev

From: Jianqun Xu <[email protected]>

Add support for Rockchip rk3588 variant of pinctrl.

Quoted 7 lines

The driver is adapted from the Linux driver.

[[email protected]:
port to latest U-boot, bring more changes from Linux]

---

Quoted 3 lines

It would be good if it tested with any function, does it?

Jagan.

Hello Jagan,

To test it with GPIO, I also added this patch to my test bench :

https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

And then, I was able to test with GPIO : powering up a LED , powering it down, also tested USB host by having the VBUS powered up by GPIO / powered down.

Other pinctrl functions tested were to boot from SD-Card, in which U-boot sets the right pinfunc for the SD pins.

  pinconfig   100  [ + ]   pinconfig             |   |-- sdmmc
  pinconfig   101  [ + ]   pinconfig             |   |   |-- sdmmc-bus4
  pinconfig   102  [ + ]   pinconfig             |   |   |-- sdmmc-clk
  pinconfig   103  [ + ]   pinconfig             |   |   |-- sdmmc-cmd
  pinconfig   104  [ + ]   pinconfig             |   |   `-- sdmmc-det
...
  pinconfig   132  [ + ]   pinconfig             |   |-- uart2
  pinconfig   133  [ + ]   pinconfig             |   |   `-- uart2m0-xfer
Quoted 2 lines

=> gpio toggle A15
gpio: pin A15 (gpio 15) value is 1

Look good to me, thanks.

Jagan.