s390x: spec_ex: Add test for misaligned load
PATCH 1/1 s390x: spec_ex: Add test for misaligned load
The operand of LOAD RELATIVE LONG must be word aligned, otherwise a specification exception occurs. Test that this exception occurs.
---
Noticed while writing another test that TCG fails this requirement, so thought it best do document this in the form of a test.
s390x/spec_ex.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-)
s390x/spec_ex.c +19 -2
@@ -136,7 +136,7 @@ static int short_psw_bit_12_is_0(void)return 0 ; } -static int bad_alignment (void ) +static int bad_alignment_lqp (void ) { uint32_t words[5] __attribute__((aligned(16)));uint32_t (*bad_aligned)[4 ] = (uint32_t (*)[4 ])&words[1 ];
@@ -149,6 +149,22 @@ static int bad_alignment(void)return 0 ; } +static int bad_alignment_lrl (void ) +{ +uint64_t r; + + asmvolatile (".pushsection .rodata\n" +" .balign 4\n" +" . = . + 2\n" +"0: .fill 4\n" +" .popsection\n" + +" lrl %0,0b\n" + :"=d" (r) + ); +return 0 ; +} +static int not_even (void ) { uint64_t quad[2] __attribute__((aligned(16))) = {0};
@@ -176,7 +192,8 @@ struct spec_ex_trigger {static const struct spec_ex_trigger spec_ex_triggers[] = { {"psw_bit_12_is_1" , &psw_bit_12_is_1, false, &fixup_invalid_psw }, {"short_psw_bit_12_is_0" , &short_psw_bit_12_is_0, false, &fixup_invalid_psw }, - {"bad_alignment" , &bad_alignment, true,NULL }, + {"bad_alignment_lqp" , &bad_alignment_lqp, true,NULL }, + {"bad_alignment_lrl" , &bad_alignment_lrl, true,NULL }, {"not_even" , ¬_even, true,NULL }, {NULL ,NULL , false,NULL }, };
base-commit: e3c5c3ef2524c58023073c0fadde2e8ae3c04ec6
Signature · 1 line
2.36.1
Quoted 2 lines · On Wed, 1 Mar 2023 14:26:38 +0100 Nina Schoetterl-Glausch <[email protected]>…
The operand of LOAD RELATIVE LONG must be word aligned, otherwise a specification exception occurs. Test that this exception occurs.
you're only testing halfword misalignment; would it make sense to test all possible misalignments? (it's only 3 of them after all)
Quoted 26 lines
Signed-off-by Nina Schoetterl-Glausch <[email protected]>---
Noticed while writing another test that TCG fails this requirement, so thought it best do document this in the form of a test.
s390x/spec_ex.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-)s390x/spec_ex.c +1
-1@@ -136,7 +136,7 @@ static int short_psw_bit_12_is_0(void)return 0 ; } -static int bad_alignment (void ) +static int bad_alignment_lqp (void ) { uint32_t words[5] __attribute__((aligned(16)));uint32_t (*bad_aligned)[4 ] = (uint32_t (*)[4 ])&words[1 ];
s390x/spec_ex.c static int bad_alignment(void) · line 156
Quoted 8 lines
s390x/spec_ex.c +5
-0@@ -149,6 +149,22 @@ static int bad_alignment(void)return 0 ; } +static int bad_alignment_lrl (void ) +{ +uint64_t r; + + asm volatile ( ".pushsection .rodata\n"
why not declare this as a local array?
uint8_t stuff[8] __attribute__((aligned(8)));
s390x/spec_ex.c static int bad_alignment(void) · line 163
Quoted 7 lines
s390x/spec_ex.c +7
-0+ " .balign 4\n" + " . = . + 2\n" + "0: .fill 4\n" + " .popsection\n" + + " lrl %0,0b\n" + : "=d" (r)
and here pass stuff + 1 or something like that?
less asm = more readable
Quoted 19 lines
s390x/spec_ex.c +6
-1+ ); +return 0 ; +} +static int not_even (void ) { uint64_t quad[2] __attribute__((aligned(16))) = {0};@@ -176,7 +192,8 @@ struct spec_ex_trigger {static const struct spec_ex_trigger spec_ex_triggers[] = { {"psw_bit_12_is_1" , &psw_bit_12_is_1, false, &fixup_invalid_psw }, {"short_psw_bit_12_is_0" , &short_psw_bit_12_is_0, false, &fixup_invalid_psw }, - {"bad_alignment" , &bad_alignment, true,NULL }, + {"bad_alignment_lqp" , &bad_alignment_lqp, true,NULL }, + {"bad_alignment_lrl" , &bad_alignment_lrl, true,NULL }, {"not_even" , ¬_even, true,NULL }, {NULL ,NULL , false,NULL }, };base-commit:
e3c5c3ef2524c58023073c0fadde2e8ae3c04ec6
Quoted 8 lines · Claudio Imbrenda
Quoted 2 lines · On Wed, 1 Mar 2023 14:26:38 +0100 Nina Schoetterl-Glausch <[email protected]>…
The operand of LOAD RELATIVE LONG must be word aligned, otherwise a specification exception occurs. Test that this exception occurs.
you're only testing halfword misalignment; would it make sense to test all possible misalignments? (it's only 3 of them after all)
No, that's not possible, the address calculation is:insn_addr + immediate * 2
So for LRL there is only one possible misalignment. For LGRL there are multiple, tho.
Quoted 30 lines
Quoted 30 lines
Signed-off-by Nina Schoetterl-Glausch <[email protected]>---
Noticed while writing another test that TCG fails this requirement, so thought it best do document this in the form of a test.
s390x/spec_ex.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-)s390x/spec_ex.c +1
-1@@ -136,7 +136,7 @@ static int short_psw_bit_12_is_0(void)return 0 ; } -static int bad_alignment (void ) +static int bad_alignment_lqp (void ) { uint32_t words[5] __attribute__((aligned(16)));uint32_t (*bad_aligned)[4 ] = (uint32_t (*)[4 ])&words[1 ];@@ -149,6 +149,22 @@ static int bad_alignment(void)return 0 ; }
Quoted 7 lines
s390x/spec_ex.c static int bad_alignment(void) · line 156
Quoted 5 lines
s390x/spec_ex.c +5
-0+static int bad_alignment_lrl (void ) +{ +uint64_t r; + + asm volatile ( ".pushsection .rodata\n"why not declare this as a local array?
I cannot put it on the stack, since I need a relative offset. I guess I could use a global symbol, but that also makes the test less self-contained.
Quoted 35 lines
uint8_tstuff[8] __attribute__((aligned(8)));s390x/spec_ex.c static int bad_alignment(void) · line 163
Quoted 7 lines
s390x/spec_ex.c +7
-0+ " .balign 4\n" + " . = . + 2\n" + "0: .fill 4\n" + " .popsection\n" + + " lrl %0,0b\n" + : "=d" (r)and here pass stuff + 1 or something like that?
less asm = more readable
Quoted 19 lines
s390x/spec_ex.c +6
-1+ ); +return 0 ; +} +static int not_even (void ) { uint64_t quad[2] __attribute__((aligned(16))) = {0};@@ -176,7 +192,8 @@ struct spec_ex_trigger {static const struct spec_ex_trigger spec_ex_triggers[] = { {"psw_bit_12_is_1" , &psw_bit_12_is_1, false, &fixup_invalid_psw }, {"short_psw_bit_12_is_0" , &short_psw_bit_12_is_0, false, &fixup_invalid_psw }, - {"bad_alignment" , &bad_alignment, true,NULL }, + {"bad_alignment_lqp" , &bad_alignment_lqp, true,NULL }, + {"bad_alignment_lrl" , &bad_alignment_lrl, true,NULL }, {"not_even" , ¬_even, true,NULL }, {NULL ,NULL , false,NULL }, };base-commit:
e3c5c3ef2524c58023073c0fadde2e8ae3c04ec6
Quoted 4 lines · On Wed, 1 Mar 2023 14:26:38 +0100 Nina Schoetterl-Glausch <[email protected]>…
The operand of LOAD RELATIVE LONG must be word aligned, otherwise a specification exception occurs. Test that this exception occurs.
Signed-off-by Nina Schoetterl-Glausch <[email protected]>
Quoted 58 lines
---
Noticed while writing another test that TCG fails this requirement, so thought it best do document this in the form of a test.
s390x/spec_ex.c | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-)s390x/spec_ex.c +19
-2@@ -136,7 +136,7 @@ static int short_psw_bit_12_is_0(void)return 0 ; } -static int bad_alignment (void ) +static int bad_alignment_lqp (void ) { uint32_t words[5] __attribute__((aligned(16)));uint32_t (*bad_aligned)[4 ] = (uint32_t (*)[4 ])&words[1 ];@@ -149,6 +149,22 @@ static int bad_alignment(void)return 0 ; } +static int bad_alignment_lrl (void ) +{ +uint64_t r; + + asmvolatile (".pushsection .rodata\n" +" .balign 4\n" +" . = . + 2\n" +"0: .fill 4\n" +" .popsection\n" + +" lrl %0,0b\n" + :"=d" (r) + ); +return 0 ; +} +static int not_even (void ) { uint64_t quad[2] __attribute__((aligned(16))) = {0};@@ -176,7 +192,8 @@ struct spec_ex_trigger {static const struct spec_ex_trigger spec_ex_triggers[] = { {"psw_bit_12_is_1" , &psw_bit_12_is_1, false, &fixup_invalid_psw }, {"short_psw_bit_12_is_0" , &short_psw_bit_12_is_0, false, &fixup_invalid_psw }, - {"bad_alignment" , &bad_alignment, true,NULL }, + {"bad_alignment_lqp" , &bad_alignment_lqp, true,NULL }, + {"bad_alignment_lrl" , &bad_alignment_lrl, true,NULL }, {"not_even" , ¬_even, true,NULL }, {NULL ,NULL , false,NULL }, };base-commit:
e3c5c3ef2524c58023073c0fadde2e8ae3c04ec6
Quoting Nina Schoetterl-Glausch (2023-03-01 14:26:38)
Quoted 4 lines
The operand of LOAD RELATIVE LONG must be word aligned, otherwise a specification exception occurs. Test that this exception occurs.
Signed-off-by Nina Schoetterl-Glausch <[email protected]>
Nico Boehr
AppliedQuoting Nina Schoetterl-Glausch (2023-03-01 14:26:38)
Quoted 4 lines
The operand of LOAD RELATIVE LONG must be word aligned, otherwise a specification exception occurs. Test that this exception occurs.
Signed-off-by Nina Schoetterl-Glausch <[email protected]>
queued, thanks.