Skip to contentSkip to conversation

media: platform: via: Handle error for dma_set_mask

PATCH New harperchen 1 participant 1 message Mar 3, 2023 Media (V4L/DVB)

lore
Share & tools
lore

harperchen

author
#0 lore raw

PATCH 1/1 media: platform: via: Handle error for dma_set_mask

As the potential failure of the dma_set_mask(), we fix this bug by checking its return value and performing proper error handling.

---
 drivers/media/platform/via/via-camera.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/media/platform/via/via-camera.c +3 -1
index 95483c84c3f2..885917cff738 100644
@@ -1208,7 +1208,9 @@ static int viacam_probe(struct platform_device *pdev)
 	 * Convince the system that we can do DMA.
 	 */
 	pdev->dev.dma_mask = &viadev->pdev->dma_mask;
-	dma_set_mask(&pdev->dev, 0xffffffff);
+	ret = dma_set_mask(&pdev->dev, 0xffffffff);
+	if (ret)
+		goto out_ctrl_hdl_free;
 	/*
 	 * Fire up the capture port.  The write to 0x78 looks purely
 	 * OLPCish; any system will need to tweak 0x1e.
Signature · 1 line
2.25.1