Skip to contentSkip to conversation

media: ipu3-cio2: support more camera sensors in cio2-bridge

PATCH In review [email protected] 4 participants 4 messages Mar 3, 2023 – Mar 31, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 media: ipu3-cio2: support more camera sensors in cio2-bridge

From: Bingbu Cao <[email protected]>

Add more camera sensors into the supported camera sensors list to make cio2-bridge to support more camera sensors.

---
Changes from v1:
- remove some sensors without available drivers
- add .link_frequencies for each sensor

---
 drivers/media/pci/intel/ipu3/cio2-bridge.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/media/pci/intel/ipu3/cio2-bridge.c +8 -0
index dfefe0d8aa95..d59bec8a94e2 100644
@@ -29,6 +29,14 @@ static const struct cio2_sensor_config cio2_supported_sensors[] = {
 	CIO2_SENSOR_CONFIG("INT347E", 1, 319200000),
 	/* Omnivision OV2680 */
 	CIO2_SENSOR_CONFIG("OVTI2680", 0),
+	/* Omnivision ov8856 */
+	CIO2_SENSOR_CONFIG("OVTI8856", 3, 180000000, 360000000, 720000000),
+	/* Omnivision ov2740 */
+	CIO2_SENSOR_CONFIG("INT3474", 1, 360000000),
+	/* Hynix hi556 */
+	CIO2_SENSOR_CONFIG("INT3537", 1, 437000000),
+	/* Omnivision ov13b10 */
+	CIO2_SENSOR_CONFIG("OVTIDB10", 1, 560000000),
 };
 
 static const struct cio2_property_names prop_names = {
Signature · 1 line
2.39.1
maintainer Reviewed-by on v2 1/1
#1 lore raw

Good morning Bingbu

Quoted 6 lines · On 03/03/2023 18:15, [email protected] wrote:

From: Bingbu Cao <[email protected]>

Add more camera sensors into the supported camera sensors list to make cio2-bridge to support more camera sensors.

Thanks; this looks ok to me now:

Quoted 28 lines

---
Changes from v1:
- remove some sensors without available drivers
- add .link_frequencies for each sensor

---
  drivers/media/pci/intel/ipu3/cio2-bridge.c | 8 ++++++++
  1 file changed, 8 insertions(+)
drivers/media/pci/intel/ipu3/cio2-bridge.c +8 -0
index dfefe0d8aa95..d59bec8a94e2 100644
@@ -29,6 +29,14 @@ static const struct cio2_sensor_config cio2_supported_sensors[] = {
  	CIO2_SENSOR_CONFIG("INT347E", 1, 319200000),
  	/* Omnivision OV2680 */
  	CIO2_SENSOR_CONFIG("OVTI2680", 0),
+	/* Omnivision ov8856 */
+	CIO2_SENSOR_CONFIG("OVTI8856", 3, 180000000, 360000000, 720000000),
+	/* Omnivision ov2740 */
+	CIO2_SENSOR_CONFIG("INT3474", 1, 360000000),
+	/* Hynix hi556 */
+	CIO2_SENSOR_CONFIG("INT3537", 1, 437000000),
+	/* Omnivision ov13b10 */
+	CIO2_SENSOR_CONFIG("OVTIDB10", 1, 560000000),
  };
 
  static const struct cio2_property_names prop_names = {
#2 lore raw
Quoted 8 lines · Dan Scally

Good morning Bingbu

Quoted 5 lines · On 03/03/2023 18:15, [email protected] wrote:

From: Bingbu Cao <[email protected]>

Add more camera sensors into the supported camera sensors list to make cio2-bridge to support more camera sensors.

Quoted 7 lines
Quoted 1 line

Thanks; this looks ok to me now:

Sakari,

Will you pick this change?

Quoted 27 lines
Quoted 27 lines

---
Changes from v1:
  - remove some sensors without available drivers
  - add .link_frequencies for each sensor

---
  drivers/media/pci/intel/ipu3/cio2-bridge.c | 8 ++++++++

  1 file changed, 8 insertions(+)
drivers/media/pci/intel/ipu3/cio2-bridge.c +8 -0
index dfefe0d8aa95..d59bec8a94e2 100644
@@ -29,6 +29,14 @@ static const struct cio2_sensor_config cio2_supported_sensors[] = {
       CIO2_SENSOR_CONFIG("INT347E", 1, 319200000),
       /* Omnivision OV2680 */
       CIO2_SENSOR_CONFIG("OVTI2680", 0),
+    /* Omnivision ov8856 */
+    CIO2_SENSOR_CONFIG("OVTI8856", 3, 180000000, 360000000, 720000000),
+    /* Omnivision ov2740 */
+    CIO2_SENSOR_CONFIG("INT3474", 1, 360000000),
+    /* Hynix hi556 */
+    CIO2_SENSOR_CONFIG("INT3537", 1, 437000000),
+    /* Omnivision ov13b10 */
+    CIO2_SENSOR_CONFIG("OVTIDB10", 1, 560000000),
   };
     static const struct cio2_property_names prop_names = {
Signature · 2 lines
Best regards,
Bingbu Cao
maintainer
#3 lore raw

Hi Bingbu,

Quoted 12 lines · Bingbu Cao
Quoted 10 lines · Dan Scally

Good morning Bingbu

Quoted 6 lines · On 03/03/2023 18:15, [email protected] wrote:

From: Bingbu Cao <[email protected]>

Add more camera sensors into the supported camera sensors list to make cio2-bridge to support more camera sensors.

Quoted 8 lines
Quoted 5 lines

Thanks; this looks ok to me now:

Sakari,

Will you pick this change?

Thanks for the ping. I must have mistakenly mark this as "under review" in patchwork earlier. It's in my tree now.

Signature · 3 lines
Kind regards,

Sakari Ailus