PCI/AER: Remove redundant Device Control Error Reporting Enable
Subsystems (2)
cover PCI/AER: Remove redundant Device Control Error Reporting Enable
From: Bjorn Helgaas <[email protected]>
Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), which appeared in v6.0, the PCI core has enabled PCIe error reporting for all devices during enumeration.
Remove driver code to do this.
Bjorn Helgaas (2):
IB/hfi1: Drop redundant pci_enable_pcie_error_reporting() IB/qib: Drop redundant pci_enable_pcie_error_reporting()
drivers/infiniband/hw/hfi1/pcie.c | 2 -- drivers/infiniband/hw/qib/qib_pcie.c | 8 -------- 2 files changed, 10 deletions(-)
Signature · 1 line
2.25.1
PATCH 1/2 IB/hfi1: Drop redundant pci_enable_pcie_error_reporting()
From: Bjorn Helgaas <[email protected]>
pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself.
Remove the redundant pci_enable_pcie_error_reporting() call from the driver.
Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver.
--- drivers/infiniband/hw/hfi1/pcie.c | 2 -- 1 file changed, 2 deletions(-)
drivers/infiniband/hw/hfi1/pcie.c +0 -2
@@ -7,7 +7,6 @@#include <linux/io.h> #include <linux/delay.h> #include <linux/vmalloc.h> -#include <linux/aer.h> #include <linux/module.h> #include "hfi.h"
@@ -65,7 +64,6 @@ int hfi1_pcie_init(struct hfi1_devdata *dd) }pci_set_master (pdev); - (void )pci_enable_pcie_error_reporting (pdev);return 0 ; bail:
Signature · 1 line
2.25.1
Re: [PATCH 1/2] IB/hfi1: Drop redundant pci_enable_pcie_error_reporting()
Quoted 10 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
pci_enable_pcie_error_reporting()enables the device to send ERR_* Messages. Sincef26e58bf6f54("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself.Remove the redundant
pci_enable_pcie_error_reporting()call from the driver.
Quoted 6 lines
Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver.
Signed-off-by Bjorn Helgaas <[email protected]>Cc Dennis Dalessandro <[email protected]>
PATCH 2/2 IB/qib: Drop redundant pci_enable_pcie_error_reporting()
In reply to Bjorn HelgaasFrom: Bjorn Helgaas <[email protected]>
pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself.
Remove the redundant pci_enable_pcie_error_reporting() call from the driver.
Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver.
--- drivers/infiniband/hw/qib/qib_pcie.c | 8 -------- 1 file changed, 8 deletions(-)
drivers/infiniband/hw/qib/qib_pcie.c +0 -8
@@ -35,7 +35,6 @@#include <linux/io.h> #include <linux/delay.h> #include <linux/vmalloc.h> -#include <linux/aer.h> #include <linux/module.h> #include "qib.h"
@@ -105,13 +104,6 @@ int qib_pcie_init(struct pci_dev *pdev, const struct pci_device_id *ent) }pci_set_master (pdev); - ret =pci_enable_pcie_error_reporting (pdev); -if (ret) { -qib_early_err (&pdev->dev, -"Unable to enable pcie error reporting: %d\n" , - ret); - ret =0 ; - } goto done; bail:
Signature · 1 line
2.25.1
Re: [PATCH 2/2] IB/qib: Drop redundant pci_enable_pcie_error_reporting()
Quoted 10 lines · Bjorn Helgaas
From: Bjorn Helgaas <[email protected]>
pci_enable_pcie_error_reporting()enables the device to send ERR_* Messages. Sincef26e58bf6f54("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself.Remove the redundant
pci_enable_pcie_error_reporting()call from the driver.
Quoted 6 lines
Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver.
Signed-off-by Bjorn Helgaas <[email protected]>Cc Dennis Dalessandro <[email protected]>