Skip to contentSkip to conversation

mips: ar71: include linux/gpio/driver.h

PATCH In review Arnd Bergmann 5 participants 7 messages Mar 8, 2023 – Mar 9, 2023 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mips: ar71: include linux/gpio/driver.h

From: Arnd Bergmann <[email protected]>

The change to remove the implicit gpio/driver.h include was done after fixing all the other users, but the ar7 file still needs the same change.

Fixes 21d9526d13b5 ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")
---
 arch/mips/ar7/gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/ar7/gpio.c +1 -1
index ae0e01b9438f..4ed833b9cc2f 100644
@@ -7,7 +7,7 @@
 
 #include <linux/init.h>
 #include <linux/export.h>
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
 
 #include <asm/mach-ar7/ar7.h>
 
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The change to remove the implicit gpio/driver.h include was done after fixing all the other users, but the ar7 file still needs the same change.

Thank you!

P.S. Bart, I believe the best strategy here is to you directly apply this to GPIO tree. If anyone needs this, you can make an immutable tag or branch with it being included.

Alternatively I can take it and issue a new immutable tag.

Tell me which way suits you better.

Quoted 23 lines
Fixes 21d9526d13b5 ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")
---
 arch/mips/ar7/gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/ar7/gpio.c +1 -1
index ae0e01b9438f..4ed833b9cc2f 100644
@@ -7,7 +7,7 @@
 
 #include <linux/init.h>
 #include <linux/export.h>
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
 
 #include <asm/mach-ar7/ar7.h>
 
Signature · 1 line
2.39.2
Signature · 2 lines
With Best Regards,
Andy Shevchenko
Reviewed-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann
Quoted 9 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The change to remove the implicit gpio/driver.h include was done after fixing all the other users, but the ar7 file still needs the same change.

Fixes 21d9526d13b5 ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")

If this is the only problem merging this set was amazingly painless.

Yours,
Linus Walleij

#3 lore raw
Quoted 8 lines · Linus Walleij
Quoted 6 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The change to remove the implicit gpio/driver.h include was done after fixing all the other users, but the ar7 file still needs the same change.

Quoted 7 lines
Quoted 3 lines
Fixes 21d9526d13b5 ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")

If this is the only problem merging this set was amazingly painless.

Too early to celebrate. We have one more patch on the same matters.

That said, I will collect them and send a new PR to Bart.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw
Quoted 5 lines · Andy Shevchenko
Quoted 3 lines

If this is the only problem merging this set was amazingly painless.

Too early to celebrate. We have one more patch on the same matters.

Yeah I would expect some more noise, I had a similar patch in one of my kernelorg branches and the zeroday robot would spit some weird bugs like this at me after a few days of randconfig builds.

Yours,
Linus Walleij

Reviewed-by on v1 1/1
#5 lore raw
In reply to Arnd Bergmann
Quoted 6 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The change to remove the implicit gpio/driver.h include was done after fixing all the other users, but the ar7 file still needs the same change.

Quoted 6 lines
Fixes 21d9526d13b5 ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")
---
  arch/mips/ar7/gpio.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by on v1 1/1
#6 lore raw
In reply to Arnd Bergmann
Quoted 9 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The change to remove the implicit gpio/driver.h include was done after fixing all the other users, but the ar7 file still needs the same change.

Fixes 21d9526d13b5 ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")

s/ar71/ar7/ in the subject, with that:

Signature · 1 line
Florian