Skip to contentSkip to conversation

gpiolib: Get rid of devprop prefix in one function

PATCH Applied Andy Shevchenko 3 participants 3 messages Mar 9, 2023 – Mar 15, 2023 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpiolib: Get rid of devprop prefix in one function

The devprop prefix in the devprop_gpiochip_set_names() adds confusion. Get rid of it.

Note we have more than one function in the same module that handles one or more device properties. This change will unify the naming schema for all of them.

---
 drivers/gpio/gpiolib.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpio/gpiolib.c +3 -3
index 45f79aee451a..8ecfe3afde1e 100644
@@ -374,7 +374,7 @@ static int gpiochip_set_desc_names(struct gpio_chip *gc)
 }
 
 /*
- * devprop_gpiochip_set_names - Set GPIO line names using device properties
+ * gpiochip_set_names - Set GPIO line names using device properties
  * @chip: GPIO chip whose lines should be named, if possible
  *
  * Looks for device property "gpio-line-names" and if it exists assigns
@@ -382,7 +382,7 @@ static int gpiochip_set_desc_names(struct gpio_chip *gc)
  * names belong to the underlying firmware node and should not be released
  * by the caller.
  */
-static int devprop_gpiochip_set_names(struct gpio_chip *chip)
+static int gpiochip_set_names(struct gpio_chip *chip)
 {
 	struct gpio_device *gdev = chip->gpiodev;
 	struct device *dev = &gdev->dev;
@@ -834,7 +834,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
 		if (ret)
 			goto err_remove_from_list;
 	}
-	ret = devprop_gpiochip_set_names(gc);
+	ret = gpiochip_set_names(gc);
 	if (ret)
 		goto err_remove_from_list;
 
Signature · 1 line
2.39.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Andy Shevchenko

The devprop prefix in the devprop_gpiochip_set_names() adds confusion. Get rid of it.

Note we have more than one function in the same module that handles one or more device properties. This change will unify the naming schema for all of them.

Yours,
Linus Walleij