staging: rtl8723bs: remove some unused functions
cover staging: rtl8723bs: remove some unused functions
This series removes some unused functions from hal/hal_com.c.
Michael Straube (5):
staging: rtl8723bs: MapCharToHexDigit() is not used
staging: rtl8723bs: ParseQualifiedString() is not used
staging: rtl8723bs: isAllSpaceOrTab() is not used
staging: rtl8723bs: linked_info_dump() is not used
staging: rtl8723bs: rtw_get_raw_rssi_info() is not used
drivers/staging/rtl8723bs/hal/hal_com.c | 108 -------------------- drivers/staging/rtl8723bs/include/hal_com.h | 9 -- 2 files changed, 117 deletions(-)
Signature · 1 line
2.39.2
PATCH 1/5 staging: rtl8723bs: MapCharToHexDigit() is not used
The function MapCharToHexDigit() is not used anywhere, remove it.
--- drivers/staging/rtl8723bs/hal/hal_com.c | 16 ---------------- drivers/staging/rtl8723bs/include/hal_com.h | 2 -- 2 files changed, 18 deletions(-)
drivers/staging/rtl8723bs/hal/hal_com.c +0 -16
@@ -859,22 +859,6 @@ bool eqNByte(u8 *str1, u8 *str2, u32 num)return true; } -/* */ -/* Description: */ -/* Translate a character to hex digit. */ -/* */ -u32 MapCharToHexDigit (char chTmp) -{ -if (chTmp >='0' && chTmp <='9' ) -return chTmp -'0' ; -else if (chTmp >='a' && chTmp <='f' ) -return 10 + (chTmp -'a' ); -else if (chTmp >='A' && chTmp <='F' ) -return 10 + (chTmp -'A' ); -else -return 0 ; -} -bool GetU1ByteIntegerFromStringInDecimal (char *Str,u8 *pInt) {u16 i =0 ;
drivers/staging/rtl8723bs/include/hal_com.h +0 -2
@@ -147,8 +147,6 @@ u8 GetHalDefVar(struct adapter *adapter, enum hal_def_variable variable,bool eqNByte (u8 *str1,u8 *str2,u32 num); -u32 MapCharToHexDigit (char chTmp); -bool ParseQualifiedString (char *In,u32 *Start,char *Out,char LeftQualifier,char RightQualifier);
Signature · 1 line
2.39.2
PATCH 2/5 staging: rtl8723bs: ParseQualifiedString() is not used
In reply to Michael StraubeThe function ParseQualifiedString() is not used anywhere, remove it.
--- drivers/staging/rtl8723bs/hal/hal_com.c | 24 --------------------- drivers/staging/rtl8723bs/include/hal_com.h | 3 --- 2 files changed, 27 deletions(-)
drivers/staging/rtl8723bs/hal/hal_com.c +0 -24
@@ -877,30 +877,6 @@ bool GetU1ByteIntegerFromStringInDecimal(char *Str, u8 *pInt)return true; } -/* <20121004, Kordan> For example, -* ParseQualifiedString(inString, 0, outString, '[', ']') gets "Kordan" from -* a string "Hello [Kordan]". -* If RightQualifier does not exist, it will hang in the while loop -*/ -bool ParseQualifiedString ( -char *In,u32 *Start,char *Out,char LeftQualifier,char RightQualifier -) -{ -u32 i =0 , j =0 ; -char c = In[(*Start)++]; - -if (c != LeftQualifier) -return false; - - i = (*Start); -while ((c = In[(*Start)++]) != RightQualifier) - ;/* find ']' */ - j = (*Start) -2 ; -strncpy ((char *)Out, (const char *)(In+i), j-i+1 ); - -return true; -} -bool isAllSpaceOrTab (u8 *data,u8 size) {u8 cnt =0 , NumOfSpaceAndTab =0 ;
drivers/staging/rtl8723bs/include/hal_com.h +0 -3
@@ -147,9 +147,6 @@ u8 GetHalDefVar(struct adapter *adapter, enum hal_def_variable variable,bool eqNByte (u8 *str1,u8 *str2,u32 num); -bool ParseQualifiedString (char *In,u32 *Start,char *Out,char LeftQualifier, -char RightQualifier); -bool GetU1ByteIntegerFromStringInDecimal (char *str,u8 *in);bool isAllSpaceOrTab (u8 *data,u8 size);
Signature · 1 line
2.39.2
PATCH 3/5 staging: rtl8723bs: isAllSpaceOrTab() is not used
In reply to Michael StraubeThe function isAllSpaceOrTab() is not used anywhere, remove it.
--- drivers/staging/rtl8723bs/hal/hal_com.c | 15 --------------- drivers/staging/rtl8723bs/include/hal_com.h | 2 -- 2 files changed, 17 deletions(-)
drivers/staging/rtl8723bs/hal/hal_com.c +0 -15
@@ -877,21 +877,6 @@ bool GetU1ByteIntegerFromStringInDecimal(char *Str, u8 *pInt)return true; } -bool isAllSpaceOrTab (u8 *data,u8 size) -{ -u8 cnt =0 , NumOfSpaceAndTab =0 ; - -while (size > cnt) { -if (data[cnt] ==' ' || data[cnt] =='\t' || data[cnt] =='\0' ) - ++NumOfSpaceAndTab; - - ++cnt; - } - -return size == NumOfSpaceAndTab; -} - -void rtw_hal_check_rxfifo_full (struct adapter *adapter) {struct dvobj_priv *psdpriv = adapter->dvobj;
drivers/staging/rtl8723bs/include/hal_com.h +0 -2
@@ -149,8 +149,6 @@ bool eqNByte(u8 *str1, u8 *str2, u32 num);bool GetU1ByteIntegerFromStringInDecimal (char *str,u8 *in); -bool isAllSpaceOrTab (u8 *data,u8 size); -void linked_info_dump (struct adapter *padapter,u8 benable);#ifdef DBG_RX_SIGNAL_DISPLAY_RAW_DATA void rtw_get_raw_rssi_info (void *sel,struct adapter *padapter);
Signature · 1 line
2.39.2
PATCH 4/5 staging: rtl8723bs: linked_info_dump() is not used
In reply to Michael StraubeThe function linked_info_dump() is not used anywhere, remove it.
--- drivers/staging/rtl8723bs/hal/hal_com.c | 21 --------------------- drivers/staging/rtl8723bs/include/hal_com.h | 1 - 2 files changed, 22 deletions(-)
drivers/staging/rtl8723bs/hal/hal_com.c +0 -21
@@ -897,27 +897,6 @@ void rtw_hal_check_rxfifo_full(struct adapter *adapter) } } -void linked_info_dump (struct adapter *padapter,u8 benable) -{ -struct pwrctrl_priv *pwrctrlpriv =adapter_to_pwrctl (padapter); - -if (padapter->bLinkInfoDump == benable) -return ; - -if (benable) { - pwrctrlpriv->org_power_mgnt = pwrctrlpriv->power_mgnt;/* keep org value */ -rtw_pm_set_lps (padapter,PS_MODE_ACTIVE ); - - pwrctrlpriv->ips_org_mode = pwrctrlpriv->ips_mode;/* keep org value */ -rtw_pm_set_ips (padapter,IPS_NONE ); - }else { -rtw_pm_set_ips (padapter, pwrctrlpriv->ips_org_mode); - -rtw_pm_set_lps (padapter, pwrctrlpriv->ips_org_mode); - } - padapter->bLinkInfoDump = benable; -} -#ifdef DBG_RX_SIGNAL_DISPLAY_RAW_DATA void rtw_get_raw_rssi_info (void *sel,struct adapter *padapter) {
drivers/staging/rtl8723bs/include/hal_com.h +0 -1
@@ -149,7 +149,6 @@ bool eqNByte(u8 *str1, u8 *str2, u32 num);bool GetU1ByteIntegerFromStringInDecimal (char *str,u8 *in); -void linked_info_dump (struct adapter *padapter,u8 benable);#ifdef DBG_RX_SIGNAL_DISPLAY_RAW_DATA void rtw_get_raw_rssi_info (void *sel,struct adapter *padapter);void rtw_store_phy_info (struct adapter *padapter,union recv_frame *prframe);
Signature · 1 line
2.39.2
PATCH 5/5 staging: rtl8723bs: rtw_get_raw_rssi_info() is not used
In reply to Michael StraubeThe function rtw_get_raw_rssi_info() is not used anywhere, remove it.
--- drivers/staging/rtl8723bs/hal/hal_com.c | 32 --------------------- drivers/staging/rtl8723bs/include/hal_com.h | 1 - 2 files changed, 33 deletions(-)
drivers/staging/rtl8723bs/hal/hal_com.c +0 -32
@@ -898,38 +898,6 @@ void rtw_hal_check_rxfifo_full(struct adapter *adapter) }#ifdef DBG_RX_SIGNAL_DISPLAY_RAW_DATA -void rtw_get_raw_rssi_info (void *sel,struct adapter *padapter) -{ -u8 isCCKrate, rf_path; -struct hal_com_data *pHalData =GET_HAL_DATA (padapter); -struct rx_raw_rssi *psample_pkt_rssi = &padapter->recvpriv.raw_rssi_info; - -netdev_dbg (padapter->pnetdev, -"RxRate = %s, PWDBALL = %d(%%), rx_pwr_all = %d(dBm)\n" , -HDATA_RATE (psample_pkt_rssi->data_rate), - psample_pkt_rssi->pwdball, psample_pkt_rssi->pwr_all); - - isCCKrate = psample_pkt_rssi->data_rate <=DESC_RATE11M ; - -if (isCCKrate) - psample_pkt_rssi->mimo_signal_strength[0 ] = psample_pkt_rssi->pwdball; - -for (rf_path =0 ; rf_path < pHalData->NumTotalRFPath; rf_path++) { -netdev_dbg (padapter->pnetdev, -"RF_PATH_%d =>signal_strength:%d(%%), signal_quality:%d(%%)\n" , - rf_path, - psample_pkt_rssi->mimo_signal_strength[rf_path], - psample_pkt_rssi->mimo_signal_quality[rf_path]); - -if (!isCCKrate) { -netdev_dbg (padapter->pnetdev, -"\trx_ofdm_pwr:%d(dBm), rx_ofdm_snr:%d(dB)\n" , - psample_pkt_rssi->ofdm_pwr[rf_path], - psample_pkt_rssi->ofdm_snr[rf_path]); - } - } -} -void rtw_dump_raw_rssi_info (struct adapter *padapter) {u8 isCCKrate, rf_path;
drivers/staging/rtl8723bs/include/hal_com.h +0 -1
@@ -150,7 +150,6 @@ bool eqNByte(u8 *str1, u8 *str2, u32 num);bool GetU1ByteIntegerFromStringInDecimal (char *str,u8 *in);#ifdef DBG_RX_SIGNAL_DISPLAY_RAW_DATA -void rtw_get_raw_rssi_info (void *sel,struct adapter *padapter);void rtw_store_phy_info (struct adapter *padapter,union recv_frame *prframe);void rtw_dump_raw_rssi_info (struct adapter *padapter);#endif
Signature · 1 line
2.39.2
Hi,
Quoted 1 line · Michael Straube
This series removes some unused functions from
hal/hal_com.c.
Thanks, the entire series looks good to me:
for the series.
Regards,
Hans
Quoted 12 lines
Michael Straube (5):
staging: rtl8723bs:MapCharToHexDigit()is not used
staging: rtl8723bs:ParseQualifiedString()is not used
staging: rtl8723bs:isAllSpaceOrTab()is not used
staging: rtl8723bs:linked_info_dump()is not used
staging: rtl8723bs:rtw_get_raw_rssi_info()is not useddrivers/staging/rtl8723bs/hal/hal_com.c | 108 -------------------- drivers/staging/rtl8723bs/include/hal_com.h | 9 -- 2 files changed, 117 deletions(-)