Skip to contentSkip to conversation

ARM: exynos: Use of_property_read_bool() for boolean properties

PATCH Applied Rob Herring 2 participants 2 messages Mar 10, 2023 – Mar 13, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: exynos: Use of_property_read_bool() for boolean properties

It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to of_property_read_bool().

---
 arch/arm/mach-exynos/suspend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-exynos/suspend.c +1 -1
index 3bf14ca78b62..6d5d7696aaf7 100644
@@ -667,7 +667,7 @@ void __init exynos_pm_init(void)
 		return;
 	}
 
-	if (WARN_ON(!of_find_property(np, "interrupt-controller", NULL))) {
+	if (WARN_ON(!of_property_read_bool(np, "interrupt-controller"))) {
 		pr_warn("Outdated DT detected, suspend/resume will NOT work\n");
 		of_node_put(np);
 		return;
Signature · 1 line
2.39.2
#1 lore raw
Quoted 6 lines · Rob Herring

It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to of_property_read_bool().

Applied, thanks!

[1/1] ARM: exynos: Use of_property_read_bool() for boolean properties

      https://git.kernel.org/krzk/linux/c/2b8ed0c89f5dc7af756473651deb1be1770d2136

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>