soc: ti: Use of_property_read_bool() for boolean properties
PATCH 1/1 soc: ti: Use of_property_read_bool() for boolean properties
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to of_property_read_bool().
--- drivers/soc/ti/knav_dma.c | 4 ++-- drivers/soc/ti/knav_qmss_acc.c | 2 +- drivers/soc/ti/knav_qmss_queue.c | 2 +- drivers/soc/ti/wkup_m3_ipc.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-)
drivers/soc/ti/knav_dma.c +2 -2
@@ -666,8 +666,8 @@ static int dma_init(struct device_node *cloud, struct device_node *dma_node) dma->rx_priority =DMA_PRIO_DEFAULT ; dma->tx_priority =DMA_PRIO_DEFAULT ; - dma->enable_all = (of_get_property (node,"ti,enable-all" ,NULL ) !=NULL ); - dma->loopback = (of_get_property (node,"ti,loop-back" ,NULL ) !=NULL ); + dma->enable_all =of_property_read_bool (node,"ti,enable-all" ); + dma->loopback =of_property_read_bool (node,"ti,loop-back" ); ret =of_property_read_u32 (node,"ti,rx-retry-timeout" , &timeout);if (ret <0 ) {
drivers/soc/ti/knav_qmss_acc.c +1 -1
@@ -521,7 +521,7 @@ int knav_init_acc_range(struct knav_device *kdev, info->pdsp = pdsp; channels = range->num_queues; -if (of_get_property (node,"multi-queue" ,NULL )) { +if (of_property_read_bool (node,"multi-queue" )) { range->flags |=RANGE_MULTI_QUEUE ; channels =1 ;if (range->queue_base & (32 -1 )) {
drivers/soc/ti/knav_qmss_queue.c +1 -1
@@ -1264,7 +1264,7 @@ static int knav_setup_queue_range(struct knav_device *kdev,if (range->num_irqs) range->flags |=RANGE_HAS_IRQ ; -if (of_get_property (node,"qalloc-by-id" ,NULL )) +if (of_property_read_bool (node,"qalloc-by-id" )) range->flags |=RANGE_RESERVED ;if (of_property_present (node,"accumulator" )) {
drivers/soc/ti/wkup_m3_ipc.c +1 -1
@@ -681,7 +681,7 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev)dev_warn (dev,"Invalid VTT GPIO(%d) pin\n" , temp); } -if (of_find_property (np,"ti,set-io-isolation" ,NULL )) +if (of_property_read_bool (np,"ti,set-io-isolation" ))wkup_m3_set_io_isolation (m3_ipc); ret = of_property_read_string(np, "firmware-name",
Signature · 7 lines
2.39.2 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Rob Herring,
Quoted 4 lines · Rob Herring
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to
of_property_read_bool().
^^ - I locally fixed the "to to" to "to"
Quoted 1 line
I have applied the following to branch ti-drivers-soc-next on [1]. Thank you!
[1/1] soc: ti: Use of_property_read_bool() for boolean properties
commit: 82e46bf71780940a5e060fcb02397ecf7f55e768
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
Signature · 1 line
Nishanth Menon <[email protected]>