ALSA: Use of_property_read_bool() for boolean properties
PATCH 1/1 ALSA: Use of_property_read_bool() for boolean properties
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to of_property_read_bool().
--- sound/ppc/tumbler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/ppc/tumbler.c +1 -1
@@ -1361,7 +1361,7 @@ int snd_pmac_tumbler_init(struct snd_pmac *chip)for_each_child_of_node (chip->node, np) {if (of_node_name_eq (np,"sound" )) { -if (of_get_property (np,"has-anded-reset" ,NULL )) +if (of_property_read_bool (np,"has-anded-reset" )) mix->anded_reset =1 ;if (of_property_present (np,"layout-id" )) mix->reset_on_sleep =0 ;
Signature · 1 line
2.39.2
Quoted 9 lines · Rob Herring
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to
of_property_read_bool().Signed-off-by Rob Herring <[email protected]>--- sound/ppc/tumbler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Ping!
Quoted 17 lines
sound/ppc/tumbler.c +1
-1@@ -1361,7 +1361,7 @@ int snd_pmac_tumbler_init(struct snd_pmac *chip)for_each_child_of_node (chip->node, np) {if (of_node_name_eq (np,"sound" )) { -if (of_get_property (np,"has-anded-reset" ,NULL )) +if (of_property_read_bool (np,"has-anded-reset" )) mix->anded_reset =1 ;if (of_property_present (np,"layout-id" )) mix->reset_on_sleep =0 ;Signature · 1 line
2.39.2
Quoted 7 lines · Rob Herring
Quoted 5 lines · Rob Herring
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to
of_property_read_bool().
Quoted 6 lines
Quoted 4 lines
Signed-off-by Rob Herring <[email protected]>--- sound/ppc/tumbler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Ping!
Sorry for the oversight. Now both patches are applied.
Takashi
Takashi Iwai
AppliedQuoted 7 lines · Rob Herring
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. Convert reading boolean properties to to
of_property_read_bool().Signed-off-by Rob Herring <[email protected]>
Applied to for-next branch.
thanks,
Takashi