Skip to contentSkip to conversation

bus: ti-sysc: Use of_property_present() for testing DT property presence

PATCH In review Rob Herring 2 participants 2 messages Mar 10, 2023 – Mar 27, 2023 OMAP2+ support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bus: ti-sysc: Use of_property_present() for testing DT property presence

It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more.

---
 drivers/bus/ti-sysc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bus/ti-sysc.c +1 -1
index 6afae9897843..34d755797db4 100644
@@ -964,7 +964,7 @@ static int sysc_map_and_check_registers(struct sysc *ddata)
 
 	sysc_check_children(ddata);
 
-	if (!of_get_property(np, "reg", NULL))
+	if (!of_property_present(np, "reg"))
 		return 0;
 
 	error = sysc_parse_registers(ddata);
Signature · 1 line
2.39.2
maintainer
#1 lore raw
Quoted 6 lines · Rob Herring

It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more.

Thanks applying into omap-for-v6.4/ti-sysc.

Tony